Re: RFS: xinha
Hi, On Fri, Feb 13, 2009 at 10:39 PM, Daniel Baumann dan...@debian.org wrote: Raphael Geissert wrote: http://mentors.debian.net/debian/pool/main/x/xinha/xinha_0.95-1.dsc sorry for the late answer. if still wanted, i can do a review beginning of next week. Another review would help as it is a complex package. Thanks Mathieu Parent -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: RFS: xinha
Raphael Geissert wrote: http://mentors.debian.net/debian/pool/main/x/xinha/xinha_0.95-1.dsc sorry for the late answer. if still wanted, i can do a review beginning of next week. -- Address:Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist Email: daniel.baum...@panthera-systems.net Internet: http://people.panthera-systems.net/~daniel-baumann/ -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: Re: RFS: xinha
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Mathieu, Daniel, Sorry for the late response, it's until now that I'm reading old messages from -mentors. Mathieu Parent wrote: 2008/11/29 Mathieu Parent math.par...@gmail.com: 2008/11/27 Raphael Geissert atomo64+deb...@gmail.com: [...] There are a couple of issues in xinha itself that I will be reporting later (security issues). Do you happen to have an email address of upstream? I couldn't find it anywhere on the website. Nope. But there are some webpages: James Sleeman: http://code.gogo.co.nz/contact/index.html Raimund Meyer: http://xinha.raimundmeyer.de/ (email may be ray AT openplans.org) Since those issues are rather minor it should be fine if xinha is, in the meanwhile, uploaded to unstable so that it goes through NEW. I'm back here to know if anything is missing to upload xinha to unstable. I think I've addressed all the tips. Just this: in debian/rules check-dfsg should be marked as a PHONY target as well. Daniel, since you are involved with other js packages: could you please take a look at xinha and sponsor it? Mathieu has done an amazingly great job preparing the package, and IMO it is perfect. The current dsc can be found at: http://mentors.debian.net/debian/pool/main/x/xinha/xinha_0.95-1.dsc Cheers, - -- Raphael Geissert - Debian Maintainer www.debian.org - get.debian.net -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkmAvoQACgkQYy49rUbZzlosGwCggcrIIkW0beecWmslfdmCKNO8 AlsAnjA5V/5JreSv9rsdXeQYY5HskeW2 =UDVt -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: Re: RFS: xinha
Hi Raphael, Daniel, On Wed, Jan 28, 2009 at 9:22 PM, Raphael Geissert atomo64+deb...@gmail.com wrote: (...) Mathieu Parent wrote: Just this: in debian/rules check-dfsg should be marked as a PHONY target as well. Done. I've uploaded the new version. Thanks. Daniel, since you are involved with other js packages: could you please take a look at xinha and sponsor it? Mathieu has done an amazingly great job preparing the package, and IMO it is perfect. The current dsc can be found at: http://mentors.debian.net/debian/pool/main/x/xinha/xinha_0.95-1.dsc Same here Mathieu Parent -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: Re: RFS: xinha
Hi, 2008/11/29 Mathieu Parent math.par...@gmail.com: Hi, 2008/11/27 Raphael Geissert atomo64+deb...@gmail.com: [...] There are a couple of issues in xinha itself that I will be reporting later (security issues). Do you happen to have an email address of upstream? I couldn't find it anywhere on the website. Nope. But there are some webpages: James Sleeman: http://code.gogo.co.nz/contact/index.html Raimund Meyer: http://xinha.raimundmeyer.de/ (email may be ray AT openplans.org) I'm back here to know if anything is missing to upload xinha to unstable. I think I've addressed all the tips. Regards Mathieu Parent -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: Re: RFS: xinha
Hi, 2008/11/27 Raphael Geissert [EMAIL PROTECTED]: Hi, [...] debian/uupdate-wrapper: | gzip xinha_$version.orig.tar.gz use max compression (a.k.a -9) Done But looks like you didn't re-compress the tarball using -9, please do. it is done now. But doesn't save much space. [...] There are a couple of issues in xinha itself that I will be reporting later (security issues). Do you happen to have an email address of upstream? I couldn't find it anywhere on the website. Nope. But there are some webpages: James Sleeman: http://code.gogo.co.nz/contact/index.html Raimund Meyer: http://xinha.raimundmeyer.de/ (email may be ray AT openplans.org) Cheers, -- Raphael Geissert - Debian Maintainer www.debian.org - get.debian.net Yogi Berra - I never said most of the things I said. Mathieu Parent -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: Re: RFS: xinha
Hi, 2008/11/23 Mathieu Parent [EMAIL PROTECTED]: Hi, Thanks for all your help 2008/11/23 Raphael Geissert [EMAIL PROTECTED]: [...] Build-Depends: debhelper (= 6.0.7~) what is that tilde doing there? (lintian should probably warn about it) the tilde is for eventual backports of debhelper (see http://lintian.debian.org/tags/debhelper-script-needs-versioned-build-depends.html). Cite: Giving the version followed by ~ is recommended so that backports will satisfy the dependency. Yeah, Russ Allbery pointed that out in -mentors right after I sent the email. [...] debian/uupdate-wrapper: | gzip xinha_$version.orig.tar.gz use max compression (a.k.a -9) Done But looks like you didn't re-compress the tarball using -9, please do. * better use the same file name as in $file (there should be no worries about replacing the file while reading from it because tar requires the whole tarball to be available/read). Original tarbal is bzip2. that's why I rename it. I missed that part, sorry. [...] Regards Mathieu Parent There are a couple of issues in xinha itself that I will be reporting later (security issues). Do you happen to have an email address of upstream? I couldn't find it anywhere on the website. Cheers, -- Raphael Geissert - Debian Maintainer www.debian.org - get.debian.net Yogi Berra - I never said most of the things I said. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: Re: RFS: xinha
Hi,
Thanks for all your help
2008/11/23 Raphael Geissert [EMAIL PROTECTED]:
Hi,
debian/control:
What about adding a replaces: htmlarea? or maybe some other mention so that
people looking for htmlarea actually find something (better).
Done
Build-Depends: debhelper (= 6.0.7~)
what is that tilde doing there? (lintian should probably warn about it)
the tilde is for eventual backports of debhelper (see
http://lintian.debian.org/tags/debhelper-script-needs-versioned-build-depends.html).
Cite: Giving the version followed by ~ is recommended so that
backports will satisfy the dependency.
debian/rules:
(cleanup) build-stamp is not needed, you can get rid of it ('build' is a PHONY
target anyway).
Removed.
#marking files as not executable (lintian warnings)
find debian/xinha/usr/share/xinha/www -type f -exec chmod -x '{}' \;
find debian/xinha/usr/share/doc/xinha/examples -type f -exec chmod -x '{}'
\;
chmod -R -x,+X debian/xinha/usr/share/xinha/www
chmod -R -x,+X debian/xinha/usr/doc/xinha/examples
Ok. Done
cp contrib/php-xinha.php $(CURDIR)/debian/xinha/usr/share/doc/xinha/examples
dh_installchangelogs -i release-notes.txt
Why are these in binary-indep and not in install just like the rest?
(I know must packages do something similar, even some (if not all) of mine).
Done. See below for php-xinha.php.
debian/copyright-REMOVED:
nice work :)
Thanks
debian/uupdate-wrapper:
| gzip xinha_$version.orig.tar.gz
use max compression (a.k.a -9)
Done
You should also:
* use 'set -e'
Done
* better use the same file name as in $file (there should be no worries about
replacing the file while reading from it because tar requires the whole
tarball
to be available/read).
Original tarbal is bzip2. that's why I rename it.
debian/copyright:
Format-Specification:
http://wiki.debian.org/Proposals/CopyrightFormat?action=recallrev=REVISION
You are actually supposed to replace REVISION with the revision of the page
you
based your copyright file on.
Of course. Done
debian/examples:
I can see some references to the php-xinha.php file in xinha itself, are you
sure it should be installed just as an example?
contrib is now installed like the rest
Cheers,
--
Raphael Geissert - Debian Maintainer
www.debian.org - get.debian.net
I have uploaded the corrected package.
Regards
Mathieu Parent
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: Re: RFS: xinha
Hi,
debian/control:
What about adding a replaces: htmlarea? or maybe some other mention so that
people looking for htmlarea actually find something (better).
Build-Depends: debhelper (= 6.0.7~)
what is that tilde doing there? (lintian should probably warn about it)
debian/rules:
(cleanup) build-stamp is not needed, you can get rid of it ('build' is a PHONY
target anyway).
#marking files as not executable (lintian warnings)
find debian/xinha/usr/share/xinha/www -type f -exec chmod -x '{}' \;
find debian/xinha/usr/share/doc/xinha/examples -type f -exec chmod -x '{}'
\;
chmod -R -x,+X debian/xinha/usr/share/xinha/www
chmod -R -x,+X debian/xinha/usr/doc/xinha/examples
cp contrib/php-xinha.php $(CURDIR)/debian/xinha/usr/share/doc/xinha/examples
dh_installchangelogs -i release-notes.txt
Why are these in binary-indep and not in install just like the rest?
(I know must packages do something similar, even some (if not all) of mine).
debian/copyright-REMOVED:
nice work :)
debian/uupdate-wrapper:
| gzip xinha_$version.orig.tar.gz
use max compression (a.k.a -9)
You should also:
* use 'set -e'
* better use the same file name as in $file (there should be no worries about
replacing the file while reading from it because tar requires the whole tarball
to be available/read).
debian/copyright:
Format-Specification:
http://wiki.debian.org/Proposals/CopyrightFormat?action=recallrev=REVISION
You are actually supposed to replace REVISION with the revision of the page you
based your copyright file on.
debian/examples:
I can see some references to the php-xinha.php file in xinha itself, are you
sure it should be installed just as an example?
Cheers,
--
Raphael Geissert - Debian Maintainer
www.debian.org - get.debian.net
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: xinha
Raphael Geissert [EMAIL PROTECTED] writes: Build-Depends: debhelper (= 6.0.7~) what is that tilde doing there? (lintian should probably warn about it) It allows the package to build with backports of debhelper 6.0.7. -- Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: Re: RFS: xinha
2008/11/19 Raphael Geissert [EMAIL PROTECTED]: Mathieu Parent wrote: Hi, Quoting [1]: Attribution-ShareAlike 2.0 debian-legal contributors think that works licensed solely under the Attribution-ShareAlike 2.0 [BY-SA] are not free according to the DFSG and should not be included in Debian. The Attribution-ShareAlike has the same problems as the Attribution 2.0 license. IOW: you either get a licence change or you have to remove them from the tarball. Done. i have also added a check in debian/rules for this. [1]http://web.archive.org/web/20070912053256/http://people.debian.org/~evan/ccsummary.html (http://evan.prodromou.name/ccsummary/ccsummary.html) ^^^ Nice, this is the same file :) ;) I've uploaded a new version in mentors that should answer your remarks. You can take a llok at it. Thanks. Cheers, -- Raphael Geissert - Debian Maintainer www.debian.org - get.debian.net Regards Mathieu Parent -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: Re: RFS: xinha
Hi
2008/11/18 Raphael Geissert [EMAIL PROTECTED]:
ping
Thanks. As I'm not in debian-mentors, I've not seen this mail
--- Forwarded message (begin)
Subject: Re: RFS: xinha
From: Raphael Geissert [EMAIL PROTECTED]
Date: Sat, 30 Aug 2008 14:43:51 -0600
Newsgroup: gmane.linux.debian.devel.mentors
Mathieu Parent wrote:
On Sat, Aug 30, 2008 at 4:30 AM, Raphael Geissert
[EMAIL PROTECTED] wrote:
Hi Mathieu,
Mathieu PARENT wrote:
Dear mentors,
I am looking for a sponsor for my package xinha.
* Package name: xinha
Version : 0.95~rc2-1
Version 0.95 has now been released, could you please update the package?
This is already done since june, see:
http://mentors.debian.net/debian/pool/main/x/xinha/xinha_0.95-1.dsc
Ok, sorry for not looking at mentors. So, let's review it so it can be
uploaded to the archive soon (won't make it for lenny, of course).
debian/control:
Standards-Version: 3.7.3
Should be updated if the package comforms to 3.8.0
Done
debian/rules:
...
cp -r plugins $(CURDIR)/debian/xinha/usr/share/xinha/www/plugins
cp -r popups $(CURDIR)/debian/xinha/usr/share/xinha/www/popups
cp -r skins $(CURDIR)/debian/xinha/usr/share/xinha/www/skins
install -t $(CURDIR)/debian/xinha/usr/share/xinha/www/ \
htmlarea.js Xinha.css XinhaCore.js XinhaLoader.js
why not just use dh_install and debian/install?
Done
find debian/xinha/usr/share/xinha/www -type f -exec chmod -x '{}'
\;
find debian/xinha/usr/share/doc/xinha/examples -type f -exec
chmod -x '{}' \;
chmod -X debian/ ?
Not sure to understand. Won't it deny browsing?
debian/copyright:
See `/usr/share/common-licenses/LGPL'.
You should be more specific and point to LGPL-2
Done
is licensed under the GPL, see `/usr/share/common-licenses/GPL'.
same here (and you should really think about that licence, as a mix of BSD +
LGPL + GPL can cause troubles).
I'm using LGPL-2.1+ now. Done.
Btw, it doesn't mention:
./XinhaCore.js:-- Copyright (c) 2005-2008 Xinha Developer Team and
contributors
./popups/about.html: Copyright (c) 2005-2008 Xinha Developer Team and
contributors
Done.
./plugins/Linker/dTree/dtree.css:| Copyright (c) 2002-2003 Geir
Landr? |
./skins/inditreuse/README:This work is licensed under the Creative Commons
Attribution-ShareAlike License.
./skins/titan/README:This work is licensed under the Creative Commons
Attribution-ShareAlike License.
And the many other copyright owners which you can find via grep -r c_owner
TODO. A bit more complex. I will dot it next.
debian/docs:
debian/dirs:
release-notes.txt should actually be installed as upstream's changelog
(dh_installchangelogs).
Done
Please fix the above mentioned issues (and investigate on the copyright
owner line which has a '?', and the licences of the plugins and skins).
Ok. Remaining issue is copyright.
http://svn.debian.org/wsvn/collab-maint/ext-maint/xinha/trunk/
Mathieu Parent
Cheers,
--
Atomo64 - Raphael
Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html
--- Forwarded message (end)
--
Raphael Geissert - Debian Maintainer
www.debian.org - get.debian.net
Regards
Mathieu Parent
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: Re: RFS: xinha
Hi, ./plugins/Linker/dTree/dtree.css:| Copyright (c) 2002-2003 Geir Landr? | ./skins/inditreuse/README:This work is licensed under the Creative Commons Attribution-ShareAlike License. ./skins/titan/README:This work is licensed under the Creative Commons Attribution-ShareAlike License. And the many other copyright owners which you can find via grep -r c_owner TODO. A bit more complex. I will dot it next. I've done a first try. there are some CC-by-sa files. Are they dfsg? or Should I remove them from tarballs? (http://evan.prodromou.name/ccsummary/ccsummary.html) Mathieu Parent -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: Re: RFS: xinha
Mathieu Parent wrote: Hi, ./plugins/Linker/dTree/dtree.css:| Copyright (c) 2002-2003 Geir Landr? | ./skins/inditreuse/README:This work is licensed under the Creative Commons Attribution-ShareAlike License. ./skins/titan/README:This work is licensed under the Creative Commons Attribution-ShareAlike License. And the many other copyright owners which you can find via grep -r c_owner TODO. A bit more complex. I will dot it next. I've done a first try. there are some CC-by-sa files. Are they dfsg? or Should I remove them from tarballs? Quoting [1]: Attribution-ShareAlike 2.0 debian-legal contributors think that works licensed solely under the Attribution-ShareAlike 2.0 [BY-SA] are not free according to the DFSG and should not be included in Debian. The Attribution-ShareAlike has the same problems as the Attribution 2.0 license. IOW: you either get a licence change or you have to remove them from the tarball. [1]http://web.archive.org/web/20070912053256/http://people.debian.org/~evan/ccsummary.html (http://evan.prodromou.name/ccsummary/ccsummary.html) ^^^ Nice, this is the same file :) Mathieu Parent Cheers, -- Raphael Geissert - Debian Maintainer www.debian.org - get.debian.net -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Fwd: Re: RFS: xinha
ping
--- Forwarded message (begin)
Subject: Re: RFS: xinha
From: Raphael Geissert [EMAIL PROTECTED]
Date: Sat, 30 Aug 2008 14:43:51 -0600
Newsgroup: gmane.linux.debian.devel.mentors
Mathieu Parent wrote:
On Sat, Aug 30, 2008 at 4:30 AM, Raphael Geissert
[EMAIL PROTECTED] wrote:
Hi Mathieu,
Mathieu PARENT wrote:
Dear mentors,
I am looking for a sponsor for my package xinha.
* Package name: xinha
Version : 0.95~rc2-1
Version 0.95 has now been released, could you please update the package?
This is already done since june, see:
http://mentors.debian.net/debian/pool/main/x/xinha/xinha_0.95-1.dsc
Ok, sorry for not looking at mentors. So, let's review it so it can be
uploaded to the archive soon (won't make it for lenny, of course).
debian/control:
Standards-Version: 3.7.3
Should be updated if the package comforms to 3.8.0
debian/rules:
...
cp -r plugins $(CURDIR)/debian/xinha/usr/share/xinha/www/plugins
cp -r popups $(CURDIR)/debian/xinha/usr/share/xinha/www/popups
cp -r skins $(CURDIR)/debian/xinha/usr/share/xinha/www/skins
install -t $(CURDIR)/debian/xinha/usr/share/xinha/www/ \
htmlarea.js Xinha.css XinhaCore.js XinhaLoader.js
why not just use dh_install and debian/install?
find debian/xinha/usr/share/xinha/www -type f -exec chmod -x '{}'
\;
find debian/xinha/usr/share/doc/xinha/examples -type f -exec
chmod -x '{}' \;
chmod -X debian/ ?
debian/copyright:
See `/usr/share/common-licenses/LGPL'.
You should be more specific and point to LGPL-2
is licensed under the GPL, see `/usr/share/common-licenses/GPL'.
same here (and you should really think about that licence, as a mix of BSD +
LGPL + GPL can cause troubles).
Btw, it doesn't mention:
./XinhaCore.js:-- Copyright (c) 2005-2008 Xinha Developer Team and
contributors
./popups/about.html: Copyright (c) 2005-2008 Xinha Developer Team and
contributors
./plugins/Linker/dTree/dtree.css:| Copyright (c) 2002-2003 Geir
Landr? |
./skins/inditreuse/README:This work is licensed under the Creative Commons
Attribution-ShareAlike License.
./skins/titan/README:This work is licensed under the Creative Commons
Attribution-ShareAlike License.
And the many other copyright owners which you can find via grep -r c_owner
debian/docs:
debian/dirs:
release-notes.txt should actually be installed as upstream's changelog
(dh_installchangelogs).
Please fix the above mentioned issues (and investigate on the copyright
owner line which has a '?', and the licences of the plugins and skins).
Mathieu Parent
Cheers,
--
Atomo64 - Raphael
Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html
--- Forwarded message (end)
--
Raphael Geissert - Debian Maintainer
www.debian.org - get.debian.net
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: xinha
On Sat, Aug 30, 2008 at 4:30 AM, Raphael Geissert [EMAIL PROTECTED] wrote: Hi Mathieu, Mathieu PARENT wrote: Dear mentors, I am looking for a sponsor for my package xinha. * Package name: xinha Version : 0.95~rc2-1 Version 0.95 has now been released, could you please update the package? This is already done since june, see: http://mentors.debian.net/debian/pool/main/x/xinha/xinha_0.95-1.dsc Mathieu Parent -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: xinha
On Saturday 30 August 2008 04:30:21 Raphael Geissert wrote: Hello, * Package name: xinha Version : 0.95~rc2-1 Version 0.95 has now been released, could you please update the package? DD's: can anyone take a look at the package when updated? there are several packages shipping their own copy of xinha or htmlarea and would be nice to have just one copy in the whole archive. Do you happen to know which are these packages and if bugs (normal) was filed against them. Sometimes, it is not possible to avoid code dups, since there might be significant incompatible deviations from the original, but sometimes it worth the effort. These should also be identified at: http://wiki.debian.org/EmbeddedCodeCopies -- pub 4096R/0E4BD0AB 2003-03-18 people.fccf.net/danchev/key pgp.mit.edu -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: xinha
George Danchev wrote: On Saturday 30 August 2008 04:30:21 Raphael Geissert wrote: Hello, * Package name: xinha Version : 0.95~rc2-1 Version 0.95 has now been released, could you please update the package? DD's: can anyone take a look at the package when updated? there are several packages shipping their own copy of xinha or htmlarea and would be nice to have just one copy in the whole archive. Do you happen to know which are these packages and if bugs (normal) was filed against them. Sometimes, it is not possible to avoid code dups, since there might be significant incompatible deviations from the original, but sometimes it worth the effort. These should also be identified at: http://wiki.debian.org/EmbeddedCodeCopies Sure, finding them is as easy as grep'ing Contents-arch: axyl horde3 And for htmlarea: moodle serendipity typo3-src-4.2? (rtehtmlarea) And no, no bugs have been filed yet (well, at least *I* haven't filed any); what I've been doing is collect the list of packages shipping their own copy, and file a RFP CC'ing their respective @packages.d.o address. My plan was to make lintian aware of those libs too as soon as the packaged js libs were uploaded. Oh, and you might also be interested in: http://lintian.debian.org/tags/embedded-javascript-library.html Cheers, -- Atomo64 - Raphael Please avoid sending me Word, PowerPoint or Excel attachments. See http://www.gnu.org/philosophy/no-word-attachments.html -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: xinha
Mathieu Parent wrote:
On Sat, Aug 30, 2008 at 4:30 AM, Raphael Geissert
[EMAIL PROTECTED] wrote:
Hi Mathieu,
Mathieu PARENT wrote:
Dear mentors,
I am looking for a sponsor for my package xinha.
* Package name: xinha
Version : 0.95~rc2-1
Version 0.95 has now been released, could you please update the package?
This is already done since june, see:
http://mentors.debian.net/debian/pool/main/x/xinha/xinha_0.95-1.dsc
Ok, sorry for not looking at mentors. So, let's review it so it can be
uploaded to the archive soon (won't make it for lenny, of course).
debian/control:
Standards-Version: 3.7.3
Should be updated if the package comforms to 3.8.0
debian/rules:
...
cp -r plugins $(CURDIR)/debian/xinha/usr/share/xinha/www/plugins
cp -r popups $(CURDIR)/debian/xinha/usr/share/xinha/www/popups
cp -r skins $(CURDIR)/debian/xinha/usr/share/xinha/www/skins
install -t $(CURDIR)/debian/xinha/usr/share/xinha/www/ \
htmlarea.js Xinha.css XinhaCore.js XinhaLoader.js
why not just use dh_install and debian/install?
find debian/xinha/usr/share/xinha/www -type f -exec chmod -x '{}'
\;
find debian/xinha/usr/share/doc/xinha/examples -type f -exec
chmod -x '{}' \;
chmod -X debian/ ?
debian/copyright:
See `/usr/share/common-licenses/LGPL'.
You should be more specific and point to LGPL-2
is licensed under the GPL, see `/usr/share/common-licenses/GPL'.
same here (and you should really think about that licence, as a mix of BSD +
LGPL + GPL can cause troubles).
Btw, it doesn't mention:
./XinhaCore.js:-- Copyright (c) 2005-2008 Xinha Developer Team and
contributors
./popups/about.html: Copyright (c) 2005-2008 Xinha Developer Team and
contributors
./plugins/Linker/dTree/dtree.css:| Copyright (c) 2002-2003 Geir
Landr? |
./skins/inditreuse/README:This work is licensed under the Creative Commons
Attribution-ShareAlike License.
./skins/titan/README:This work is licensed under the Creative Commons
Attribution-ShareAlike License.
And the many other copyright owners which you can find via grep -r c_owner
debian/docs:
debian/dirs:
release-notes.txt should actually be installed as upstream's changelog
(dh_installchangelogs).
Please fix the above mentioned issues (and investigate on the copyright
owner line which has a '?', and the licences of the plugins and skins).
Mathieu Parent
Cheers,
--
Atomo64 - Raphael
Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: xinha
Hi Mathieu, Mathieu PARENT wrote: Dear mentors, I am looking for a sponsor for my package xinha. * Package name: xinha Version : 0.95~rc2-1 Version 0.95 has now been released, could you please update the package? DD's: can anyone take a look at the package when updated? there are several packages shipping their own copy of xinha or htmlarea and would be nice to have just one copy in the whole archive. * URL : http://xinha.webfactional.com/ * License : BSD Section : web It builds these binary packages: xinha - powerful WYSIWYG HTML editor The package appears to be lintian clean. The upload would fix these bugs: 479708 (ITP: xinha -- powerful WYSIWYG HTML editor) The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/x/xinha - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/x/xinha/xinha_0.95~rc2-1.dsc I would be glad if someone uploaded this package for me. Kind regards Mathieu Parent Cheers, -- Atomo64 - Raphael Please avoid sending me Word, PowerPoint or Excel attachments. See http://www.gnu.org/philosophy/no-word-attachments.html -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: xinha
OoO Lors de la soirée naissante du mardi 20 mai 2008, vers 18:38, Mathieu PARENT [EMAIL PROTECTED] disait: For debian/rules, use install file instead of cp. That's not very Not done (how to install directories ?) Hi Mathieu! Use dirs file. Well, this is a matter of taste. The debian/rules is much shorter to read this way. -- BOFH excuse #81: Please excuse me, I have to circuit an AC line through my head to get this database working. pgp9i5uSlMUBm.pgp Description: PGP signature
Re: RFS: xinha
On Wed, May 14, 2008 at 7:58 PM, Vincent Bernat [EMAIL PROTECTED] wrote: OoO En cette soirée bien amorcée du lundi 12 mai 2008, vers 22:48, ;) Mathieu PARENT [EMAIL PROTECTED] disait: I am looking for a sponsor for my package xinha. * Package name: xinha Version : 0.95~rc2-1 * URL : http://xinha.webfactional.com/ * License : BSD Section : web Hi Mathieu! Hi ! DM-Upload-Allowed is now a recognized fields by dpkg. You can therefore drop XS- before it. However, a first time sponsor won't upload your package with this flag before knowing your skills more. Done Your debian/copyright is incomplete. There are some files licensed using PHP license 2.02. This license won't be accepted for main. You should check with upstream this problem. Maybe there is a more recent version with a more acceptable license. Asked this on IRC. For now, I remove these files from orig.tar.gz. I've also added LGPL to copyright file. Your debian/watch does not work. Corrected For debian/rules, use install file instead of cp. That's not very Not done (how to install directories ?) important though. Why don't you include contrib/php-xinha.php in debian/examples? Done Why do you keep empty directories? I've replaced them by symlink to /etc/xinha subfolders. This will allow installation of smileys, dictionaries, ... There is one lintian warning remaining: W: xinha: script-not-executable ./usr/share/xinha/plugins/SpellChecker/spell-check-logic.cgi Marking this one as executable. This is a cgi script. Thanks. Uploaded again to mentors.d.o Thanks -- printk(autofs: Out of inode numbers -- what the heck did you do??\n); 2.0.38 /usr/src/linux/fs/autofs/root.c
Re: RFS: xinha
OoO En cette soirée bien amorcée du lundi 12 mai 2008, vers 22:48, Mathieu PARENT [EMAIL PROTECTED] disait: I am looking for a sponsor for my package xinha. * Package name: xinha Version : 0.95~rc2-1 * URL : http://xinha.webfactional.com/ * License : BSD Section : web Hi Mathieu! DM-Upload-Allowed is now a recognized fields by dpkg. You can therefore drop XS- before it. However, a first time sponsor won't upload your package with this flag before knowing your skills more. Your debian/copyright is incomplete. There are some files licensed using PHP license 2.02. This license won't be accepted for main. You should check with upstream this problem. Maybe there is a more recent version with a more acceptable license. Your debian/watch does not work. For debian/rules, use install file instead of cp. That's not very important though. Why don't you include contrib/php-xinha.php in debian/examples? Why do you keep empty directories? There is one lintian warning remaining: W: xinha: script-not-executable ./usr/share/xinha/plugins/SpellChecker/spell-check-logic.cgi Thanks. -- printk(autofs: Out of inode numbers -- what the heck did you do??\n); 2.0.38 /usr/src/linux/fs/autofs/root.c pgp8z0xc0uuFN.pgp Description: PGP signature
RFS: xinha
Dear mentors, I am looking for a sponsor for my package xinha. * Package name: xinha Version : 0.95~rc2-1 * URL : http://xinha.webfactional.com/ * License : BSD Section : web It builds these binary packages: xinha - powerful WYSIWYG HTML editor The package appears to be lintian clean. The upload would fix these bugs: 479708 (ITP: xinha -- powerful WYSIWYG HTML editor) The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/x/xinha - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/x/xinha/xinha_0.95~rc2-1.dsc I would be glad if someone uploaded this package for me. Kind regards Mathieu Parent -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
