Re: Cleaning up after 'gbp buildpackage'
On Mon, Jul 09, 2018 at 09:12:05AM -0600, Daniele Nicolodi wrote: > On 7/9/18 12:49 AM, Andrey Rahmatullin wrote: > > On Sun, Jul 08, 2018 at 07:52:19PM -0600, Daniele Nicolodi wrote: > >> The package builds just fine without intermediated cleaning, it is just > >> gbp that complains about uncommitted changes to the source tree. That's > >> why I think I'm missing something about the gbp workflow, as I think > >> that systematically using --git-ignore-new is not the right thing. > > > > The gbp workflow implies you are not building in-tree. > > Thanks! That is what I was missing. > > Would it make sense to have this highlighted more prominently in the > documentation of gbp? I don't recall seeing it mentioned anywhere. I can > prepare a patch. Where would be a good place to add it? > > Why is building off-tree the recommended workflow? I have this exact problem as well. I solved it for me by using a build-area setup as I am used to it back from svn-buildpackage. Can I have some explanation, what in-free and off-tree building means and how that compares to the build-area feature? Greetings Marc -- - Marc Haber | "I don't trust Computers. They | Mailadresse im Header Leimen, Germany| lose things."Winona Ryder | Fon: *49 6224 1600402 Nordisch by Nature | How to make an American Quilt | Fax: *49 6224 1600421
Re: Cleaning up after 'gbp buildpackage'
On Mon, Jul 09, 2018 at 09:12:05AM -0600, Daniele Nicolodi wrote: > >> The package builds just fine without intermediated cleaning, it is just > >> gbp that complains about uncommitted changes to the source tree. That's > >> why I think I'm missing something about the gbp workflow, as I think > >> that systematically using --git-ignore-new is not the right thing. > > > > The gbp workflow implies you are not building in-tree. > > Thanks! That is what I was missing. > > Would it make sense to have this highlighted more prominently in the > documentation of gbp? I don't recall seeing it mentioned anywhere. I can > prepare a patch. Where would be a good place to add it? > > Why is building off-tree the recommended workflow? All I know is https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=859594#17 -- WBR, wRAR signature.asc Description: PGP signature
Re: Cleaning up after 'gbp buildpackage'
On 7/8/18 8:21 PM, Tong Sun wrote: > See the recommendation here > https://lists.debian.org/debian-mentors/2018/07/msg00086.html > from Shengjing on using `gbp buildpackage export-dir` > feature and see if it might help. It helped for my case. I believe that you are referring too the '--git-export-dir' option. Cheers, Dan
Re: Cleaning up after 'gbp buildpackage'
On 7/9/18 12:49 AM, Andrey Rahmatullin wrote: > On Sun, Jul 08, 2018 at 07:52:19PM -0600, Daniele Nicolodi wrote: >> The package builds just fine without intermediated cleaning, it is just >> gbp that complains about uncommitted changes to the source tree. That's >> why I think I'm missing something about the gbp workflow, as I think >> that systematically using --git-ignore-new is not the right thing. > > The gbp workflow implies you are not building in-tree. Thanks! That is what I was missing. Would it make sense to have this highlighted more prominently in the documentation of gbp? I don't recall seeing it mentioned anywhere. I can prepare a patch. Where would be a good place to add it? Why is building off-tree the recommended workflow? Cheers, Dan
Re: Cleaning up after 'gbp buildpackage'
On Sun, 08 Jul 2018, Daniele Nicolodi wrote: > On 08/07/2018 19:28, Henrique de Moraes Holschuh wrote: > > On Sun, 08 Jul 2018, Daniele Nicolodi wrote: > >> After a successful package build done with 'gbp buildpackage' the > >> package directory is left in a state which requires to run 'debuild -- > >> clean' before being able to build the package again. > > > > Packages must be buildable several times in a row *without* the need to > > *manually* call the clean target. > > > > If it needs intermediate cleaning, arrange for it to detect and do so > > automatically. > > The package builds just fine without intermediated cleaning, it is just > gbp that complains about uncommitted changes to the source tree. That's I see. Yeah, that's gbp trying too hard to protect you from yourself :( You can, of course, configure it to never warn, but then you lose that last line of defense. -- Henrique Holschuh
Re: Cleaning up after 'gbp buildpackage'
On Mon, Jul 09, 2018 at 10:51:10AM +0200, Ferenc Wágner wrote: > > gbp runs clean before the second build > > Gbp runs clean before each build, but the default clean command was > changed to /bin/true in version 0.6.9. Ah indeed. Because of my first point. -- WBR, wRAR signature.asc Description: PGP signature
Re: Cleaning up after 'gbp buildpackage'
Andrey Rahmatullin writes: > gbp runs clean before the second build Gbp runs clean before each build, but the default clean command was changed to /bin/true in version 0.6.9. You can try gbp buildpackage --git-cleaner="debuild -- clean" or something similar. -- Feri
Re: Cleaning up after 'gbp buildpackage'
On Sun, Jul 08, 2018 at 07:52:19PM -0600, Daniele Nicolodi wrote: > The package builds just fine without intermediated cleaning, it is just > gbp that complains about uncommitted changes to the source tree. That's > why I think I'm missing something about the gbp workflow, as I think > that systematically using --git-ignore-new is not the right thing. The gbp workflow implies you are not building in-tree. Even if you are, gbp runs clean before the second build, so if there are uncommitted changes then something is broken. Can you please provide more specific info? -- WBR, wRAR signature.asc Description: PGP signature
Re: Cleaning up after 'gbp buildpackage'
On Sun, Jul 8, 2018 at 9:53 PM Daniele Nicolodi - dani...@grinta.net wrote: > On 08/07/2018 19:28, Henrique de Moraes Holschuh wrote: > > On Sun, 08 Jul 2018, Daniele Nicolodi wrote: > >> After a successful package build done with 'gbp buildpackage' the > >> package directory is left in a state which requires to run 'debuild -- > >> clean' before being able to build the package again. > > > > Packages must be buildable several times in a row *without* the need to > > *manually* call the clean target. > > > > If it needs intermediate cleaning, arrange for it to detect and do so > > automatically. > > The package builds just fine without intermediated cleaning, it is just > gbp that complains about uncommitted changes to the source tree. That's > why I think I'm missing something about the gbp workflow, as I think > that systematically using --git-ignore-new is not the right thing. > See the recommendation here https://lists.debian.org/debian-mentors/2018/07/msg00086.html from Shengjing on using `gbp buildpackage export-dir` feature and see if it might help. It helped for my case.
Re: Cleaning up after 'gbp buildpackage'
On 08/07/2018 19:28, Henrique de Moraes Holschuh wrote: > On Sun, 08 Jul 2018, Daniele Nicolodi wrote: >> After a successful package build done with 'gbp buildpackage' the >> package directory is left in a state which requires to run 'debuild -- >> clean' before being able to build the package again. > > Packages must be buildable several times in a row *without* the need to > *manually* call the clean target. > > If it needs intermediate cleaning, arrange for it to detect and do so > automatically. The package builds just fine without intermediated cleaning, it is just gbp that complains about uncommitted changes to the source tree. That's why I think I'm missing something about the gbp workflow, as I think that systematically using --git-ignore-new is not the right thing. Cheers, Dan
Re: Cleaning up after 'gbp buildpackage'
On Sun, 08 Jul 2018, Daniele Nicolodi wrote: > After a successful package build done with 'gbp buildpackage' the > package directory is left in a state which requires to run 'debuild -- > clean' before being able to build the package again. Packages must be buildable several times in a row *without* the need to *manually* call the clean target. If it needs intermediate cleaning, arrange for it to detect and do so automatically. -- Henrique Holschuh
