Re: Question about a file inside debian directory
On Sun, Dec 09, 2018 at 09:22:34PM +0100, Jose G. López wrote: > On Fri, 7 Dec 2018 16:37:27 +0500 > Andrey Rahmatullin wrote: > > > On Fri, Dec 07, 2018 at 11:59:16AM +0100, Jose G. López wrote: > > > Well my problem is that upstream's software is intended to build just > > > an executable and I'm building a shared library. > > This is even more important problem. Are you sure you can do it properly? > > I will contact upstream to see if she is insterested in autotoolize her > software and give her a hand with that. > In the meantime, I think the package is building and working properly; > I did some tests linking litle programs with the library, executing, ... It's not just about testing something right now, it's a long-term commitment. You need to maintain the ABI and make sure all users of the library never break. -- WBR, wRAR signature.asc Description: PGP signature
Re: Question about a file inside debian directory
On Fri, 7 Dec 2018 16:37:27 +0500 Andrey Rahmatullin wrote: > On Fri, Dec 07, 2018 at 11:59:16AM +0100, Jose G. López wrote: > > Well my problem is that upstream's software is intended to build just > > an executable and I'm building a shared library. > This is even more important problem. Are you sure you can do it properly? I will contact upstream to see if she is insterested in autotoolize her software and give her a hand with that. In the meantime, I think the package is building and working properly; I did some tests linking litle programs with the library, executing, ... > On Fri, 7 Dec 2018 13:50:07 +0100 > Adam Borowski wrote: > There's also a third way: as debian/rules is a makefile, it can do whatever > you want. Patching the upstream Makefile is good when you want to amend or > change some issue, not when you replace it completely. Thank you Adam, I followed your advice and moved all building instructions to debian/rules. Source package is uploaded to mentors: https://mentors.debian.net/package/fathom dget -x https://mentors.debian.net/debian/pool/main/f/fathom/fathom_1.0-1.dsc And the repository at: https://salsa.debian.org/josgalo-guest/fathom.git If someone can review it and believes it's correct, I will open an RFS bug. Regards, pgpZaJys7LPTf.pgp Description: PGP signature
Re: Question about a file inside debian directory
On Fri, Dec 07, 2018 at 11:35:52AM +0100, Jose G. López wrote: > Dear mentors, > > Is it permitted by the Debian Policy to have a personalized makefile inside > debian > directory and call it from rules file? Or I should patch the upstream's > makefile completly? There's also a third way: as debian/rules is a makefile, it can do whatever you want. Patching the upstream Makefile is good when you want to amend or change some issue, not when you replace it completely. Meow! -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ Ivan was a worldly man: born in St. Petersburg, raised in ⢿⡄⠘⠷⠚⠋⠀ Petrograd, lived most of his life in Leningrad, then returned ⠈⠳⣄ to the city of his birth to die.
Re: Question about a file inside debian directory
On Fri, Dec 07, 2018 at 11:59:16AM +0100, Jose G. López wrote: > Well my problem is that upstream's software is intended to build just > an executable and I'm building a shared library. This is even more important problem. Are you sure you can do it properly? -- WBR, wRAR signature.asc Description: PGP signature
Re: Question about a file inside debian directory
On Fri, 7 Dec 2018 10:43:26 + Mo Zhou wrote: > Hi Jose, > > If you think writting a new makefile is better than patching the > upstream build system, please go ahead. However, having to write a > makefiles by oneself often signifies problematic upstream. > > On Fri, 7 Dec 2018 15:40:17 +0500 > Andrey Rahmatullin wrote: > The ideal thing is to fix the problem in the upstream, not locally. For > that you usually need to make a patch first. > What problem are you solving in this way? Thanks Mo, Andrey! Well my problem is that upstream's software is intended to build just an executable and I'm building a shared library. It's a requirement as I plan to package some current chess engines who are embedding this probe tool. Regards, pgpRmLsepTphq.pgp Description: PGP signature
Re: Question about a file inside debian directory
Hi Jose, If you think writting a new makefile is better than patching the upstream build system, please go ahead. However, having to write a makefiles by oneself often signifies problematic upstream. On Fri, Dec 07, 2018 at 11:35:52AM +0100, Jose G. López wrote: > Dear mentors, > > Is it permitted by the Debian Policy to have a personalized makefile inside > debian > directory and call it from rules file? Or I should patch the upstream's > makefile completly? > > I'm packaging fathom[0][1] and can't find an answer. > Thanks and sorry if the answer is obvious. > > Regards, > > [0] Bug#915242: fathom -- Library for probing Syzygy tablebases [ITP] > [1] https://salsa.debian.org/josgalo-guest/fathom.git (test branch)
Re: Question about a file inside debian directory
On Fri, Dec 07, 2018 at 11:35:52AM +0100, Jose G. López wrote: > Dear mentors, > > Is it permitted by the Debian Policy to have a personalized makefile inside > debian > directory and call it from rules file? Or I should patch the upstream's > makefile completly? > > I'm packaging fathom[0][1] and can't find an answer. > Thanks and sorry if the answer is obvious. The ideal thing is to fix the problem in the upstream, not locally. For that you usually need to make a patch first. What problem are you solving in this way? -- WBR, wRAR signature.asc Description: PGP signature
