Re: RFS: gthumb (updated and adopted package)
David Paleino wrote: Il giorno Wed, 2 Jan 2008 11:57:17 +0100 David Paleino [EMAIL PROTECTED] ha scritto: ... I've prepared a new version (3:2.10.8-1). Which is finally ready, thanks to Ove Kaaven, who avoided me going mad, and to Julien Valroff, who helped as well. dget http://mentors.debian.net/debian/pool/main/g/gthumb/gthumb_2.10.8-1.dsc This version has two serious bugs: 1.) gthumb-data ships /usr/share/icons/hicolor/48x48/apps/gthumb.png which was in gthumb in older releases. An upgrade fails because of that. You need a conflicts/replaces: ghtumb ( 2.10.8-1) 2.) It uses gtk-update-icon-cache in postinst. This is also a serious bug. Use dh_icons instead. I'm not sure if the above version got uploaded to unstable (and is currently in NEW). If so, please prepare a fixed version -2 asap so this version doesn't hit unstable. Cheers, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
Re: RFS: gthumb (updated and adopted package)
Michael Biebl wrote: David Paleino wrote: Il giorno Wed, 2 Jan 2008 11:57:17 +0100 David Paleino [EMAIL PROTECTED] ha scritto: ... I've prepared a new version (3:2.10.8-1). Which is finally ready, thanks to Ove Kaaven, who avoided me going mad, and to Julien Valroff, who helped as well. dget http://mentors.debian.net/debian/pool/main/g/gthumb/gthumb_2.10.8-1.dsc This version has two serious bugs: Oh, and another thing: the documentation is licensed under the GFDL but debian/copyright does not contain this info. Please fix that too. Cheers, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
Re: RFS: gthumb (updated and adopted package)
Il giorno Mon, 21 Jan 2008 23:32:57 +0100 Michael Biebl [EMAIL PROTECTED] ha scritto: Michael Biebl wrote: David Paleino wrote: dget http://mentors.debian.net/debian/pool/main/g/gthumb/gthumb_2.10.8-1.dsc This version has two serious bugs: Oh, and another thing: the documentation is licensed under the GFDL but debian/copyright does not contain this info. Please fix that too. Thank you for pointing those issues. :) They've already been fixed in SVN (collab-maint), and I'm now building the package I will upload on mentors. I hope this package will be uploaded before -1 enters incoming :) Kindly, David -- . ''`. Debian maintainer | http://wiki.debian.org/DavidPaleino : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/ `. `'` GPG: 1392B174 | http://snipr.com/qa_page `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: gthumb (updated and adopted package)
David Paleino wrote: Il giorno Mon, 21 Jan 2008 23:32:57 +0100 Michael Biebl [EMAIL PROTECTED] ha scritto: Michael Biebl wrote: David Paleino wrote: dget http://mentors.debian.net/debian/pool/main/g/gthumb/gthumb_2.10.8-1.dsc This version has two serious bugs: Oh, and another thing: the documentation is licensed under the GFDL but debian/copyright does not contain this info. Please fix that too. Thank you for pointing those issues. :) They've already been fixed in SVN (collab-maint), and I'm now building the package I will upload on mentors. debian/control is missing a Replaces: gthumb ( 3:2.10.8-1) Besides that, I think it's safe to delete gthumb.postinst.old and gthumb.postrm.old. This is what VCSes are for ;-) Cheers, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
Re: RFS: gthumb (updated and adopted package)
David Paleino wrote: Il giorno Mon, 07 Jan 2008 05:52:03 +0100 Michael Biebl [EMAIL PROTECTED] ha scritto: Could you please make the yelp dependency a Recommends? May I ask why? Sure. I believe yelp is better suited as a Depends (AFAIK, to read gnome-doc documentation, you need yelp) gthumbs main purpose is to display images. It works perfectly fine without an installed yelp, yelp is only needed if you want to show gthumbs program documentation, which e.g. I never used until today. Recommends is absolutely sufficient for that (One could even argue if Suggests is sufficient). Imho there is no reason why gthumb has to have a hard dependency on yelp. Quoting the policy: Depends This declares an absolute dependency. A package will not be configured unless all of the packages listed in its Depends field have been correctly configured. The Depends field should be used if the depended-on package is required for the depending package to provide a significant amount of functionality. Recommends This declares a strong, but not absolute, dependency. The Recommends field should list packages that would be found together with this one in all but unusual installations. Imo yelp doesn't satisfy the provide a significant amount of functionality clause as gthumbs purpose is to be an image-viewer and not a help-viewer. Cheers, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
Re: RFS: gthumb (updated and adopted package)
Il giorno Sun, 13 Jan 2008 10:53:37 +0100 Michael Biebl [EMAIL PROTECTED] ha scritto: David Paleino wrote: I believe yelp is better suited as a Depends (AFAIK, to read gnome-doc documentation, you need yelp) gthumbs main purpose is to display images. It works perfectly fine without an installed yelp, yelp is only needed if you want to show gthumbs program documentation, which e.g. I never used until today. Recommends is absolutely sufficient for that (One could even argue if Suggests is sufficient). ... You're absolutely right, thank you for pointing this out :) It's been fixed in SVN (collab-maint), I hope someone didn't sponsor it yet ;) Kindly, David -- . ''`. Debian maintainer | http://wiki.debian.org/DavidPaleino : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/ `. `'` GPG: 1392B174 | http://snipr.com/qa_page `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: gthumb (updated and adopted package)
Il giorno Mon, 07 Jan 2008 05:52:03 +0100 Michael Biebl [EMAIL PROTECTED] ha scritto: Could you please make the yelp dependency a Recommends? May I ask why? I believe yelp is better suited as a Depends (AFAIK, to read gnome-doc documentation, you need yelp) Kindly, David -- . ''`. Debian maintainer | http://wiki.debian.org/DavidPaleino : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/ `. `'` GPG: 1392B174 | http://snipr.com/qa_page `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: gthumb (updated and adopted package)
On 13/01/2008, David Paleino wrote: Could you please make the yelp dependency a Recommends? May I ask why? So that it gets pulled in by default. But so that one can still choose not to install yelp at all, e.g. because one isn't interested at all by documentation (e.g. because online helps will be sufficient, if ever needed). Cheers, -- Cyril Brulebois pgplbIdro2s7S.pgp Description: PGP signature
Re: RFS: gthumb (updated and adopted package)
David Paleino wrote: Il giorno Wed, 2 Jan 2008 11:57:17 +0100 David Paleino [EMAIL PROTECTED] ha scritto: ... I've prepared a new version (3:2.10.8-1). Which is finally ready, thanks to Ove Kaaven, who avoided me going mad, and to Julien Valroff, who helped as well. Could you please make the yelp dependency a Recommends? Cheers, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
Re: RFS: gthumb (updated and adopted package)
Il giorno Wed, 2 Jan 2008 11:57:17 +0100 David Paleino [EMAIL PROTECTED] ha scritto: ... I've prepared a new version (3:2.10.8-1). Which is finally ready, thanks to Ove Kaaven, who avoided me going mad, and to Julien Valroff, who helped as well. dget http://mentors.debian.net/debian/pool/main/g/gthumb/gthumb_2.10.8-1.dsc Please have a look at it: it now leaves data/gthumb.desktop modified after the build, because there are some patches that edit the source files for it. But there's no easy solution for this, AFAICT. As soon as libopenraw gets sponsored as well, I'll release a -2 with libopenraw support (it's just a configure flag to add, nothing difficult ;)). In the meanwhile, I believe it's better uploading this version and closing all those bugs ;) Have a nice day, David -- . ''`. Debian maintainer | http://snipurl.com/qa_page : :' : Linuxer #334216 | http://www.hanskalabs.net/ `. `'`GPG: 1392B174 | http://www.debianizzati.org/ `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: gthumb (updated and adopted package)
Il giorno Wed, 2 Jan 2008 12:02:58 +0100 David Paleino [EMAIL PROTECTED] ha scritto: Please don't upload it yet. I've just found out a minor issue during build: after svn-buildpackage the sources are left modified. Looking at it right now. Ok, I can't solve this, thus asking for help. Upstream's tarball provides a file, src/GNOME_GThumb.h, which is dynamically generated during the build. Now, it happens that this file, at the end of the build, is different from the provided one, and $(MAKE) distclean deletes it. This gives a tarball different from the original one, thus having unmatching md5sums. What I've done is: 1) patching the Makefile.{am,in} to make that file stay there after distclean; 2) patching the cited file to prevent modifications during the build (it's just a line removed), so that when the unpatch rule does its job, it goes back to the original file. These actions did have catastrofic effects: the build fails, looking for a non-existant file, which is named after a Makefile rule. I can't understand why make is looking for that file; it is not referenced anywhere, only in that rule (it's something like gthumb_sources_idl_stamp). This is probably due to the fact that the removed line is: #line 14 /usr/share/idl/bonobo-2.0/Bonobo.idl Without those patches, it builds just fine, but this is what happens when the build finishes: $ svn-buildpackage ... ... $ svn status M src/GNOME_GThumb.h $ This isn't, obviously, optimal: I'd expect a FTBFS if this package gets uploaded, and I wouldn't know how to fix it, since I'm not able right now. Any help? :) David -- . ''`. Debian maintainer | http://snipurl.com/qa_page : :' : Linuxer #334216 | http://www.hanskalabs.net/ `. `'`GPG: 1392B174 | http://www.debianizzati.org/ `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: gthumb (updated and adopted package)
Hi David, Le jeudi 03 janvier 2008 à 19:22 +0100, David Paleino a écrit : [...] .. $ svn status M src/GNOME_GThumb.h $ This isn't, obviously, optimal: I'd expect a FTBFS if this package gets uploaded, and I wouldn't know how to fix it, since I'm not able right now. Just a suggestion: why not copy the original file while building, and move the copy back to its original location in the clean rule? Cheers, Julien -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: gthumb (updated and adopted package)
Il giorno Thu, 03 Jan 2008 19:28:33 +0100 Julien Valroff [EMAIL PROTECTED] ha scritto: Hi David, Hi Julien, Le jeudi 03 janvier 2008 à 19:22 +0100, David Paleino a écrit : [...] .. $ svn status M src/GNOME_GThumb.h $ This isn't, obviously, optimal: I'd expect a FTBFS if this package gets uploaded, and I wouldn't know how to fix it, since I'm not able right now. Just a suggestion: why not copy the original file while building, and move the copy back to its original location in the clean rule? Uhm. This seems a ugly hack to me, but might work :) (/me stupid for not thinking before!) Let me try, I'll be here (I hope) in ~5mins (build time ;)) David -- . ''`. Debian maintainer | http://snipurl.com/qa_page : :' : Linuxer #334216 | http://www.hanskalabs.net/ `. `'`GPG: 1392B174 | http://www.debianizzati.org/ `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: gthumb (updated and adopted package)
Hi Ove, (please don't CC me, I'm subscribed to the list) Il giorno Thu, 03 Jan 2008 22:27:55 +0100 Ove Kaaven [EMAIL PROTECTED] ha scritto: David Paleino skrev: Upstream's tarball provides a file, src/GNOME_GThumb.h, which is dynamically generated during the build. Now, it happens that this file, at the end of the build, is different from the provided one, and $(MAKE) distclean deletes it. Does it *need* to exist before you start the build, or is it a completely autogenerated file? If the latter, you shouldn't have to do anything at all. Let distclean wipe it, it'll result in a clean .diff.gz. It seems like is not needed: $ svn rm src/GNOME_GThumb.h D src/GNOME_GThumb.h $ svn status M debian/patches/series M debian/rules D src/GNOME_GThumb.h $ svn-buildpackage ... ... build command was successful; binaries are in /deb/rep/build-area/. The changes file is: /deb/rep/build-area/gthumb_2.10.8-1_i386.changes Binary packages: /deb/rep/build-area/gthumb_2.10.8-1_i386.deb /deb/rep/build-area/gthumb-data_2.10.8-1_all.deb rm -rf /deb/rep/build-area/gthumb-2.10.8 $ svn status M debian/patches/series M debian/rules D src/GNOME_GThumb.h $ but... read the following. This gives a tarball different from the original one, thus having unmatching md5sums. If it's a non-native package, the orig tarball doesn't change. If you're making a new tarball after building, you're doing something wrong. Pretty much any attempt to create the exact same tarball more than once is doomed to fail, if only because the timestamp will be different. I'm not recreating the tarball. The first times I was making packages, my sponsors told me that the result of debuild clean (or fakeroot debian/rules clean) had to be the same as the original tarball unpacked + debian/. Is this wrong? This is the real question: upstream provides that file, while at the end of debian/rules clean I simply delete it, thus having different tarballs (in a wider sense) I hope you got my point. Kindly, David -- . ''`. Debian maintainer | http://snipurl.com/qa_page : :' : Linuxer #334216 | http://www.hanskalabs.net/ `. `'`GPG: 1392B174 | http://www.debianizzati.org/ `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: gthumb (updated and adopted package)
David Paleino skrev: Il giorno Wed, 2 Jan 2008 12:02:58 +0100 David Paleino [EMAIL PROTECTED] ha scritto: Please don't upload it yet. I've just found out a minor issue during build: after svn-buildpackage the sources are left modified. Looking at it right now. Ok, I can't solve this, thus asking for help. Upstream's tarball provides a file, src/GNOME_GThumb.h, which is dynamically generated during the build. Now, it happens that this file, at the end of the build, is different from the provided one, and $(MAKE) distclean deletes it. Does it *need* to exist before you start the build, or is it a completely autogenerated file? If the latter, you shouldn't have to do anything at all. Let distclean wipe it, it'll result in a clean .diff.gz. This gives a tarball different from the original one, thus having unmatching md5sums. If it's a non-native package, the orig tarball doesn't change. If you're making a new tarball after building, you're doing something wrong. Pretty much any attempt to create the exact same tarball more than once is doomed to fail, if only because the timestamp will be different. (Just pitching in...) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: gthumb (updated and adopted package)
David Paleino skrev: I'm not recreating the tarball. The first times I was making packages, my sponsors told me that the result of debuild clean (or fakeroot debian/rules clean) had to be the same as the original tarball unpacked + debian/. Is this wrong? I'd qualify that somewhat. It's certainly good practice; the idea is that building again never results in something different, and it's good to be clean anyway. However, if doing that is difficult (such as if upstream forgot to run distclean and left cruft in the orig tarball), I think it's also reasonable to follow the following rule (considering dpkg-buildpackage will invoke clean before building): Original tarball + debian diff + debuild clean = debuild + debuild clean or, failing that, at least the fundamental rule: Original tarball + debian diff + debuild + debuild clean = another debuild + debuild clean You should never break this last rule, but the stricter rule you're currently following is not really worth bending over backwards for IMHO. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: gthumb (updated and adopted package)
Il giorno Fri, 28 Dec 2007 23:59:37 +0100 David Paleino [EMAIL PROTECTED] ha scritto: Dear mentors, I am looking for a sponsor for the new version 3:2.10.7-1 I've prepared a new version (3:2.10.8-1). ... The package is not lintian clean, it has 3 overrides: - gthumb: menu-icon-missing (it is in gthumb-data, no need to duplicate it) Now this is the only overrode warning (libraries have gone into a private directory using RPATH: /usr/lib/gthumb/) ... The upload would fix the ITA bug #457591 It would also fix (notice there are a couple more bugs fixed over the last summary mail I sent): 452929 - gthumb: fit and width zoom options do not work (important) 457350 - gthumb: crash when trying to print (important) 298881 - gthumb: Options on the command line are ineffective (normal) 340820 - gthumb help is broken (normal) 446413 - gthumb: corrupt memory when trying to print (normal) 454298 - crashes when trying to print (normal) 457021 - gthumb: please add alternative dependency on rarian-compat (normal) 310095 - gthumb: no key binding for 'Do Not Save' (minor) 404086 - gthumb: menu shortcut conflict with de locale (minor) 403736 - please improve .desktop (wishlist) 456602 - gthumb: Do not depend upon versioned scrollkeeper (wishlist) 457509 - new version available (2.10.6) (wishlist) (i.e. 2 important, 5 normal, 2 minor, 3 wishlist) The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/g/gthumb - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/g/gthumb/gthumb_2.10.7-1.dsc I would be glad if someone uploaded this package for me. Kindly, David -- . ''`. Debian maintainer | http://snipurl.com/qa_page : :' : Linuxer #334216 | http://www.hanskalabs.net/ `. `'`GPG: 1392B174 | http://www.debianizzati.org/ `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: gthumb (updated and adopted package)
Il giorno Wed, 2 Jan 2008 11:57:17 +0100 David Paleino [EMAIL PROTECTED] ha scritto: I've prepared a new version (3:2.10.8-1). (sorry for keeping quoting myself, just didn't want to start a new thread) Please don't upload it yet. I've just found out a minor issue during build: after svn-buildpackage the sources are left modified. Looking at it right now. David -- . ''`. Debian maintainer | http://snipurl.com/qa_page : :' : Linuxer #334216 | http://www.hanskalabs.net/ `. `'`GPG: 1392B174 | http://www.debianizzati.org/ `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: gthumb (updated and adopted package)
Le dimanche 30 décembre 2007 à 08:50 +0100, David Paleino a écrit : Il giorno Sun, 30 Dec 2007 08:32:20 +0100 Julien Valroff [EMAIL PROTECTED] ha scritto: I have built the new release, but still an issue with libgthumb.so - gthumb can't find the library: $ ldd /usr/bin/gthumb | grep not found libgthumb.so = not found I attach the build log as there are many related Lintian warnings/errors s/Lintian/dpkg-shlibdeps/ ^^ Those warnings are because dpkg-shlibdeps sees many unneeded linkings. If I'm not wrong, there is a discussion on debian-devel about adding -Wl,--as-needed to LDFLAGS to avoid those warnings [1]. I mainly refer to the warnings refering to missing libgthumb.so as you have noticed below. However, on my system: $ ldd /usr/bin/gthumb | grep libgthumb libgthumb.so = /usr/lib/gthumb/libgthumb.so (0xb7ef9000) Are you sure you have the right package? What does $ dpkg -c package.deb | grep libgthumb return? Is libgthumb.so still a symlink? No, it is in /usr/lib/gthumb/libgthumb.so About the buildlog youo attached: at line 2527, libgthumb.so gets correctly installed into the tmp/ directory: /usr/bin/install -c .libs/libgthumb.so /tmp/gthumb-2.10.7/debian/tmp/usr/lib/gthumb/libgthumb.so This might be indicative though: dpkg-shlibdeps: warning: couldn't find library libgthumb.so needed by debian/gthumb/usr/lib/gthumb/gthumb/modules/libduplicates.so (its RPATH is ''). Note: libraries are not searched in other binary packages that do not have any shlibs file. To help dpkg-shlibdeps find private libraries, you might need to set LD_LIBRARY_PATH. and similarly for other libraries (happens also for me). So, we said that the shlibs file is useless, dpkg here suggests that it only searches into shlibs-providing packages. Should I make a symlink /usr/lib/libgthumb.so pointing to the real .so, and override package name doesn't match SONAME warnings, or...? Creating a symlink in /usr/lib does work: $ ldd /usr/bin/gthumb | grep libgthumb libgthumb.so = /usr/lib/libgthumb.so (0x2b6e5c45a000) That's what was done by the previous maintainer. I am not sure it is the right thing to do. What I don't understand is why it works for you and not for me. Don't you have a ligthumb.so file remaining in /usr/lib from a previous installation? I've just rebuilt the package, and libgthumb.so is correctly placed into /usr/lib/gthumb/. And, again: It is well installed now, but gthumb cannot find it in /usr/lib/gthumb So, I guess, is it probably a amd64-related/specific problem? Again, I am not an expert but I wouldn't understand why. The only particularity I am aware of is: /etc/ld.so.conf.d/x86_64-linux-gnu.conf stating: # Multiarch support /lib/x86_64-linux-gnu /usr/lib/x86_64-linux-gnu Cheers, Julien -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: gthumb (updated and adopted package)
Il giorno Sun, 30 Dec 2007 09:55:55 +0100 Julien Valroff [EMAIL PROTECTED] ha scritto: However, on my system: $ ldd /usr/bin/gthumb | grep libgthumb libgthumb.so = /usr/lib/gthumb/libgthumb.so (0xb7ef9000) Are you sure you have the right package? What does $ dpkg -c package.deb | grep libgthumb return? Is libgthumb.so still a symlink? No, it is in /usr/lib/gthumb/libgthumb.so That is the right location. Creating a symlink in /usr/lib does work: $ ldd /usr/bin/gthumb | grep libgthumb libgthumb.so = /usr/lib/libgthumb.so (0x2b6e5c45a000) That's what was done by the previous maintainer. I am not sure it is the right thing to do. That's why I removed that link, it was meaningless (until what you're reporting now). What I don't understand is why it works for you and not for me. Don't you have a ligthumb.so file remaining in /usr/lib from a previous installation? No: $ ls -lah /usr/lib/libgthumb* ls: /usr/lib/libgthumb*: No such file or directory $ This is kinda weird. Try removing (and purging, let's be sure) the package, deleting all of what you downloaded until now, dget -x the dsc file and recompile it. I'll do the same, and, if the case, reupload the package on mentors.debian.net. I can't understand why it's acting this way. :( Kindly, David -- . ''`. Debian maintainer | http://snipurl.com/qa_page : :' : Linuxer #334216 | http://www.hanskalabs.net/ `. `'`GPG: 1392B174 | http://www.debianizzati.org/ `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: gthumb (updated and adopted package)
Il giorno Sun, 30 Dec 2007 09:55:55 +0100 Julien Valroff [EMAIL PROTECTED] ha scritto: ... Creating a symlink in /usr/lib does work: $ ldd /usr/bin/gthumb | grep libgthumb libgthumb.so = /usr/lib/libgthumb.so (0x2b6e5c45a000) Strangely enough, I've just reproduced it. Recompiled the debianized source from collab-maint SVN (where I maintain my packages), and running gthumb raises: gthumb: error while loading shared libraries: libgthumb.so: cannot open shared object file: No such file or directory Now, there are two possible solutions: a) creating a symlink (do I need to create a shlibs?) b) moving everything from /usr/lib/gthumb/ to /usr/lib/ I would prefer the first solution, since those libraries are private ones and shouldn't be used by other programs. Any idea? Kindly, David -- . ''`. Debian maintainer | http://snipurl.com/qa_page : :' : Linuxer #334216 | http://www.hanskalabs.net/ `. `'`GPG: 1392B174 | http://www.debianizzati.org/ `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: gthumb (updated and adopted package)
Le dimanche 30 décembre 2007 à 10:02 +0100, David Paleino a écrit : Il giorno Sun, 30 Dec 2007 09:55:55 +0100 [...] This is kinda weird. It is, yes. Try removing (and purging, let's be sure) the package, deleting all of what you downloaded until now, dget -x the dsc file and recompile it. I'll do the same, and, if the case, reupload the package on mentors.debian.net. I have done it, and still the same issue. The timestamp of the latest changelog entry is Sat, 29 Dec 2007 21:40:26 +0100, is that correct? Cheers, Julien -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: gthumb (updated and adopted package)
(sorry for quoting myself) Il giorno Sun, 30 Dec 2007 10:25:25 +0100 David Paleino [EMAIL PROTECTED] ha scritto: ... Now, there are two possible solutions: a) creating a symlink (do I need to create a shlibs?) b) moving everything from /usr/lib/gthumb/ to /usr/lib/ I believe I've found an error in the libraries tree. In the configure script I was setting libdir and libexecdir to /usr/lib/gthumb. This way, this is what we had in /usr/lib/: /usr/lib/ /usr/lib/gthumb/ /usr/lib/gthumb/libgthumb.so /usr/lib/gthumb/bonobo/ /usr/lib/gthumb/bonobo/servers/ /usr/lib/gthumb/bonobo/servers/GNOME_GThumb.server /usr/lib/gthumb/gthumb/ /usr/lib/gthumb/gthumb/modules/ /usr/lib/gthumb/gthumb/modules/libsearch.so /usr/lib/gthumb/gthumb/modules/libpngexporter.so /usr/lib/gthumb/gthumb/modules/libphotoimporter.so /usr/lib/gthumb/gthumb/modules/libwebexporter.so /usr/lib/gthumb/gthumb/modules/libjpegtran.so /usr/lib/gthumb/gthumb/modules/libduplicates.so which is, obviously, wrong. I'm now compiling with libdir and libexecdir to /usr/lib, I'll also need a shlibs file and some lintian overrides (package name and SONAME, and some other). I'll report as soon as I put a fixed version on mentors :) Cheers, David -- . ''`. Debian maintainer | http://snipurl.com/qa_page : :' : Linuxer #334216 | http://www.hanskalabs.net/ `. `'`GPG: 1392B174 | http://www.debianizzati.org/ `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: gthumb (updated and adopted package)
Il giorno Sun, 30 Dec 2007 10:37:36 +0100 David Paleino [EMAIL PROTECTED] ha scritto: (sorry for quoting myself) ... I'm now compiling with libdir and libexecdir to /usr/lib, I'll also need a shlibs file and some lintian overrides (package name and SONAME, and some other). I'll report as soon as I put a fixed version on mentors :) Lintian complains again now (obviously): E: gthumb: shlib-missing-in-control-file libgthumb.so for usr/lib/libgthumb.so W: gthumb: unused-shlib-entry-in-control-file libgthumb gthumb W: gthumb: package-name-doesnt-match-sonames libgthumb These are the warnings I did override at the very beginning of this thread; the proposed solution was to move everything under /usr/lib/gthumb/, but I don't really like it. Neither the symlink solution sounds clean. I've just sent a mail to debian-devel on how to write a proper shlibs file for unversioned SONAMEs (I wrote there because I believe I can have a larger audience to look at the post) I'll wait for a reply before proceeding. Kindly, David -- . ''`. Debian maintainer | http://snipurl.com/qa_page : :' : Linuxer #334216 | http://www.hanskalabs.net/ `. `'`GPG: 1392B174 | http://www.debianizzati.org/ `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: gthumb (updated and adopted package)
Il giorno Sun, 30 Dec 2007 11:18:36 +0100 David Paleino [EMAIL PROTECTED] ha scritto: ... I'll wait for a reply before proceeding. In the meanwhile, I've built a package which works just fine: http://mentors.debian.net/debian/pool/main/g/gthumb/gthumb_2.10.7-1.dsc It puts everything in /usr/lib, but libgthumb.so, which is put in /usr/lib/gthumb. This way we have: /usr/lib/ /usr/lib/bonobo/ /usr/lib/bonobo/servers/ /usr/lib/bonobo/servers/GNOME_GThumb.server /usr/lib/gthumb/ /usr/lib/gthumb/libgthumb.so /usr/lib/gthumb/modules/ /usr/lib/gthumb/modules/libsearch.so /usr/lib/gthumb/modules/libpngexporter.so /usr/lib/gthumb/modules/libphotoimporter.so /usr/lib/gthumb/modules/libwebexporter.so /usr/lib/gthumb/modules/libjpegtran.so /usr/lib/gthumb/modules/libduplicates.so ... /usr/lib/libgthumb.so - gthumb/libgthumb.so (note the difference from the previous similar mail) To me, if there are not other solutions for the unversioned SONAME, this package is ready to be uploaded. Have a nice day, David -- . ''`. Debian maintainer | http://snipurl.com/qa_page : :' : Linuxer #334216 | http://www.hanskalabs.net/ `. `'`GPG: 1392B174 | http://www.debianizzati.org/ `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: gthumb (updated and adopted package)
Il giorno Sun, 30 Dec 2007 12:18:01 +0100 David Paleino [EMAIL PROTECTED] ha scritto: ... To me, if there are not other solutions for the unversioned SONAME, this package is ready to be uploaded. Final version: using -Wl,-rpath,/usr/lib/gthumb. The package is now ready. Cheers, David -- . ''`. Debian maintainer | http://snipurl.com/qa_page : :' : Linuxer #334216 | http://www.hanskalabs.net/ `. `'`GPG: 1392B174 | http://www.debianizzati.org/ `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: gthumb (updated and adopted package)
Il giorno Fri, 28 Dec 2007 23:59:37 +0100 David Paleino [EMAIL PROTECTED] ha scritto: Dear mentors, I am looking for a sponsor for the new version 3:2.10.7-1 of the package gthumb, which I'm adopting. ... The upload would fix the ITA bug #457591 It would currently also close (I've updated the package available on mentors in the meanwhile): #310095 - gthumb: no key binding for 'Do Not Save' #340820 - gthumb help is broken #403736 - please improve .desktop #404086 - gthumb: menu shortcut conflict with de locale #456602 - gthumb: Do not depend upon versioned scrollkeeper #457021 - gthumb: please add alternative dependency on rarian-compat #457509 - new version available (2.10.6) Please consider uploading it :) The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/g/gthumb - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/g/gthumb/gthumb_2.10.7-1.dsc I would be glad if someone uploaded this package for me. Kind regards, David -- . ''`. Debian maintainer | http://snipurl.com/qa_page : :' : Linuxer #334216 | http://www.hanskalabs.net/ `. `'`GPG: 1392B174 | http://www.debianizzati.org/ `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: gthumb (updated and adopted package)
Hi David, Le samedi 29 décembre 2007 à 19:16 +0100, David Paleino a écrit : Il giorno Fri, 28 Dec 2007 23:59:37 +0100 David Paleino [EMAIL PROTECTED] ha scritto: Dear mentors, I am looking for a sponsor for the new version 3:2.10.7-1 of the package gthumb, which I'm adopting. ... The upload would fix the ITA bug #457591 It would currently also close (I've updated the package available on mentors in the meanwhile): [...] Please consider uploading it :) I have built the package from the sources available on mentors, and gthumb cannot load: $ LANG=C gthumb gthumb: error while loading shared libraries: libgthumb.so: cannot open shared object file: No such file or directory Indeed, libgthumb.so is not part of the package: [EMAIL PROTECTED]:/tmp$ dpkg --contents gthumb_2.10.7-1_amd64.deb | grep libgthumb.so lrwxrwxrwx root/root 0 2007-12-29 19:37 ./usr/lib/gthumb/libgthumb.so - gthumb/libgthumb.so [EMAIL PROTECTED]:/tmp$ ll /usr/lib/gthumb/ total 948 drwxr-xr-x 3 root root 4096 2007-12-29 20:12 bonobo drwxr-xr-x 3 root root 4096 2007-12-29 20:12 gthumb -rw-r--r-- 1 root root 952630 2007-12-29 19:37 libgthumb.a -rw-r--r-- 1 root root 1730 2007-12-29 19:37 libgthumb.la lrwxrwxrwx 1 root root 19 2007-12-29 20:12 libgthumb.so - gthumb/libgthumb.so [EMAIL PROTECTED]:/tmp$ ll /usr/lib/gthumb/gthumb/modules/ total 924 -rw-r--r-- 1 root root 33614 2007-12-29 19:37 libduplicates.a -rw-r--r-- 1 root root 1803 2007-12-29 19:37 libduplicates.la -rw-r--r-- 1 root root 30304 2007-12-29 19:37 libduplicates.so -rw-r--r-- 1 root root 67110 2007-12-29 19:37 libjpegtran.a -rw-r--r-- 1 root root 1789 2007-12-29 19:37 libjpegtran.la -rw-r--r-- 1 root root 58824 2007-12-29 19:37 libjpegtran.so -rw-r--r-- 1 root root 99260 2007-12-29 19:37 libphotoimporter.a -rw-r--r-- 1 root root 1962 2007-12-29 19:37 libphotoimporter.la -rw-r--r-- 1 root root 78680 2007-12-29 19:37 libphotoimporter.so -rw-r--r-- 1 root root 103816 2007-12-29 19:37 libpngexporter.a -rw-r--r-- 1 root root 1810 2007-12-29 19:37 libpngexporter.la -rw-r--r-- 1 root root 70280 2007-12-29 19:37 libpngexporter.so -rw-r--r-- 1 root root 34566 2007-12-29 19:37 libsearch.a -rw-r--r-- 1 root root 1775 2007-12-29 19:37 libsearch.la -rw-r--r-- 1 root root 32848 2007-12-29 19:37 libsearch.so -rw-r--r-- 1 root root 150228 2007-12-29 19:37 libwebexporter.a -rw-r--r-- 1 root root 1810 2007-12-29 19:37 libwebexporter.la -rw-r--r-- 1 root root 97832 2007-12-29 19:37 libwebexporter.so Cheers, Julien -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: gthumb (updated and adopted package)
Il giorno Sat, 29 Dec 2007 20:18:04 +0100 Julien Valroff [EMAIL PROTECTED] ha scritto: Hi David, Hi Julien, I have built the package from the sources available on mentors, and gthumb cannot load: $ LANG=C gthumb gthumb: error while loading shared libraries: libgthumb.so: cannot open shared object file: No such file or directory Indeed, libgthumb.so is not part of the package: I must have missed it, let me check the source, I'll report as soon as I get something :) Thank you, David (who was too busy in checking filed bugs who didn't notice induced ones...) -- . ''`. Debian maintainer | http://snipurl.com/qa_page : :' : Linuxer #334216 | http://www.hanskalabs.net/ `. `'`GPG: 1392B174 | http://www.debianizzati.org/ `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: gthumb (updated and adopted package)
Il giorno Sat, 29 Dec 2007 20:28:30 +0100 David Paleino [EMAIL PROTECTED] ha scritto: ... I must have missed it, let me check the source, I'll report as soon as I get something :) The package now is fully functional, I've also integrated a patch for yet another bug (#452929). Please consider testing it :) Thank you, David -- . ''`. Debian maintainer | http://snipurl.com/qa_page : :' : Linuxer #334216 | http://www.hanskalabs.net/ `. `'`GPG: 1392B174 | http://www.debianizzati.org/ `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: gthumb (updated and adopted package)
Hi David, Le samedi 29 décembre 2007 à 21:29 +0100, David Paleino a écrit : Il giorno Sat, 29 Dec 2007 20:28:30 +0100 David Paleino [EMAIL PROTECTED] ha scritto: ... I must have missed it, let me check the source, I'll report as soon as I get something :) The package now is fully functional, I've also integrated a patch for yet another bug (#452929). Please consider testing it :) I have built the new release, but still an issue with libgthumb.so - gthumb can't find the library: $ ldd /usr/bin/gthumb | grep not found libgthumb.so = not found I attach the build log as there are many related Lintian warnings/errors - might be useful for you. Cheers, Julien gthumb_2.10.7-1_amd64.build.gz Description: GNU Zip compressed data
Re: RFS: gthumb (updated and adopted package)
Le dimanche 30 décembre 2007 à 08:30 +0100, Julien Valroff a écrit : Hi David, Le samedi 29 décembre 2007 à 21:29 +0100, David Paleino a écrit : Il giorno Sat, 29 Dec 2007 20:28:30 +0100 David Paleino [EMAIL PROTECTED] ha scritto: ... I must have missed it, let me check the source, I'll report as soon as I get something :) The package now is fully functional, I've also integrated a patch for yet another bug (#452929). Please consider testing it :) I have built the new release, but still an issue with libgthumb.so - gthumb can't find the library: $ ldd /usr/bin/gthumb | grep not found libgthumb.so = not found I attach the build log as there are many related Lintian warnings/errors s/Lintian/dpkg-shlibdeps/ ^^ - might be useful for you. Cheers, Julien -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: gthumb (updated and adopted package)
Il giorno Sun, 30 Dec 2007 08:32:20 +0100 Julien Valroff [EMAIL PROTECTED] ha scritto: I have built the new release, but still an issue with libgthumb.so - gthumb can't find the library: $ ldd /usr/bin/gthumb | grep not found libgthumb.so = not found I attach the build log as there are many related Lintian warnings/errors s/Lintian/dpkg-shlibdeps/ ^^ Those warnings are because dpkg-shlibdeps sees many unneeded linkings. If I'm not wrong, there is a discussion on debian-devel about adding -Wl,--as-needed to LDFLAGS to avoid those warnings [1]. However, on my system: $ ldd /usr/bin/gthumb | grep libgthumb libgthumb.so = /usr/lib/gthumb/libgthumb.so (0xb7ef9000) Are you sure you have the right package? What does $ dpkg -c package.deb | grep libgthumb return? Is libgthumb.so still a symlink? About the buildlog youo attached: at line 2527, libgthumb.so gets correctly installed into the tmp/ directory: /usr/bin/install -c .libs/libgthumb.so /tmp/gthumb-2.10.7/debian/tmp/usr/lib/gthumb/libgthumb.so This might be indicative though: dpkg-shlibdeps: warning: couldn't find library libgthumb.so needed by debian/gthumb/usr/lib/gthumb/gthumb/modules/libduplicates.so (its RPATH is ''). Note: libraries are not searched in other binary packages that do not have any shlibs file. To help dpkg-shlibdeps find private libraries, you might need to set LD_LIBRARY_PATH. and similarly for other libraries (happens also for me). So, we said that the shlibs file is useless, dpkg here suggests that it only searches into shlibs-providing packages. Should I make a symlink /usr/lib/libgthumb.so pointing to the real .so, and override package name doesn't match SONAME warnings, or...? I've just rebuilt the package, and libgthumb.so is correctly placed into /usr/lib/gthumb/. And, again: $ which gthumb /usr/bin/gthumb $ gthumb --version GNOME gthumb 2.10.7 $ ldd `which gthumb`|grep libgthumb.so libgthumb.so = /usr/lib/gthumb/libgthumb.so (0xb7ec3000) So, I guess, is it probably a amd64-related/specific problem? Kindly, David [1] http://www.mail-archive.com/[EMAIL PROTECTED]/msg254615.html -- . ''`. Debian maintainer | http://snipurl.com/qa_page : :' : Linuxer #334216 | http://www.hanskalabs.net/ `. `'`GPG: 1392B174 | http://www.debianizzati.org/ `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: gthumb (updated and adopted package)
On Fri, Dec 28, 2007 at 11:59:37PM +0100, David Paleino wrote: I am looking for a sponsor for the new version 3:2.10.7-1 of the package gthumb, which I'm adopting. The package is not lintian clean, it has 3 overrides: - gthumb: no-shlibs-control-file and package-name-doesnt-match-sonames(libgthumb is a private library and should not be used by any other program; libgthumb.so doesn't even have a proper SONAME and version number.) Don't override this, it *is* a bug in the package. The propper fix is to move the library into a private directory inside /usr/lib, say /usr/lib/gthumb -- Rodrigo Gallardo GPG-Fingerprint: 7C81 E60C 442E 8FBC D975 2F49 0199 8318 ADC9 BC28 signature.asc Description: Digital signature
Re: RFS: gthumb (updated and adopted package)
Il giorno Fri, 28 Dec 2007 17:22:59 -0600 Luis Rodrigo Gallardo Cruz [EMAIL PROTECTED] ha scritto: Don't override this, it *is* a bug in the package. The propper fix is to move the library into a private directory inside /usr/lib, say /usr/lib/gthumb Thank you. Should I call ldconfig in post{inst,rm} also in this case then? Lintian complains about it: it says it's useless. Should I override this, or is it really useless? Kindly, David -- . ''`. Debian maintainer | http://snipurl.com/qa_page : :' : Linuxer #334216 | http://www.hanskalabs.net/ `. `'`GPG: 1392B174 | http://www.debianizzati.org/ `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: gthumb (updated and adopted package)
David Paleino [EMAIL PROTECTED] writes: Luis Rodrigo Gallardo Cruz [EMAIL PROTECTED] ha scritto: Don't override this, it *is* a bug in the package. The propper fix is to move the library into a private directory inside /usr/lib, say /usr/lib/gthumb Thank you. Should I call ldconfig in post{inst,rm} also in this case then? Lintian complains about it: it says it's useless. Should I override this, or is it really useless? I think it's really useless. ldconfig manages the information for libraries on the default search path. Private libraries don't need it, and Policy 8.1.1 only says to run ldconfig when installing libraries into the default search path. -- Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: gthumb (updated and adopted package)
Il giorno Fri, 28 Dec 2007 23:02:10 -0800 Russ Allbery [EMAIL PROTECTED] ha scritto: David Paleino [EMAIL PROTECTED] writes: Should I call ldconfig in post{inst,rm} also in this case then? Lintian complains about it: it says it's useless. Should I override this, or is it really useless? I think it's really useless. ldconfig manages the information for libraries on the default search path. Private libraries don't need it, and Policy 8.1.1 only says to run ldconfig when installing libraries into the default search path. I've uploaded the new package with the suggested fixes. The location is the usual mentors.debian.net URL I posted before. Thanks for your interest, David -- . ''`. Debian maintainer | http://snipurl.com/qa_page : :' : Linuxer #334216 | http://www.hanskalabs.net/ `. `'`GPG: 1392B174 | http://www.debianizzati.org/ `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature