Re: RFS: policyd-weight (3rd)
Hi Ansgar, sorry that I could not look at your package even after I said that I would earlier, but I did not have enough free time. But it was uploaded in the end anyway :) No problem - I've just fixed another bug (#641538) in my local packet. It is not possible to change the package after an upload without making a new release that increases the version number. That said this change can probably wait until there are other changes as Thomas said. Ah, i see. Is it worth to increase the version number and upload the package when there is one (non critical) bug fixed and the missing /etc/default/policy-weight shipped? thank you, Werner -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4f0ab401.2040...@aloah-from-hell.de
Re: RFS: policyd-weight (3rd)
Hi, can anyone re-upload the package ? :) regards, Werner Detter Am 07.01.12 11:45, schrieb wer...@aloah-from-hell.de: Dear Mentors, I've just installed my policyd-weight package from unstable. There my /etc/default/policyd-weight file is not created, currently I'm not sure if the version that has been uploaded to mentors does include the /etc/default/policyd-weight file already so I've downloaded the source and it's not in there. Could you please re-upload the package? I've just uploaded the latest version to mentors. Sorry for the circumstances. Thank you, Werner Detter -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4f09a7db.6010...@aloah-from-hell.de
Re: RFS: policyd-weight (3rd)
On 01/06/2012 09:32 PM, wer...@aloah-from-hell.de wrote: Hi Thomas, I've received an email from Debian FTP-Masters with the information that the package got rejected: --- Reject Reasons: policyd-weight_0.1.15.2-1_all.deb: deb contents timestamp check failed [type 'exceptions.NameError': global name 'MTime' is not defined] --- What's wrong? Just my server clock having an issue (it *was* in advance of few hours). As you saw, I re-uploaded and it's ok now. Thomas -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4f0a0677.9040...@debian.org
Re: RFS: policyd-weight (3rd)
On 01/08/2012 10:27 PM, wer...@aloah-from-hell.de wrote: Hi, can anyone re-upload the package ? :) regards, Werner Detter http://qa.debian.org/developer.php?login=wer...@aloah-from-hell.de It's in, as you can see! I don't think re-uploading only for the /etc/default/policyd-weight is worth the trouble. Just keep this in mind (and in your Vcs / workstation) for the next time! Thomas -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4f0a0787.3010...@debian.org
Re: RFS: policyd-weight (3rd)
Hi, sorry that I could not look at your package even after I said that I would earlier, but I did not have enough free time. But it was uploaded in the end anyway :) wer...@aloah-from-hell.de writes: Could you please re-upload the package? I've just uploaded the latest version to mentors. Sorry for the circumstances. It is not possible to change the package after an upload without making a new release that increases the version number. That said this change can probably wait until there are other changes as Thomas said. Regards, Ansgar -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/871ur9s666@deep-thought.43-1.org
Re: RFS: policyd-weight (3rd)
Dear Mentors, I've just installed my policyd-weight package from unstable. There my /etc/default/policyd-weight file is not created, currently I'm not sure if the version that has been uploaded to mentors does include the /etc/default/policyd-weight file already so I've downloaded the source and it's not in there. Could you please re-upload the package? I've just uploaded the latest version to mentors. Sorry for the circumstances. Thank you, Werner Detter -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4f082233.5050...@aloah-from-hell.de
Re: RFS: policyd-weight (3rd)
On 01/06/2012 01:14 PM, Thomas Goirand wrote: Your debian/init.d script shouldn't set the PATH at all. All the folders it is putting in PATH are already accessible in the default $PATH, so don't change it. FYI, pabs don't agree with me, and think declaring the $PATH is the way to go. So please ignore this. Thomas -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4f06ae90.9060...@debian.org
Re: RFS: policyd-weight (3rd)
Hi Thomas, thanks for your helpfull comments. What was in /etc/default/policyd-weight? Why aren't you using it anymore? It behaves like the current package in unstable/testing/stable. The file /etc/default/policyd-weight isn't created but the init script takes account of it. /etc/default/policyd-weight is the place to add daemon-options for policyd-weight. What should we do here? Generate the file? Or don't take account of it in the init script? Your package seems using /var/run/policyd-weight/, but where exactly is that folder created? Shouldn't an mkdir -p be added to your init.d script? What is the use of /var/run/policyd-weight by the way? The creation of this directory is done by policyd-weight, so no need to create it via the init-script. Policyd-weight uses this directory for saving the PID and furthermore creates some more directories in /var/run/policyd-weight (for caching etc.). It behaves like the current policyd-weight in unstable/testing/stable. Thank you and best regards, Werner Detter Apart from that, I think the package is nicely improved, and would deserve to be uploaded. Thomas -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4f06deb8.9070...@aloah-from-hell.de
Re: RFS: policyd-weight (3rd)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello Werner, On 06.01.2012 12:44, wer...@aloah-from-hell.de wrote: What should we do here? Generate the file? Or don't take account of it in the init script? there is a slight disagreement between several positions within Debian regarding /etc/default/daemon options. That's confusing and something we should work on, but that needs to be addressed at a higher level. For you, in particular, you can choose either alternative for now. That's to use a /etc/default/daemon file or not. If you opt to do so, I'd suggest you to ship an example file how users are supposed to pass configuration options to your daemon, e.g. something like ## This is a POSIX shell fragment sourced by /etc/init.d/policyd-weight ## variable: DAEMON_OPTS ## daemon options to policyd-weight ## default: unset #DAEMON_OPTS= - -- with kind regards, Arno Töll IRC: daemonkeeper on Freenode/OFTC GnuPG Key-ID: 0x9D80F36D -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJPBue8AAoJEMcrUe6dgPNtYVgP/2HeSrPGiAHzzPm7QCB7j36K 1J1z3pQ4QbBlBRCSGaZndPWIIvUoEn2kVgVH4bXhzs7IF6r+byndWtyN/NsZbhnf wR/V7lOQEJPjwdcJkPBVhGFTdrM2Y7LJEsyZjASRoqiU9CojTj/GuWsUz4amU3rK /INr3lHRY9KTiNGdev3rB4dDUFJ8L2VHI0AGs5+5/rK8S/cvqqsLwf4vMwYLaJFz lNf//s3FJpHhu+zArPCrkfX5lx7tCcV86uJ8m6wcMavdP+r7ZT2EGyXGC5vcV3Ua csvBrdHLfdVX4J7WYACRLjye+c4e8h293ktZphZNr3//LPcM/zsSYq9RPcCHeknw KqLKSzRx8CbuW1UBl6kJ4CNdWYP8KRXDmVsYFqIJrFT7qY1UhpZtuZ8B5pJ2yK3p P8XcNTx/BiAKVOSPYQv+jJb2QUGS0QhRB8Hvxc3khfu+bB6TZIeAmyV9jR01cXZx 55OjU3y9Y0mQq4uihybvXoR7LwokeXNdX5fs6fxRe3rZUJbWJvMmv/HOuJZcyQqp heDmEMhQ5eW2a9x/Zfc9bd0YPO5dxP8j9kQjYsYWpyr9VBVCrQFVHHBv5odoHwCH VnCgX1GadT0Dokaw6tYzdWo5T1S4Fu25Nz0QNJ/Lyt1GFq06ZTxR8tiWTRTuYjg6 46FfJsYm/B/5emEiObvM =C78D -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4f06e7bc.3020...@toell.net
Re: RFS: policyd-weight (3rd)
Hi Arno, there is a slight disagreement between several positions within Debian regarding /etc/default/daemon options. That's confusing and something we should work on, but that needs to be addressed at a higher level. Ok, i see. For you, in particular, you can choose either alternative for now. That's to use a /etc/default/daemon file or not. If you opt to do so, I'd suggest you to ship an example file how users are supposed to pass configuration options to your daemon, e.g. something like ## This is a POSIX shell fragment sourced by /etc/init.d/policyd-weight ## variable: DAEMON_OPTS ## daemon options to policyd-weight ## default: unset #DAEMON_OPTS= I think that's the way to go. But where in source package should i put the file in my source package? I would then copy the file by postinst to /etc/default/policyd-weight ? Thank you, Werner -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4f06e9c9.40...@aloah-from-hell.de
Re: RFS: policyd-weight (3rd)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello Werner, On 06.01.2012 13:32, wer...@aloah-from-hell.de wrote: I think that's the way to go. But where in source package should i put the file in my source package? I would then copy the file by postinst to /etc/default/policyd-weight ? typically you would put it in debian/policyd-weight and install it through dh_install(1). - -- with kind regards, Arno Töll IRC: daemonkeeper on Freenode/OFTC GnuPG Key-ID: 0x9D80F36D -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJPBupPAAoJEMcrUe6dgPNtpp8P/jyBU7ou6PnJeVQmY4x/ysGQ itFIQDqH8hM9zybz2sMVPFTSYmu+ODIjITLNuGrPPKW1Ih9D4tIWvaMllH+PIYmA 3SyVNnGJX7pvJN6fS91Y6mvGObnXMftWoIDbZK/OxXpmpm3hlRKM4LfSXy4nIqzB u6O8Vs5TqmLJKgRrsExZYamc+R0OIaVRjHSdngF7vXE3VKTQSgLkHAeZSxOu0pwC SyeDJFcoX3Zee8FfSDZO7WzJ2JfZUTDeJlERO5URKP0E9JVvE4j0/iaEwcjO9J3X //f1GQ/6WTLhgrQ1EGA+WcVYMchV008ODkxuSiTPLgWsQalfn8IO+E320o+FsbiV 26nZ44n1UXIf94lBgY5Apx/dqBn0P0wCUwzvyMnoVrWTQT1eFJRcPM+4Qk3XIavn dlnsqHjIJIx8MNiWTHbSi9N4YUQwdL5JnyeiKwqhFhkhZl1wW1vf5DBBRwx0OYbb p3BUEav2uD+B0/u9Qm9lIWLymB47X0w1PDuQ/qgg4dxJ5iTdhHtIszXa7hC2Z0dR e2rY3hcCrab74foyMi07MDRj1Bha6wEeSKo2nFjLNp8zXZr34wpgT0fshp0N4JG9 3UDq2+3AYDfOcXFA0RkY/ys12a47tiB7PzUtZt/AogTzXgjft7YxG0BHyGKS8kLj mn1BFNfOtdFQnO4HYcWv =rl8X -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4f06ea4f.3090...@toell.net
Re: RFS: policyd-weight (3rd)
On 01/06/2012 07:44 PM, wer...@aloah-from-hell.de wrote: Hi Thomas, thanks for your helpfull comments. What was in /etc/default/policyd-weight? Why aren't you using it anymore? It behaves like the current package in unstable/testing/stable. The file /etc/default/policyd-weight isn't created but the init script takes account of it. /etc/default/policyd-weight is the place to add daemon-options for policyd-weight. What should we do here? Generate the file? Or don't take account of it in the init script? I'd add a file there, with lots of comments, and all the options that you can put in it. It doesn't mater if absolutely every options are commented out, the point is to document what can be done with useful comments. Maybe you can do that on your next upload? The creation of this directory is done by policyd-weight, so no need to create it via the init-script. Policyd-weight uses this directory for saving the PID and furthermore creates some more directories in /var/run/policyd-weight (for caching etc.). It behaves like the current policyd-weight in unstable/testing/stable. Cool ! Since all the points I've asked you about have been addressed, I have uploaded the package. Thanks for your contribution to Debian, and thanks for being patient enough with all my (sometimes silly) questions, and your package polishing. Taking over maintenance of orphan packages is one of the best way to contribute to Debian! Cheers, Thomas Goirand (zigo) -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4f06ef6e.4070...@debian.org
Re: RFS: policyd-weight (3rd)
Hi Thomas, I'd add a file there, with lots of comments, and all the options that you can put in it. It doesn't mater if absolutely every options are commented out, the point is to document what can be done with useful comments. Maybe you can do that on your next upload? done :) I've added debian/default with the following content and re-uploaded the package. ## This is a POSIX shell fragment sourced by /etc/init.d/policyd-weight ## variable: DAEMON_OPTS ## daemon options to policyd-weight, possible options: ## ## Options ##-D Don't detach master - run master in foreground ##-d Debug, don't daemonize, log to STDOUT ##-f /path/to/file Specify a configuration file ##-h This help ##-k Kill cache instance ##-s Show cache entries and exit. With -d show debug ## cache entries ##-v Show version and exit ## ## default: unset # DAEMON_OPTS= Since all the points I've asked you about have been addressed, I have uploaded the package. I'm really happy about that :) Thank you. Thanks for your contribution to Debian, and thanks for being patient enough with all my (sometimes silly) questions, and your package polishing. Thanks for your help and your patience as this is my first package that i contributed to Debian. Also Thanks to Arno and Ansgar for their comments and hints :) I've learned a lot during my first package creation for Debian. Cheers, Werner Detter -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4f06f748.1030...@aloah-from-hell.de
Re: RFS: policyd-weight (3rd)
Hi Thomas, I've received an email from Debian FTP-Masters with the information that the package got rejected: --- Reject Reasons: policyd-weight_0.1.15.2-1_all.deb: deb contents timestamp check failed [type 'exceptions.NameError': global name 'MTime' is not defined] --- What's wrong? Thanks, Werner -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4f06f801.7060...@aloah-from-hell.de
Re: RFS: policyd-weight (3rd)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06.01.2012 14:32, wer...@aloah-from-hell.de wrote: What's wrong? That seems to be a bug in in dak to me. I've tried to ask relevent persons, maybe they can help you out. - -- with kind regards, Arno Töll IRC: daemonkeeper on Freenode/OFTC GnuPG Key-ID: 0x9D80F36D -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJPBvpIAAoJEMcrUe6dgPNtUSwP/RIHEgq4sFld465vl59VgQUG flbhaQ94xEtcRo2+7py1R4XMWA72Goas6H3CsA3HZUgeeKfcgz3Z8jI72fJjkaUS eHQFI5rUi1TuXd5jkKBrvkDkTk77/47xCHQRGN0pMkL5HW/U/cIxpcokGzMLUy20 QnfIyViL36kj0EyTFmmlH0N/5yykd44FpL4TtmhiCDwuYG0yNZV31gj1T7p32A9F VZ56KDdWzEBaUl7lafYSBRpyjlB64XSBWExx2+NE9lmi637pUUO060sWibzMvJlK XxpnenAZgVz7iOySU8q4xMiI7VG6vbk4A+R8klgpLxpDUI/2Bs7CvFOKzbLyRsnp 9atyHkJ6WAuWWVHw45L23gfP7+56guKx0H4MCC3XMSuhfhnxlMWYSJu1pBDtM4FJ T/T80ZcrqGLzG8Czw/H5TdFl4fmaC6UaWLd/VsXaSwSJivU7/pyB0p+1wGJb+O9e jJito4pM1Y+/nIKoquVzsxWMiZ8LAPSQvaBytpqMUt7/NujaoCxeC/sRtrWPMv2R dXQXxkpq9cIauWp1zKoM8uIxtTAfj5DNO+fvGtZAm+Ka1KBYeriytyspy0xT6IdW 4/oRs6aO7Hlbt3W+VC7mlZTZMiyvdNPzqxeIefD2OzH4zA1Zj4iVQ7fHYSJX6iDC rH1ShBD3O/jKLTLnRghm =GhrX -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4f06fa49.7000...@toell.net
Re: RFS: policyd-weight (3rd)
Hi Arno, That seems to be a bug in in dak to me. I've tried to ask relevent persons, maybe they can help you out. OK, thank you :) Have a nice day, Werner -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4f06fae6.9070...@aloah-from-hell.de
Re: RFS: policyd-weight (3rd)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06.01.2012 14:45, wer...@aloah-from-hell.de wrote: That seems to be a bug in in dak to me. I've tried to ask relevent persons, maybe they can help you out. Mark fixed a bug in dak which produced your faulty error message. The problem was the cryptic error, the rationale for being thrown however was not. Apparently there is something completely wrong on Thomas' system regarding the system time. dak rejected the upload because of bad timestamps in the binary package. [14:51] mhy that line is looking for files with really bad timestamps which causes a reject - it's just that it failed to explain why it was rejected due to the bug - -- with kind regards, Arno Töll IRC: daemonkeeper on Freenode/OFTC GnuPG Key-ID: 0x9D80F36D -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJPBz90AAoJEMcrUe6dgPNtYBgQAMfozHOq5lMgoTEHj/G8iht2 88C7JRFTe68iAjHH9soDxaLH/5JKmYr3yl3XeNb0LzFhs1SJVCUwLif8qs1NB2KS riCNlt3SAD1N7skAWzccw60fvcF8+2xWCsveHHhsIZMtnakySna2WC2NTFhCPbuA OOecju8bcctym4eIAbAXp9Hgj7Uhc6FSweUa2wjGIa9GM+xBCHbFZpk8LqyWbXCr hFmk/maONi6WwxCLDhVMkJxI1XiNhbbt+PD4nzslSAc3f/f7XpX0RT6Z5N1YSASP aXKhO5oQaDIkiQ1QpJWu4F3OgG7yxWWoJgKAZFzUK9mTAgWIXeqI3iO0inIB8kFa kA2fYcm54k076byGUu7L7DVEfXuJ+E1W+FCrhm3ypL7d4fON+aywU16dRdm1Hegb Fow/31R1zEIT9accU3z6bwpVt4C2G9WQnMKXGUncZ/K67IQ04M5hmDWbOmyo69lg l72AUvTn+jzI6aewFazglHPBQAknvbLENlM8Rawet2676iAkgjeEg1kYZ6fJnuP/ 1q6TWwl7RI10hv+SbZPSdViZmFQGfU8dLpvGR+Lndmnfchr3Q3RS+KZDWXQqH6b0 P7QLHJcOnsbOwcsB63sk68yDZw0zUDBYdO5Fa/BZLA6zPogkCtGYirRVB9p3JA6t Drdp5HiCyKsZDcbXSevh =pSSZ -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4f073f75.7040...@toell.net
Re: RFS: policyd-weight (3rd)
Hi again,
I do have another question left.
I've just discovered that there are some files left in the debian directory
after package
creation, e.g.
debian/files
debian/policyd-weight.*
debian/policyd-weight.*.debhelper
debian/*.dephelper.log
debian/policyd-weight/
As source packages should not contain files like debian/files. I've enabled
Debugging via
DH_VERBOSE=1 and I do see that dh_clean is deleting those files pretty much at
the beginning
of package-creation.
-- cut --
debian/rules clean
dh_testdir
dh_testroot
dh_clean
rm -f debian/policyd-weight.substvars
rm -f debian/policyd-weight.*.debhelper
rm -rf debian/policyd-weight/
rm -f debian/*.debhelper.log
rm -f debian/files
find . \( \( -type f -a \
\( -name '#*#' -o -name '.*~' -o -name '*~' -o -name DEADJOE \
-o -name '*.orig' -o -name '*.rej' -o -name '*.bak' \
-o -name '.*.orig' -o -name .*.rej -o -name '.SUMS' \
-o -name TAGS -o \( -path '*/.deps/*' -a -name '*.P' \) \
\) -exec rm -f {} \; \) -o \
\( -type d -a -name autom4te.cache -prune -exec rm -rf {} \; \)
\)
rm -f *-stamp
-- cut --
So as those files are just deleted at the beginning of the package and
afterwards are recreated
through the build process. I'm not sure if
a) it's ok that the files reside in the debian directory ?
b) I missed a dh_clean (or pedant) somewhere ?
c) I have to delete those manually?
Thank you,
Werner Detter
PS: here's my debian/rules snippet
clean:
dh_testdir
dh_testroot
dh_clean
install: build
dh_testdir
dh_testroot
dh_prep
dh_installdirs
install -D -m 644 policyd-weight
debian/policyd-weight/usr/sbin/policyd-weight
# Build architecture-independent files here.
binary-indep: build install
dh_testdir
dh_testroot
dh_installchangelogs changes.txt
dh_installdocs
dh_installinit -- defaults 19 21
dh_installman man/man5/policyd-weight.conf.5 man/man8/policyd-weight.8
dh_link
dh_compress
dh_fixperms
dh_perl
dh_installdeb
dh_gencontrol
dh_md5sums
dh_builddeb
# Build architecture-dependent files here.
build-arch: build
build-indep: build
binary-arch: build install
binary: binary-indep binary-arch
.PHONY: build clean binary-indep binary-arch binary install
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4f075868.5000...@aloah-from-hell.de
Re: RFS: policyd-weight (3rd)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello Werner, On 06.01.2012 21:24, wer...@aloah-from-hell.de wrote: a) it's ok that the files reside in the debian directory ? b) I missed a dh_clean (or pedant) somewhere ? c) I have to delete those manually? I didn't actually try your source package, but it looks feasible. These files are created by a regular build process and entirely typical for a debhelper based workflow. Every temporary file in debian YOU don't create during build but debhelper is being cleaned by dh_clean. So, as long as you call dh_clean in your clean target, you do not need to worry about it. You will find them after every build attempt of your binary packages. As long as they do not appear in the resulting source package (which they won't, if you made everything right), all is good. Clean the build tree manually if you're worried about them (e.g. call fakeroot debian/rules clean). dpkg-buildpackage will do so automatically prior to build your package. - -- with kind regards, Arno Töll IRC: daemonkeeper on Freenode/OFTC GnuPG Key-ID: 0x9D80F36D -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJPB1ysAAoJEMcrUe6dgPNtDHcP/i5y1dmISh3X47PvRJ0k1AdX WVkZHuyrfl21YZYHHHN/+1g8PqWeLgURySaEloNGv7umrHI8JG1PjdszEOY5sybj YYx/aF2DQUR4qPeqpnVgIfR3648v9x8Gf4M8/ROkn2Fm55XYZ8Oamcc+ImahyX0Z Vdigka68ea0uV2RnjnxWg2GCdqZq4+KZk1s3ko8wikm0lnlYIJqxnQUSE+ADdzfw vP/wSlYQltcqMO5iVsdSKdWr4jVkekmhqjGEbcb7ttUSLiTKVYRnO7zFUjj4GAbD MpbPyQAbQaQd97USvhKXVTpBTIQGlthSMe44oOy0vWrnP77z6mFOnOZ08kcwobyM Fy5UP2j2EpTwXwl4XqlyKUeY7pT+gkcolrBQyGaFhpqHszjWUmj7pXs/CnhI9+vB LzVh1j9gK1hCjBpTLKeoaPdzId7pDipSz5QOPdVuUPFyGRHU+4c0SQ5VXa+V+JW8 0Qu6P9VcQCtEL0jckxOodNG7DbOrs+26fpfNfVnOr9j6gFW9z1KFiuet0C65xj7G 8LbZ4QsyJpCf+xY4QnW7xuwuIuDZXbw2lZQSzKwiYhJuNbiEPg9VTeK6NEPIuW7b Woj1FKlwM6ghAyxvuFU1ZaGEsLquLf20T5JH7rmKc9Cc4X6R1o5o+G0wSp6v7I5i 5AcMwPyMcdUuBuvGhQQ5 =kZlu -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4f075cac.4070...@toell.net
Re: RFS: policyd-weight (3rd)
Hi Arno, a) it's ok that the files reside in the debian directory ? b) I missed a dh_clean (or pedant) somewhere ? c) I have to delete those manually? I didn't actually try your source package, but it looks feasible. These files are created by a regular build process and entirely typical for a debhelper based workflow. Every temporary file in debian YOU don't create during build but debhelper is being cleaned by dh_clean. So, as long as you call dh_clean in your clean target, you do not need to worry about it. You will find them after every build attempt of your binary packages. As long as they do not appear in the resulting source package (which they won't, if you made everything right), all is good. I see, i was a little confused but your explanation made things clear to me. Thank you. Would linitian complain e.g. for example about those files? Clean the build tree manually if you're worried about them (e.g. call fakeroot debian/rules clean). dpkg-buildpackage will do so automatically prior to build your package. I just ran fakeroot debian/rules clean after the build process, all files are gone. Thanks for your patience help and for answering my (maybe silly) questions! Cheers, WErn -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4f075f25.8090...@aloah-from-hell.de
Re: RFS: policyd-weight (3rd)
On 01/06/2012 02:07 AM, wer...@aloah-from-hell.de wrote: Dear mentors, I am looking for a sponsor for my package policyd-weight. * Package name: policyd-weight Version : 0.1.15.2-1 Upstream Author : Robert Felber * URL : www.policyd-weight.org * License : GPL-2+ Section : mail It builds those binary packages: policyd-weight - Perl policy daemon for the Postfix MTA To access further information about this package, please visit the following URL: http://mentors.debian.net/package/policyd-weight Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/p/policyd-weight/policyd-weight_0.1.15.2-1.dsc I would be glad if someone uploaded this package for me. Kind regards, Werner Detter Your debian/init.d script shouldn't set the PATH at all. All the folders it is putting in PATH are already accessible in the default $PATH, so don't change it. What was in /etc/default/policyd-weight? Why aren't you using it anymore? Your package seems using /var/run/policyd-weight/, but where exactly is that folder created? Shouldn't an mkdir -p be added to your init.d script? What is the use of /var/run/policyd-weight by the way? Apart from that, I think the package is nicely improved, and would deserve to be uploaded. Thomas -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4f068340.5040...@debian.org
