Re: RFS: tartarus
Dies schrieb Arno Töll (deb...@toell.net): * You bundle a Perl module in your source tarball. Please package this separately. Even if the perl module is only used by the scripts packaged? I created the module when several programs used the same functions and configuration data, so I am not sure whether a dedicated perl package is really that useful. * Your original source tarball did not match the package source directory you use to produce the package from. This resulted in a quilt/3.0 changes patch in patches/debian-changes-0.9.8-1. Please update your source tarball accordingly and re-upload. This is probably glitch in the git-buildpackage configuration, repackaging should fix that. * You install man pages through dh_installman, but they belong to the upstream part of your package. Please consider writing an install target upstream for them. * You don't have an install target at all in your upstream package, eventually you want to add that instead of relying to various debhelper. I'll think about adding that, thank you. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110529184923.gv13...@zirkel.wertarbyte.de
Re: RFS: tartarus
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Stefan, On 29.05.2011 20:49, Stefan Tomanek wrote: * You bundle a Perl module in your source tarball. Please package this separately. Even if the perl module is only used by the scripts packaged? I created the module when several programs used the same functions and configuration data, so I am not sure whether a dedicated perl package is really that useful. you opted to install it to a system wide location, which qualifies for this requirement, yes. If you would choose to install it to a private location (i.e. relative to your program only, not reachable by site @INC) this could come over this requirement[*]. Note it is perfectly fine to bundle the library in a single source tarball, just generate a separate binary (Perl) package. That's not a big deal. [*] At this point I should note I am no Debian Developer. This means I can't sponsor you, therefore you are free to ignore my advises anyway. - -- with kind regards, Arno Töll IRC: daemonkeeper on Freenode/OFTC GnuPG Key-ID: 0x9D80F36D -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJN4poWAAoJEMcrUe6dgPNtOQwP+wR9G92YprJheb5mQFaBZq8B 793xipJiHsmTTmoI7XLI3tWsgLr1pKCol2uMzGzXjvCMOBlvaRVdTJpmjI/q0WpP gqHiTQvTbMthXHy/H6gFp4OCCJsfAMDP76rOpRWGvigrOoXAZNxpJlo3FFIDMAlz D9tg8QgWtg+1XmNjsi5FsAihVdxqdiyEmeVboJSYMcZMSH9LJ0F8/L9RWAnvjWRX xEAfaZVjzjQqCq1GngA+cfQISHqcltTuID48QirfzoETnUsbE5eQrbXhU+i685YI fN+bH04ydxSP3UKpDxNAKwdiRlQrd00QEik3YDWHW/MxVlSLIp8j4LAB6tVbO3Ui ApIT1EGdEeFMDt1SKpKiWRk9m3lDS5L41+xHnTt8H1R01uQyOcAM3m+ElnAseDs/ lRuHd/ox98dFogOuUnp/s4W13ok/y97ea05vh25418aJd7cyUNBECB/RTfJcsUQ0 EhO8yV1kxYjDpHla+nrkztDQzNxULBoBJc4CDbUFj55iD9K2IsSKnjURh7VqBmyV lBtd0oDvbA7Kkf/0E3wo2ea0ie4EPRFnFGAdd4ymcTTg5MP7DvfT8+M2STHx2Uce yjbokhWhpvFr14PoA+VMVBcxslSc7N51DiWag92UQa9CYMQVwsLgfOJAigWXnITn oetDiYPA8wTakSIC+Lo4 =3r07 -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4de29a17.1080...@toell.net
Re: RFS: tartarus
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi Stefan,
I took a look into your package. I have some comments you may want to
consider.
On 25.05.2011 23:18, Stefan Tomanek wrote:
I am looking for a sponsor for my package tartarus.
...
The upload would fix these bugs: 604447
* You don't mention the ITP you filed in debian/changelog. Please do that.
* You seem to use a merged changelog for your (upstream) changes and
Debian packaging related stuff. This is not the intention of
debian/changelog. You shall outline there /packaging/ relevant changes
in comparison to your upstream package. Moreover you seem to have a
long(er) history of internal used Debian packages you mention in your
changelog. This could be confusing for Debian users, maybe you want to
clean this up, once you eventually moved your upstream changes to a
dedicated upstream changelog. See also [2].
* You use debhelper version 7, you could bump to version 8 as this is
the suggested version to be used these days. Learn more on debhelper(7).
* You should use a VCS to track your packaging efforts [1]. If you don't
have one, you could consider to joint the collab-maint project on Alioth
[3].
* You bundle a Perl module in your source tarball. Please package this
separately. There is a Perl policy covering Perl modules [4]. Once you
did, you may also depend on the ${perl:Depends} substitute dh_perl(1)
generates.
* Your original source tarball did not match the package source
directory you use to produce the package from. This resulted in a
quilt/3.0 changes patch in patches/debian-changes-0.9.8-1. Please update
your source tarball accordingly and re-upload.
* You install man pages through dh_installman, but they belong to the
upstream part of your package. Please consider writing an install target
upstream for them.
* You don't have an install target at all in your upstream package,
eventually you want to add that instead of relying to various debhelper.
Besides of those things (where most are minor improvements) I think your
package looks good, good work.
[1]
http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-vcs
[2]
http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-changelog-errors
[3] http://wiki.debian.org/Alioth/PackagingProject
[4] http://www.debian.org/doc/packaging-manuals/perl-policy/index.html
- --
with kind regards,
Arno Töll
IRC: daemonkeeper on Freenode/OFTC
GnuPG Key-ID: 0x9D80F36D
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBAgAGBQJN4YnRAAoJEMcrUe6dgPNt6iAQAMvoyazA7Lnzn6sIfWrgFmWy
AypOedR0GGHHjfFtSgyCWd9EsjrTohty8FtMS0YEGfPja8a6KiBvRvJ9GE70nj+V
2z28Pfx3LjsSiZKtXtAs6K7RSaJ4AW/Y4JjKdESSXzhgqwbO8T5HhcSCNErfVti5
BvxnUMm8PG/Bfe5QY8cICC+5lsJy8hCzwQhdUiROObLRKz8cD9lm41A4GQPEjNoD
mWIr/DswyZEbek6ICHWobBnpCu+FyA63NUdwngCH9pZ8fTh4cvOPoSjus0X90UdI
AdgVzE+pI2/MjT/843Appvbl+OgJlWhnx8Gk4Lf2hi+K8rusjXI+cakuBP94DxA1
lkI92eyHfZsZKYYLUcdPIEzDCCFriWkPWK0MkUfLdK5f2m//EhsFigpfwj3F3uKR
O1/DOxaYqygNd6104Z4ZjxYVpe6fDRGK9zq1CT0eesqqZiYQBxm7/LYuAh21x9NG
gNeCmNHDmAOV5j4+y0xooBUWqsfvqeQ9NSgiRI7XT6K+VEHSwLjRsnLPG456m47l
lkFwrECKb+EA1hE2SdrvYArjTzZ3E5fX14mQk25Iqxy5rWjfG/Gws4lDsz50V84f
Tt4CqOzMtKQdS7T7FRzXEY/j35ZdvFDZ7AhaUaKYz7kvZvRsaKw7q1LFE1hPcD+8
j+zduSlzfWuPKaOfr0nt
=HbGS
-END PGP SIGNATURE-
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4de189d1.4030...@toell.net
Re: RFS: tartarus
Hi Stefan, 22/11/2010 11:52 +0100, Stefan Tomanek wrote: Dear mentors, I am looking for a sponsor for my package tartarus. * Package name: tartarus Version : 0.9.4-2 Upstream Author : Stefan Tomanek stefan.tomanek+tarta...@wertarbyte.de * URL : http://wertarbyte.de/tartarus.shtml * License : GPLv3 Section : utils It builds these binary packages: tartarus - script based backup system The package appears to be lintian clean. The upload would fix these bugs: 604447 My motivation for maintaining this package is: I've written tartarus as a simple backup solution for my dedicated server. It uses parts of the unix toolshed that should be available even in the most basic rescue system, making recovery easy in case things go wrong. By using Bash and Perl, the program is easily extendable and offers various hooks that can be used to modify its behaviour, while including features like LVM snapshots, on-the-fly-uploading and compression/encryption out of the box. I created the package to simplify the installation on now roughly 1100 systems using this program (http://wertarbyte.de/stats/tartarus-use.png) on a regular basis and I would really like to this this included into Debian. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/t/tartarus - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/t/tartarus/tartarus_0.9.4-2.dsc I would be glad if someone uploaded this package for me. I'm not a DD, but here's my (quick) review for your package. I hope it's useful for you: * Lintian checking (it's not Lintian clean): - I: tartarus source: debian-watch-file-is-missing It's a good practice to add a watch file. - W: tartarus source: out-of-date-standards-version 3.8.0 (current is 3.9.1) You should check [1] and upgrade to Standards-Version to 3.9.1 - I: tartarus: spelling-error-in-manpage usr/share/man/man1/tartarus.1.gz managable manageable You can find this spelling error in $ grep -nR managable * bin/tartarus:26:# configuration from easily managable configuration files. It can store If you are the upstreamer, you can easily correct it in upstream source before packaging. - P: tartarus: no-upstream-changelog It could be nice if upstream have an upstream changelog and it could be accessible from Debian package. * Debian files checking: - debian/changelog: I think you should not add previous changes before entering the package to Debian. So this package version should be 0.9.4-1, altough you had it before in a personal repo. - debian/rules: You can delete commented lines that tell us you are using a template. - debian/menu: Consider to create it. - debian/patches: You have a debian/patches automatic file (debian-changes-0.9.4-2): If this patch is necessary for Debian package, you should comment why in the patch file. If it's fine to have this change in upstream and you're the upstreamer, you can change it in upstream code before packaging. * Ustream source checking: - Upstream source should be licensed. I haven't checked how program works. If any other person from the list sees a mistake in my review, reviews of my review are welcomed! Cheers, Mònica [1] http://www.debian.org/doc/packaging-manuals/upgrading-checklist.txt signature.asc Description: This is a digitally signed message part
Re: RFS: tartarus
Thanks for your feedback, I just created a new package version which should take care of most issues described by you. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101122162454.gk15...@zirkel.wertarbyte.de
Re: RFS: tartarus
On Mon, 22 Nov 2010 13:57:01 +0100, Mònica Ramírez Arceda wrote: Hi Mònica, I'm not a DD, but here's my (quick) review for your package. I hope it's useful for you: Thanks for doing this diligent review of Stefan's package. Just 2 quick comments: - debian/changelog: I think you should not add previous changes before entering the package to Debian. So this package version should be 0.9.4-1, altough you had it before in a personal repo. I'm not sure there is a consensus on this issue; my personal opinion is that it's better to keep the previous work if older binary packages have been available from non-official repositories, as it makes updates easier for users of those packages. - debian/menu: Consider to create it. I'm not sure if a menu entry for a command-line script is really that helpful. If any other person from the list sees a mistake in my review, reviews of my review are welcomed! :) Cheers, gregor -- .''`. http://info.comodo.priv.at/ -- GPG key IDs: 0x8649AA06, 0x00F3CFE4 : :' : Debian GNU/Linux user, admin, developer - http://www.debian.org/ `. `' Member of VIBE!AT SPI, fellow of Free Software Foundation Europe `-NP: Bruce Springsteen: My father's house signature.asc Description: Digital signature
