Re: RFS: tickr -- GTK-based highly graphically-customizable RSS Feed Ticker

2011-09-10 Thread Luca Falavigna
Il 10/09/2011 00:46, Emmanuel Thomas-Maurin ha scritto:
 Thank you for your comments. I made all the changes and re-uploaded my
 package.

Looks better now, here's another round of minor adjustments:

debian/rules:
* I'd drop DH_VERBOSE, it's only useful for debugging purposes
* Delete extra space between dh and @

debian/tickr.1
* I'd move it to upstream tarball, to allow use by other distributions
* Lintian complains about minus signs as hypens:
hyphen-used-as-minus-sign usr/share/man/man1/tickr.1.gz:7
hyphen-used-as-minus-sign usr/share/man/man1/tickr.1.gz:8

debian/watch:
* I'd remove comments and white lines

-- 
  .''`.
 :  :' :   Luca Falavigna dktrkr...@debian.org
 `.  `'
   `-



signature.asc
Description: OpenPGP digital signature


Re: RFS: tickr -- GTK-based highly graphically-customizable RSS Feed Ticker

2011-09-10 Thread Emmanuel Thomas-Maurin
Thanks. All adjustments made.

On 09/10/2011 10:53 AM, Luca Falavigna wrote:
 Il 10/09/2011 00:46, Emmanuel Thomas-Maurin ha scritto:
 Thank you for your comments. I made all the changes and re-uploaded my
 package.
 
 Looks better now, here's another round of minor adjustments:
 
 debian/rules:
 * I'd drop DH_VERBOSE, it's only useful for debugging purposes
 * Delete extra space between dh and @
 
 debian/tickr.1
 * I'd move it to upstream tarball, to allow use by other distributions
 * Lintian complains about minus signs as hypens:
 hyphen-used-as-minus-sign usr/share/man/man1/tickr.1.gz:7
 hyphen-used-as-minus-sign usr/share/man/man1/tickr.1.gz:8
 
 debian/watch:
 * I'd remove comments and white lines

-- 
Emmanuel Thomas-Maurin manutm...@gmail.com


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4e6b61c0.2070...@gmail.com



Re: RFS: tickr -- GTK-based highly graphically-customizable RSS Feed Ticker

2011-09-10 Thread Luca Falavigna
Il 10/09/2011 15:10, Emmanuel Thomas-Maurin ha scritto:
 Thanks. All adjustments made.

... and package uploaded, thanks for your contribution to Debian!

-- 
  .''`.
 :  :' :   Luca Falavigna dktrkr...@debian.org
 `.  `'
   `-



signature.asc
Description: OpenPGP digital signature


Re: RFS: tickr -- GTK-based highly graphically-customizable RSS Feed Ticker

2011-09-10 Thread Emmanuel Thomas-Maurin
On 09/10/2011 04:10 PM, Luca Falavigna wrote:
 Il 10/09/2011 15:10, Emmanuel Thomas-Maurin ha scritto:
 Thanks. All adjustments made.
 
 ... and package uploaded, thanks for your contribution to Debian!
 

Thanks a lot for your help!  :)

-- 
Emmanuel Thomas-Maurin manutm...@gmail.com


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4e6b70dd.4040...@gmail.com



Re: RFS: tickr -- GTK-based highly graphically-customizable RSS Feed Ticker

2011-09-09 Thread Luca Falavigna
Hi Emmanuel,
here are some comments about your upstream source tarball:

Il 09/09/2011 15:26, Emmanuel Thomas-Maurin ha scritto:
 http://mentors.debian.net/debian/pool/main/t/tickr/tickr_0.5.3-1.dsc

* win32_install_stuff/dlls/*.dll has no source code, it has to be
dropped in order for tickr to be accepted in main
* LICENSE is redundant, you already provide COPYING file
* Consider removing autom4te.cache directory
* I'd remove potentially useless files:
  - deb_build_stuff (store directory in a separate location?)
  - previous_Changelog* (merge them into ChangeLog?)
  - Readme_* (merge them into README?)

-- 
  .''`.
 :  :' :   Luca Falavigna dktrkr...@debian.org
 `.  `'
   `-



signature.asc
Description: OpenPGP digital signature


Re: RFS: tickr -- GTK-based highly graphically-customizable RSS Feed Ticker

2011-09-09 Thread Emmanuel Thomas-Maurin
Hi Luca,

Thank you for your comments. I made all the changes and re-uploaded my
package.

On 09/09/2011 11:04 PM, Luca Falavigna wrote:
 Hi Emmanuel,
 here are some comments about your upstream source tarball:
 
 Il 09/09/2011 15:26, Emmanuel Thomas-Maurin ha scritto:
 http://mentors.debian.net/debian/pool/main/t/tickr/tickr_0.5.3-1.dsc
 
 * win32_install_stuff/dlls/*.dll has no source code, it has to be
 dropped in order for tickr to be accepted in main
 * LICENSE is redundant, you already provide COPYING file
 * Consider removing autom4te.cache directory
 * I'd remove potentially useless files:
   - deb_build_stuff (store directory in a separate location?)
   - previous_Changelog* (merge them into ChangeLog?)
   - Readme_* (merge them into README?)
 

-- 
Emmanuel Thomas-Maurin manutm...@gmail.com


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4e6a9732.4010...@gmail.com