Re: acsccid (Updated)
Dear Kilian Thank you for your review and upload. I learnt a lot in Debian packaging. Regards Godfrey -Original Message- From: Kilian Krause Sent: Friday, August 05, 2011 3:52 PM To: Godfrey Chung Cc: debian-mentors@lists.debian.org Subject: Re: acsccid (Updated) Hi Godfrey, On Thu, 2011-08-04 at 17:47 +0800, Godfrey Chung wrote: Dear Kilian Thank you for your review of my package. 1. Done. 2. Done. 3. override_dh_auto_install section is removed, please see No. 4 and comments had been added to override_dh_makeshlibs section. 4. Initially, I used libccid for my reference. I think putting Info.plist to /etc is for user convenience of file modification. mv and ln is removed to avoid to break FHS. 5. Done. 6. The package name is changed to libacsccid1. 7. The output is triggered by adding --enable-udev option to configure and it will modify a option in Info.plist file. This option is not used in the latest version of pcsc-lite. 8. The upstream contains empty change log. Please have a look of my updated package. Thanks! Thanks! Built, Signed, Uploaded. -- Best regards, Kilian -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/07AEBC7CF7034406A32CAAF9EA8702E8@GODFREYPC
Re: acsccid (Updated)
Hi Godfrey, On Thu, 2011-08-04 at 17:47 +0800, Godfrey Chung wrote: > Dear Kilian > > Thank you for your review of my package. > > 1. Done. > > 2. Done. > > 3. override_dh_auto_install section is removed, please see No. 4 and > comments had been added to override_dh_makeshlibs section. > > 4. Initially, I used libccid for my reference. I think putting > Info.plist to /etc is for user convenience of file modification. mv > and ln is removed to avoid to break FHS. > > 5. Done. > > 6. The package name is changed to libacsccid1. > > 7. The output is triggered by adding --enable-udev option to configure > and it will modify a option in Info.plist file. This option is not > used in the latest version of pcsc-lite. > > 8. The upstream contains empty change log. > > Please have a look of my updated package. Thanks! Thanks! Built, Signed, Uploaded. -- Best regards, Kilian signature.asc Description: This is a digitally signed message part
Re: acsccid (Updated)
Dear Kilian Thank you for your review of my package. 1. Done. 2. Done. 3. override_dh_auto_install section is removed, please see No. 4 and comments had been added to override_dh_makeshlibs section. 4. Initially, I used libccid for my reference. I think putting Info.plist to /etc is for user convenience of file modification. mv and ln is removed to avoid to break FHS. 5. Done. 6. The package name is changed to libacsccid1. 7. The output is triggered by adding --enable-udev option to configure and it will modify a option in Info.plist file. This option is not used in the latest version of pcsc-lite. 8. The upstream contains empty change log. Please have a look of my updated package. Thanks! Regards Godfrey -Original Message- From: Kilian Krause Sent: Thursday, August 04, 2011 4:29 AM To: Godfrey Chung Cc: debian-mentors@lists.debian.org Subject: Re: acsccid (Updated) Hi Godfrey, On Tue, Aug 02, 2011 at 11:53:45AM +0800, Godfrey Chung wrote: > I just updated debian/copyright. Please have a look. Thanks! Thanks for your work. Having a first look myself at your package I find: 1. You build-depend on autotools-dev but don't use it in debian/rules' dh call. Please add it to dh. 2. Your patch lacks a DEP-3 header indicating where this patch came from and whether upstream was notified of this to support their development in case it wasn't pulled from there. 3. Your override_dh_auto_install target in debian/rules lacks a tab (to make syntax highlighting happy) and more importantly you override override_dh_makeshlibs without any rationale I could see. Please put a comment why this is needed or remove the override. 4. Regarding the mv and symlink you may want to talk to upstream about supporting sysconfdir in a proper way. I think they will find it helpful to learn that FHS doesn't foresee /usr writeable and thus suitable for config files. 5. The debian/rules template header can be omited too. 6. The name "libacsccid" does not follow the recommended naming scheme for libraries. It should be libacsccid102 or something alike. See [1] for details. 7. Building your package I still see: udev support:no This seems not to be the intended output looking at the udev rules file. There is no Depends on udev too however. Are you sure that the built package works ok if built in a clean pbuilder? 8. The upstream changelog is not shipped in the binary package. Please consider adding it too. [1]: http://www.debian.org/doc/debian-policy/ch-sharedlibs.html#s-sharedlibs-runtime -- Best regards, Kilian
Re: acsccid (Updated)
Hi Godfrey, On Tue, Aug 02, 2011 at 11:53:45AM +0800, Godfrey Chung wrote: > I just updated debian/copyright. Please have a look. Thanks! Thanks for your work. Having a first look myself at your package I find: 1. You build-depend on autotools-dev but don't use it in debian/rules' dh call. Please add it to dh. 2. Your patch lacks a DEP-3 header indicating where this patch came from and whether upstream was notified of this to support their development in case it wasn't pulled from there. 3. Your override_dh_auto_install target in debian/rules lacks a tab (to make syntax highlighting happy) and more importantly you override override_dh_makeshlibs without any rationale I could see. Please put a comment why this is needed or remove the override. 4. Regarding the mv and symlink you may want to talk to upstream about supporting sysconfdir in a proper way. I think they will find it helpful to learn that FHS doesn't foresee /usr writeable and thus suitable for config files. 5. The debian/rules template header can be omited too. 6. The name "libacsccid" does not follow the recommended naming scheme for libraries. It should be libacsccid102 or something alike. See [1] for details. 7. Building your package I still see: udev support:no This seems not to be the intended output looking at the udev rules file. There is no Depends on udev too however. Are you sure that the built package works ok if built in a clean pbuilder? 8. The upstream changelog is not shipped in the binary package. Please consider adding it too. [1]: http://www.debian.org/doc/debian-policy/ch-sharedlibs.html#s-sharedlibs-runtime -- Best regards, Kilian signature.asc Description: Digital signature
Re: acsccid (Updated)
Dear Michael I just updated debian/copyright. Please have a look. Thanks! Regards Godfrey From: Godfrey Chung Sent: Monday, August 01, 2011 5:27 PM To: debian-mentors@lists.debian.org Subject: Re: acsccid (Updated) Dear Michael Thank you for your review of my package. The package had been updated and fixed the following problem: 1. Change debian/copyright file to DEP-5 format. 2. Add a patch to fix compatibility with pcsc-lite >= 1.7.3. 3. Remove debian/README.Debian file to avoid confusion of udev package installation. The udev support option is not used in the latest version of pcsc-lite. 4. Update Standards-Version to 3.9.2. 5. Remove example comments in debian/watch file. I had run pbuilder to verify the package. Regards Godfrey -Original Message- From: Michael Tautschnig Sent: Saturday, July 30, 2011 7:47 PM To: Godfrey Chung Cc: debian-mentors@lists.debian.org Subject: Re: RFS: acsccid (Updated) Hi, > Dear mentors, > > I am looking for a sponsor for my package "acsccid". Actually, I posted the > request about 1 month ago and I did not receive any response here. > > The package had been updated and fix the following problems: > 1. The project is hosted in sourceforge now and watch file is updated. > 2. Remove dh_makeshlibs from rules file. > 3. Fix non-redistributable reference manual problem. > > * Package name: acsccid > Version : 1.0.2-1 > Upstream Author : Advanced Card Systems Ltd. > * URL : http://acsccid.sourceforge.net/ > * License : LGPL-2.1 > Section : libs > > It builds these binary packages: > libacsccid - PC/SC driver for ACS USB CCID smart card readers > > The package appears to be lintian clean. > [...] This may be true, but it doesn't build :-/ Well, to start out in proper order, here's my review results: - Please use DEP-5 format for debian/copyright and please make extra-sure you don't miss any copyright holders as the package seems to have quite a number of them. DEP-5 format will make this much easier to check. - You probably want to add a Depends: on udev instead of merely recommending it in some README file. - configure yields the following result: ... udev support:no ... I'm not sure this is intended. - Your package fails to build from source: ifdhandler.c: In function ‘IFDHControl’: ifdhandler.c:1416:22: error: ‘FEATURE_MCT_READERDIRECT’ undeclared (first use in this function) ifdhandler.c:1416:22: note: each undeclared identifier is reported only once for each function it appears in make[3]: *** [libacsccid_la-ifdhandler.lo] Error 1 make[3]: Leaving directory `/home/tautschnig/debian/acsccid/acsccid-1.0.2/src' Please get those fixed, then another more thorough package review will follow. Best, Michael
Re: acsccid (Updated)
Dear Michael Thank you for your review of my package. The package had been updated and fixed the following problem: 1. Change debian/copyright file to DEP-5 format. 2. Add a patch to fix compatibility with pcsc-lite >= 1.7.3. 3. Remove debian/README.Debian file to avoid confusion of udev package installation. The udev support option is not used in the latest version of pcsc-lite. 4. Update Standards-Version to 3.9.2. 5. Remove example comments in debian/watch file. I had run pbuilder to verify the package. Regards Godfrey -Original Message- From: Michael Tautschnig Sent: Saturday, July 30, 2011 7:47 PM To: Godfrey Chung Cc: debian-mentors@lists.debian.org Subject: Re: RFS: acsccid (Updated) Hi, > Dear mentors, > > I am looking for a sponsor for my package "acsccid". Actually, I posted the > request about 1 month ago and I did not receive any response here. > > The package had been updated and fix the following problems: > 1. The project is hosted in sourceforge now and watch file is updated. > 2. Remove dh_makeshlibs from rules file. > 3. Fix non-redistributable reference manual problem. > > * Package name: acsccid > Version : 1.0.2-1 > Upstream Author : Advanced Card Systems Ltd. > * URL : http://acsccid.sourceforge.net/ > * License : LGPL-2.1 > Section : libs > > It builds these binary packages: > libacsccid - PC/SC driver for ACS USB CCID smart card readers > > The package appears to be lintian clean. > [...] This may be true, but it doesn't build :-/ Well, to start out in proper order, here's my review results: - Please use DEP-5 format for debian/copyright and please make extra-sure you don't miss any copyright holders as the package seems to have quite a number of them. DEP-5 format will make this much easier to check. - You probably want to add a Depends: on udev instead of merely recommending it in some README file. - configure yields the following result: ... udev support:no ... I'm not sure this is intended. - Your package fails to build from source: ifdhandler.c: In function ‘IFDHControl’: ifdhandler.c:1416:22: error: ‘FEATURE_MCT_READERDIRECT’ undeclared (first use in this function) ifdhandler.c:1416:22: note: each undeclared identifier is reported only once for each function it appears in make[3]: *** [libacsccid_la-ifdhandler.lo] Error 1 make[3]: Leaving directory `/home/tautschnig/debian/acsccid/acsccid-1.0.2/src' Please get those fixed, then another more thorough package review will follow. Best, Michael
Re: RFS: acsccid (Updated)
Hi, > Dear mentors, > > I am looking for a sponsor for my package "acsccid". Actually, I posted the > request about 1 month ago and I did not receive any response here. > > The package had been updated and fix the following problems: > 1. The project is hosted in sourceforge now and watch file is updated. > 2. Remove dh_makeshlibs from rules file. > 3. Fix non-redistributable reference manual problem. > > * Package name: acsccid > Version : 1.0.2-1 > Upstream Author : Advanced Card Systems Ltd. > * URL : http://acsccid.sourceforge.net/ > * License : LGPL-2.1 > Section : libs > > It builds these binary packages: > libacsccid - PC/SC driver for ACS USB CCID smart card readers > > The package appears to be lintian clean. > [...] This may be true, but it doesn't build :-/ Well, to start out in proper order, here's my review results: - Please use DEP-5 format for debian/copyright and please make extra-sure you don't miss any copyright holders as the package seems to have quite a number of them. DEP-5 format will make this much easier to check. - You probably want to add a Depends: on udev instead of merely recommending it in some README file. - configure yields the following result: ... udev support:no ... I'm not sure this is intended. - Your package fails to build from source: ifdhandler.c: In function ‘IFDHControl’: ifdhandler.c:1416:22: error: ‘FEATURE_MCT_READERDIRECT’ undeclared (first use in this function) ifdhandler.c:1416:22: note: each undeclared identifier is reported only once for each function it appears in make[3]: *** [libacsccid_la-ifdhandler.lo] Error 1 make[3]: Leaving directory `/home/tautschnig/debian/acsccid/acsccid-1.0.2/src' Please get those fixed, then another more thorough package review will follow. Best, Michael pgp05k30TMWKV.pgp Description: PGP signature
RFS: acsccid (Updated)
Dear mentors, I am looking for a sponsor for my package "acsccid". Actually, I posted the request about 1 month ago and I did not receive any response here. The package had been updated and fix the following problems: 1. The project is hosted in sourceforge now and watch file is updated. 2. Remove dh_makeshlibs from rules file. 3. Fix non-redistributable reference manual problem. * Package name: acsccid Version : 1.0.2-1 Upstream Author : Advanced Card Systems Ltd. * URL : http://acsccid.sourceforge.net/ * License : LGPL-2.1 Section : libs It builds these binary packages: libacsccid - PC/SC driver for ACS USB CCID smart card readers The package appears to be lintian clean. The upload would fix these bugs: 627038 My motivation for maintaining this package is: This package contains the official PC/SC driver for ACS USB CCID smart card readers. Compared with libccid, it supports many latest readers from ACS. Users of these readers are required to install this driver. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/a/acsccid - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/a/acsccid/acsccid_1.0.2-1.dsc This is my first package and I would be glad if someone reviewed and uploaded this package for me. Kind regards Godfrey Chung
