Re: cython/bison issue (Was: acedb: FTBFS: acein.c:2045:15: error: implicit declaration of function ‘add_history’ [-Werror=implicit-function-declaration])
Hi Jeremy, Am Sat, Apr 13, 2024 at 10:46:17PM +0100 schrieb Jeremy Sowden: > > The one after this looks like a GTK problem, and that's the point at > which I bow out. Thanks a lot for your help so far. Your patches are pushed to Git. Kind regards Andreas. -- https://fam-tille.de
Re: cython/bison issue (Was: acedb: FTBFS: acein.c:2045:15: error: implicit declaration of function ‘add_history’ [-Werror=implicit-function-declaration])
On 2024-04-13, at 21:48:10 +0100, Jeremy Sowden wrote: > On 2024-04-13, at 09:31:07 +0200, Andreas Tille wrote: > > Control: tags -1 help > > thanks > > > > Hi, > > > > while I was able to fix the origininal cause of the failure I'm now blocked > > by > > some issue that cython seems to miss adding some > >#include > > but I have no idea how to accomplish this. The Salsa CI build log[1] says: > > > > ... > > y.tab.c: In function 'yyparse': > > y.tab.c:1409:16: error: implicit declaration of function 'yylex' > > [-Werror=implicit-function-declaration] > > y.tab.c:2185:7: error: implicit declaration of function 'yyerror'; did you > > mean 'YYerror'? [-Werror=implicit-function-declaration] > > In file included from aqlparse.y:335: > > aqlparse.l: In function 'yylex': > > ... > > > > Any help would be welcome > > Andreas. > > You are missing declarations: > > * `yylex` - this needs to be added to the yacc source > * `yyerror` - this is present but hidden by a CPP conditional > * `yywrap` - this is not needed (grep for "YY_SKIP_YYWRAP") and can be >disabled > > Patch attached. I attach a fix for the next error: gcc -g -Wall -DACEDB4 `../w3rdparty/include-config glib-2.0 gtk+-2.0` -I.. -I../wh -I../wstaden -DACEDB_GTK -DLINUX -c -o sigsubs.o sigsubs.c sigsubs.c: In function 'getSignalText': sigsubs.c:486:30: error: '_sys_siglist' undeclared (first use in this function) 486 | char **signal_textlist = &(_sys_siglist[0]) ; | ^~~~ sigsubs.c:486:30: note: each undeclared identifier is reported only once for each function it appears in The one after this looks like a GTK problem, and that's the point at which I bow out. J. diff --git a/w4/sigsubs.c b/w4/sigsubs.c index 2fd0c6ce9155..9d2942df1642 100644 --- a/w4/sigsubs.c +++ b/w4/sigsubs.c @@ -467,6 +467,10 @@ static char *getSignalText(int sig_num) return "unknown"; +#elif defined(LINUX) + + return strsignal(sig_num); + #else char *sig_text = NULL ; @@ -485,7 +489,7 @@ static char *getSignalText(int sig_num) char **signal_textlist = &(_sys_siglist[0]) ; -#if defined(LINUX) || defined(OPTERON) || defined(HP) +#if defined(OPTERON) || defined(HP) int signal_max= _NSIG ; #else int signal_max= _sys_nsig ; signature.asc Description: PGP signature
Re: cython/bison issue (Was: acedb: FTBFS: acein.c:2045:15: error: implicit declaration of function ‘add_history’ [-Werror=implicit-function-declaration])
On 2024-04-13, at 09:31:07 +0200, Andreas Tille wrote:
> Control: tags -1 help
> thanks
>
> Hi,
>
> while I was able to fix the origininal cause of the failure I'm now blocked by
> some issue that cython seems to miss adding some
>#include
> but I have no idea how to accomplish this. The Salsa CI build log[1] says:
>
> ...
> y.tab.c: In function 'yyparse':
> y.tab.c:1409:16: error: implicit declaration of function 'yylex'
> [-Werror=implicit-function-declaration]
> y.tab.c:2185:7: error: implicit declaration of function 'yyerror'; did you
> mean 'YYerror'? [-Werror=implicit-function-declaration]
> In file included from aqlparse.y:335:
> aqlparse.l: In function 'yylex':
> ...
>
> Any help would be welcome
> Andreas.
You are missing declarations:
* `yylex` - this needs to be added to the yacc source
* `yyerror` - this is present but hidden by a CPP conditional
* `yywrap` - this is not needed (grep for "YY_SKIP_YYWRAP") and can be
disabled
Patch attached.
You can find more info about all three in the flex and bison manuals.
J.
diff --git a/waql/aql_.h b/waql/aql_.h
index cde94a97896b..dd3b89116280 100644
--- a/waql/aql_.h
+++ b/waql/aql_.h
@@ -448,7 +448,7 @@ char* aqlNodeTypeName (AqlNodeType inType);
char* aqlOpTypeName (AqlOpType inType);
char* aqlLocSourceTypeName (AqlLocSourceType inType);
-#if defined(IBM)
+#if defined(IBM) || defined(LINUX)
/* predeclare lex.yy.c fns */
void yyerror (char *s);
#endif
diff --git a/waql/aqlparse.l b/waql/aqlparse.l
index 313375027957..bc232e0a4c48 100644
--- a/waql/aqlparse.l
+++ b/waql/aqlparse.l
@@ -102,6 +102,8 @@
%}
+%option noyywrap
+
letter [A-Za-z]
digit [0-9]
id {letter}({letter}|{digit}|"_")*
diff --git a/waql/aqlparse.y b/waql/aqlparse.y
index 9989831a4838..975ae325c14c 100644
--- a/waql/aqlparse.y
+++ b/waql/aqlparse.y
@@ -77,6 +77,8 @@ static int tokPos[1024];
/**/
+int yylex(void);
+
%}
%union {
signature.asc
Description: PGP signature
cython/bison issue (Was: acedb: FTBFS: acein.c:2045:15: error: implicit declaration of function ‘add_history’ [-Werror=implicit-function-declaration])
Control: tags -1 help thanks Hi, while I was able to fix the origininal cause of the failure I'm now blocked by some issue that cython seems to miss adding some #include but I have no idea how to accomplish this. The Salsa CI build log[1] says: ... y.tab.c: In function 'yyparse': y.tab.c:1409:16: error: implicit declaration of function 'yylex' [-Werror=implicit-function-declaration] y.tab.c:2185:7: error: implicit declaration of function 'yyerror'; did you mean 'YYerror'? [-Werror=implicit-function-declaration] In file included from aqlparse.y:335: aqlparse.l: In function 'yylex': ... Any help would be welcome Andreas. [1] https://salsa.debian.org/med-team/acedb/-/jobs/5580840 -- https://fam-tille.de
