Re: lintian .packlist warning and debian/rules modification

2007-10-14 Thread Russ Allbery
Justin Pryzby [EMAIL PROTECTED] writes:

 The debhelper tools (dh_install) used to use debian/tmp but now
 (depending on DH_COMPAT) use debian/$package.  So this is a small-ish
 lintian bug.

I've changed the lintian message to use debian/pkg instead.

-- 
Russ Allbery ([EMAIL PROTECTED])   http://www.eyrie.org/~eagle/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Re: lintian .packlist warning and debian/rules modification

2007-09-10 Thread Felipe Sateler
Justin Pryzby wrote:

 Hi,
 
 The debhelper tools (dh_install) used to use debian/tmp but now
 (depending on DH_COMPAT) use debian/$package.  So this is a small-ish
 lintian bug.

But debian/tmp also happens to be where dh_make defaults to install (make
DESTDIR=$(CURDIR)/debian/tmp), and then copy/move files over
debian/$package with dh_install.


-- 

  Felipe Sateler


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



lintian .packlist warning and debian/rules modification

2007-09-09 Thread Jeremiah Foster
I ran debuilder with lintian and received this output (amongst other  
messages)


E: libhtml-treebuilder-xpath-perl: package-installs-packlist usr/lib/ 
perl5/auto/HTML/TreeBuilder/XPath/.packlist

N:
N:   Packages built using the perl MakeMaker package will have a file  
named
N:   .packlist in them. Those files are useless, and (in some cases)  
have
N:   the additional problem of creating an architecture-specific  
directory

N:   name in an architecture-independent package.
N:
N:   They can be suppressed by adding the following to debian/rules:
N:
N:   find debian/tmp -type f -name .packlist | xargs rm -f
N:
N:   -find debian/tmp/usr/lib/perl5 -type d -empty | xargs rmdir -p
N:
N:   Or by telling MakeMaker to use vendor install dirs; consult a  
recent

N:   version of perl policy. Perl 5.6.0-12 or higher supports this.

Google had remarkably little information on this lintian error. But  
fortunately I had other rules files on my system that had
the above command(s) in their rules file so I copied them as much as  
I could. I placed the previously mentioned find commands under  
various places in the rules file to no effect (the lintian error kept  
appearing.)


Below is an example of the output I would receive:

snip

find debian/tmp -type f -name .packlist | xargs -r rm -f
find: debian/tmp: No such file or directory
find debian/tmp -type d -empty | xargs -r rmdir -p
find: debian/tmp: No such file or directory

snip

What I did to finally get rid of this error was to change the command  
to this:


# remove .packlist files inserted by MakeMaker
find . -type f -name .packlist | xargs -r rm -f

I changed the directories find looks in because of the error message  
from find saying: No such file or directory even though  
the .packlist file existed. (I think that the directory debian/tmp  
was not being created.)


I then placed the changed code (the line above with my comment) in  
the install section of the debian/rules file and the lintian error  
went away! I hope this helps some one else.


If you think I was wrong to do it this way please inform me of the  
proper way to do it or any changes I should make.


Thanks,

Jeremiah Foster


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Re: lintian .packlist warning and debian/rules modification

2007-09-09 Thread Justin Pryzby
On Sun, Sep 09, 2007 at 07:40:28PM +0200, Jeremiah Foster wrote:
 I ran debuilder with lintian and received this output (amongst other 
 messages)

 E: libhtml-treebuilder-xpath-perl: package-installs-packlist 
 usr/lib/perl5/auto/HTML/TreeBuilder/XPath/.packlist
 N:
 N:   Packages built using the perl MakeMaker package will have a file named
 N:   .packlist in them. Those files are useless, and (in some cases) have
 N:   the additional problem of creating an architecture-specific directory
 N:   name in an architecture-independent package.
 N:
 N:   They can be suppressed by adding the following to debian/rules:
 N:
 N:   find debian/tmp -type f -name .packlist | xargs rm -f
 N:
 N:   -find debian/tmp/usr/lib/perl5 -type d -empty | xargs rmdir -p
 N:
 N:   Or by telling MakeMaker to use vendor install dirs; consult a recent
 N:   version of perl policy. Perl 5.6.0-12 or higher supports this.

 Below is an example of the output I would receive:

 snip

 find debian/tmp -type f -name .packlist | xargs -r rm -f
 find: debian/tmp: No such file or directory
 find debian/tmp -type d -empty | xargs -r rmdir -p
 find: debian/tmp: No such file or directory

 snip

 What I did to finally get rid of this error was to change the command to 
 this:

 # remove .packlist files inserted by MakeMaker
 find . -type f -name .packlist | xargs -r rm -f

 I changed the directories find looks in because of the error message from 
 find saying: No such file or directory even though the .packlist file 
 existed. (I think that the directory debian/tmp was not being created.)
Hi,

The debhelper tools (dh_install) used to use debian/tmp but now
(depending on DH_COMPAT) use debian/$package.  So this is a small-ish
lintian bug.

You should probably do find ./debian/ instead of find . to avoid
removing files from ./ except from ./debian/.. since a strict reading
of policy requires that after the clean rule is run you have to end
up in the same state as immediately after dpkg -x $dsc.

Justin


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Re: lintian .packlist warning and debian/rules modification

2007-09-09 Thread Jeremiah Foster


On Sep 9, 2007, at 8:22 PM, Damyan Ivanov wrote:

I then placed the changed code (the line above with my comment) in  
the

install section of the debian/rules file and the lintian error went
away! I hope this helps some one else.

If you think I was wrong to do it this way please inform me of the
proper way to do it or any changes I should make.



The debhelper tools (dh_install) used to use debian/tmp but now
(depending on DH_COMPAT) use debian/$package.  So this is a small-ish
lintian bug.


Should I file a bug report? (I am happy to if people think it is  
worth it.) I suppose I can pass along a patch based on what I have done.


Use the correct directory when find ... -delete-ing things. Look  
where

$(MAKE) install installs it. I guess this should be $(TMP)


I have set it to:

find $(TMP) -type f -name .packlist | xargs -r rm -f

Jeremiah



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Re: lintian .packlist warning and debian/rules modification

2007-09-09 Thread Damyan Ivanov
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

- -=| Jeremiah Foster,  9.09.2007 20:40 |=-
 E: libhtml-treebuilder-xpath-perl: package-installs-packlist
 usr/lib/perl5/auto/HTML/TreeBuilder/XPath/.packlist
 N:
 N:   Packages built using the perl MakeMaker package will have a file named
 N:   .packlist in them. Those files are useless, and (in some cases) have
 N:   the additional problem of creating an architecture-specific directory
 N:   name in an architecture-independent package.
 N:
 N:   They can be suppressed by adding the following to debian/rules:
 N:
 N:   find debian/tmp -type f -name .packlist | xargs rm -f
 N:
 N:   -find debian/tmp/usr/lib/perl5 -type d -empty | xargs rmdir -p
 N:
 N:   Or by telling MakeMaker to use vendor install dirs; consult a recent
 N:   version of perl policy. Perl 5.6.0-12 or higher supports this.
 
 
 Below is an example of the output I would receive:
 
 snip
 
 find debian/tmp -type f -name .packlist | xargs -r rm -f
 find: debian/tmp: No such file or directory
 find debian/tmp -type d -empty | xargs -r rmdir -p
 find: debian/tmp: No such file or directory

Which means that the debian/tmp thing is wrong.

 What I did to finally get rid of this error was to change the command to
 this:
 
 # remove .packlist files inserted by MakeMaker
 find . -type f -name .packlist | xargs -r rm -f
 
 I then placed the changed code (the line above with my comment) in the
 install section of the debian/rules file and the lintian error went
 away! I hope this helps some one else.
 
 If you think I was wrong to do it this way please inform me of the
 proper way to do it or any changes I should make.

Use the correct directory when find ... -delete-ing things. Look where
$(MAKE) install installs it. I guess this should be $(TMP)
- --
damJabberID: [EMAIL PROTECTED]
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG5DnuHqjlqpcl9jsRAl1IAKCaaGr58O6xDWzOtVN8FAU6F+gY6gCfb/O9
L5eOb2R+bmQP9EpZbNiWdXw=
=zOVR
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]