Re: revieuws
On Wed, 5 Feb 2014 20:46:44 +, Roelof Wobbenrwob...@hotmail.com wrote: Hello, Today I uploaded my first package called audiosum. You can find it here : https://mentors.debian.net/package/audiosum What do you mentors think of this package ? Roelof I am not a DD, and because of this I cannot sponsor the package, but: The package doesn't build in a clean chroot - (It looks like you are missing a Build-Depends on libmhash-dev.) To catch problems like this, you should build the package in a clean chroot, which can be done with the pbuilder package, see this page for some information: https://www.debian.org/doc/manuals/maint-guide/build.en.html#pbuilder (I have just taken a quick look at the package, this is not a complete review of it.) best regards -- Andreas Rönnquist mailingli...@gusnan.se gus...@gusnan.se signature.asc Description: PGP signature
Re: revieuws
On 02/05/2014 12:46 PM, Roelof Wobben wrote: Hello, Today I uploaded my first package called audiosum. You can find it here : https://mentors.debian.net/package/audiosum What do you mentors think of this package ? Hi. I'm not a DD, but... 1. Well, manpages could be better, but I think upstream should fix them either manually or make them more help2man friendly. Oh wait, upstream is me! :-/ I'll work on that for 0.3.1 or 0.4. I don't know what other mentors think, if the manpages should be fixed immediately (which would be difficult for upstream to do) or if it's ok to go on like that and fix them in a future version of the package. 2. In the debian/control file, there are unused lines (Vcs-*). I'd suggest you remove them, not just comment them. 3.The description is wrong and not understandable. A user should be able to make sense of what the pagckage does just my looking at its description. Try this: Description: Tool to checksum audio in mp3 files and find duplicates Audiosum displays the checksum for non-ID3 content in audio files. This makes it possible to find mp3 files that only differ on their ID3 tags. Audiodup is an included wrapper for audiosum that finds and lists duplicate files. 4. I see that the debian/copyright file says: License: GPL-3 This package [blah, blah...] either version 2 of the License, or (at your option) any later version. It appears to me that you took the text from GPLv2 instead of v3. 5. Finally, and most importantly; it didn't build here. Here's the log. $ debuild -us -uc dpkg-buildpackage -rfakeroot -D -us -uc dpkg-buildpackage: source package audiosum dpkg-buildpackage: source version 0.3-1 dpkg-buildpackage: source distribution unstable dpkg-buildpackage: source changed by Roelof Wobben r.wob...@home.nl dpkg-source --before-build audiosum-0.3 dpkg-buildpackage: host architecture amd64 dpkg-checkbuilddeps: Unmet build dependencies: dh-autoreconf dpkg-buildpackage: warning: build dependencies/conflicts unsatisfied; aborting dpkg-buildpackage: warning: (Use -d flag to override.) debuild: fatal error at line 1364: dpkg-buildpackage -rfakeroot -D -us -uc failed Thanks again. It's almost there. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/52f3cd0a.8060...@alvarezp.ods.org
RE: revieuws
Date: Thu, 6 Feb 2014 09:57:30 -0800 From: alvar...@alvarezp.ods.org To: rwob...@hotmail.com CC: debian-mentors@lists.debian.org Subject: Re: revieuws On 02/05/2014 12:46 PM, Roelof Wobben wrote: Hello, Today I uploaded my first package called audiosum. You can find it here : https://mentors.debian.net/package/audiosum What do you mentors think of this package ? Hi. I'm not a DD, but... 1. Well, manpages could be better, but I think upstream should fix them either manually or make them more help2man friendly. Oh wait, upstream is me! :-/ I'll work on that for 0.3.1 or 0.4. I don't know what other mentors think, if the manpages should be fixed immediately (which would be difficult for upstream to do) or if it's ok to go on like that and fix them in a future version of the package. I also do not know. What do you think can be better about the manpages. Maybe I can try to change it. 2. In the debian/control file, there are unused lines (Vcs-*). I'd suggest you remove them, not just comment them. Oke, I will change that in version -3. 3.The description is wrong and not understandable. A user should be able to make sense of what the pagckage does just my looking at its description. Try this: Description: Tool to checksum audio in mp3 files and find duplicates Audiosum displays the checksum for non-ID3 content in audio files. This makes it possible to find mp3 files that only differ on their ID3 tags. Audiodup is an included wrapper for audiosum that finds and lists duplicate files. I will also change that in version -3 4. I see that the debian/copyright file says: License: GPL-3 This package [blah, blah...] either version 2 of the License, or (at your option) any later version. It appears to me that you took the text from GPLv2 instead of v3. Will change that also as soon as I find the tekst from v3. 5. Finally, and most importantly; it didn't build here. Here's the log. $ debuild -us -uc dpkg-buildpackage -rfakeroot -D -us -uc dpkg-buildpackage: source package audiosum dpkg-buildpackage: source version 0.3-1 dpkg-buildpackage: source distribution unstable dpkg-buildpackage: source changed by Roelof Wobben r.wob...@home.nl dpkg-source --before-build audiosum-0.3 dpkg-buildpackage: host architecture amd64 dpkg-checkbuilddeps: Unmet build dependencies: dh-autoreconf dpkg-buildpackage: warning: build dependencies/conflicts unsatisfied; aborting dpkg-buildpackage: warning: (Use -d flag to override.) debuild: fatal error at line 1364: dpkg-buildpackage -rfakeroot -D -us -uc failed Did you try this before the build. apt-get install dh-autoreconf I did that and then it builds fine. As far as I know debuild never takes the build requirements with the build. Thanks again. It's almost there. You thanks for all the remarks. I learn a lot of them. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/dub121-w3f3412382a111d7259feaae...@phx.gbl
FW: revieuws
Date: Thu, 6 Feb 2014 19:29:04 + From: dan...@serverb.co.uk To: rwob...@hotmail.com Subject: Re: revieuws -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/02/14 18:19, Roelof Wobben wrote: 2. In the debian/control file, there are unused lines (Vcs-*). I'd suggest you remove them, not just comment them. Oke, I will change that in version -3. 3.The description is wrong and not understandable. A user should be able to make sense of what the pagckage does just my looking at its description. Try this: Description: Tool to checksum audio in mp3 files and find duplicates Audiosum displays the checksum for non-ID3 content in audio files. This makes it possible to find mp3 files that only differ on their ID3 tags. Audiodup is an included wrapper for audiosum that finds and lists duplicate files. I will also change that in version -3 With regards to the versioning and build numbers, I was taught that until the package is actually uploaded to Debian... the build number should stay at [Upstream]-1. Though I'm from previous emails I have seen it suggested that this doesn't matter. Personally I think it looks cleaner for the package to enter Debian at build 1. If i'm incorrect, anybody please feel free to correct me. Thanks for the remark. 5. Finally, and most importantly; it didn't build here. Here's the log. $ debuild -us -uc dpkg-buildpackage -rfakeroot -D -us -uc dpkg-buildpackage: source package audiosum dpkg-buildpackage: source version 0.3-1 dpkg-buildpackage: source distribution unstable dpkg-buildpackage: source changed by Roelof Wobben r.wob...@home.nl dpkg-source --before-build audiosum-0.3 dpkg-buildpackage: host architecture amd64 dpkg-checkbuilddeps: Unmet build dependencies: dh-autoreconf dpkg-buildpackage: warning: build dependencies/conflicts unsatisfied; aborting dpkg-buildpackage: warning: (Use -d flag to override.) debuild: fatal error at line 1364: dpkg-buildpackage -rfakeroot -D -us -uc failed Did you try this before the build. apt-get install dh-autoreconf I did that and then it builds fine. As far as I know debuild never takes the build requirements with the build. Thanks again. It's almost there. You thanks for all the remarks. I learn a lot of them. As was mentioned earlier, you need to setup pbuilder/cowbuilder. This enables you to build the package that same way the Debian Build machines do. Part of the buildd/pbuilder process is to install the Build-Depends each time the package is built, giving you a clean build environment Personally I use the pbuilder-dist script from the ubuntu-dev-tools [1] I have used a cowbuilder chroot and there everything work. The remark was from a user not from me. Roelof -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/dub121-w4fc50bdf863f5b269de2bae...@phx.gbl
Re: revieuws
On 06/02/14 10:19, Roelof Wobben wrote: 1. Well, manpages could be better, but I think upstream should fix them either manually or make them more help2man friendly. Oh wait, upstream is me! :-/ I'll work on that for 0.3.1 or 0.4. I don't know what other mentors think, if the manpages should be fixed immediately (which would be difficult for upstream to do) or if it's ok to go on like that and fix them in a future version of the package. I also do not know. What do you think can be better about the manpages. Maybe I can try to change it. If you can, that would be great! You probably will need to get yourself into quilt/dquilt and learn a bit of the troff language. I eventually will fix that in upstream. 5. Finally, and most importantly; it didn't build here. Here's the log. $ debuild -us -uc (snipped) dpkg-checkbuilddeps: Unmet build dependencies: dh-autoreconf dpkg-buildpackage: warning: build dependencies/conflicts unsatisfied; aborting Did you try this before the build. apt-get install dh-autoreconf I did that and then it builds fine. As far as I know debuild never takes the build requirements with the build. Oh, yes, you're right, and dh-autoreconf is already specified in debian/control. I already tested 'debuild -us -uc debuild -us -uc' and it passes too. That would be all the comments from me. Thanks. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/52f40417.4070...@alvarezp.ods.org
revieuws
Hello, Today I uploaded my first package called audiosum. You can find it here : https://mentors.debian.net/package/audiosum What do you mentors think of this package ? Roelof
