Re: systemd service unit causing lintian init issues

2015-09-30 Thread Matt Zagrabelny
On Tue, Sep 29, 2015 at 11:20 PM, Andrey Rahmatullin  wrote:
> On Tue, Sep 29, 2015 at 03:12:18PM -0500, Matt Zagrabelny wrote:
>> A quick look at the source for dh_installinit doesn't show much about
>> the '-p', nor '--remaining' options. Can you elaborate or point to
>> further docs?
> FWIW those are common debhelper options and so found in debhelper(7).

Thanks! I was guessing that they were common options, but I checked dh(1).

-m



Re: systemd service unit causing lintian init issues

2015-09-29 Thread Andrey Rahmatullin
On Tue, Sep 29, 2015 at 03:12:18PM -0500, Matt Zagrabelny wrote:
> A quick look at the source for dh_installinit doesn't show much about
> the '-p', nor '--remaining' options. Can you elaborate or point to
> further docs?
FWIW those are common debhelper options and so found in debhelper(7).

-- 
WBR, wRAR


signature.asc
Description: PGP signature


Re: systemd service unit causing lintian init issues

2015-09-29 Thread Matt Zagrabelny
Hi Niels,

On Tue, Sep 29, 2015 at 2:44 PM, Niels Thykier  wrote:
 [...]
>>
>> With a Build-Depends on dh-systemd. Those tweaks seemed to fix it. I
>> also submitted a wishlist documentation bug:
>>
>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800043
>>
>> Thanks!
>>
>> -m
>>
>
> Use:
>
> override_dh_installinit:
> dh_installinit -p --noscripts
> dh_installinit --remaining

A quick look at the source for dh_installinit doesn't show much about
the '-p', nor '--remaining' options. Can you elaborate or point to
further docs?

Thanks!

-m



Re: systemd service unit causing lintian init issues

2015-09-29 Thread Niels Thykier
Niels Thykier:
> [...]
> 

Sorry, I somehow managed to confuse it with "--onlyscripts", which needs
that treatment.  Please ignore my previous mail. :)

~Niels





Re: systemd service unit causing lintian init issues

2015-09-29 Thread Niels Thykier
Matt Zagrabelny:
> Hi Tino,
> 
> On Tue, Sep 29, 2015 at 3:41 AM, Tino Mettler  wrote:
>> On Wed, Sep 23, 2015 at 16:36:42 -0500, Matt Zagrabelny wrote:
>>> Greetings,
>>>
>>> I'm packaging up a firewall script that ships with a systemd service
>>> unit file. lintian is complaining about an init script:
>>>
>>> % lintian fw-skel_0.06-1_all.deb
>>> W: fw-skel: init.d-script-not-marked-as-conffile etc/init.d/fw-skel
>>> E: fw-skel: init.d-script-not-included-in-package etc/init.d/fw-skel
>>
>> Hi,
>>
>> I had a similar issue in the past. How does your debian/rules file look
>> like? I'll try to remember what I did wrong.
> 
> I had a minimalistic rules file:
> 
> [...]
> 
> With a Build-Depends on dh-systemd. Those tweaks seemed to fix it. I
> also submitted a wishlist documentation bug:
> 
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800043
> 
> Thanks!
> 
> -m
> 

Use:

override_dh_installinit:
dh_installinit -p --noscripts
dh_installinit --remaining

Thanks,
~Niels





Re: systemd service unit causing lintian init issues

2015-09-29 Thread Matt Zagrabelny
Hi Tino,

On Tue, Sep 29, 2015 at 3:41 AM, Tino Mettler  wrote:
> On Wed, Sep 23, 2015 at 16:36:42 -0500, Matt Zagrabelny wrote:
>> Greetings,
>>
>> I'm packaging up a firewall script that ships with a systemd service
>> unit file. lintian is complaining about an init script:
>>
>> % lintian fw-skel_0.06-1_all.deb
>> W: fw-skel: init.d-script-not-marked-as-conffile etc/init.d/fw-skel
>> E: fw-skel: init.d-script-not-included-in-package etc/init.d/fw-skel
>
> Hi,
>
> I had a similar issue in the past. How does your debian/rules file look
> like? I'll try to remember what I did wrong.

I had a minimalistic rules file:

#!/usr/bin/make -f

%:
dh $@

After sending out the initial email to d-mentors, I changed it to:

#!/usr/bin/make -f

%:
dh $@ --with systemd

override_dh_installinit:
dh_installinit --noscripts

With a Build-Depends on dh-systemd. Those tweaks seemed to fix it. I
also submitted a wishlist documentation bug:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800043

Thanks!

-m



Re: systemd service unit causing lintian init issues

2015-09-29 Thread Arturo Borrero Gonzalez
On 23 September 2015 at 23:36, Matt Zagrabelny  wrote:
> Greetings,
>
> I'm packaging up a firewall script that ships with a systemd service
> unit file. lintian is complaining about an init script:
>

Could please point to the complete source package?

thanks.

-- 
Arturo Borrero González



Re: systemd service unit causing lintian init issues

2015-09-29 Thread Tino Mettler
On Tue, Sep 29, 2015 at 10:41:12 +0200, Tino Mettler wrote:
> On Wed, Sep 23, 2015 at 16:36:42 -0500, Matt Zagrabelny wrote:
> > Greetings,
> > 
> > I'm packaging up a firewall script that ships with a systemd service
> > unit file. lintian is complaining about an init script:
> > 
> > % lintian fw-skel_0.06-1_all.deb
> > W: fw-skel: init.d-script-not-marked-as-conffile etc/init.d/fw-skel
> > E: fw-skel: init.d-script-not-included-in-package etc/init.d/fw-skel
> 
> Hi,
> 
> I had a similar issue in the past. How does your debian/rules file look
> like? I'll try to remember what I did wrong.

IIRC the culprit was that I used an override for dh_installinit to
install multiple services using dh_installinit --name.

Regards,
Tino



Re: systemd service unit causing lintian init issues

2015-09-29 Thread Tino Mettler
On Wed, Sep 23, 2015 at 16:36:42 -0500, Matt Zagrabelny wrote:
> Greetings,
> 
> I'm packaging up a firewall script that ships with a systemd service
> unit file. lintian is complaining about an init script:
> 
> % lintian fw-skel_0.06-1_all.deb
> W: fw-skel: init.d-script-not-marked-as-conffile etc/init.d/fw-skel
> E: fw-skel: init.d-script-not-included-in-package etc/init.d/fw-skel

Hi,

I had a similar issue in the past. How does your debian/rules file look
like? I'll try to remember what I did wrong.

Regards,
Tino



systemd service unit causing lintian init issues

2015-09-23 Thread Matt Zagrabelny
Greetings,

I'm packaging up a firewall script that ships with a systemd service
unit file. lintian is complaining about an init script:

% lintian fw-skel_0.06-1_all.deb
W: fw-skel: init.d-script-not-marked-as-conffile etc/init.d/fw-skel
E: fw-skel: init.d-script-not-included-in-package etc/init.d/fw-skel
%

There is, of course, no init script:

% dpkg-deb -c fw-skel_0.06-1_all.deb  | grep init
%

The postinst and prerm both reference an absent init script:

% dpkg-deb -e fw-skel_0.06-1_all.deb
% grep init DEBIAN/*
DEBIAN/postinst:# Automatically added by dh_installinit
DEBIAN/postinst:if [ -x "/etc/init.d/fw-skel" ]; then
DEBIAN/postrm:# Automatically added by dh_installinit
DEBIAN/prerm:# Automatically added by dh_installinit
DEBIAN/prerm:if [ -x "/etc/init.d/fw-skel" ]; then
%

It seems that dh-systemd is working in some capacity:

% dpkg-deb -c fw-skel_0.06-1_all.deb| grep systemd
drwxr-xr-x root/root 0 2015-09-23 15:18 ./lib/systemd/
drwxr-xr-x root/root 0 2015-09-23 15:18 ./lib/systemd/system/
-rw-r--r-- root/root   200 2015-09-23 15:18
./lib/systemd/system/fw-skel.service
%

I'm building this using a sid cowbuilder + gbp, FWIW.

Any ideas for keeping SysV init out of the postinst and friends?

Thanks!

-m