Bug#1061868: kodi: FTBFS: Settings.h:60:3: note: candidate expects 1 argument, 0 provided

2024-02-04 Thread Vasyl Gello
Control: fixed -1 2:20.3+dfsg-1
Control: close -1

Dear Aurelien,

I ported the patch pointed by Rechi to 20.3 and uploaded whole thing to 
unstable.
I added that patch after I generated d/changelog so cloding it manually now.

Cheers,
Vasyl

Bug#1061868: kodi: FTBFS: Settings.h:60:3: note: candidate expects 1 argument, 0 provided

2024-01-29 Thread Aurelien Jarno
Source: kodi
Version: 2:20.2+dfsg-4
Severity: serious
Tags: ftbfs
Justification: fails to build from source (but built successfully in the past)

Dear maintainer,

kodi fails to build from source. From my build log on amd64:

| cd /<>/obj-x86_64-linux-gnu/build/interfaces/legacy && 
/usr/bin/c++  -I/<>/obj-x86_64-linux-gnu -I/<> 
-I/<>/lib -I/<>/xbmc 
-I/<>/xbmc/platform/linux 
-I/<>/xbmc/cores/VideoPlayer 
-I/<>/obj-x86_64-linux-gnu/build 
-I/<>/xbmc/platform/posix -isystem 
/<>/obj-x86_64-linux-gnu/build/include -isystem 
/usr/include/dbus-1.0 -isystem /usr/lib/x86_64-linux-gnu/dbus-1.0/include 
-isystem /usr/include/pipewire-0.3 -isystem /usr/include/spa-0.2 -isystem 
/usr/include/python3.11 -isystem /usr/include/samba-4.0 -isystem 
/usr/include/libxml2 -isystem 
/<>/obj-x86_64-linux-gnu/build/cores/RetroPlayer/messages -isystem 
/usr/include/freetype2 -isystem /usr/include/fribidi -isystem /usr/include/lzo 
-isystem /usr/include/libdrm -g -ffile-prefix-map=/<>=. 
-fstack-protector-strong -fstack-clash-protection -Wformat 
-Werror=format-security -fcf-protection -O3 -Wdate-time -D_FORTIFY_SOURCE=2 
-D_XBMC -DDEB_VERSION=\"2:20.2+dfsg-4\" -Wall -Wdouble-promotion 
-Wmissing-field-initializers -Wsign-compare -Wextra -Wno-unused-parameter 
-Wno-cast-function-type -Wnon-virtual-dtor -O2 -g -DNDEBUG -std=c++17 
-DTARGET_POSIX -DTARGET_LINUX -D_GNU_SOURCE -DHAVE_LINUX_UDMABUF=1 
-DHAVE_LINUX_DMA_HEAP=1 -DHAVE_LINUX_DMA_BUF=1 -DHAVE_MKOSTEMP=1 
-DHAVE_LINUX_MEMFD=1 -DHAVE_STATX=1 -DHAVE_SSE=1 -DHAVE_SSE2=1 -DHAVE_SSE3=1 
-DHAVE_SSSE3=1 -DHAVE_SSE4_1=1 -D__STDC_CONSTANT_MACROS -D_FILE_OFFSET_BITS=64 
-DHAS_POSIX_NETWORK -DHAS_LINUX_NETWORK -DHAS_BUILTIN_SYNC_ADD_AND_FETCH=1 
-DHAS_BUILTIN_SYNC_SUB_AND_FETCH=1 -DHAS_BUILTIN_SYNC_VAL_COMPARE_AND_SWAP=1 
-DHAVE_INOTIFY=1 -DHAVE_POSIX_FADVISE=1 -DHAVE_LOCALTIME_R=1 -DHAVE_GMTIME_R=1 
-DHAVE_INTTYPES_H=1 -DHAS_ALSA=1 -DHAS_AVAHI=1 -DHAS_ZEROCONF=1 
-DHAVE_LIBBLURAY=1 -DHAVE_LIBBLURAY_BDJ=1 -DHAVE_LIBCEC=1 -DHAS_DBUS=1 
-DHAS_ISO9660PP=1 -DHAVE_LCMS2=1 -DCMS_NO_REGISTER_KEYWORD=1 -DHAS_LIRC=1 
-DHAS_WEB_SERVER=1 -DHAS_WEB_INTERFACE=1 -DHAS_FILESYSTEM_NFS=1 
-DHAS_NFS_SET_TIMEOUT -DHAS_NFS_MOUNT_GETEXPORTS_TIMEOUT -DHAS_PIPEWIRE=1 
-DHAS_AIRPLAY=1 -DHAS_PULSEAUDIO=1 -DHAS_PYTHON=1 -DHAS_FILESYSTEM_SMB=1 
-DHAS_SNDIO=1 -DHAVE_LIBUDEV=1 -DHAS_UDFREAD=1 -DHAVE_LIBXSLT=1 -DHAVE_LIBVA=1 
-DHAS_GLX=1 -DHAVE_LIBVDPAU=1 -DDATE_HAS_STRINGVIEW -DFFMPEG_VER_SHA=\"4.4.1\" 
-DHAVE_GCRYPT=1 -DSPDLOG_FMT_EXTERNAL -DSPDLOG_DEBUG_ON 
-DSPDLOG_NO_ATOMIC_LEVELS -DSPDLOG_ENABLE_PATTERN_PADDING -DSPDLOG_COMPILED_LIB 
-I/usr/include -DSPDLOG_SHARED_LIB -DHAS_EGL=1 -DHAVE_EGLEXTANGLE=1 
-DHAVE_X11=1 -DHAVE_LIBXRANDR=1 -DHAVE_HDR_OUTPUT_METADATA=1 
-DHAVE_DRM_MODIFIER_NAME=1 -DHAS_GL=1 -DHAVE_WAYLAND=1 -DHAVE_GBM=1 
-DHAS_GBM_BO_MAP=1 -DHAS_GBM_MODIFIERS=1 -DHAS_MYSQL=1 -DHAS_UPNP=1 
-DHAS_DVD_DRIVE -DHAS_CDDA_RIPPER -DHAS_AIRTUNES=1 
-DBIN_INSTALL_PATH=\"/usr/lib/x86_64-linux-gnu/kodi\" 
-DINSTALL_PATH=\"/usr/share/kodi\" -Werror=double-promotion 
-Werror=missing-field-initializers -Werror=sign-compare -MD -MT 
build/interfaces/legacy/CMakeFiles/legacy_interface.dir/InfoTagVideo.cpp.o -MF 
CMakeFiles/legacy_interface.dir/InfoTagVideo.cpp.o.d -o 
CMakeFiles/legacy_interface.dir/InfoTagVideo.cpp.o -c 
/<>/xbmc/interfaces/legacy/InfoTagVideo.cpp
| /<>/obj-x86_64-linux-gnu/build/swig/AddonModuleXbmcaddon.i.cpp: 
In function ‘PyObject* 
PythonBindings::xbmcaddon_XBMCAddon_xbmcaddon_Settings_New(PyTypeObject*, 
PyObject*, PyObject*)’:
| 
/<>/obj-x86_64-linux-gnu/build/swig/AddonModuleXbmcaddon.i.cpp:1896:56:
 error: no matching function for call to 
‘XBMCAddon::xbmcaddon::Settings::Settings()’
|  1896 |   apiResult = new XBMCAddon::xbmcaddon::Settings(  );
|   |^
| In file included from /<>/xbmc/interfaces/legacy/Addon.h:14,
|  from 
/<>/obj-x86_64-linux-gnu/build/swig/AddonModuleXbmcaddon.i.cpp:31:
| /<>/xbmc/interfaces/legacy/Settings.h:60:3: note: candidate: 
‘XBMCAddon::xbmcaddon::Settings::Settings(std::shared_ptr)’
|60 |   Settings(std::shared_ptr settings);
|   |   ^~~~
| /<>/xbmc/interfaces/legacy/Settings.h:60:3: note:   candidate 
expects 1 argument, 0 provided
| make[4]: *** [build/swig/CMakeFiles/python_binding.dir/build.make:121: 
build/swig/CMakeFiles/python_binding.dir/AddonModuleXbmcaddon.i.cpp.o] Error 1
| make[4]: Leaving directory '/<>/obj-x86_64-linux-gnu'
| make[3]: *** [CMakeFiles/Makefile2:12028: 
build/swig/CMakeFiles/python_binding.dir/all] Error 2
| make[3]: *** Waiting for unfinished jobs

A full build log on riscv64 is also available there:
https://buildd.debian.org/status/fetch.php?pkg=kodi=riscv64=2%3A20.2%2Bdfsg-4%2Bb3=1706500015=0

Regards
Aurelien