Re: BioPython: Some Python modules not found in tests at package build time

2014-04-28 Thread Andreas Tille
Hi,

On Sat, Apr 26, 2014 at 09:12:45PM +0200, Jakub Wilk wrote:
 * Andreas Tille andr...@an3as.eu, 2014-04-25, 16:08:
 [Debian Python Modules Team
 python-modules-t...@lists.alioth.debian.org in CC since it
 maintains python-reportlab]
 
 ITYM s/maintains/is in Uploaders of/. It makes a big difference here...

Does this mean that not any member of the team could upload a fixed
package?  That would be strange regarding my experience with packaging
teams.

 Well, this was rather me forgetting a python-imaging dependency
 - I (wrongly) assumed that python-pil would be sufficient.
 
 Note that python-imaging is only a compatibility package. It would
 be better to port biopython to the new PIL API.

Well, I have no idea what porting really means.  If there might be a
simple patch that would be OK.  Otherwise I can only hope for upstream.
 
 Unfortunately the result remained the same.  I somehow came to the
 conclusion that the problem is caused by a broken reportlab
 package
 
 I came to the same conclusion. I've attached what seems to be a
 minimal test-case:
 ...
 If I understand correctly, reportlab is trying to use non-free Adobe
 PostScript fonts, which (unsurprisingly) doesn't work on Debian
 systems. It should use the substitutes from the gsfonts package
 instead.

As I just reported to #745985 your patch works nicely.  Many thanks for
it.  It would be great if there would be an upload of this fix in a
short timeframe.

Many thanks

   Andreas.

-- 
http://fam-tille.de


-- 
To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/2014042841.gk8...@an3as.eu



Re: BioPython: Some Python modules not found in tests at package build time

2014-04-28 Thread Jakub Wilk

* Andreas Tille andr...@an3as.eu, 2014-04-28, 13:11:
[Debian Python Modules Team 
python-modules-t...@lists.alioth.debian.org in CC since it 
maintains python-reportlab]


ITYM s/maintains/is in Uploaders of/. It makes a big difference 
here...


Does this mean that not any member of the team could upload a fixed 
package?


I don't know that. What I know is that there were no commits to the 
package's repository by the maintainers since 2006. And changes by other 
team members made to the repository weren't integrated in package 
either.


Well, this was rather me forgetting a python-imaging dependency - I 
(wrongly) assumed that python-pil would be sufficient.


Note that python-imaging is only a compatibility package. It would be 
better to port biopython to the new PIL API.


Well, I have no idea what porting really means.


python-imaging's description more or less says what you have to change:
“PIL used to provide a PIL.pth file which allowed you to `import Image` 
but this is deprecated.  Use `from PIL import Image` now, or install 
this compatibility package to temporarily get the old behavior back.”


If there might be a simple patch that would be OK.  Otherwise I can 
only hope for upstream.


That attached (untested) patch should do the trick.

--
Jakub Wilk
diff --git a/Tests/test_GenomeDiagram.py b/Tests/test_GenomeDiagram.py
--- a/Tests/test_GenomeDiagram.py
+++ b/Tests/test_GenomeDiagram.py
@@ -27,7 +27,7 @@
 Install reportlab if you want to use Bio.Graphics.)
 
 try:
-import Image
+from PIL import Image
 from reportlab.graphics import renderPM
 except ImportError:
 #This is an optional part of ReportLab, so may not be installed.
diff --git a/Tests/test_GraphicsBitmaps.py b/Tests/test_GraphicsBitmaps.py
--- a/Tests/test_GraphicsBitmaps.py
+++ b/Tests/test_GraphicsBitmaps.py
@@ -35,7 +35,7 @@
 bitmaps with Bio.Graphics.)
 try:
 # Skip the test if PIL is not installed
-import Image as i
+from PIL import Image as i
 del i
 except:
 raise MissingPythonDependencyError(


Re: RFS: python-ebooklib

2014-04-28 Thread Vincent Cheng
On Fri, Apr 25, 2014 at 8:24 AM, Daniel James dan...@64studio.com wrote:
 Hi Zygmunt,

 I think you are quite welcome to join DPMT

 https://wiki.debian.org/Teams/PythonModulesTeam/HowToJoin

 Thanks, I have sent a request via the web interface. I have also helped
 upstream create some Sphinx documentation and re-uploaded the package to
 include it.

Please update Vcs-Svn and Vcs-Browser if you choose to store your
packaging in the team's svn repo, and update the Maintainer field as
well (in d/control).

Also, don't hardcode python versions in your package's dependencies
(as mentioned previously on the list [1] - and if you're not
subscribed to the list already, please do so).

Regards,
Vincent

[1] https://lists.debian.org/debian-python/2014/04/msg00040.html


-- 
To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/CACZd_tBuE42_7n=cyzpx4mboqlmgxncqrwqyotayax5nsnu...@mail.gmail.com