review for python-ciso8601/2.3.1-1

[Jeroen Ploemen]

hi Lance,

I took a look at the python-ciso8601 package, put up for sponsorship
in the Python team. Just missed you on IRC, so sending comments by
email instead:

* copyright:
  + incorrect info for upstream (license file in sources states 2014,
does not mention a "tomst");
  + missing info for isocalendar.c, timezone.c (PSF resp. MIT, both
with other copyright holders than Close.io).

* autopkgtest: all defined tests only run for the default python
  version; please test with all supported Python versions.


Otherwise looking good. Please re-add the package to the channel
topic on IRC once the above issues have been addressed.


pgp7SCIPrb2jv.pgp
Description: OpenPGP digital signature

Re: Review + Upload for a few Django-related packages

[Utkarsh Gupta]

Hi again,

On Tue, Aug 8, 2023 at 11:35 PM Lena Voytek  wrote:
> And here are some Django 4 specific updates:
>
> https://salsa.debian.org/python-team/packages/python-django-tagging/-/merge_requests/2
> https://salsa.debian.org/python-team/packages/django-menu-generator-ng/-/merge_requests/1

Uploaded both with the "Team upload" addition to d/ch. :)


- u

Re: Review + Upload for a few Django-related packages

[Utkarsh Gupta]

Hi Lena,

On Tue, Aug 8, 2023 at 11:35 PM Lena Voytek  wrote:
> https://salsa.debian.org/python-team/packages/django-assets/-/merge_requests/3

Sponsored that upload after adding "Team upload" to d/ch! :)

> https://salsa.debian.org/python-team/packages/django-dbbackup/-/merge_requests/1

django-dbbackup fails to build from source. Could you please look into
it and fix that?


- u

review for riscemu/2.2.5-1

[Jeroen Ploemen]

hi Bo,

I took a look at the riscemu package, put up for sponsorship in the
Python team. Some (mostly minor) issues came up:

* copyright:
  + upstream years are incorrect (license file, sources have 2021-2022
resp. 2023).
  + leftover boilerplate comments.
  + empty line (dot) at the start of the license paragraph.

* control:
  + no need to mention -doc/-examples pkgs in the long description,
that's what a suggested dependency is for.
  + tiny (< 10kB) examples package is probably best merged into the
documentation package.

* rules:
  + weird comment at the top of the file (leftover TODO?).
  + variables for doc and example dirs defined but not used?
  + documentation dir /usr/share/doc/riscemu-doc/; did you mean
/usr/share/doc/riscemu/?

* d/riscemu-examples.install used for examples; these should be
  handled by dh_installexamples instead.

* lintian hit: W: riscemu: no-manual-page [usr/bin/riscemu].


pgpwzY4vnizLt.pgp
Description: OpenPGP digital signature