Re: Please help with test suite error and installation problem of python-aws-xray-sdk (Was: If there is no response in debian-python then debian-science might be the right team)

2018-01-15 Thread Piotr Ożarowski 
[Andreas Tille, 2018-01-15]
> Now I need to exclude those tests that try to access remote network
> locations but I failed with the same method as you proposed above.
> 
> Any clue how I can do that properly (please Git pull to see my failed
> attempts).

if you want to disable specific test (not the whole file) in pytest, use
"-k-somename" (note the "-" after "-k")
-- 
GPG: 1D2F A898 58DA AF62 1786 2DF7 AEF6 F1A2 A745 7645

Re: Please help with test suite error and installation problem of python-aws-xray-sdk (Was: If there is no response in debian-python then debian-science might be the right team)

2018-01-15 Thread Andreas Tille 
Hi Piotr,

On Mon, Jan 15, 2018 at 01:52:27PM +0100, Piotr Ożarowski wrote:
> async (and all aio* libs in other tests) is not available in Python 2.7
> so simply disable them. You can do this in debian/rules:
> 
> export PYBUILD_TEST_ARGS_python2=--ignore tests/test_async_local_storage.py 
> --ignore tests/test_async_recorder.py --ignore tests/ext/aiobotocore/ 
> --ignore tests/ext/aiohttp/

Ahh, very helpful hint!
 
Now I need to exclude those tests that try to access remote network
locations but I failed with the same method as you proposed above.

Any clue how I can do that properly (please Git pull to see my failed
attempts).

Kind regards

   Andreas.

[1]  https://salsa.debian.org/science-team/python-aws-xray-sdk.git

-- 
http://fam-tille.de

Re: Please help with test suite error and installation problem of python-aws-xray-sdk (Was: If there is no response in debian-python then debian-science might be the right team)

2018-01-15 Thread Piotr Ożarowski 
[Andreas Tille, 2018-01-15]
>   1) test suite
> 
> I: pybuild base:184: cd 
> /build/python-aws-xray-sdk-0.95/.pybuild/pythonX.Y_2.7/build; python2.7 -m 
> pytest tests
> = test session starts 
> ==
> platform linux2 -- Python 2.7.14+, pytest-3.2.1, py-1.4.34, pluggy-0.4.0
> rootdir: /build/python-aws-xray-sdk-0.95, inifile:
> collected 57 items / 4 errors
> 
>  ERRORS 
> 
>  ERROR collecting 
> .pybuild/pythonX.Y_2.7/build/tests/test_async_local_storage.py.
> /usr/lib/python2.7/dist-packages/_pytest/python.py:395: in _importtestmodule
> mod = self.fspath.pyimport(ensuresyspath=importmode)
> /usr/lib/python2.7/dist-packages/py/_path/local.py:662: in pyimport
> __import__(modname)
> E File 
> "/build/python-aws-xray-sdk-0.95/.pybuild/pythonX.Y_2.7/build/tests/test_async_local_storage.py",
>  line 10
> E   async def _test():
> E   ^
> E   SyntaxError: invalid syntax

async (and all aio* libs in other tests) is not available in Python 2.7
so simply disable them. You can do this in debian/rules:

export PYBUILD_TEST_ARGS_python2=--ignore tests/test_async_local_storage.py 
--ignore tests/test_async_recorder.py --ignore tests/ext/aiobotocore/ --ignore 
tests/ext/aiohttp/


>   2) installation of the resulting package:
> 
> E:Sub-process /usr/bin/dpkg returned an error code (1)
> Traceback (most recent call last):
>   File "/usr/share/wajig/debfile-deps.py", line 56, in 
> main(sys.argv[1])
>   File "/usr/share/wajig/debfile-deps.py", line 48, in main
> cache.commit(apt.progress.text.AcquireProgress())
>   File "/usr/lib/python3/dist-packages/apt/cache.py", line 529, in commit
> raise SystemError("installArchives() failed")
> SystemError: installArchives() failed
> python-aws-xray-sdk (0.95-1) wird eingerichtet ...
>   File "/usr/lib/python2.7/dist-packages/aws_xray_sdk/core/async_context.py", 
> line 14
> def __init__(self, *args, loop=None, use_task_factory=True, **kwargs):
>  ^
> SyntaxError: invalid syntax
> 
>   File 
> "/usr/lib/python2.7/dist-packages/aws_xray_sdk/core/async_recorder.py", line 
> 20
> async def wrapper(wrapped, instance, args, kwargs):
> ^
> SyntaxError: invalid syntax
> 
>   File 
> "/usr/lib/python2.7/dist-packages/aws_xray_sdk/ext/aiobotocore/patch.py", 
> line 30
> async def _xray_traced_aiobotocore(wrapped, instance, args, kwargs):
> ^
> SyntaxError: invalid syntax
> 
>   File 
> "/usr/lib/python2.7/dist-packages/aws_xray_sdk/ext/aiohttp/middleware.py", 
> line 11
> async def middleware(app, handler):
> ^
> SyntaxError: invalid syntax

similar issue here, async stuff will not work in 2.7, you can tell
dh_python2 to remove these files by adding
debian/python-aws-xray-sdk.pyremove file containing:

  aws_xray_sdk/core/async_*
  aws_xray_sdk/ext/aiobotocore/
  aws_xray_sdk/ext/aiohttp/

-- 
GPG: 1D2F A898 58DA AF62 1786 2DF7 AEF6 F1A2 A745 7645

Re: Please help with test suite error and installation problem of python-aws-xray-sdk (Was: If there is no response in debian-python then debian-science might be the right team)

2018-01-15 Thread Andreas Tille 
Hi Simon & Tristan (racing condition with same answer),

On Mon, Jan 15, 2018 at 12:21:02PM +, Simon McVittie wrote:
> On Mon, 15 Jan 2018 at 12:59:29 +0100, Andreas Tille wrote:
> > E File 
> > "/build/python-aws-xray-sdk-0.95/.pybuild/pythonX.Y_2.7/build/tests/test_async_local_storage.py",
> >  line 10
> > E   async def _test():
> > E   ^
> > E   SyntaxError: invalid syntax
> 
> Looks like it needs python3 >= 3.5. 
> https://www.google.com/search?q=async%20def
> 
> > python-aws-xray-sdk (0.95-1) wird eingerichtet ...
> >   File 
> > "/usr/lib/python2.7/dist-packages/aws_xray_sdk/core/async_context.py", line 
> > 14
> > def __init__(self, *args, loop=None, use_task_factory=True, **kwargs):
> >  ^
> > SyntaxError: invalid syntax
> 
> That's Python 3 syntax too. https://www.python.org/dev/peps/pep-3102/

Setup.py of the package says:

...
   'Programming Language :: Python',
'Programming Language :: Python :: 2',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.4',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
...


In the end we actually need this also for Python 2.7 since python-pandas
is also 2.7 and Python 3 (and several reverse depends of python-pandas
need 2.7 as well).  Seems I need to open an issue on Github.

Further question: It seems my packaging is broken since the test is only
run on Python 2.7 (and is breaking there as you know).  What am I missing
to run the Python 3 tests?

Kind regards

   Andreas.

-- 
http://fam-tille.de

Re: Please help with test suite error and installation problem of python-aws-xray-sdk (Was: If there is no response in debian-python then debian-science might be the right team)

2018-01-15 Thread Tristan Seligmann 
On Mon, 15 Jan 2018 at 13:59 Andreas Tille  wrote:

>SyntaxError: invalid syntax
> !!! Interrupted: 4 errors during collection
> 
>

All of these syntax errors relate to syntax that only exist on Python 3,
thus I would conclude that this package does not support Python 2.

Re: Please help with test suite error and installation problem of python-aws-xray-sdk (Was: If there is no response in debian-python then debian-science might be the right team)

2018-01-15 Thread Simon McVittie 
On Mon, 15 Jan 2018 at 12:59:29 +0100, Andreas Tille wrote:
> E File 
> "/build/python-aws-xray-sdk-0.95/.pybuild/pythonX.Y_2.7/build/tests/test_async_local_storage.py",
>  line 10
> E   async def _test():
> E   ^
> E   SyntaxError: invalid syntax

Looks like it needs python3 >= 3.5. https://www.google.com/search?q=async%20def

> python-aws-xray-sdk (0.95-1) wird eingerichtet ...
>   File "/usr/lib/python2.7/dist-packages/aws_xray_sdk/core/async_context.py", 
> line 14
> def __init__(self, *args, loop=None, use_task_factory=True, **kwargs):
>  ^
> SyntaxError: invalid syntax

That's Python 3 syntax too. https://www.python.org/dev/peps/pep-3102/

smcv

Please help with test suite error and installation problem of python-aws-xray-sdk (Was: If there is no response in debian-python then debian-science might be the right team)

2018-01-15 Thread Andreas Tille 
Hi Yaroslav,

On Mon, Jan 15, 2018 at 05:26:28AM -0500, Yaroslav Halchenko wrote:
> I don't mind helping to maintain it under any of those teams. Thank you 
> Andreas for taking care about this new dependency. I will look into updating 
> pandas package

That's very welcome and help is actually needed.  I have pushed my
preliminary attempt to Debian Science Git[1].  Since the test suite was
featuring four errors I simply forced the result of dh_auto_test to true
to get some package for a first test.  This needs to be investigated
before uploading.  Unfortunately the install process also throws errors
when compyling to byte code.  Here are the issues I'm facing and I'm
struck with:

  1) test suite

I: pybuild base:184: cd 
/build/python-aws-xray-sdk-0.95/.pybuild/pythonX.Y_2.7/build; python2.7 -m 
pytest tests
= test session starts ==
platform linux2 -- Python 2.7.14+, pytest-3.2.1, py-1.4.34, pluggy-0.4.0
rootdir: /build/python-aws-xray-sdk-0.95, inifile:
collected 57 items / 4 errors

 ERRORS 
 ERROR collecting 
.pybuild/pythonX.Y_2.7/build/tests/test_async_local_storage.py.
/usr/lib/python2.7/dist-packages/_pytest/python.py:395: in _importtestmodule
mod = self.fspath.pyimport(ensuresyspath=importmode)
/usr/lib/python2.7/dist-packages/py/_path/local.py:662: in pyimport
__import__(modname)
E File 
"/build/python-aws-xray-sdk-0.95/.pybuild/pythonX.Y_2.7/build/tests/test_async_local_storage.py",
 line 10
E   async def _test():
E   ^
E   SyntaxError: invalid syntax
__ ERROR collecting .pybuild/pythonX.Y_2.7/build/tests/test_async_recorder.py __
/usr/lib/python2.7/dist-packages/_pytest/python.py:395: in _importtestmodule
mod = self.fspath.pyimport(ensuresyspath=importmode)
/usr/lib/python2.7/dist-packages/py/_path/local.py:662: in pyimport
__import__(modname)
E File 
"/build/python-aws-xray-sdk-0.95/.pybuild/pythonX.Y_2.7/build/tests/test_async_recorder.py",
 line 9
E   async def async_method2():
E   ^
E   SyntaxError: invalid syntax
 ERROR collecting 
.pybuild/pythonX.Y_2.7/build/tests/ext/aiobotocore/test_aiobotocore.py.
/usr/lib/python2.7/dist-packages/_pytest/python.py:395: in _importtestmodule
mod = self.fspath.pyimport(ensuresyspath=importmode)
/usr/lib/python2.7/dist-packages/py/_path/local.py:662: in pyimport
__import__(modname)
E File 
"/build/python-aws-xray-sdk-0.95/.pybuild/pythonX.Y_2.7/build/tests/ext/aiobotocore/test_aiobotocore.py",
 line 24
E   async def test_describe_table(loop, recorder):
E   ^
E   SyntaxError: invalid syntax
 ERROR collecting 
.pybuild/pythonX.Y_2.7/build/tests/ext/aiohttp/test_aiohttp.py.
/usr/lib/python2.7/dist-packages/_pytest/python.py:395: in _importtestmodule
mod = self.fspath.pyimport(ensuresyspath=importmode)
/usr/lib/python2.7/dist-packages/py/_path/local.py:662: in pyimport
__import__(modname)
E File 
"/build/python-aws-xray-sdk-0.95/.pybuild/pythonX.Y_2.7/build/tests/ext/aiohttp/test_aiohttp.py",
 line 46
E   async def handle_ok(self, request: web.Request) -> web.Response:
E   ^
E   SyntaxError: invalid syntax
!!! Interrupted: 4 errors during collection 
=== 4 error in 0.69 seconds 


  2) installation of the resulting package:

E:Sub-process /usr/bin/dpkg returned an error code (1)
Traceback (most recent call last):
  File "/usr/share/wajig/debfile-deps.py", line 56, in 
main(sys.argv[1])
  File "/usr/share/wajig/debfile-deps.py", line 48, in main
cache.commit(apt.progress.text.AcquireProgress())
  File "/usr/lib/python3/dist-packages/apt/cache.py", line 529, in commit
raise SystemError("installArchives() failed")
SystemError: installArchives() failed
python-aws-xray-sdk (0.95-1) wird eingerichtet ...
  File "/usr/lib/python2.7/dist-packages/aws_xray_sdk/core/async_context.py", 
line 14
def __init__(self, *args, loop=None, use_task_factory=True, **kwargs):
 ^
SyntaxError: invalid syntax

  File "/usr/lib/python2.7/dist-packages/aws_xray_sdk/core/async_recorder.py", 
line 20
async def wrapper(wrapped, instance, args, kwargs):
^
SyntaxError: invalid syntax

  File 
"/usr/lib/python2.7/dist-packages/aws_xray_sdk/ext/aiobotocore/patch.py", line 
30
async def _xray_traced_aiobotocore(wrapped, instance, args, kwargs):
^
SyntaxError: invalid syntax

  File 
"/usr/lib/python2.7/dist-packages/aws_xray_sdk/ext/aiohttp/middleware.py", line 
11
async def middleware(app, handler):
^
SyntaxError: invalid syntax


Any help would be really appreciated.

Kind regards

Andreas.


[1] https://salsa.debian.org/science-team/python-aws-xray-sdk.git

-- 
http://fam-tille.de