Re: RFR: python-secretstorage
Fixed, thanks for your review! -- Dmitry Shachnev On Mon, Jun 25, 2012 at 10:30 PM, Jakub Wilk wrote: > * Dmitry Shachnev , 2012-06-22, 11:47: > >> I am looking for a review of my package "python-secretstorage". > > DM-Upload-Allowed is supposed to be added by the sponsor, not by the DM. > > Licence field in DEP-5 copyright file should use the same formatting rules > as the Description field in debian/control. (See Debian Policy 5.6.13 for > details.) > > -- > Jakub Wilk -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/cakimphusb2qg1ju+bqnu8mklu4rnd+jxw2+gtlssfvh9ryh...@mail.gmail.com
Re: RFR: python-secretstorage
* Dmitry Shachnev , 2012-06-22, 11:47: I am looking for a review of my package "python-secretstorage". DM-Upload-Allowed is supposed to be added by the sponsor, not by the DM. Licence field in DEP-5 copyright file should use the same formatting rules as the Description field in debian/control. (See Debian Policy 5.6.13 for details.) -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120625183030.ga7...@jwilk.net
Re: RFR: python-secretstorage
On 22 June 2012 12:37, Simon McVittie wrote: > FYI this shouldn't be necessary on Linux if you're either under X or > running dbus-daemon manually, but it's still needed on kFreeBSD and > probably Hurd, even if you run dbus-daemon manually. The tests failed during an archive rebuild - that line was apparently to fix the issue: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=674351 >> PYTHONS="$(PYTHON2) $(PYTHON3)" xvfb-run -a debian/runtests.sh > > You don't need X for D-Bus if you run a dbus-daemon yourself. > tools/with-session-bus.sh in src:telepathy-glib and other Telepathy > packages is a relatively simple way to achieve that: run it like this: Thanks, that's good to know. Good luck getting it in as a general tool. In my case, I think notification-daemon itself requires an X server. Best wishes, Thomas -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caovn4qj3xxpsfeiwayacb4vknkckkqkc2guol69+dmk50yb...@mail.gmail.com
Re: RFR: python-secretstorage
On 22/06/12 11:27, Thomas Kluyver wrote: > I recently did a wrapper for the dbus desktop notifications API > 5 # This is needed on buildd so that dbus can use ~/.dbus > 6 export HOME = $(CURDIR) FYI this shouldn't be necessary on Linux if you're either under X or running dbus-daemon manually, but it's still needed on kFreeBSD and probably Hurd, even if you run dbus-daemon manually. (It's needed on kFreeBSD because dbus supports Linux credentials-passing, but not FreeBSD credentials-passing; so it falls back to proving its uid by writing a "cookie" to a well-known location in $HOME.) > PYTHONS="$(PYTHON2) $(PYTHON3)" xvfb-run -a debian/runtests.sh You don't need X for D-Bus if you run a dbus-daemon yourself. tools/with-session-bus.sh in src:telepathy-glib and other Telepathy packages is a relatively simple way to achieve that: run it like this: with-session-bus.sh --session -- debian/runtests.sh I want to add a new "dbus-run-session" tool to dbus itself[1], which is basically with-session-bus.sh but simpler and in C. I'm waiting for code review on that; it probably won't be there in time for wheezy. S [1] https://bugs.freedesktop.org/show_bug.cgi?id=39196 -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4fe458ec.1010...@debian.org
Re: RFR: python-secretstorage
I was following your discussions about that, thanks! In my case it's more difficult: I need a running gnome-keyring-daemon with a configured default keyring. I'll try playing with xvfb later (when I have more time, and when I get async functions working). -- Dmitry Shachnev On Fri, Jun 22, 2012 at 2:27 PM, Thomas Kluyver wrote: > On 22 June 2012 08:47, Dmitry Shachnev wrote: >> There is a small test script in the tarball (I plan to add "real" >> unit-tests in the next releases), but it requires dbus and >> gnome-keyring daemons running, so I don't think it's possible to run >> it at the build time. > > I recently did a wrapper for the dbus desktop notifications API, which > is tested with dbus and notification-daemon running. It was suggested > that it wasn't necessary to run those tests, but after a bit of > fiddling we got it working. You're welcome to crib from that: > > http://anonscm.debian.org/viewvc/python-modules/packages/python-notify2/trunk/debian/ > > Best wishes, > Thomas -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAKimPHWE9=rrnd71vsfppbqmjouyunucppecpeuoet6odnt...@mail.gmail.com
Re: RFR: python-secretstorage
On 22 June 2012 08:47, Dmitry Shachnev wrote: > There is a small test script in the tarball (I plan to add "real" > unit-tests in the next releases), but it requires dbus and > gnome-keyring daemons running, so I don't think it's possible to run > it at the build time. I recently did a wrapper for the dbus desktop notifications API, which is tested with dbus and notification-daemon running. It was suggested that it wasn't necessary to run those tests, but after a bit of fiddling we got it working. You're welcome to crib from that: http://anonscm.debian.org/viewvc/python-modules/packages/python-notify2/trunk/debian/ Best wishes, Thomas -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caovn4qjfzcp1cnyzag5he9v36vdbnkuatfszmsqhcsyt4nf...@mail.gmail.com
