Re: RFS: Didjvu, Djvusmooth, Ocrodjvu, Pybtex
* Daniel Stender , 2010-11-05, 18:45: /python-apps/packages/ocrodjvu/tags/0.4.6-3 FTR, I uploaded ocrodjvu. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101122202651.ga8...@jwilk.net
Re: RFS: Didjvu, Djvusmooth, Ocrodjvu, Pybtex
Another problem:
To give "XS-Python-Version: >= 2.6" together with "${misc:Depends},
${python:Depends}, python (>=
2.7) | python-argparse" in debian/control results in an INFO file in the
deb-packet which contains:
"Depends: python (>= 2.6), python (>= 2.7) | python-argparse"
On 06.11.2010 14:16, Stefano Rivera wrote:
> Hi debian-python (2010.11.06_12:15:18_+0200)
>> Well, it installs, as Jakub also pointed out, you'll need a patch or
>> your own wrapper to get Python to find the private module.
>
> Or the obvious solution, your previous one (and the one used by
> the other packages in this set), to use a symlink to the wrapper, which
> you put in /usr/share/didjvu.
>
> didjvu is missing a dependency on python-gamera.
>
>> Files: debian/*
>> -Copyright: 2009, 2010 Jakub Wilk
>> +Copyright: 2010 Daniel Stender
>
> I don't think you should forget Jakub, just add yourself.
>
> Otherwise no issues I can see.
>
> SR
--
http://www.danielstender.com/granthinam/
GPG key ID: 1654BD9C
--
To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4cd58899.3020...@danielstender.com
Re: RFS: Didjvu, Djvusmooth, Ocrodjvu, Pybtex
Hi debian-python (2010.11.06_12:15:18_+0200) > Well, it installs, as Jakub also pointed out, you'll need a patch or > your own wrapper to get Python to find the private module. Or the obvious solution, your previous one (and the one used by the other packages in this set), to use a symlink to the wrapper, which you put in /usr/share/didjvu. didjvu is missing a dependency on python-gamera. > Files: debian/* > -Copyright: 2009, 2010 Jakub Wilk > +Copyright: 2010 Daniel Stender I don't think you should forget Jakub, just add yourself. Otherwise no issues I can see. SR -- Stefano Rivera http://tumbleweed.org.za/ H: +27 21 465 6908 C: +27 72 419 8559 UCT: x3127 -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101106131618.gq29...@bach.rivera.co.za
Re: RFS: Didjvu, Djvusmooth, Ocrodjvu, Pybtex
All refreshed. How do I update tags? Svn copy (/trunk /tags/foo) says "permission denied". Thanks for all pointers, Daniel Stender On 06.11.2010 11:15, Stefano Rivera wrote: > Hi Daniel (2010.11.06_11:47:14_+0200) >>> argparse is part of the standard library in Python 2.7. A dependency on >>> python (>= 2.7) | python-argparse is probably preferable. >> >> Allright. > > I suppose that's not necessary, Jakub had a good point that python will > probably provide python-argparse when 2.7 is the default version. That > appears to be how previous transitions (without renames) into the stdlib > were handled. > >> Didn't get it. It says: "This work was packaged for Debian by Daniel >> Stender" and also states the >> license of both the upstream and the packet. I was following again >> maint-guide (5.2) with details. > > I'm saying you should add something like: > | The Debian packaging is (C) 2010, Daniel Stender > | and is licensed under the GPL v2, see above > or use DEP-5, with a "Files: debian/*" section. Your Licence block looks > like it was copied from another debian/copyright file that used DEP5. > http://dep.debian.net/deps/dep5/ > >> Yes, great! I've got problems with "dh $@" that without the lib path >> the modules were considered to be public, now it works. > > Well, it installs, as Jakub also pointed out, you'll need a patch or > your own wrapper to get Python to find the private module. > >> But without my links the executeable resides in /usr/share/bin, isn't >> that substandard? > > Hmm, I don't see that, but you haven't committed your changes to the > repo yet, so I can't look at the code you are working with. > >> Please, one more towards the procedure of updated already tagged stuff: svn >> commit or again >> debcommit? Then svn copy /trunk /tags/0.2.1-1? > > I debcommit when I've made changes to debian/changelog (i.e. when I > first make a change). If I have to go back and fix something which > hasn't been published yet, then there won't be a changelog entry, so I > have to provide my own commit message with svn commit. > > SR -- http://www.danielstender.com/granthinam/ GPG key ID: 1654BD9C -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4cd54a6f.6060...@danielstender.com
Re: RFS: Didjvu, Djvusmooth, Ocrodjvu, Pybtex
Hi Daniel (2010.11.06_11:47:14_+0200) > > argparse is part of the standard library in Python 2.7. A dependency on > > python (>= 2.7) | python-argparse is probably preferable. > > Allright. I suppose that's not necessary, Jakub had a good point that python will probably provide python-argparse when 2.7 is the default version. That appears to be how previous transitions (without renames) into the stdlib were handled. > Didn't get it. It says: "This work was packaged for Debian by Daniel Stender" > and also states the > license of both the upstream and the packet. I was following again > maint-guide (5.2) with details. I'm saying you should add something like: | The Debian packaging is (C) 2010, Daniel Stender | and is licensed under the GPL v2, see above or use DEP-5, with a "Files: debian/*" section. Your Licence block looks like it was copied from another debian/copyright file that used DEP5. http://dep.debian.net/deps/dep5/ > Yes, great! I've got problems with "dh $@" that without the lib path > the modules were considered to be public, now it works. Well, it installs, as Jakub also pointed out, you'll need a patch or your own wrapper to get Python to find the private module. > But without my links the executeable resides in /usr/share/bin, isn't > that substandard? Hmm, I don't see that, but you haven't committed your changes to the repo yet, so I can't look at the code you are working with. > Please, one more towards the procedure of updated already tagged stuff: svn > commit or again > debcommit? Then svn copy /trunk /tags/0.2.1-1? I debcommit when I've made changes to debian/changelog (i.e. when I first make a change). If I have to go back and fix something which hasn't been published yet, then there won't be a changelog entry, so I have to provide my own commit message with svn commit. SR -- Stefano Rivera http://tumbleweed.org.za/ H: +27 21 465 6908 C: +27 72 419 8559 UCT: x3127 -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101106101518.gp29...@bach.rivera.co.za
Re: RFS: Didjvu, Djvusmooth, Ocrodjvu, Pybtex
Thanks Stefano for checking the packets and for the precious pointers (for most
of the issues it's
hard to find comprehensive documentation).
On 05.11.2010 20:46, Stefano Rivera wrote:
> As a not-yet-DD I can't upload, but here's a review.
>
> First, we don't tag releases until they are uploaded. You can leave the
> changelog entry as UNRELEASED, and the sponsor will fix that and tag on
> upload.
I was following maint-guide 4.3 with that: "distribution should be either
unstable (or even
experimental) [16]" - but I was wondering about this anyway. Thanks for the
pointer! I've fixed that
for all packages.
>> /python-apps/packages/didjvu/tags/0.2.1-1/ initial release of 0.2.1
>> Depends: ${misc:Depends}, ${python:Depends}, python-imaging, libdjvulibre21
>> (>= 3.5.21), python-argparse
>
> I'd suggest wrapping that (after every comma is quite neat).
>
> argparse is part of the standard library in Python 2.7. A dependency on
> python (>= 2.7) | python-argparse is probably preferable.
Allright.
> The description could probably be broken into a couple of shorter
> paragraphs.
Mhmm, too long? o.k.
> debian/copyright mentions jwilk, but not you. You should state the
> licencing of your packaging.
Didn't get it. It says: "This work was packaged for Debian by Daniel Stender"
and also states the
license of both the upstream and the packet. I was following again maint-guide
(5.2) with details.
> Also, you BD on debhelper >= 7, but use an override, which requires
> debhelper >= 7.0.50~.
Fixed.
> debian/rules: Not a fan of dh $...@?
> I'm guessing you misunderstood my message on this topic, as you are
> totally avoiding the setup.py and using dh_install + dh_link to install
> files.
> I think the following debian/rules will do what you want (and you won't
> need debian/install or debian/links any more):
>
>
> #!/usr/bin/make -f
> %:
> dh $@
>
> override_dh_auto_install:
> dh_auto_install -- --install-lib /usr/share/didjvu
>
Yes, great! I've got problems with "dh $@" that without the lib path the
modules were considered to
be public, now it works. But without my links the executeable resides in
/usr/share/bin, isn't that
substandard?
> For new packages, you should probably consider using dh_python2 instead
> of python-support. The eventual plan is to migrate all Python packages
> to it.
Yes definitely. I've followed Piotr's presentation at debconf 2010 on this. I
would like to to put
that on the agenda for further work on that.
>> /python-apps/packages/djvusmooth/tags/0.2.8-2/
> Predates you, but "djvusmooth is a graphical editor for DjVu
> files, which allows to:" isn't correct English grammar. ..."which allows
> one to" would be better.
Fixed.
> You probably want to add yourself to debian/copyright (even if you
> haven't made any significant modifications yet). This applies to all the
> packages.
Ah yes sure ... just overseen it. Fixed everywhere.
>> /python-apps/packages/ocrodjvu/tags/0.4.6-3 closes important bug
>> #600539 in testing
> My previous argparse comment still applies, but this is aimed at squeeze
> which doesn't have python2.7, so you don't need to do this yet (but
> consider it for the trunk, please).
Allright.
>> /python-apps/packages/pybtex/tags/0.14.1-1 new upstream release
> I see some trailing whitespace in debian/changelog.
> Mixed tabs and spaces in debian/postinst (naughty jwilk)
All fixed and refreshed (so, everything else seem to be alright I'll guess).
Please, one more towards the procedure of updated already tagged stuff: svn
commit or again
debcommit? Then svn copy /trunk /tags/0.2.1-1?
Greetings,
Daniel Stender
--
To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4cd52422.2000...@danielstender.com
Re: Sponsors and ‘UNRELE ASED ’ suite (was: RFS: Didjvu, Djvusmooth, Ocrodjvu, Pybtex)
Hi Ben (2010.11.05_23:18:41_+0200) > Is this common practise among sponsors? It is for debian-python. I don't have any experience with other SVN-using teams. > If the above convention (the sponsor will change ‘UNRELEASED’ to the > appropriate suite name before re-building) is common, is it documented > anywhere? No idea about documentation, I've just been told to do this on the IRC channel. The closest is: * After upload, tag the latest revision running svn-buildpackage --svn-tag-only into 'package-foo' directory. from http://python-modules.alioth.debian.org/python-modules-policy.html Yes, it does mean the sponsoree has to state which suite is desired. But it saves on a lot of untagging and retagging in each round of review, and makes it a little easier to know the state of things when reading the repo. SR -- Stefano Rivera http://tumbleweed.org.za/ H: +27 21 465 6908 C: +27 72 419 8559 UCT: x3127 -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101105215758.gn29...@bach.rivera.co.za
Sponsors and ‘UNRELEASED’ suite (was: RFS: Didjvu, Djvusmooth, Ocrodjvu, Pybtex)
Moving this non-Python part of the discussion to ‘debian-mentors’. Stefano Rivera writes: > First, we don't tag releases until they are uploaded. You can leave the > changelog entry as UNRELEASED, and the sponsor will fix that and tag on > upload. Is this common practise among sponsors? I was under the impression that the maintainer should create the package exactly as it should be uploaded into Debian, and the sponsor can expect to make no modifications before re-building. So I always put the intended target suite in the changelog entry. If the above convention (the sponsor will change ‘UNRELEASED’ to the appropriate suite name before re-building) is common, is it documented anywhere? -- \ “From the moment I picked your book up until I laid it down I | `\was convulsed with laughter. Someday I intend reading it.” | _o__)—Groucho Marx | Ben Finney -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/87r5ezeafi.fsf...@benfinney.id.au
Re: RFS: Didjvu, Djvusmooth, Ocrodjvu, Pybtex
* Stefano Rivera , 2010-11-05, 21:46: debian/rules: Not a fan of dh $...@? FWIW, I have nothing against dh $@, but I'm opposed to abuse of %-rules. #!/usr/bin/make -f %: dh $@ override_dh_auto_install: dh_auto_install -- --install-lib /usr/share/didjvu Now you need only to jump through a few hops to let the binary find the modules. ;> /python-apps/packages/ocrodjvu/tags/0.4.6-3 My previous argparse comment still applies, but this is aimed at squeeze which doesn't have python2.7, so you don't need to do this yet (but consider it for the trunk, please). It's been already "python (>= 2.7) | python-argparse" for a while, in both branches. That said, I'm not sure if this change was necessary at all. New python will surely "Provide: python-argparse", won't it? -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101105210134.ga5...@jwilk.net
Re: RFS: Didjvu, Djvusmooth, Ocrodjvu, Pybtex
On Nov 05, 2010, at 09:46 PM, Stefano Rivera wrote: >#!/usr/bin/make -f >%: > dh $@ [...] > >For new packages, you should probably consider using dh_python2 instead >of python-support. The eventual plan is to migrate all Python packages >to it. Which should be as easy as adding "--with python2" to the end of the dh line. -Barry signature.asc Description: PGP signature
Re: RFS: Didjvu, Djvusmooth, Ocrodjvu, Pybtex
Hi Daniel (2010.11.05_19:45:42_+0200)
> I'm kindly asking for overchecking/uploading of the following packages:
As a not-yet-DD I can't upload, but here's a review.
First, we don't tag releases until they are uploaded. You can leave the
changelog entry as UNRELEASED, and the sponsor will fix that and tag on
upload.
> /python-apps/packages/didjvu/tags/0.2.1-1/initial release of 0.2.1
> Depends: ${misc:Depends}, ${python:Depends}, python-imaging, libdjvulibre21
> (>= 3.5.21), python-argparse
I'd suggest wrapping that (after every comma is quite neat).
argparse is part of the standard library in Python 2.7. A dependency on
python (>= 2.7) | python-argparse is probably preferable.
The description could probably be broken into a couple of shorter
paragraphs.
debian/copyright mentions jwilk, but not you. You should state the
licencing of your packaging.
debian/rules: Not a fan of dh $...@?
I'm guessing you misunderstood my message on this topic, as you are
totally avoiding the setup.py and using dh_install + dh_link to install
files.
Also, you BD on debhelper >= 7, but use an override, which requires
debhelper >= 7.0.50~.
I think the following debian/rules will do what you want (and you won't
need debian/install or debian/links any more):
#!/usr/bin/make -f
%:
dh $@
override_dh_auto_install:
dh_auto_install -- --install-lib /usr/share/didjvu
For new packages, you should probably consider using dh_python2 instead
of python-support. The eventual plan is to migrate all Python packages
to it.
> /python-apps/packages/djvusmooth/tags/0.2.8-2/
Predates you, but "djvusmooth is a graphical editor for DjVu
files, which allows to:" isn't correct English grammar. ..."which allows
one to" would be better.
You probably want to add yourself to debian/copyright (even if you
haven't made any significant modifications yet). This applies to all the
packages.
> /python-apps/packages/ocrodjvu/tags/0.4.6-3 closes important bug
> #600539 in testing
My previous argparse comment still applies, but this is aimed at squeeze
which doesn't have python2.7, so you don't need to do this yet (but
consider it for the trunk, please).
> /python-apps/packages/pybtex/tags/0.14.1-1new upstream release
I see some trailing whitespace in debian/changelog.
Mixed tabs and spaces in debian/postinst (naughty jwilk)
SR
--
Stefano Rivera
http://tumbleweed.org.za/
H: +27 21 465 6908 C: +27 72 419 8559 UCT: x3127
--
To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20101105194624.gm29...@bach.rivera.co.za
RFS: Didjvu, Djvusmooth, Ocrodjvu, Pybtex
Hi people, I'm kindly asking for overchecking/uploading of the following packages: /python-apps/packages/didjvu/tags/0.2.1-1/ initial release of 0.2.1 /python-apps/packages/djvusmooth/tags/0.2.8-2/ /python-apps/packages/ocrodjvu/tags/0.4.6-3 closes important bug #600539 in testing /python-apps/packages/pybtex/tags/0.14.1-1 new upstream release All packages are lintian clean. Thank you very much in advance, Daniel Stender -- http://www.danielstender.com/granthinam/ GPG key ID: 1654BD9C -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4cd442c6.50...@danielstender.com
