Re: Salvaging pylibtiff to Debian Python team or removing it from Debian?

[Andreas Tille]

Uploaded with the fixes below as Maintainer Debian QA Group 


On Sat, Oct 22, 2016 at 07:44:37AM +0200, Maximiliano Curia wrote:
> ¡Hola Andreas!
> 
> El 2016-10-21 a las 09:36 +0200, Andreas Tille escribió:
> >the former maintainer of pylibtiff inside Debian Med team Mathieu
> >Malaterre does not care for the package any more and thus I tried my luck
> >to salvage it.  I have no personal interest in this package nor does it
> >have any rdepends.  There is no direct connection to the Debian Med topic
> >but since there are some users according to popcon[1] it might be worth
> >saving.
> 
> I won't be able to work on this in the foreseeable future, but I can
> probably help with the mentioned errors.
> 
> > File "/usr/lib/python2.7/dist-packages/libtiff/libtiff_ctypes.py", line
> >36print 'You should add %r to PATH environment variable and reboot.' %
> >(os.path.dirname (lib))
> >^ SyntaxError: invalid syntax
> 
> This looks valid, but probably fails if using:
> from __future__ import print_function
> you can probably fix this by adding the parenthesis needed for the function
> invocation:
> print('You should add %r to PATH environment variable and reboot.' % 
> (os.path.dirname (lib)))
> 
> > File "/usr/lib/python2.7/dist-packages/libtiff/optparse_gui.py", line 201
> >print(msg, file=sys.stderr)   ^ SyntaxError: invalid
> >syntax
> 
> This is probably failing because of a missing:
> from __future__ import print_function
> at the beginning of the file (it needs to be added before any other import).
> 
> In python2 print is a statement that you use as print "Hi", in python3 it's a
> function that you use as print("Hi"), using the __future__ snippet you can
> use (in python 2.7) print as a function, this is generally a good idea as it
> eases the migration to python3 process.
> 
> Happy hacking,
> -- 
> "If you have too many special cases, you are doing it wrong." -- Craig Zarouni
> Saludos /\/\ /\ >< `/



-- 
http://fam-tille.de

Re: Salvaging pylibtiff to Debian Python team or removing it from Debian?

[Scott Kitterman]

On Saturday, October 22, 2016 08:30:50 AM Andreas Tille wrote:
> ¡Hola Maxi!
> 
> On Sat, Oct 22, 2016 at 07:44:37AM +0200, Maximiliano Curia wrote:
> > El 2016-10-21 a las 09:36 +0200, Andreas Tille escribió:
> > >the former maintainer of pylibtiff inside Debian Med team Mathieu
> > >Malaterre does not care for the package any more and thus I tried my luck
> > >to salvage it.  I have no personal interest in this package nor does it
> > >have any rdepends.  There is no direct connection to the Debian Med topic
> > >but since there are some users according to popcon[1] it might be worth
> > >saving.
> > 
> > I won't be able to work on this in the foreseeable future, but I can
> > probably help with the mentioned errors.
> 
> Thanks for your attempt to help.  I think I'd manage for this upload.
> The problem is that I'd like to habd over the package to proper
> maintenance.  I'm not really sure whether simply dumping it to QA team
> is a good solution.  So I wonder whether it is OK, to fix these issues
> and move the packaging to Python Git and use Python Modules team as
> maintainer.

It still needs a human uploader.  Unless someone's volunteering for that it 
should go to QA or be removed.

Scott K

Re: Salvaging pylibtiff to Debian Python team or removing it from Debian?

[Andreas Tille]

¡Hola Maxi!

On Sat, Oct 22, 2016 at 07:44:37AM +0200, Maximiliano Curia wrote:
> El 2016-10-21 a las 09:36 +0200, Andreas Tille escribió:
> >the former maintainer of pylibtiff inside Debian Med team Mathieu
> >Malaterre does not care for the package any more and thus I tried my luck
> >to salvage it.  I have no personal interest in this package nor does it
> >have any rdepends.  There is no direct connection to the Debian Med topic
> >but since there are some users according to popcon[1] it might be worth
> >saving.
> 
> I won't be able to work on this in the foreseeable future, but I can
> probably help with the mentioned errors.

Thanks for your attempt to help.  I think I'd manage for this upload.
The problem is that I'd like to habd over the package to proper
maintenance.  I'm not really sure whether simply dumping it to QA team
is a good solution.  So I wonder whether it is OK, to fix these issues
and move the packaging to Python Git and use Python Modules team as
maintainer.
 
Kind regards

   Andreas.

-- 
http://fam-tille.de

Re: Salvaging pylibtiff to Debian Python team or removing it from Debian?

[Maximiliano Curia]

¡Hola Andreas!

El 2016-10-21 a las 09:36 +0200, Andreas Tille escribió:
the former maintainer of pylibtiff inside Debian Med team Mathieu 
Malaterre does not care for the package any more and thus I tried 
my luck to salvage it.  I have no personal interest in this package 
nor does it have any rdepends.  There is no direct connection to 
the Debian Med topic but since there are some users according to 
popcon[1] it might be worth saving.


I won't be able to work on this in the foreseeable future, but I can probably 
help with the mentioned errors.


 File "/usr/lib/python2.7/dist-packages/libtiff/libtiff_ctypes.py", line 36 
   print 'You should add %r to PATH environment variable and reboot.' % (os.path.dirname (lib)) 
^ 
SyntaxError: invalid syntax


This looks valid, but probably fails if using:
from __future__ import print_function
you can probably fix this by adding the parenthesis needed for the function 
invocation:

print('You should add %r to PATH environment variable and reboot.' % 
(os.path.dirname (lib)))

 File "/usr/lib/python2.7/dist-packages/libtiff/optparse_gui.py", line 201 
   print(msg, file=sys.stderr) 
  ^ 
SyntaxError: invalid syntax


This is probably failing because of a missing:
from __future__ import print_function
at the beginning of the file (it needs to be added before any other import).

In python2 print is a statement that you use as print "Hi", in python3 it's a
function that you use as print("Hi"), using the __future__ snippet you can use 
(in python 2.7) print as a function, this is generally a good idea as it eases 
the migration to python3 process.


Happy hacking,
--
"If you have too many special cases, you are doing it wrong." -- Craig Zarouni
Saludos /\/\ /\ >< `/


signature.asc
Description: PGP signature

Re: Salvaging pylibtiff to Debian Python team or removing it from Debian?

[Mathieu Malaterre]

On Fri, Oct 21, 2016 at 9:36 AM, Andreas Tille  wrote:
[...]
> So if anybody in the Python team would like to take over from here on
> I'd be really happy.  Otherwise I consider either orphaning the package
> or ask ftpmaster for removal.
[...]

Orphan bug report was sent in April 2013:

https://bugs.debian.org/705208

2cts

Salvaging pylibtiff to Debian Python team or removing it from Debian?

[Andreas Tille]

Hi,

the former maintainer of pylibtiff inside Debian Med team Mathieu
Malaterre does not care for the package any more and thus I tried
my luck to salvage it.  I have no personal interest in this package
nor does it have any rdepends.  There is no direct connection to
the Debian Med topic but since there are some users according to
popcon[1] it might be worth saving.

Thus I fetched the latest upstream commit from Github and moved
the packaging to Alioth Git[2] which I consider saver for manually
created source tarballs.

I admit that I'm a bit scared by those two ctypes patches which
seem to be ignored by upstream and always need re-adjustment for
new upstream versions.

Anywway, my try to salvage the package ended up when I tried to
install what results from building [2] in a chroot:



  File "/usr/lib/python2.7/dist-packages/libtiff/libtiff_ctypes.py", line 36
print 'You should add %r to PATH environment variable and reboot.' % 
(os.path.dirname (lib))
 ^
SyntaxError: invalid syntax

  File "/usr/lib/python2.7/dist-packages/libtiff/optparse_gui.py", line 201
print(msg, file=sys.stderr)
   ^
SyntaxError: invalid syntax


So if anybody in the Python team would like to take over from here on
I'd be really happy.  Otherwise I consider either orphaning the package
or ask ftpmaster for removal.

Kind regards

  Andreas.

[1] https://qa.debian.org/popcon.php?package=pylibtiff
[2] https://anonscm.debian.org/git/debian-med/pylibtiff.git

-- 
http://fam-tille.de