Source: qtwebengine-opensource-src Version: 5.10.1+dfsg-4 Severity: important
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 qtwebengine-opensource-src build-depends on libvpx-dev, but makes no use of it. libvpx is used with the embedded Chromium, which in the past relied on experimental libvpx headers, but this was change several years ago, just not corrected in the configure check of qtwebengine-opensource-src. Attached patch addresses the configure check. To ensure that system lib is used (failing build instead of silently using embedded code copy), additionally "config_args" in debian/rules should declare "-feature-webengine-system-libvpx". On a related note, several more "-feature-*" should probably be added to ensure avoidance of the various other embedded code copies. - Jonas -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEn+Ppw2aRpp/1PMaELHwxRsGgASEFAls/c4AACgkQLHwxRsGg ASGJlw//ZWsWlrbTAm32BXQLbgqKFHVcAmAKazMLMZ5DD/RXdLDgct5Dx4VWozEd wyFvlq5FhrfqC4zXhsR4gh/IOF3fpP6c9b1TzNEQThAoPTw2tj7Bkb9lA/x+s1nt wEgUPyVV+GzMfqbgiCktX5JHdxhtItNs7uZYf+oFSPkgWCnM6Qg6vbIiURmZaaXl Md7SfLF/F18ImAtRr/4SOBY8hFGqCingKIM/56vqsjaPSN6zTgRvvLDH7C72mg0W 77mfkowRr+lKJQX+yWnAr5MprxWRsYml6gyN0o+N/iul/z7j65sPBzSvMXgFPT4a S8Jcp/FDmRdFU6wks4prl1S6toHwSHjzWhtlbfwccJ+2kQ7vWBW8usPbpv1X7hbI vzhxW5vY0BFRaewbjJPhaPJM5Iva1S0JLIzn3BCv2pDzYOj55R81DJkQPVRbuuZu SyaTwR/p4uC0IVJqVKZtr3W8Hevu5tbpix+OdnRZa/s0HUTEkJjFhVRX8n4dk7Y8 0cX7NDWharRQ+dYlNxNzY9kmaJgVaipLC5U5sR8rElfWIMlWxmXdQXuc6FOziZme 1xzoFNHMQ3z3so7gW7yyo5HcdX8jxMfhLAq2Btc7JNueMoiPXo2Ty9GDWjp64IR4 Za3aW9c/6gw2uABDLzc70bti+lXY0QYWC9PoHQ62W3Q2gLgZgnQ= =+O3g -----END PGP SIGNATURE-----
Description: Fix use system shared libvpx library QTWebengine checks before build if system shared libvpx library works. . Previously the embedded code copy of Chromium depended on experimental parts of libvpx, but that was later discovered to be unneeded and code adapted since September 2016: <https://bugs.chromium.org/p/chromium/issues/detail?id=575651> . Apparently QTwebengine simply missed that change and didn't adapt its checks accordingly. Author: Jonas Smedegaard <d...@jones.dk> Last-Update: 2018-07-06 --- This patch header follows DEP-3: http://dep.debian.net/deps/dep3/ --- a/config.tests/libvpx/libvpx.cpp +++ b/config.tests/libvpx/libvpx.cpp @@ -26,7 +26,7 @@ ** ****************************************************************************/ -#include <vpx/svc_context.h> +#include <vpx/vp8cx.h> #include <vpx/vpx_frame_buffer.h> #include <vpx/vp8dx.h>
