¡Hola Vangelis! El 2014-06-03 a las 14:01 +0300, Vangelis Mouhtsis escribió: > I hope this looks a bit better, review it and correct me > because i choose GPL-2+ instead of GPL-2. > You are right with GPL, thats not specified versions at > all.
> About BSD-3-clause license to be honest i was not aware.
> Files: afaras/src/afarasview.cpp
> afaras/src/afarasview.h
> ksimond/config/ksimondsettings.cpp
...
> sscd/src/sscqueries.h
> Copyright: 2008-2013, Peter Grasch <peter.gra...@bedahr.org>
> License: GPL-2+
> Files: afaras/src/Messages.sh
> build.sh
...
> ssc/Messages.sh
> Copyright: *No copyright*
> License: GPL-2+
> Files: plugins/Commands/ATSPI/atspiconfiguration.cpp
> plugins/Commands/ATSPI/atspiconfiguration.h
...
> simonlib/simonsound/soundoutputbuffer.h
> Copyright: 2009-2011, Grasch Peter <peter.gra...@bedahr.org>
> License: GPL-2+
> Files: plugins/Conditions/ActiveWindow/activewindow.cpp
> plugins/Conditions/ActiveWindow/activewindow.h
...
> simonlib/simonsound/samplegroupitemdelegate.h
> Copyright: 2011, Adam Nash <adam.t.n...@gmail.com>
> License: GPL-2+
Maybe I haven't made myself clear enough, these kind of blocks can be grouped
by license, merging the copyright holders list, so instead of listing every
copyright holder for every file you just list:
Files: *
Copyright: 2008-2013, Peter Grasch <peter.gra...@bedahr.org>
2011, Adam Nash <adam.t.n...@gmail.com>
License: GPL-2+
> Files: plugins/Commands/Keyboard/flowlayout.cpp
> plugins/Commands/Keyboard/flowlayout.h
> Copyright: 2009, Nokia Corporation and/or its subsidiary(-ies)
> License: BSD-3-clause
> Files: simonlib/simonsound/qsemaphore2.cpp
> simonlib/simonsound/qsemaphore2.h
> Copyright: 2011, Nokia Corporation and/or its subsidiary(-ies)
> License: BSD-3-clause
These block are wrong, the files are under a Qt Commercial or LGPL-2.1 or
GPL-3 license
> License: GPL-2+
> This package is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License as published by
> the Free Software Foundation; either version 2 of the License, or
> (at your option) any later version.
> .
> This package is distributed in the hope that it will be useful,
> but WITHOUT ANY WARRANTY; without even the implied warranty of
> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> GNU General Public License for more details.
> .
> You should have received a copy of the GNU General Public License
> along with this program. If not, see <http://www.gnu.org/licenses/>
> .
> On Debian systems, the complete text of the GNU General
> Public License version 2 can be found in "/usr/share/common-licenses/GPL-2+".
The indentation of this block is wrong, the lines in paragraph should start
with a space.
> License: BSD-3-clause
> Redistribution and use in source and binary forms are permitted
> provided that the above copyright notice and this paragraph are
> duplicated in all such forms and that any documentation,
> advertising materials, and other materials related to such
> distribution and use acknowledge that the software was developed
> by the organization. The name of the
> organization may not be used to endorse or promote products derived
> from this software without specific prior written permission.
> THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR
> IMPLIED WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED
> WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.
idem
Also, you are still missing the blocks that correspond to the .cmake files.
--
"Any sufficiently advanced technology is indistinguishable from magic."
-- Clarke's Third Law
Saludos /\/\ /\ >< `/
signature.asc
Description: Digital signature
