Processed: your mail
Processing commands for cont...@bugs.debian.org: > block 982844 by 983298 Bug #982844 [ocserv] two regressions in ocserv 1.1.2 regarding udp handling 982844 was not blocked by any bugs. 982844 was not blocking any bugs. Added blocking bug(s) of 982844: 983298 > thanks Stopping processing here. Please contact me if you need assistance. -- 982844: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=982844 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#983298: unblock: ocserv/1.1.2-2
Package: release.debian.org
User: release.debian@packages.debian.org
Usertags: unblock
Severity: normal
Dear release team,
This is a pre-approval request that please unblock package ocserv/1.1.2-2, which
is a version with cherry picked upstream bug fixes.
unblock ocserv/1.1.2-2
Regards,
Aron
diff -Nru ocserv-1.1.2/debian/changelog ocserv-1.1.2/debian/changelog
--- ocserv-1.1.2/debian/changelog 2020-12-17 18:38:57.0 +0800
+++ ocserv-1.1.2/debian/changelog 2021-02-22 11:37:07.0 +0800
@@ -1,3 +1,9 @@
+ocserv (1.1.2-2) unstable; urgency=medium
+
+ * d/patches: cherry-pick upstream post 1.1.2 bug fixes
+
+ -- Aron Xu Mon, 22 Feb 2021 11:37:07 +0800
+
ocserv (1.1.2-1) unstable; urgency=medium
* New upstream version 1.1.2
diff -Nru
ocserv-1.1.2/debian/patches/0009-update_auth_time_stats-cast-operations-to-avoid-over.patch
ocserv-1.1.2/debian/patches/0009-update_auth_time_stats-cast-operations-to-avoid-over.patch
---
ocserv-1.1.2/debian/patches/0009-update_auth_time_stats-cast-operations-to-avoid-over.patch
1970-01-01 08:00:00.0 +0800
+++
ocserv-1.1.2/debian/patches/0009-update_auth_time_stats-cast-operations-to-avoid-over.patch
2021-02-22 11:33:03.0 +0800
@@ -0,0 +1,27 @@
+From e035221030f8fdfbb38483889631916fef9d9798 Mon Sep 17 00:00:00 2001
+From: Nikos Mavrogiannopoulos
+Date: Wed, 9 Dec 2020 15:05:24 +0100
+Subject: [PATCH 09/36] update_auth_time_stats: cast operations to avoid
+ overflows
+
+Signed-off-by: Nikos Mavrogiannopoulos
+---
+ src/sec-mod-auth.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/sec-mod-auth.c b/src/sec-mod-auth.c
+index c769643c..b4b2f3fd 100644
+--- a/src/sec-mod-auth.c
b/src/sec-mod-auth.c
+@@ -131,7 +131,7 @@ static void update_auth_time_stats(sec_mod_st * sec,
time_t secs)
+
+ if (secs > sec->max_auth_time)
+ sec->max_auth_time = secs;
+- sec->avg_auth_time =
(sec->avg_auth_time*(sec->total_authentications-1)+secs) /
sec->total_authentications;
++ sec->avg_auth_time =
((uint64_t)sec->avg_auth_time*((uint64_t)(sec->total_authentications-1))+secs)
/ (uint64_t)sec->total_authentications;
+ }
+
+ static
+--
+2.20.1
+
diff -Nru
ocserv-1.1.2/debian/patches/0020-ocserv-worker-renamed-loop-to-worker_loop.patch
ocserv-1.1.2/debian/patches/0020-ocserv-worker-renamed-loop-to-worker_loop.patch
---
ocserv-1.1.2/debian/patches/0020-ocserv-worker-renamed-loop-to-worker_loop.patch
1970-01-01 08:00:00.0 +0800
+++
ocserv-1.1.2/debian/patches/0020-ocserv-worker-renamed-loop-to-worker_loop.patch
2021-02-22 11:35:22.0 +0800
@@ -0,0 +1,131 @@
+From 47c6638286a694b4d278e01b278f64f9368b3e1a Mon Sep 17 00:00:00 2001
+From: Nikos Mavrogiannopoulos
+Date: Sat, 12 Dec 2020 22:41:50 +0100
+Subject: [PATCH 20/36] ocserv-worker: renamed loop to worker_loop
+
+This avoids warnings and static analyzers complains about
+the libev functions hiding the global 'loop' variable
+
+Signed-off-by: Nikos Mavrogiannopoulos
+---
+ src/worker-vpn.c | 34 +-
+ 1 file changed, 17 insertions(+), 17 deletions(-)
+
+Index: ocserv/src/worker-vpn.c
+===
+--- ocserv.orig/src/worker-vpn.c
ocserv/src/worker-vpn.c
+@@ -95,7 +95,7 @@ struct worker_st *global_ws = NULL;
+ static int terminate = 0;
+ static int terminate_reason = REASON_SERVER_DISCONNECT;
+
+-static struct ev_loop *loop = NULL;
++static struct ev_loop *worker_loop = NULL;
+ ev_io command_watcher;
+ ev_io tls_watcher;
+ ev_io tun_watcher;
+@@ -433,8 +433,8 @@ static int setup_dtls_connection(struct
+ dtls->dtls_session = session;
+ ev_init(>io, dtls_watcher_cb);
+ ev_io_set(>io, dtls->dtls_tptr.fd, EV_READ);
+- ev_io_start(loop, >io);
+- ev_invoke(loop, >io, EV_READ);
++ ev_io_start(worker_loop, >io);
++ ev_invoke(worker_loop, >io, EV_READ);
+
+ return 0;
+ fail:
+@@ -2609,7 +2609,7 @@ static int test_for_tcp_health_probe(str
+
+ static void syserr_cb (const char *msg)
+ {
+- struct worker_st * ws = ev_userdata(loop);
++ struct worker_st * ws = ev_userdata(worker_loop);
+ int err = errno;
+
+ oclog(ws, LOG_ERR, "libev fatal error: %s / %s", msg, strerror(err));
+@@ -2637,7 +2637,7 @@ static void cstp_send_terminate(struct w
+
+ static void command_watcher_cb (EV_P_ ev_io *w, int revents)
+ {
+- struct worker_st *ws = ev_userdata(loop);
++ struct worker_st *ws = ev_userdata(worker_loop);
+
+ int ret = handle_commands_from_main(ws);
+ if (ret == ERR_NO_CMD_FD) {
+@@ -2723,7 +2723,7 @@ static void invoke_dtls_if_needed(struct
+ if ((dtls->udp_state > UP_WAIT_FD) &&
+ (dtls->dtls_session != NULL) &&
+ (gnutls_record_check_pending(dtls->dtls_session))) {
+- ev_invoke(loop, >io, EV_READ);
++ ev_invoke(worker_loop, >io, EV_READ);
+ }
+ }
+
+@@ -2757,9
Bug#983233: New autopkgtest shouldn’t trigger a regression
Le 21/02/2021 à 16:02, Paul Gevers a écrit : Control: tags -1 moreinfo Hi David, On 21-02-2021 12:53, David Prévot wrote: I recently added an autopkgtest to a package, and the autopkgtest failed on all suites. I’m surprised to see that failure considered as a regression (#983211) […] We realize that `regression` doesn't quite cover how we use it […] we consider failing tests in testing RC [1]. Hence, allowing a package with a failing test to migrate to testing would immediately make it RC buggy, hence we block it. `regression` doesn't fully cover it, we read it as "there wasn't an RC bug in testing, and now there will be, hence regression" but it's a bit stretched. Do you have a suggestion to use there instead (a word, not a sentence)? Maybe “failing test” since you used it twice to describe the actual issue (but that’s two words) or even simply (test) “failure”? The current policy makes it almost worth to remove autopkgtest in order to avoid what you call “regression”. Yet, such removal would check all boxes of what is called “regression” according to some some online [dict]ionary: “a return to a previous and less advanced or worse state, condition, or way of behaving”. dict: https://dictionary.cambridge.org/dictionary/english/regression Regards David
Processed: Re: Bug#983233: New autopkgtest shouldn’t trigger a regression
Processing control commands: > tags -1 moreinfo Bug #983233 [release.debian.org] New autopkgtest shouldn’t trigger a regression Added tag(s) moreinfo. -- 983233: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=983233 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#983233: New autopkgtest shouldn’t trigger a regression
Control: tags -1 moreinfo Hi David, On 21-02-2021 12:53, David Prévot wrote: > I recently added an autopkgtest to a package, and the autopkgtest failed > on all suites. I’m surprised to see that failure considered as a > regression (#983211), so I believe there is a mistake somewhere (maybe > that’s just me not getting what “regression” means, if so that might > deserve being documented). We realize that `regression` doesn't quite cover how we use it in Debian, but this part was taken over from Ubuntu. In Debian, we consider failing tests in testing RC [1]. Hence, allowing a package with a failing test to migrate to testing would immediately make it RC buggy, hence we block it. `regression` doesn't fully cover it, we read it as "there wasn't an RC bug in testing, and now there will be, hence regression" but it's a bit stretched. Do you have a suggestion to use there instead (a word, not a sentence)? Paul [1] https://release.debian.org/bullseye/rc_policy.txt OpenPGP_signature Description: OpenPGP digital signature
Processed: Re: Bug#983233: New autopkgtest shouldn’t trigger a regression
Processing control commands: > reassign -1 release.debian.org Bug #983233 [debci] New autopkgtest shouldn’t trigger a regression Bug reassigned from package 'debci' to 'release.debian.org'. Ignoring request to alter found versions of bug #983233 to the same values previously set Ignoring request to alter fixed versions of bug #983233 to the same values previously set -- 983233: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=983233 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#983233: New autopkgtest shouldn’t trigger a regression
Package: debci Severity: normal X-Debbugs-Cc: Debian Release Team Hi, I recently added an autopkgtest to a package, and the autopkgtest failed on all suites. I’m surprised to see that failure considered as a regression (#983211), so I believe there is a mistake somewhere (maybe that’s just me not getting what “regression” means, if so that might deserve being documented). Regards David signature.asc Description: PGP signature
Bug#983174: marked as done (nmu: r-cran-alakazam_1.1.0-1)
Your message dated Sun, 21 Feb 2021 11:08:32 +0100 with message-id and subject line Re: Bug#983174: nmu: r-cran-alakazam_1.1.0-1 has caused the Debian Bug report #983174, regarding nmu: r-cran-alakazam_1.1.0-1 to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 983174: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=983174 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems --- Begin Message --- Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: binnmu nmu r-cran-alakazam_1.1.0-1 . amd64 . unstable . -m "rebuild on buildd" --- End Message --- --- Begin Message --- On 2021-02-20 16:45:16 +0200, Adrian Bunk wrote: > Package: release.debian.org > Severity: normal > User: release.debian@packages.debian.org > Usertags: binnmu > > nmu r-cran-alakazam_1.1.0-1 . amd64 . unstable . -m "rebuild on buildd" Scheduled Cheers -- Sebastian Ramacher signature.asc Description: PGP signature --- End Message ---
