Bug#1032237: bullseye-pu: zfs-linux/2.0.3-9+deb11u1

[Aron Xu]

Package: release.debian.org
Severity: normal
Tags: bullseye
User: release.debian@packages.debian.org
Usertags: pu
X-Debbugs-CC: pkg-zfsonlinux-de...@alioth-lists.debian.net

Dear release team,

I would like to apply a few patches to address some stability issues in the
zfs-linux package in bullseye. All the patches are cherry-picked from upstream

2.0.x and 2.1.x stable branches.

* 0002-Initialize-ZIL-buffers.patch
 zio_crypt.c |1 +
 1 file changed, 1 insertion(+)
* 0003-Fix-crash-in-zio_done-error-reporting.patch
 zio.c |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
* 0004-Fix-AVX512BW-Fletcher-code-on-AVX512-but-not-BW-mach.patch
 zfs_fletcher_avx512.c |8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)
* 0005-Fix-zfs_get_data-access-to-files-with-wrong-generati.patch
 cmd/ztest/ztest.c  |4 ++--
 include/sys/zil.h  |3 ++-
 include/sys/zvol_impl.h|4 ++--
 module/os/linux/zfs/zfs_vnops_os.c |   14 +-
 module/zfs/zfs_log.c   |5 +
 module/zfs/zil.c   |3 ++-
 module/zfs/zvol.c  |3 ++-
 7 files changed, 28 insertions(+), 8 deletions(-)
* 0006-Linux-always-check-or-verify-return-of-igrab.patch
 include/os/linux/zfs/sys/zfs_znode_impl.h |8 +++-
 module/os/linux/zfs/zfs_ctldir.c  |3 ++-
 module/os/linux/zfs/zfs_vfsops.c  |6 +-
 module/os/linux/zfs/zpl_inode.c   |3 ++-
 4 files changed, 16 insertions(+), 4 deletions(-)
* 0007-Avoid-deadlock-when-removing-L2ARC-devices-under-I-O.patch
 arc.c |   17 ++---
 zio.c |3 ---
 2 files changed, 6 insertions(+), 14 deletions(-)
* 0008-file-reference-counts-can-get-corrupted.patch
 include/sys/fm/util.h   |5 +++--
 include/sys/zfs_file.h  |6 --
 include/sys/zfs_ioctl.h |2 +-
 include/sys/zfs_onexit.h|4 ++--
 lib/libzpool/kernel.c   |   20 +---
 module/os/freebsd/zfs/zfs_file_os.c |   19 ++-
 module/os/linux/zfs/zfs_file_os.c   |   28 +++-
 module/zfs/fm.c |   20 
 module/zfs/zfs_ioctl.c  |   71 
++-
 module/zfs/zfs_onexit.c |   23 +--
 10 files changed, 91 insertions(+), 107 deletions(-)
* 0009-libshare-nfs-don-t-leak-nfs_lock_fd-when-lock-fails.patch
 freebsd/nfs.c |   13 +
 linux/nfs.c   |   13 +
 2 files changed, 18 insertions(+), 8 deletions(-)

Regards,
Aron
diff -Nru zfs-linux-2.0.3/debian/changelog zfs-linux-2.0.3/debian/changelog
--- zfs-linux-2.0.3/debian/changelog2021-07-01 13:44:20.0 +0800
+++ zfs-linux-2.0.3/debian/changelog2023-03-02 00:15:02.0 +0800
@@ -1,3 +1,9 @@
+zfs-linux (2.0.3-9+deb11u1) bullseye; urgency=medium
+
+  * cherry-pick upstream fixes for stability issues
+
+ -- Aron Xu   Thu, 02 Mar 2023 00:15:02 +0800
+
 zfs-linux (2.0.3-9) unstable; urgency=medium
 
   * Cherry-pick "Remove iov_iter_advance() for iter_write" (Closes: #989373)
diff -Nru zfs-linux-2.0.3/debian/patches/0002-Initialize-ZIL-buffers.patch 
zfs-linux-2.0.3/debian/patches/0002-Initialize-ZIL-buffers.patch
--- zfs-linux-2.0.3/debian/patches/0002-Initialize-ZIL-buffers.patch
1970-01-01 08:00:00.0 +0800
+++ zfs-linux-2.0.3/debian/patches/0002-Initialize-ZIL-buffers.patch
2023-02-27 15:29:01.0 +0800
@@ -0,0 +1,31 @@
+From e219935f10f6f604a3dafb4727715c3741480fd4 Mon Sep 17 00:00:00 2001
+From: Brian Behlendorf 
+Date: Fri, 5 Mar 2021 14:45:13 -0800
+Subject: [PATCH] Initialize ZIL buffers
+
+When populating a ZIL destination buffer ensure it is always
+zeroed before its contents are constructed.
+
+Reviewed-by: Matthew Ahrens 
+Reviewed-by: Tom Caputi 
+Signed-off-by: Brian Behlendorf 
+Closes #11687
+---
+ module/os/linux/zfs/zio_crypt.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/module/os/linux/zfs/zio_crypt.c b/module/os/linux/zfs/zio_crypt.c
+index 96dabe55a..e2abc0ae2 100644
+--- a/module/os/linux/zfs/zio_crypt.c
 b/module/os/linux/zfs/zio_crypt.c
+@@ -1399,6 +1399,7 @@ zio_crypt_init_uios_zil(boolean_t encrypt, uint8_t 
*plainbuf,
+   nr_src = 1;
+   nr_dst = 0;
+   }
++  bzero(dst, datalen);
+ 
+   /* find the start and end record of the log block */
+   zilc = (zil_chain_t *)src;
+-- 
+2.30.2
+
diff -Nru 
zfs-linux-2.0.3/debian/patches/0003-Fix-crash-in-zio_done-error-reporting.patch 
zfs-linux-2.0.3/debian/patches/0003-Fix-crash-in-zio_done-error-reporting.patch
--- 
zfs-linux-2.0.3/debian/patches/0003-Fix-crash-in-zio_done-error-reporting.patch 
1970-01-01 08:00:00.0 +0800
+++ 
zfs-linux-2.0.3/debian/patches/0003-Fix-crash-in-zio_done-error-reporting.patch 
2023-02-27 15:33:33.0 +0800
@@ -0,0 +1,49 @@
+From 

NEW changes in stable-new

[Debian FTP Masters]

Processing changes file: libvirt_7.0.0-3+deb11u2_all-buildd.changes
  ACCEPT
Processing changes file: libvirt_7.0.0-3+deb11u2_amd64-buildd.changes
  ACCEPT
Processing changes file: libvirt_7.0.0-3+deb11u2_arm64-buildd.changes
  ACCEPT
Processing changes file: libvirt_7.0.0-3+deb11u2_armel-buildd.changes
  ACCEPT
Processing changes file: libvirt_7.0.0-3+deb11u2_armhf-buildd.changes
  ACCEPT
Processing changes file: libvirt_7.0.0-3+deb11u2_i386-buildd.changes
  ACCEPT
Processing changes file: libvirt_7.0.0-3+deb11u2_mips64el-buildd.changes
  ACCEPT
Processing changes file: libvirt_7.0.0-3+deb11u2_mipsel-buildd.changes
  ACCEPT
Processing changes file: libvirt_7.0.0-3+deb11u2_ppc64el-buildd.changes
  ACCEPT
Processing changes file: libvirt_7.0.0-3+deb11u2_s390x-buildd.changes
  ACCEPT

NEW changes in stable-new

[Debian FTP Masters]

Processing changes file: libvirt_7.0.0-3+deb11u2_source.changes
  ACCEPT

Bug#1030709: libvirt 7.0.0-3+deb11u2 flagged for acceptance

[Adam D Barratt]

package release.debian.org
tags 1030709 = bullseye pending
thanks

Hi,

The upload referenced by this bug report has been flagged for acceptance into 
the proposed-updates queue for Debian bullseye.

Thanks for your contribution!

Upload details
==

Package: libvirt
Version: 7.0.0-3+deb11u2

Explanation: fix test failures when combined with newer Xen versions

Processed: libvirt 7.0.0-3+deb11u2 flagged for acceptance

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> package release.debian.org
Limiting to bugs with field 'package' containing at least one of 
'release.debian.org'
Limit currently set to 'package':'release.debian.org'

> tags 1030709 = bullseye pending
Bug #1030709 [release.debian.org] bullseye-pu: package libvirt/7.0.0-3+deb11u2
Added tag(s) pending; removed tag(s) confirmed.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
1030709: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1030709
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#1031927: Handling the libsgutils2-2 #994758 bookworm-ignore

[Jonathan McDowell]

On Wed, Mar 01, 2023 at 08:07:09AM +, Jonathan McDowell wrote:
> On Mon, Feb 27, 2023 at 09:11:46PM +0100, Paul Gevers wrote:
> > On 25-02-2023 14:30, Adrian Bunk wrote:
> > > With the bookworm-ignore for #994758,
> > 
> > I'll admit that I misjudged that bug; with this message I'll clear the
> > bookworm-ignore tag.
> > 
> > > bullseye and bookworm
> > > will ship libsgutils2-2 packages with different so-name.
> > 
> > Although the transition freeze has started long time ago, it seems that
> > doing a proper transition is the best way to fix this issue. If somebody is
> > up to the task to prepare the upload, we can ask ftp-master to process the
> > upload swiftly. (Please upload to experimental to avoid the ftp-master from
> > rejecting the package immediately and to enable reviewing if that's not done
> > before the upload.)
> 
> This does not look overly hard and I have some familiarity with the
> package having uploaded in the past. If no one else is already looking
> at it I'll aim to have a version with a libsgutils2-1.46 library package
> uploaded to experimental by the end of today.

Now sitting in NEW for experimental:

https://ftp-master.debian.org/new/sg3-utils_1.46-2.html

I have confirmed:

 * It will not co-exist with the libsgutils2-2 package in bookworm
   (thanks to the versioned breaks/replaces)
 * It will co-exist with the libsgutils2-2 package in bullseye (which is
   1.45-1 and has no overlapping files)
 * Operation of the sg3-utils package with this new build

It turns out I do not have access to the salsa git repo at present, but
I've requested it and will push the changes there when it is granted.

J.

-- 
No one told you when to run, you missed the starting gun.
This .sig brought to you by the letter L and the number 39
Product of the Republic of HuggieTag


signature.asc
Description: PGP signature

Bug#1032185: libgusb 0.4.5 uploaded during freeze, is it intended for Debian 12 'bookworm'?

[Simon McVittie]

Source: libgusb
Version: 0.4.5-1
Severity: important
X-Debbugs-Cc: debian-release@lists.debian.org

I notice that libgusb 0.4.5-1 was uploaded a few days ago. Is this package
intended to go into Debian 12 'bookworm'? It seems like a larger diff than
I would have expected at this stage in the release.

Debian has been in soft freeze since 2023-02-12. More information about the
freeze policy: .
.

If this version is intended for bookworm, RC bug #1032183 will need fixing.

If this version is not intended for bookworm, it should have been uploaded
to experimental; please talk to your co-maintainer about the best way to
revert to 0.3.x in unstable if necessary.

Thanks,
smcv

Bug#1031927: Handling the libsgutils2-2 #994758 bookworm-ignore

[Jonathan McDowell]

On Mon, Feb 27, 2023 at 09:11:46PM +0100, Paul Gevers wrote:
> Control: tags 994758 - bookworm-ignore
> 
> Hi Adrian,
> 
> Thanks for caring.
> 
> On 25-02-2023 14:30, Adrian Bunk wrote:
> > With the bookworm-ignore for #994758,
> 
> I'll admit that I misjudged that bug; with this message I'll clear the
> bookworm-ignore tag.
> 
> > bullseye and bookworm
> > will ship libsgutils2-2 packages with different so-name.
> 
> Although the transition freeze has started long time ago, it seems that
> doing a proper transition is the best way to fix this issue. If somebody is
> up to the task to prepare the upload, we can ask ftp-master to process the
> upload swiftly. (Please upload to experimental to avoid the ftp-master from
> rejecting the package immediately and to enable reviewing if that's not done
> before the upload.)

This does not look overly hard and I have some familiarity with the
package having uploaded in the past. If no one else is already looking
at it I'll aim to have a version with a libsgutils2-1.46 library package
uploaded to experimental by the end of today.

J.

-- 
/-\ |   If at first you don't succeed,
|@/  Debian GNU/Linux Developer |   create an "NT" version.
\-  |


signature.asc
Description: PGP signature