Bug#1038344: bookworm-pu: package request-tracker5/5.0.3+dfsg-2+deb12u1
On Mon, 2023-06-26 at 07:01 +0100, Jonathan Wiltshire wrote:
> On Mon, Jun 26, 2023 at 04:42:27PM +1200, Andrew Ruthven wrote:
> > Changelog updated as requested, and uploaded to bookworm.
>
> You need a tilde in the version, not a plus ("lower than"). I'll reject
> the
> upload, you can upload a fixed version whenever you like.
Doh. Fixed.
Cheers,
Andrew
--
Andrew Ruthven, Wellington, New Zealand
and...@etc.gen.nz |
Catalyst Cloud: | This space intentionally left blank
https://catalystcloud.nz |
Bug#1038344: bookworm-pu: package request-tracker5/5.0.3+dfsg-2+deb12u1
On Sun, 2023-06-25 at 17:43 +0100, Jonathan Wiltshire wrote: > Control: tag -1 confirmed > > I just happened to look at this; otherwise as it was still tagged > "moreinfo" it would probably have been waiting for attention for quite a > while. Oops, I did wonder if I should change the tag. > As 5.0.3+dfsg-3 in unstable is limited to these changes anyway, you can > backport it directly and the version history makes things a bit clearer > for > some infrastructure. Just add a changelog entry on top of the unstable > version, "Backport to bookworm" or something, version 5.0.3+dfsg- > 3~deb12u1, > target bookworm. Don't remove the changelog for 5.0.3+dfsg-3. > > Example: > https://release.debian.org/proposed-updates/bookworm_diffs/onionshare_2.6-5~deb12u1.debdiff > > Other than that, please go ahead. Awesome, thank you. I figured it'd make life easier to upload only these changes to unstable initially. Changelog updated as requested, and uploaded to bookworm. Cheers, Andrew -- Andrew Ruthven, Wellington, New Zealand and...@etc.gen.nz | Catalyst Cloud: | This space intentionally left blank https://catalystcloud.nz |
Bug#1038344: bookworm-pu: package request-tracker5/5.0.3+dfsg-2+deb12u1
[Resent Cc'ing in the bug, Evolution dropped it first time round, sigh] On Sat, 2023-06-17 at 13:05 +0100, Adam D. Barratt wrote: > You appear to have attached a binary debdiff. Please provide a _source_ > debdiff for checking. My apologies, first time I've done this. I had generated it as well. Please find the source debdiff attached. The patches are managed using git-dpm which is why the git commit ID has changed for all of them. The patch in question is debianize_version.diff . Cheers, Andrew -- Andrew Ruthven, Wellington, New Zealand and...@etc.gen.nz | Catalyst Cloud: | This space intentionally left blank https://catalystcloud.nz | diff -Nru request-tracker5-5.0.3+dfsg/debian/changelog request-tracker5-5.0.3+dfsg/debian/changelog --- request-tracker5-5.0.3+dfsg/debian/changelog 2022-07-22 01:28:17.0 +1200 +++ request-tracker5-5.0.3+dfsg/debian/changelog 2023-06-11 14:19:13.0 +1200 @@ -1,3 +1,11 @@ +request-tracker5 (5.0.3+dfsg-2+deb12u1) bookworm; urgency=medium + + * Strip Debian version suffix from generated hyperlinks to upstream docs +(Closes: 1033304). + * Fix the changelog date entry for the 5.0.3+dfsg-2 release. + + -- Andrew Ruthven Sun, 11 Jun 2023 14:19:13 +1200 + request-tracker5 (5.0.3+dfsg-2) unstable; urgency=medium * Add more fields to d/upstream/metadata @@ -13,7 +21,7 @@ * Remove dependency on lsb-base as it is an obsolete package. * Refresh d/copyright - -- Andrew Ruthven Fri, 22 Jul 2022 01:28:17 +1200 + -- Andrew Ruthven Sat, 04 Feb 2023 12:30:17 +1300 request-tracker5 (5.0.3+dfsg-1.1) unstable; urgency=medium diff -Nru request-tracker5-5.0.3+dfsg/debian/.git-dpm request-tracker5-5.0.3+dfsg/debian/.git-dpm --- request-tracker5-5.0.3+dfsg/debian/.git-dpm 2022-07-22 01:28:17.0 +1200 +++ request-tracker5-5.0.3+dfsg/debian/.git-dpm 2023-06-05 20:13:11.0 +1200 @@ -1,6 +1,6 @@ # see git-dpm(1) from git-dpm package -c18433eb098f64a7c1d81502e7bcc689a2df0943 -c18433eb098f64a7c1d81502e7bcc689a2df0943 +28481171ee3345c8bed6efb9d5a46cfce1547fc0 +28481171ee3345c8bed6efb9d5a46cfce1547fc0 52cb0ca22325e7a067f0a3411ffb55ef03d47aa4 52cb0ca22325e7a067f0a3411ffb55ef03d47aa4 request-tracker5_5.0.3+dfsg.orig.tar.gz diff -Nru request-tracker5-5.0.3+dfsg/debian/patches/debianize_charts.diff request-tracker5-5.0.3+dfsg/debian/patches/debianize_charts.diff --- request-tracker5-5.0.3+dfsg/debian/patches/debianize_charts.diff 2022-07-22 01:28:17.0 +1200 +++ request-tracker5-5.0.3+dfsg/debian/patches/debianize_charts.diff 2023-06-05 20:13:11.0 +1200 @@ -1,4 +1,4 @@ -From 90ca199172517271447e571d777964324343ef1a Mon Sep 17 00:00:00 2001 +From e4a897eeca21986a0fe788ad15edb6f500c99772 Mon Sep 17 00:00:00 2001 From: Andrew Ruthven Date: Thu, 9 Jul 2020 23:03:35 +1200 Subject: On Debian there is no need to install the GD modules if GD is diff -Nru request-tracker5-5.0.3+dfsg/debian/patches/debianize_commands.diff request-tracker5-5.0.3+dfsg/debian/patches/debianize_commands.diff --- request-tracker5-5.0.3+dfsg/debian/patches/debianize_commands.diff 2022-07-22 01:28:17.0 +1200 +++ request-tracker5-5.0.3+dfsg/debian/patches/debianize_commands.diff 2023-06-05 20:13:11.0 +1200 @@ -1,4 +1,4 @@ -From 13f2358416863200df51361f2643e7ec35680748 Mon Sep 17 00:00:00 2001 +From 2b5ef414f9d88dc4321d602dda5556c6bd04eb90 Mon Sep 17 00:00:00 2001 From: Andrew Ruthven Date: Thu, 9 Jul 2020 22:53:09 +1200 Subject: Use Debian location of commands and data diff -Nru request-tracker5-5.0.3+dfsg/debian/patches/debianize_extensions.diff request-tracker5-5.0.3+dfsg/debian/patches/debianize_extensions.diff --- request-tracker5-5.0.3+dfsg/debian/patches/debianize_extensions.diff 2022-07-22 01:28:17.0 +1200 +++ request-tracker5-5.0.3+dfsg/debian/patches/debianize_extensions.diff 2023-06-05 20:13:11.0 +1200 @@ -1,4 +1,4 @@ -From 4ea4ef63b501e9c635c0d18340f15107427f59be Mon Sep 17 00:00:00 2001 +From 83787c6f7b0c8f3683bc06c756575e444e2fc808 Mon Sep 17 00:00:00 2001 From: Andrew Ruthven Date: Thu, 9 Jul 2020 22:33:55 +1200 Subject: Point to Debian locaton of mason_data. diff -Nru request-tracker5-5.0.3+dfsg/debian/patches/debianize_version.diff request-tracker5-5.0.3+dfsg/debian/patches/debianize_version.diff --- request-tracker5-5.0.3+dfsg/debian/patches/debianize_version.diff 2022-07-22 01:28:17.0 +1200 +++ request-tracker5-5.0.3+dfsg/debian/patches/debianize_version.diff 2023-06-05 20:13:11.0 +1200 @@ -1,4 +1,4 @@ -From 55312fbba42fbedd49061601741d5960061d5703 Mon Sep 17 00:00:00 2001 +From e00d7b16bc8b70db0125349ead6841adfa1d4c32 Mon Sep 17 00:00:00 2001 From: Dominic Hargreaves Date: Thu, 31 Dec 2015 12:17:56 + Subject: Extract the correct (Debian) version number in configure.ac @@ -8,9 +8,10 @@ Patch-Name: debianize_version.diff --- - configure.ac | 8 - share/html/Elements/Footer | 2 +- - 2 files changed, 5 insertions(+), 5 deletions(-) + config
Bug#1038344: bookworm-pu: package request-tracker5/5.0.3+dfsg-2+deb12u1
Package: release.debian.org Severity: normal Tags: bookworm User: release.debian@packages.debian.org Usertags: pu X-Debbugs-Cc: request-track...@packages.debian.org Control: affects -1 + src:request-tracker5 [ Reason ] The version in bookworm includes a bug where the suffix we append to the upstream version is included in a generated URL for accessing documentation about configuration settings presented in the UI. Bug report: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1033304 We weren't able to include this in the bookworm releases as our packages suffered a FTBFS issue due to a rhino and closure-compiler issue, as discussed here: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1036159 By the time the issues with closure-compiler and rhino were resolved it was too late to get a fixed version of request-tracker5 into bookworm. I have also included a minor fix to the date string in d/changelog for 5.0.3+dfsg-2 as I failed to update the date when I uploaded that version, and then due to the FTBFS issue I wasn't able to resolve it when I spotted it. Version 5.0.3+dfsg-3 in unstable only includes the fixes which are proposed for bookworm. [ Impact ] When an RT administrator attempts to look up the documentation for a configuration setting, they'll get a 404. [ Tests ] I have installed the proposed packages on my personal RT installation running bookworm, and verified that the generated links are correct and work. [ Risks ] Low risk. [ Checklist ] [x] *all* changes are documented in the d/changelog [x] I reviewed all changes and I approve them [x] attach debdiff against the package in (old)stable [x] the issue is verified as fixed in unstable [ Changes ] d/patch/debianize_version.diff now modifies share/html/Admin/Tools/Config/Elements/Option to strip everything after and including '+dfsg-' from the version string. [ Other info ] I acknowledge that it would be preferable to link to documentation contained within the running system, but our packages don't currently configure the generated documentation to be accessible via the web. File lists identical (after any substitutions)
Bug#1031587: [request-tracker-maintainers] Bug#1031587: Handling of the request-tracker4 -> request-tracker5 transition in bookworm
Hi folks, > Sorry for the long delay. Myself and, I think, Andrew have been short > on time. Yes, my apologies, I've been very busy the last couple of months. > The transition is basically ready to go, but I've been rethinking the > need > to drop request-tracker4, given it will all be quite tight. It turns > out that > request-tracker4 is still supported upstream > (https://bestpractical.com/release-policy) > and there's no specific EoL set. When we first started the plan to > deprecate request-tracker4 in Debian, I think we were assuming > otherwise. > The package is in good shape and I believe otherwise ready to be > released. > > If Andrew is in agreement, I therefore think we should let request- > tracker4 > be released with the next release. We can reconsider whether to drop > it from > the release + 1 at a more leisurely pace. The work we've done to date > will not > be wasted effort. Yes, I'm okay with keeping request-tracker4 in Bookworm, as Dominic says, the package is in good shape. Cheers, Andrew -- Andrew Ruthven, Wellington, New Zealand and...@etc.gen.nz | Catalyst Cloud: | This space intentionally left blank https://catalystcloud.nz |
Bug#1031587: [request-tracker-maintainers] Bug#1031587: Handling of the request-tracker4 -> request-tracker5 transition in bookworm
On Sun, 2023-02-19 at 00:12 +0200, Adrian Bunk wrote: > https://release.debian.org/testing/freeze_policy.html#soft > > ... > Dropping or adding binary packages to a source package, moving > binaries between source packages or renaming source or binary > packages is no longer allowed. Packages with these changes will not > be allowed to migrate to testing. These changes are also no longer > appropriate in unstable. > ... > > > The problem is that opening of #1030749 is de facto > a request-tracker4 -> request-tracker5 transition that > happened 4 weeks after the deadline for transitions. The soft freeze date snuck up on us. :( Given the minimal impact to packages, is this a transition? If you look at the release and EOL dates on https://bestpractical.com/release-policy/ you'll see that Best Practical typically end of life releases 3-4 years after the next release. 5.0 was released in 2020, therefore it is worth considering that 4.4 will most likely be EOL in 2023 or 2024. For practical support reasons, we're concerned about releasing Bookworm with 4.4. > There are two options for resolving this: > 1. Treat #1030749 as a forbidden transition and ship both versions > of request-tracker in bookworm, or > 2. grant reverse dependencies an exception from the soft freeze > rules for the request-tracker4 -> request-tracker5 transition. > > > For option 2 I looked at the 9 reverse dependencies of request- > tracker4 > in the autoremoval list: > > RT extension installer that has to stop depending on > both versions: > - libmodule-install-rtx-perl This will need to updated after all the below packages are updated. > No package remame required, has to upgrade to the upstream version > that supports request-tracker5: > - librt-extension-commandbymail-perl We've had updated packaging ready to go for a while, but it looks like we'd forgotten to upload it. Current proposed package does introduce new packages, but we could drop that and re-use the existing package name. > Ships packages for both versions and has to drop the > request-tracker4 package: > - rt-extension-assets-import-csv > > request-tracker4 -> request-tracker5 transition prepared > in experimental: > - rt-extension-customfieldsonupdate > - rt-extension-calendar > - rt-extension-jsgantt > - rt-extension-nagios > - rt-extension-smsnotify Some of these will need to be updated, but that is relatively straightforward. > Update to latest upstream version and package rename required: > - rt-extension-repeatticket Again, we have updated packaging ready, again includes new package names. But the splitting into new packages can be dropped. Cheers, Andrew -- Andrew Ruthven, Wellington, New Zealand and...@etc.gen.nz | Catalyst Cloud: | This space intentionally left blank https://catalystcloud.nz |
Re: Don't ship gnupg1 with bullseye
Hey, On Tue, 2021-02-02 at 08:33 +, Dominic Hargreaves wrote: > Checking reverse dependencies... > # Broken Depends: > libgnupg-perl: libgnupg-perl libgnupg-perl only supports GnuPG v1.4 and given it hasn't had a release since 2012 I doubt it will gain support for v2.2. > # Broken Build-Depends: > libgnupg-interface-perl: gnupg1 > > The dependencies in libgnupg-interface-perl and libpgp-sign-perl look > straightforward to remove. The build dependency in libgnupg-interface-perl is easy enough to remove. I've pushed a branch to Salsa called "drop-gnupg1" which does this along with dropping the tests I added for GnuPG v1 compatibility. Cheers, Andrew -- Andrew Ruthven, Wellington, New Zealand and...@etc.gen.nz | Catalyst Cloud: | This space intentionally left blank https://catalystcloud.nz |
Re: Debian Miniconf in Auckland
On Fri, 2015-01-09 at 09:10 +0100, Niels Thykier wrote: Thanks for informing of the event. Unfortunately, it seems that none of us are available for participating and providing an talk on the Jessie status on the given notice. Best of luck with the conference and the bug squashing party. We greatly appreciate your efforts. :) Hi Niels (and co), Ah well, it was worth a shot. Thanks, Andrew -- Andrew Ruthven, Wellington, New Zealand and...@etc.gen.nz | linux.conf.au 2015 New Zealand's only Cloud: | BeAwesome in Auckland, NZ https://catalyst.net.nz/cloud | http://lca2015.linux.org.au -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/1420796703.25638.0.ca...@etc.gen.nz
Debian Miniconf in Auckland
Hey, I'm organising a Mini-conference about Debian as part of the linux.conf.au 2015 [0] conference which is running on Monday next weekend in Auckland, New Zealand. I was just wondering if there is anyone from the release team who'd be in a position, and willing to, give us an update on Jessie? Skype or Google Hangouts will probably need to be the order of day unless you're going be in Auckland! More info about the mini conference (and the associated mini-debconf) is here: http://nz2015.mini.debconf.org/ Cheers, Andrew [0] http://lca2015.linux.org.au -- Andrew Ruthven, Wellington, New Zealand and...@etc.gen.nz | linux.conf.au 2015 New Zealand's only Cloud: | BeAwesome in Auckland, NZ https://catalyst.net.nz/cloud | http://lca2015.linux.org.au -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/1420408046.23311.76.ca...@etc.gen.nz
Bug#772516: unblock: mythtv-status/0.10.6-1
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
Please unblock package mythtv-status
Version 0.10.4 in testing has two bugs:
- It doesn't correctly handle UTF-8 in generated emails with Perl 5.20 (which
will be released with Jessie) - no bug has been raised for this
- It incorrectly strips out some information - bug #729400
I have also signed this new version with my new 4096 bit GPG key and xz is
now used.
Appropriate debdiff's are attached. The debdiff against the dsc files excludes
the test files added for testing #729400 to reduce the noise and the manpage
which only shows bumps.
unblock mythtv-status/0.10.6-1
-- System Information:
Debian Release: 8.0
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.14.17-vs2.3.6.13-beng (SMP w/8 CPU cores)
Locale: LANG=en_NZ.UTF-8, LC_CTYPE=POSIX (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/bash
File lists identical (after any substitutions)
Control files: lines which differ (wdiff format)
Installed-Size: [-146-] {+147+}
Version: [-0.10.4-1-] {+0.10.6-1+}
diff -Nru --exclude '*.t' --exclude '*.xml' --exclude '*.1' mythtv-status-0.10.4/ChangeLog mythtv-status-0.10.6/ChangeLog
--- mythtv-status-0.10.4/ChangeLog 2013-10-28 22:39:56.0 +1300
+++ mythtv-status-0.10.6/ChangeLog 2014-12-05 10:18:31.0 +1300
@@ -1,3 +1,15 @@
+2014-12-02 Andrew Ruthven
+ Add in more UTF-8 encodings as required for Perl v5.18, thanks to
+ Jan Schneider for reporting the UTF-8 issue.
+
+2014-09-11 Andrew Ruthven
+ Spotted that if the next recording is in 30 hours, then it is
+ displayed as 0 Days, 3. Correct it so it'll be displayed
+ as 30 Hours. Also fixes an issue where 0 hours was removed
+ if the hour was a multiple of 10. Thanks to Stephan Seitz for
+ reporting the multiple of 10 issue.
+
+
2013-10-28 Andrew Ruthven
Guard against zero total disk space, this affected Werner Mahr.
diff -Nru --exclude '*.t' --exclude '*.xml' --exclude '*.1' mythtv-status-0.10.4/bin/mythtv-status mythtv-status-0.10.6/bin/mythtv-status
--- mythtv-status-0.10.4/bin/mythtv-status 2013-10-28 22:39:56.0 +1300
+++ mythtv-status-0.10.6/bin/mythtv-status 2014-12-05 10:18:31.0 +1300
@@ -85,7 +85,7 @@
my $return_code_only = 0;
-my $VERSION = '0.10.4';
+my $VERSION = '0.10.6';
# Some display blocks are disabled by default:
$c-{'display'}{'Shows due to Auto Expire'} = 0;
@@ -477,7 +477,7 @@
}
$str =~ s/\b1 (Day|Hour|Minute)s/1 $1/g;
-$str =~ s/(, )?0 Hours(, )?//;
+$str =~ s/\b0 (Days|Hours)(, )?//;
$str =~ s/, 0 Minutes$//;
if ($seconds = $c-{'recording_in_warn'}) {
@@ -681,10 +681,10 @@
my $mail = MIME::Entity-build(
To = $c-{'email'},
- Subject = $title . (defined $suffix ? - $suffix : ''),
+ Subject = encode('UTF-8', $title . (defined $suffix ? - $suffix : '')),
Charset = $charset,
Encoding= quoted-printable,
- Data= $output
+ Data= encode('UTF-8', $output),
);
$mail-send('sendmail');
diff -Nru --exclude '*.t' --exclude '*.xml' --exclude '*.1' mythtv-status-0.10.4/debian/changelog mythtv-status-0.10.6/debian/changelog
--- mythtv-status-0.10.4/debian/changelog 2013-10-28 23:03:44.0 +1300
+++ mythtv-status-0.10.6/debian/changelog 2014-12-05 10:23:14.0 +1300
@@ -1,3 +1,21 @@
+mythtv-status (0.10.6-1) unstable; urgency=low
+
+ * New upstream release.
+ * Brings in a minor change that was on master, but missed from the
+release-0.10 git branch.
+ * Update standards version to 3.9.6.
+
+ -- Andrew Ruthven and...@etc.gen.nz Fri, 05 Dec 2014 10:17:37 +1300
+
+mythtv-status (0.10.5-1) unstable; urgency=low
+
+ * New upstream release (Closes: #729400).
+ * Fix sending emails with UTF-8 characters in them with Perl = 5.18.
+ * Fix removing 0 hours from Next Recording In if the hour is a multiple
+of 10.
+
+ -- Andrew Ruthven and...@etc.gen.nz Tue, 02 Dec 2014 20:29:13 +1300
+
mythtv-status (0.10.4-1) unstable; urgency=low
* New upstream release (Closes: #724166, #709377, #709449).
diff -Nru --exclude '*.t' --exclude '*.xml' --exclude '*.1' mythtv-status-0.10.4/debian/control mythtv-status-0.10.6/debian/control
--- mythtv-status-0.10.4/debian/control 2013-10-28 23:00:07.0 +1300
+++ mythtv-status-0.10.6/debian/control 2014-12-05 10:22:42.0 +1300
@@ -3,7 +3,7 @@
Priority: extra
Maintainer: Andrew Ruthven and...@etc.gen.nz
Build-Depends: debhelper (= 6), po-debconf
-Standards-Version: 3.9.4
+Standards-Version: 3.9.6
Homepage: http://www.etc.gen.nz/projects/mythtv/mythtv-status.html
Vcs-Git: http://git.etc.gen.nz/mythtv-status.git
Vcs-Browser: http://git.etc.gen.nz/cgi-bin/gitweb.cgi?p=mythtv-status.git;a=summary
Bug#691548: unblock: mythtv-status/0.10.2-2
On Wed, 2012-12-19 at 20:16 +0100, Julien Cristau wrote: On Sat, Oct 27, 2012 at 15:08:29 +1300, Andrew Ruthven wrote: The version in unstable removes some extraneous debugging from the init.d (bug #681684) and adds support for the new dynamic motd logic in Wheezy (bug #688034 should probably be flagged as Important). Meh. What business does this thing have to mess with motd... Because it is useful? And on some hardware running it in real time while a user is logging in is slow enough that it is a real pain, that was my original use case. diff -Nru mythtv-status-0.10.2/debian/init.d mythtv-status-0.10.2/debian/init.d --- mythtv-status-0.10.2/debian/init.d 2012-03-22 23:33:58.0 +1300 +++ mythtv-status-0.10.2/debian/init.d 2012-10-02 21:47:53.0 +1300 @@ -21,8 +21,8 @@ # Provides: mythtv-status # Required-Start:$remote_fs # Required-Stop: $remote_fs -# Should-Start: $named mythtv-backend -# Should-Stop: $named mythtv-backend +# Should-Start: $named mythtv-backend $motd +# Should-Stop: $named mythtv-backend $motd What's $motd? Shouldn't this be motd (no $)? A bug. I've just uploaded a new .deb to unstable to fix this and a minor verbosity that could occur in some cases. I've attached two debdiffs: 0.10.2-1 (wheezy) - 0.10.2-3 (new package) 0.10.2-2 (sid)- 0.10.2-3 (new package) The only other change in the debdiff is the Perl version used to generate the man page. Cheers! -- Andrew Ruthven, Wellington, New Zealand At home: and...@etc.gen.nz | linux.conf.au 2013 | Come join the party... | http://lca2013.linux.org.au diff -Nru mythtv-status-0.10.2/debian/changelog mythtv-status-0.10.2/debian/changelog --- mythtv-status-0.10.2/debian/changelog 2012-07-07 16:34:36.0 +1200 +++ mythtv-status-0.10.2/debian/changelog 2012-12-20 10:31:07.0 +1300 @@ -1,3 +1,18 @@ +mythtv-status (0.10.2-3) unstable; urgency=low + + * Fix the use of motd as a facility name, shouldn't be $motd. +Reported by Julian Cristau, thank you. + * Don't abort the init.d if we can't remove /var/run/motd.orig. + + -- Andrew Ruthven and...@etc.gen.nz Thu, 20 Dec 2012 10:29:31 +1300 + +mythtv-status (0.10.2-2) unstable; urgency=low + + * Handle a stale temp file more gracefully (Closes: #681684) + * base-files 6.11 in Wheezy uses /var/run/motd.dynamic (Closes: #688034) + + -- Andrew Ruthven and...@etc.gen.nz Tue, 02 Oct 2012 21:50:10 +1300 + mythtv-status (0.10.2-1) unstable; urgency=low * New upstream release. (Closes: #680358) diff -Nru mythtv-status-0.10.2/debian/init.d mythtv-status-0.10.2/debian/init.d --- mythtv-status-0.10.2/debian/init.d 2012-03-22 23:33:58.0 +1300 +++ mythtv-status-0.10.2/debian/init.d 2012-12-20 10:29:04.0 +1300 @@ -21,8 +21,8 @@ # Provides: mythtv-status # Required-Start:$remote_fs # Required-Stop: $remote_fs -# Should-Start: $named mythtv-backend -# Should-Stop: $named mythtv-backend +# Should-Start: $named mythtv-backend motd +# Should-Stop: $named mythtv-backend motd # Default-Start: 2 3 4 5 # Default-Stop: 0 1 6 # Short-Description: Update the MOTD with the MythTV status @@ -35,6 +35,7 @@ NAME=mythtv-status# Introduce the short server's name here DESC=MythTV Status # Introduce a short description here TEMPFILE=/var/run/motd.mythtv-status +WORKFILE=/var/run/motd test -x $DAEMON || exit 0 @@ -53,6 +54,9 @@ exit fi +# Debian Wheezy+ handles the MOTD differently. +[ -f /var/run/motd.dynamic ] WORKFILE=/var/run/motd.dynamic + set -e case $1 in @@ -60,14 +64,18 @@ log_daemon_msg Updating $DESC $NAME # Just incase someone has removed their motd file. -[ -f /var/run/motd ] || touch /var/run/motd -[ -f /var/run/motd.orig ] || cp /var/run/motd /var/run/motd.orig +[ -f $WORKFILE ] || touch $WORKFILE +[ -f /var/run/motd.orig ] || cp $WORKFILE /var/run/motd.orig +# If the tempfile is less than 15 minutes old, object, otherwise +# we'll assume that something went wrong and remove it. if [ -f $TEMPFILE ]; then - echo Hey, $TEMPFILE already exists 12 - ls -l /var/run/motd* 12 - ps -ef | grep mythtv-status 12 - cat /var/run/motd.new 12 + AGE=$(stat -c %Z $TEMPFILE); + if expr $AGE \ $(date +'%s') - 900 + then +log_warning_msg I think another $NAME is running. +exit 1 + fi fi cp /var/run/motd.orig $TEMPFILE @@ -77,12 +85,10 @@ $DAEMON $ARGS -h $HOST $TEMPFILE || ret=$? if [ $ret -eq 0 -o $ret -eq 1 ]; then if [ ! -f $TEMPFILE ]; then -# My file has gone away. WTF?! Spit out some debugging. - echo Odd, $TEMPFILE has gone away. Start: $date, End: $(date) 12 -ls -l /var/run/motd* 12 -ps -ef | grep mythtv-status 12 +log_failure_msg My temporary
Bug#691548: unblock: mythtv-status/0.10.2-2
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Please unblock package mythtv-status The version in unstable removes some extraneous debugging from the init.d (bug #681684) and adds support for the new dynamic motd logic in Wheezy (bug #688034 should probably be flagged as Important). diff -Nru mythtv-status-0.10.2/debian/changelog mythtv-status-0.10.2/debian/changelog --- mythtv-status-0.10.2/debian/changelog 2012-07-07 16:34:36.0 +1200 +++ mythtv-status-0.10.2/debian/changelog 2012-10-02 21:50:36.0 +1300 @@ -1,3 +1,10 @@ +mythtv-status (0.10.2-2) unstable; urgency=low + + * Handle a stale temp file more gracefully (Closes: #681684) + * base-files 6.11 in Wheezy uses /var/run/motd.dynamic (Closes: #688034) + + -- Andrew Ruthven and...@etc.gen.nz Tue, 02 Oct 2012 21:50:10 +1300 + mythtv-status (0.10.2-1) unstable; urgency=low * New upstream release. (Closes: #680358) diff -Nru mythtv-status-0.10.2/debian/init.d mythtv-status-0.10.2/debian/init.d --- mythtv-status-0.10.2/debian/init.d 2012-03-22 23:33:58.0 +1300 +++ mythtv-status-0.10.2/debian/init.d 2012-10-02 21:47:53.0 +1300 @@ -21,8 +21,8 @@ # Provides: mythtv-status # Required-Start:$remote_fs # Required-Stop: $remote_fs -# Should-Start: $named mythtv-backend -# Should-Stop: $named mythtv-backend +# Should-Start: $named mythtv-backend $motd +# Should-Stop: $named mythtv-backend $motd # Default-Start: 2 3 4 5 # Default-Stop: 0 1 6 # Short-Description: Update the MOTD with the MythTV status @@ -35,6 +35,7 @@ NAME=mythtv-status# Introduce the short server's name here DESC=MythTV Status # Introduce a short description here TEMPFILE=/var/run/motd.mythtv-status +WORKFILE=/var/run/motd test -x $DAEMON || exit 0 @@ -53,6 +54,9 @@ exit fi +# Debian Wheezy+ handles the MOTD differently. +[ -f /var/run/motd.dynamic ] WORKFILE=/var/run/motd.dynamic + set -e case $1 in @@ -60,14 +64,18 @@ log_daemon_msg Updating $DESC $NAME # Just incase someone has removed their motd file. -[ -f /var/run/motd ] || touch /var/run/motd -[ -f /var/run/motd.orig ] || cp /var/run/motd /var/run/motd.orig +[ -f $WORKFILE ] || touch $WORKFILE +[ -f /var/run/motd.orig ] || cp $WORKFILE /var/run/motd.orig +# If the tempfile is less than 15 minutes old, object, otherwise +# we'll assume that something went wrong and remove it. if [ -f $TEMPFILE ]; then - echo Hey, $TEMPFILE already exists 12 - ls -l /var/run/motd* 12 - ps -ef | grep mythtv-status 12 - cat /var/run/motd.new 12 + AGE=$(stat -c %Z $TEMPFILE); + if expr $AGE \ $(date +'%s') - 900 + then +log_warning_msg I think another $NAME is running. +exit 1 + fi fi cp /var/run/motd.orig $TEMPFILE @@ -77,12 +85,10 @@ $DAEMON $ARGS -h $HOST $TEMPFILE || ret=$? if [ $ret -eq 0 -o $ret -eq 1 ]; then if [ ! -f $TEMPFILE ]; then -# My file has gone away. WTF?! Spit out some debugging. - echo Odd, $TEMPFILE has gone away. Start: $date, End: $(date) 12 -ls -l /var/run/motd* 12 -ps -ef | grep mythtv-status 12 +log_failure_msg My temporary file has gone away, failed. +exit 1 else -mv $TEMPFILE /var/run/motd +mv $TEMPFILE $WORKFILE fi log_end_msg 0 else @@ -91,7 +97,7 @@ ;; stop) log_daemon_msg Stopping $DESC $NAME -[ -f /var/run/motd.orig ] cp /var/run/motd.orig /var/run/motd +[ -f /var/run/motd.orig ] cp /var/run/motd.orig $WORKFILE rm /var/run/motd.orig log_end_msg 0 ;; @@ -100,11 +106,11 @@ log_failure_msg $NAME is not running exit 1 fi -if [ ! -f /var/run/motd ]; then - log_failure_msg $NAME is not running (no motd file!) +if [ ! -f $WORKFILE ]; then + log_failure_msg $NAME is not running (no motd file)! exit 1 fi -if [ $(date -d 15 minutes ago +%s) -gt $(stat -c %Y /var/run/motd) ] +if [ $(date -d 15 minutes ago +%s) -gt $(stat -c %Y $WORKFILE) ] then log_failure_msg $NAME is not running (motd file is stale) exit 1 diff -Nru mythtv-status-0.10.2/debian/mythtv-status.1 mythtv-status-0.10.2/debian/mythtv-status.1 --- mythtv-status-0.10.2/debian/mythtv-status.1 2012-07-07 22:39:39.0 +1200 +++ mythtv-status-0.10.2/debian/mythtv-status.1 2012-10-03 14:39:16.0 +1300 @@ -124,7 +124,7 @@ .\ .\ .IX Title MYTHTV-STATUS 1 -.TH MYTHTV-STATUS 1 2012-07-07 perl v5.14.2 User Contributed Perl Documentation +.TH MYTHTV-STATUS 1 2012-07-12 perl v5.14.2 User Contributed Perl Documentation .\ For nroff, turn off justification. Always turn off hyphenation; it makes .\ way too many mistakes in technical documents. .if n .ad
Bug#680753: unblock: mythtv-status/0.10.2-1
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Please unblock package mythtv-status This version fixes BTS bugs: #680358 - Bug if the next recording is more than 1 day in the future #680372 - Danish debconf translation As I'm also the upstream maintainer fixing 680358 by cutting a new release seemed a good idea. I also noticed yesterday a bug with UTF-8, and another one which required two occurences of 23058 with 58. The debdiff is fairly length because I added a test case for the UTF-8 bug, and fixed a failing test. Cheers! unblock mythtv-status/0.10.2-1 -- System Information: Debian Release: wheezy/sid APT prefers common APT policy: (500, 'common'), (500, 'unstable') Architecture: i386 (i686) Kernel: Linux 3.2.20-vs2.3.2.10-beng (SMP w/2 CPU cores) Locale: LANG=en_NZ.UTF-8, LC_CTYPE=en_NZ (charmap=ISO-8859-1) (ignored: LC_ALL set to en_NZ) Shell: /bin/sh linked to /bin/dash -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120708111021.22043.1927.report...@build-sid-i386.agr.etc.gen.nz
Re: Freeze exception request for mythtv-status
On Mon, 2008-11-17 at 01:20 +0100, Julien Cristau wrote: On Fri, Nov 7, 2008 at 20:05:02 +0100, Adeodato Simó wrote: +# Just incase someone has removed their motd file. +[ ! -f /var/run/motd ] touch /var/run/motd [ ! -f /var/run/motd.orig ] cp /var/run/motd /var/run/motd.orig This is wrong for a `set -e` script. If those files exist, the left part of the expression will fail, and the script will abort. The proper way to do it is: [ -f /var/run/motd ] || touch /var/run/motd [ -f /var/run/motd.orig ] || cp /var/run/motd /var/run/motd.orig FWIW, set -e won't abort the script with the above code (well, unless touch or cp fail). From dash(1): -e errexit If not interactive, exit immediately if any untested command fails. The exit status of a com‐ mand is considered to be explicitly tested if the command is used to control an if, elif, while, or until; or if the command is the left hand operand of an “” or “||” operator. Which nicely explains why it was still working correctly for me. Thanks for clearing that up! -- Andrew Ruthven, Wellington, New Zealand At home: [EMAIL PROTECTED] | This space intentionally |left blank. signature.asc Description: This is a digitally signed message part
Freeze exception request for mythtv-status
Gidday,
I'd like to request a freeze exception for mythtv-status, for which I'm
both the upstream and the Debian maintainers. The latest version
(0.9.0-4) in Sid contains the following fixes to the one in Lenny. The
only substantial changes are in the init.d script.
* Don't abort the init.d sciprt if /var/run/motd is missing (which can
in turn abort dpkg if it is being installed)
* mythtv-status was changed to return a different exit code in some
circumstances and the init.d script in Lenny doesn't handle this
correctly, the init.d file needs to do the right thing.
I've attached the output from debdiff to this email.
Cheers!
PS. please CC me on any replies.
--
Andrew Ruthven, Wellington, New Zealand
At home: [EMAIL PROTECTED] | This space intentionally
|left blank.
diff -wu mythtv-status-0.9.0/debian/mythtv-status.1 mythtv-status-0.9.0/debian/mythtv-status.1
--- mythtv-status-0.9.0/debian/mythtv-status.1
+++ mythtv-status-0.9.0/debian/mythtv-status.1
@@ -1,15 +1,7 @@
-.\ Automatically generated by Pod::Man 2.16 (Pod::Simple 3.07)
+.\ Automatically generated by Pod::Man 2.1801 (Pod::Simple 3.05)
.\
.\ Standard preamble:
.\
-.de Sh \ Subsection heading
-.br
-.if t .Sp
-.ne 5
-.PP
-\fB\\$1\fR
-.PP
-..
.de Sp \ Vertical space (when we can't use .PP)
.if t .sp .5v
.if n .sp
@@ -53,7 +45,7 @@
.el .ds Aq '
.\
.\ If the F register is turned on, we'll generate index entries on stderr for
-.\ titles (.TH), headers (.SH), subsections (.Sh), items (.Ip), and index
+.\ titles (.TH), headers (.SH), subsections (.SS), items (.Ip), and index
.\ entries marked with X in POD. Of course, you'll have to process the
.\ output yourself in some meaningful fashion.
.ie \nF \{\
@@ -132,7 +124,7 @@
.\
.\
.IX Title MYTHTV-STATUS 1
-.TH MYTHTV-STATUS 1 2008-07-22 perl v5.10.0 User Contributed Perl Documentation
+.TH MYTHTV-STATUS 1 2008-10-30 perl v5.10.0 User Contributed Perl Documentation
.\ For nroff, turn off justification. Always turn off hyphenation; it makes
.\ way too many mistakes in technical documents.
.if n .ad l
diff -wu mythtv-status-0.9.0/debian/changelog mythtv-status-0.9.0/debian/changelog
--- mythtv-status-0.9.0/debian/changelog
+++ mythtv-status-0.9.0/debian/changelog
@@ -1,3 +1,28 @@
+mythtv-status (0.9.0-4) unstable; urgency=medium
+
+ * It turns out that release 0.9.1 of mythtv-status snuck into
+the 0.9.0-2 upload, back that out for now.
+
+ -- Andrew Ruthven [EMAIL PROTECTED] Thu, 30 Oct 2008 13:55:01 +1300
+
+mythtv-status (0.9.0-3) unstable; urgency=medium
+
+ * If someone has removed /var/run/motd then tries to install (or
+reinstall) this package, then it fails. We should make sure that
+doesn't happen by making sure that /var/run/motd exists.
+ * Provide some sanity checking before updating the MOTD file in
+the init.d script to make sure that mythtv-status didn't die.
+
+ -- Andrew Ruthven [EMAIL PROTECTED] Tue, 28 Oct 2008 15:12:02 +1300
+
+mythtv-status (0.9.0-2) unstable; urgency=low
+
+ * The init.d script shouldn't check the return code anymore, as the
+return code may be 1 if there are any warnings present. This
+has been stopping the MOTD from being updated.
+
+ -- Andrew Ruthven [EMAIL PROTECTED] Mon, 26 Sep 2008 09:16:53 +1200
+
mythtv-status (0.9.0-1) unstable; urgency=low
* New upstream release.
diff -wu mythtv-status-0.9.0/debian/init.d mythtv-status-0.9.0/debian/init.d
--- mythtv-status-0.9.0/debian/init.d
+++ mythtv-status-0.9.0/debian/init.d
@@ -57,15 +57,23 @@
case $1 in
start|reload|refresh|restart|force-reload)
log_daemon_msg Updating $DESC $NAME
+
+# Just incase someone has removed their motd file.
+[ ! -f /var/run/motd ] touch /var/run/motd
[ ! -f /var/run/motd.orig ] cp /var/run/motd /var/run/motd.orig
cp /var/run/motd.orig /var/run/motd.new
-if $DAEMON $ARGS -h $HOST /var/run/motd.new
-then
+set +e
+$DAEMON $ARGS -h $HOST /var/run/motd.new 2 /dev/null
+ret=$?
+set -e
+if [ $ret -eq 0 -o $ret -eq 1 ]; then
mv /var/run/motd.new /var/run/motd
-fi
log_end_msg 0
+else
+ log_failure_msg
+fi
;;
stop)
log_daemon_msg Stopping $DESC $NAME
signature.asc
Description: This is a digitally signed message part
