Bug#683303: unblock: kvirc/4:4.1.3+20111124.svn5988-2
Hi! Thank you very much for the approval. Since I received the freeze exception confirmation I've been searching for an sponsor since I don't have upload rights. After some days pinging on several places I resorted to sponsorship-requests procedure though BTS. The bug number for this is: 687458 I'll let you know anyway when anything relevant happens. I hope someone hands over this. Regards, -- Raúl Sánchez Siles -Proud Debian user- Linux registered user #416098 signature.asc Description: This is a digitally signed message part.
Bug#683303: unblock: kvirc/4:4.1.3+20111124.svn5988-2
El Sábado, 4 de agosto de 2012, Julien Cristau escribió:
On Mon, Jul 30, 2012 at 18:31:39 +0200, Raúl Sánchez Siles wrote:
[...]
Care to send a non-reversed debdiff? That makes it kinda painful to
read.
Oops! Sorry. Find it attached now.
Cheers,
Julien
Regards,
--
Raúl Sánchez Siles
-Proud Debian user-
Linux registered user #416098
diff -Nru kvirc-4.1.3+2024.svn5988/debian/changelog kvirc-4.1.3+2024.svn5988/debian/changelog
--- kvirc-4.1.3+2024.svn5988/debian/changelog 2011-11-24 13:26:20.0 +0100
+++ kvirc-4.1.3+2024.svn5988/debian/changelog 2012-07-19 21:56:22.0 +0200
@@ -1,3 +1,14 @@
+kvirc (4:4.1.3+2024.svn5988-2) unstable; urgency=low
+
+ * Updated debhelper build-depends to better cope with multiarch.
+ * Fix must not be Multi-Arch: same kvirc is Multi-Arch: foreign
+(Closes: #658058)
+ * Actually provide valid -dbg package. Added 30_upstream_build-g
+ * Fix Hardening flags missing. Applying suggested changes.
+(Closes: #669189) Thanks to Simon Ruderich.
+
+ -- Raúl Sánchez Siles rasas...@gmail.com Thu, 19 Jul 2012 21:56:08 +0200
+
kvirc (4:4.1.3+2024.svn5988-1) unstable; urgency=low
The Land Equilibrium release.
diff -Nru kvirc-4.1.3+2024.svn5988/debian/control kvirc-4.1.3+2024.svn5988/debian/control
--- kvirc-4.1.3+2024.svn5988/debian/control 2011-09-29 16:24:58.0 +0200
+++ kvirc-4.1.3+2024.svn5988/debian/control 2012-07-18 18:09:05.0 +0200
@@ -1,5 +1,5 @@
Source: kvirc
-Build-Depends: debhelper (= 8.9.4),
+Build-Depends: debhelper (= 9),
cmake (= 2.8.4+dfsg.1-3),
kdelibs5-dev,
libperl-dev,
@@ -33,7 +33,7 @@
${shlibs:Depends},
${misc:Depends}
Suggests: kvirc-dbg (= ${binary:Version})
-Multi-Arch: same
+Multi-Arch: foreign
Description: KDE-based next generation IRC client with module support
A highly configurable graphical IRC client with an MDI interface,
built-in scripting language, support for IRC DCC, drag drop file
diff -Nru kvirc-4.1.3+2024.svn5988/debian/patches/00_hardening_upstream.patch kvirc-4.1.3+2024.svn5988/debian/patches/00_hardening_upstream.patch
--- kvirc-4.1.3+2024.svn5988/debian/patches/00_hardening_upstream.patch 1970-01-01 01:00:00.0 +0100
+++ kvirc-4.1.3+2024.svn5988/debian/patches/00_hardening_upstream.patch 2012-07-18 18:09:05.0 +0200
@@ -0,0 +1,18 @@
+Description: Use build flags from environment (dpkg-buildflags).
+ Necessary for hardening flags.
+Author: Simon Ruderich si...@ruderich.org
+Last-Update: 2012-04-17
+
+--- kvirc-4.1.3+2024.svn5988.orig/CMakeLists.txt
kvirc-4.1.3+2024.svn5988/CMakeLists.txt
+@@ -220,8 +220,8 @@ ELSE()
+ ENDIF()
+ IF(CMAKE_COMPILER_IS_GNUCXX)
+ #force gdb options
+- SET(CMAKE_CXX_FLAGS -O3 -fomit-frame-pointer -DNDEBUG --no-enforce-eh-specs -pipe --exec-charset=UTF-8 --input-charset=UTF-8 --no-implement-inlines --unit-at-a-time --fast-math)
+- SET(CMAKE_C_FLAGS -O3 -fomit-frame-pointer -DNDEBUG --no-enforce-eh-specs -pipe --exec-charset=UTF-8 --input-charset=UTF-8 --no-implement-inlines --unit-at-a-time --fast-math)
++ SET(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} -O3 -fomit-frame-pointer -DNDEBUG --no-enforce-eh-specs -pipe --exec-charset=UTF-8 --input-charset=UTF-8 --no-implement-inlines --unit-at-a-time --fast-math)
++ SET(CMAKE_C_FLAGS ${CMAKE_C_FLAGS} -O3 -fomit-frame-pointer -DNDEBUG --no-enforce-eh-specs -pipe --exec-charset=UTF-8 --input-charset=UTF-8 --no-implement-inlines --unit-at-a-time --fast-math)
+ INCLUDE(CheckCXXCompilerFlag)
+ CHECK_CXX_COMPILER_FLAG(-fvisibility-inlines-hidden CXX_HAS_VIH_FLAG)
+ #gcc doesn't support visibility on PE/win32
diff -Nru kvirc-4.1.3+2024.svn5988/debian/patches/30_upstream_build-g kvirc-4.1.3+2024.svn5988/debian/patches/30_upstream_build-g
--- kvirc-4.1.3+2024.svn5988/debian/patches/30_upstream_build-g 1970-01-01 01:00:00.0 +0100
+++ kvirc-4.1.3+2024.svn5988/debian/patches/30_upstream_build-g 2012-07-18 18:09:05.0 +0200
@@ -0,0 +1,24 @@
+Description: Added compiler flag generating debug information.
+ With the current provided cmake flags, no debug information was generated in
+ the compilation. The proper flag is added to either CMAKE_C_FLAGS and
+ CMAKE_CXX_FLAGS.
+ .
+ This patch should be forwarded upstream.
+Author: Raúl Sánchez Siles rasas...@gmail.com
+Last-Update: 2012-03-15
+Origin: vendor, http://git.debian.org/?p=pkg-kde/kde-extras/kvirc.git;a=blob_plain;f=debian/patches/30_upstream_build-g;hb=HEAD
+Forwarded: no
+---
+--- a/CMakeLists.txt
b/CMakeLists.txt
+@@ -220,8 +220,8 @@
+ ENDIF()
+ IF(CMAKE_COMPILER_IS_GNUCXX)
+ #force gdb options
+- SET(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} -O3 -fomit-frame-pointer -DNDEBUG --no-enforce-eh-specs -pipe --exec-charset=UTF-8 --input-charset=UTF-8 --no-implement-inlines --unit-at-a-time --fast-math)
+- SET(CMAKE_C_FLAGS ${CMAKE_C_FLAGS} -O3 -fomit-frame-pointer -DNDEBUG --no-enforce-eh-specs -pipe
Bug#683303: unblock: kvirc/4:4.1.3+20111124.svn5988-2
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
Please unblock package kvirc
This is a resend/summary of [0] according to [1].
kvirc (4:4.1.3+2024.svn5988-2) unstable; urgency=low
* Updated debhelper build-depends to better cope with multiarch.
* Fix must not be Multi-Arch: same kvirc is Multi-Arch: foreign
(Closes: #658058)
* Actually provide valid -dbg package. Added 30_upstream_build-g
* Fix Hardening flags missing. Applying suggested changes.
(Closes: #669189) Thanks to Simon Ruderich.
Full source at [2], debdiff attached.
unblock kvirc/4:4.1.3+2024.svn5988-2
[0] http://lists.debian.org/debian-release/2012/07/msg01468.html
[1] http://lists.debian.org/debian-devel-announce/2012/07/msg4.html
[2]
http://mentors.debian.net/debian/pool/main/k/kvirc/kvirc_4.1.3+2024.svn5988-2.dsc
-- System Information:
Debian Release: wheezy/sid
APT prefers unstable
APT policy: (600, 'unstable'), (500, 'testing'), (100, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.4-trunk-amd64 (SMP w/2 CPU cores)
Locale: LANG=es_ES.UTF-8, LC_CTYPE=es_ES.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
diff -Nru kvirc-4.1.3+2024.svn5988/debian/changelog kvirc-4.1.3+2024.svn5988/debian/changelog
--- kvirc-4.1.3+2024.svn5988/debian/changelog 2012-07-19 21:56:22.0 +0200
+++ kvirc-4.1.3+2024.svn5988/debian/changelog 2011-11-24 13:26:20.0 +0100
@@ -1,14 +1,3 @@
-kvirc (4:4.1.3+2024.svn5988-2) unstable; urgency=low
-
- * Updated debhelper build-depends to better cope with multiarch.
- * Fix must not be Multi-Arch: same kvirc is Multi-Arch: foreign
-(Closes: #658058)
- * Actually provide valid -dbg package. Added 30_upstream_build-g
- * Fix Hardening flags missing. Applying suggested changes.
-(Closes: #669189) Thanks to Simon Ruderich.
-
- -- Raúl Sánchez Siles rasas...@gmail.com Thu, 19 Jul 2012 21:56:08 +0200
-
kvirc (4:4.1.3+2024.svn5988-1) unstable; urgency=low
The Land Equilibrium release.
diff -Nru kvirc-4.1.3+2024.svn5988/debian/control kvirc-4.1.3+2024.svn5988/debian/control
--- kvirc-4.1.3+2024.svn5988/debian/control 2012-07-18 18:09:05.0 +0200
+++ kvirc-4.1.3+2024.svn5988/debian/control 2011-09-29 16:24:58.0 +0200
@@ -1,5 +1,5 @@
Source: kvirc
-Build-Depends: debhelper (= 9),
+Build-Depends: debhelper (= 8.9.4),
cmake (= 2.8.4+dfsg.1-3),
kdelibs5-dev,
libperl-dev,
@@ -33,7 +33,7 @@
${shlibs:Depends},
${misc:Depends}
Suggests: kvirc-dbg (= ${binary:Version})
-Multi-Arch: foreign
+Multi-Arch: same
Description: KDE-based next generation IRC client with module support
A highly configurable graphical IRC client with an MDI interface,
built-in scripting language, support for IRC DCC, drag drop file
diff -Nru kvirc-4.1.3+2024.svn5988/debian/patches/00_hardening_upstream.patch kvirc-4.1.3+2024.svn5988/debian/patches/00_hardening_upstream.patch
--- kvirc-4.1.3+2024.svn5988/debian/patches/00_hardening_upstream.patch 2012-07-18 18:09:05.0 +0200
+++ kvirc-4.1.3+2024.svn5988/debian/patches/00_hardening_upstream.patch 1970-01-01 01:00:00.0 +0100
@@ -1,18 +0,0 @@
-Description: Use build flags from environment (dpkg-buildflags).
- Necessary for hardening flags.
-Author: Simon Ruderich si...@ruderich.org
-Last-Update: 2012-04-17
-
kvirc-4.1.3+2024.svn5988.orig/CMakeLists.txt
-+++ kvirc-4.1.3+2024.svn5988/CMakeLists.txt
-@@ -220,8 +220,8 @@ ELSE()
- ENDIF()
- IF(CMAKE_COMPILER_IS_GNUCXX)
- #force gdb options
-- SET(CMAKE_CXX_FLAGS -O3 -fomit-frame-pointer -DNDEBUG --no-enforce-eh-specs -pipe --exec-charset=UTF-8 --input-charset=UTF-8 --no-implement-inlines --unit-at-a-time --fast-math)
-- SET(CMAKE_C_FLAGS -O3 -fomit-frame-pointer -DNDEBUG --no-enforce-eh-specs -pipe --exec-charset=UTF-8 --input-charset=UTF-8 --no-implement-inlines --unit-at-a-time --fast-math)
-+ SET(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} -O3 -fomit-frame-pointer -DNDEBUG --no-enforce-eh-specs -pipe --exec-charset=UTF-8 --input-charset=UTF-8 --no-implement-inlines --unit-at-a-time --fast-math)
-+ SET(CMAKE_C_FLAGS ${CMAKE_C_FLAGS} -O3 -fomit-frame-pointer -DNDEBUG --no-enforce-eh-specs -pipe --exec-charset=UTF-8 --input-charset=UTF-8 --no-implement-inlines --unit-at-a-time --fast-math)
- INCLUDE(CheckCXXCompilerFlag)
- CHECK_CXX_COMPILER_FLAG(-fvisibility-inlines-hidden CXX_HAS_VIH_FLAG)
- #gcc doesn't support visibility on PE/win32
diff -Nru kvirc-4.1.3+2024.svn5988/debian/patches/30_upstream_build-g kvirc-4.1.3+2024.svn5988/debian/patches/30_upstream_build-g
--- kvirc-4.1.3+2024.svn5988/debian/patches/30_upstream_build-g 2012-07-18 18:09:05.0 +0200
+++ kvirc-4.1.3+2024.svn5988/debian/patches/30_upstream_build-g 1970-01-01 01:00:00.0 +0100
@@ -1,24 +0,0 @@
-Description: Added compiler flag generating debug information
Re: Request for kvirc freeze exception.
Hi!
(Debian KDE Extras Team mail address corrected)
El Jueves, 12 de julio de 2012, Cyril Brulebois escribió:
Hello,
and thanks for checking with us.
Raúl Sánchez Siles rasas...@gmail.com (06/07/2012):
Since I don't have upload rights I requested regular uploaders
first, then kde- extras team for sponsoring. The situation was such
that I failed to manage time left to freeze properly and upload didn't
happen. Moreover upstream released the 4.2.0 version, which I'm
proposing now and which differs slightly with my sponsoring requests.
I'm asking now considering kvirc package 4:4.2.0-1 into wheezy, Taking
into account [2], I'd like to support my petition on the following
points:
· Bugs 658058 and 669189 matches multiarch and hardening flags release
goals, respectively.
We could consider that.
· All packages generated are priority optional or extra, and
therefore unlikely to harm any other parts of the system. There is no
other debian package, excluding those generated by kvirc source
package, that depends on it.
Noted, but that alone won't make us give you carte blanche.
· New upstream release include a very high density of translation
updates. For instance, full debdiff [3] shows 646 files changed, 99946
insertions(+), 72202 deletions(-) whereas debdiff [4], excluding po
dir shows 305 files changed, 5472 insertions(+), 6656 deletions(-)
Even excluding translation updates (which is at least for now very OK
according to our freeze policy), that's still huge.
· New upstream release starts 4.2.x major versions, Historically
there have been 1 or 2 upstream minor revisions which we (debian) may
profit from, specially as regards with security or serious issues. If
4.2.0 is not deployed in Wheezy our base version will be
4.1.3+2024.svn5988-1, based on a development snapshot. From the
maintainers point of view, basing on a stable release is more than
convenient.
I can understand that, but that's unfortunate it got released so late as
far as the wheezy freeze is concerned.
· One extra cosmetic-point is that this upload means zero bug
package. Something that I guess every package maintainer would like
to see for his packaged stuff :)
Sorry, but totally irrelevant. :p
To summarize, not sure what to advise for this package. Surely the
proposed changes are much larger than what I'd like at this point of the
release cycle.
Mraw,
KiBi.
Thanks for your answer. My apologise for the delay, vacancy were on its way.
Given your answer and provided there are no other opinions here I decided to
prepare a package[0] backporting just the points considered. This is the
changelog:
kvirc (4:4.1.3+2024.svn5988-2) unstable; urgency=low
* Updated debhelper build-depends to better cope with multiarch.
* Fix must not be Multi-Arch: same kvirc is Multi-Arch: foreign
(Closes: #658058)
* Actually provide valid -dbg package. Added 30_upstream_build-g
* Fix Hardening flags missing. Applying suggested changes.
(Closes: #669189) Thanks to Simon Ruderich.
[0]
http://mentors.debian.net/debian/pool/main/k/kvirc/kvirc_4.1.3+2024.svn5988-2.dsc
Please, let me know if this approach is acceptable to you and if I can do
anything else to help about this issue.
Regards,
--
Raúl Sánchez Siles
-Proud Debian user-
Linux registered user #416098
diff -Nru kvirc-4.1.3+2024.svn5988/debian/changelog kvirc-4.1.3+2024.svn5988/debian/changelog
--- kvirc-4.1.3+2024.svn5988/debian/changelog 2012-07-19 21:56:22.0 +0200
+++ kvirc-4.1.3+2024.svn5988/debian/changelog 2011-11-24 13:26:20.0 +0100
@@ -1,14 +1,3 @@
-kvirc (4:4.1.3+2024.svn5988-2) unstable; urgency=low
-
- * Updated debhelper build-depends to better cope with multiarch.
- * Fix must not be Multi-Arch: same kvirc is Multi-Arch: foreign
-(Closes: #658058)
- * Actually provide valid -dbg package. Added 30_upstream_build-g
- * Fix Hardening flags missing. Applying suggested changes.
-(Closes: #669189) Thanks to Simon Ruderich.
-
- -- Raúl Sánchez Siles rasas...@gmail.com Thu, 19 Jul 2012 21:56:08 +0200
-
kvirc (4:4.1.3+2024.svn5988-1) unstable; urgency=low
The Land Equilibrium release.
diff -Nru kvirc-4.1.3+2024.svn5988/debian/control kvirc-4.1.3+2024.svn5988/debian/control
--- kvirc-4.1.3+2024.svn5988/debian/control 2012-07-18 18:09:05.0 +0200
+++ kvirc-4.1.3+2024.svn5988/debian/control 2011-09-29 16:24:58.0 +0200
@@ -1,5 +1,5 @@
Source: kvirc
-Build-Depends: debhelper (= 9),
+Build-Depends: debhelper (= 8.9.4),
cmake (= 2.8.4+dfsg.1-3),
kdelibs5-dev,
libperl-dev,
@@ -33,7 +33,7 @@
${shlibs:Depends},
${misc:Depends}
Suggests: kvirc-dbg (= ${binary:Version})
-Multi-Arch: foreign
+Multi-Arch: same
Description: KDE-based next generation IRC client with module support
A highly configurable graphical IRC client with an MDI
Request for kvirc freeze exception.
Dear Release Managers: About a month ago I updated the kvirc package[0][1] to a newer version according to the following changelog entries: kvirc (4:4.2.0-1) unstable; urgency=low * New upstream release. * Updated debhelper build-depends to better cope with multiarch. * Fix must not be Multi-Arch: same kvirc is Multi-Arch: foreign (Closes: #658058) * Actually provide valid -dbg package. Added 30_upstream_build-g * Fix Hardening flags missing. Applying suggested changes. (Closes: #669189) Thanks to Simon Ruderich. Since I don't have upload rights I requested regular uploaders first, then kde- extras team for sponsoring. The situation was such that I failed to manage time left to freeze properly and upload didn't happen. Moreover upstream released the 4.2.0 version, which I'm proposing now and which differs slightly with my sponsoring requests. I'm asking now considering kvirc package 4:4.2.0-1 into wheezy, Taking into account [2], I'd like to support my petition on the following points: · Bugs 658058 and 669189 matches multiarch and hardening flags release goals, respectively. · All packages generated are priority optional or extra, and therefore unlikely to harm any other parts of the system. There is no other debian package, excluding those generated by kvirc source package, that depends on it. · New upstream release include a very high density of translation updates. For instance, full debdiff [3] shows 646 files changed, 99946 insertions(+), 72202 deletions(-) whereas debdiff [4], excluding po dir shows 305 files changed, 5472 insertions(+), 6656 deletions(-) · New upstream release starts 4.2.x major versions, Historically there have been 1 or 2 upstream minor revisions which we (debian) may profit from, specially as regards with security or serious issues. If 4.2.0 is not deployed in Wheezy our base version will be 4.1.3+2024.svn5988-1, based on a development snapshot. From the maintainers point of view, basing on a stable release is more than convenient. · One extra cosmetic-point is that this upload means zero bug package. Something that I guess every package maintainer would like to see for his packaged stuff :) I also offer to carry out any suggestion you may deem important in order to get package in shape for wheezy. In other words, I appreciate your advise on how to proceed. Thanks and best regards, [0] http://anonscm.debian.org/gitweb/?p=pkg-kde/kde-extras/kvirc.git [1] http://mentors.debian.net/debian/pool/main/k/kvirc/kvirc_4.2.0-1.dsc [2] http://release.debian.org/wheezy/freeze_policy.html [3] http://trismegisto.no-ip.org/incoming/kvirc_testing-4.2.0.debdiff.xz (11879KiB uncompressed) [4] http://trismegisto.no-ip.org/incoming/kvirc_testing-4.2.0-nopo.debdiff.xz (848KiB uncompressed) -- Raúl Sánchez Siles -Proud Debian user- Linux registered user #416098 signature.asc Description: This is a digitally signed message part.
Re: [SRM] kvirc 4:4.0.4-1 for stable-proposed-updates [2nd attempt]
Hi Adam (et al.) El Martes, 10 de Mayo de 2011, Adam D. Barratt escribió: Hi, On Tue, 2011-05-03 at 01:15 +0200, Raúl Sánchez Siles wrote: Not strictly Monday (here) but at least I have a diff, available at [0]. Thanks for that, and apologies for not getting back to you sooner. I bet you had some other important things to deal with ;) I tried to remove all unnecessary changes from the former big diff. There are still some minor changes that could be added, but I preferred to go for the simplest version in order to have an assessment about the feasibility of this kind of patch. If you deem this, or something very similar, can be accepted I'll go on with the testing which shouldn't be very different to what we are testing right now. To be honest skimming the patch took quite a while (as you may have already noticed) and sure this is not a reason to accept it. What I'm trying to say is that I don't mind spending some more time on this and have it in shape for a Stable release which was our aim from the beginning. The updated diff is much more manageable; thanks. Given the brevity of the changelog, would it be possible to tie the changes down to related bug reports, git commits, or something similar? I did notice that some of the changes have ticket IDs included in the comments, but there's quite a number which don't. So far I've double checked the diff and seems I haven't hopefully overlooked any fixes. Regarding your traceability request I'll try my best to link those. I'll take a look at the changes with traceability in mind and I'll give you a time estimate when I'm ready. I've also have been running the proposed version on a Squeeze system and haven't seen any relevant issue so far. Regards, Adam Same... -- Raúl Sánchez Siles -Proud Debian user- Linux registered user #416098 signature.asc Description: This is a digitally signed message part.
Re: [SRM] kvirc 4:4.0.4-1 for stable-proposed-updates [2nd attempt]
Hello (again): El Lunes, 25 de Abril de 2011, Raúl Sánchez Siles escribió: Hello: On Mon, Apr 25, 2011 at 04:58:26PM +0100, Adam D. Barratt wrote: Hi, On Thu, 2011-03-31 at 19:39 +0100, Adam D. Barratt wrote: On Thu, 2011-03-31 at 15:13 +0200, Raúl Sánchez Siles wrote: We assume that you agree or at least you will consider translation changes. Assuming they're updated translations and apply to whatever set of changes we end up finally considering, we'll certainly look at them. We tend not to add new translations but from the debdiff they all look like updates (fwiw, historically we've not really accepted updated translations either). Our plan is to work out a new diff that excludes these changes, we'll let you know as soon as we have it ready for review. It's probably expected before next week. Thanks, and for caring about fixing kvirc in Debian stable. Is there an updated ETA for that new diff? Thanks for your interest in this issue. I apologize for the longish delay. It's certainly not being an easy task, but I'm working on it. I'll need some more time, my previous estimate was obviously very optimistic. My figures now are at least a week more for a neat/tidy diff and then one more week for testing. I'm not intending to tightly engage this schedule since I'm having some real life overhead, but I'll try harder this time. Thanks for the patience. Regards, Regards, Adam Not strictly Monday (here) but at least I have a diff, available at [0]. I tried to remove all unnecessary changes from the former big diff. There are still some minor changes that could be added, but I preferred to go for the simplest version in order to have an assessment about the feasibility of this kind of patch. If you deem this, or something very similar, can be accepted I'll go on with the testing which shouldn't be very different to what we are testing right now. To be honest skimming the patch took quite a while (as you may have already noticed) and sure this is not a reason to accept it. What I'm trying to say is that I don't mind spending some more time on this and have it in shape for a Stable release which was our aim from the beginning. [0] http://trismegisto.no-ip.org/incoming/kvirc_4.0.2-4.0.4_b.debdiff.lzma Regards, -- Raúl Sánchez Siles -Proud Debian user- Linux registered user #416098 signature.asc Description: This is a digitally signed message part.
Re: [SRM] kvirc 4:4.0.4-1 for stable-proposed-updates [2nd attempt]
Hello: On Mon, Apr 25, 2011 at 04:58:26PM +0100, Adam D. Barratt wrote: Hi, On Thu, 2011-03-31 at 19:39 +0100, Adam D. Barratt wrote: On Thu, 2011-03-31 at 15:13 +0200, Raúl Sánchez Siles wrote: We assume that you agree or at least you will consider translation changes. Assuming they're updated translations and apply to whatever set of changes we end up finally considering, we'll certainly look at them. We tend not to add new translations but from the debdiff they all look like updates (fwiw, historically we've not really accepted updated translations either). Our plan is to work out a new diff that excludes these changes, we'll let you know as soon as we have it ready for review. It's probably expected before next week. Thanks, and for caring about fixing kvirc in Debian stable. Is there an updated ETA for that new diff? Thanks for your interest in this issue. I apologize for the longish delay. It's certainly not being an easy task, but I'm working on it. I'll need some more time, my previous estimate was obviously very optimistic. My figures now are at least a week more for a neat/tidy diff and then one more week for testing. I'm not intending to tightly engage this schedule since I'm having some real life overhead, but I'll try harder this time. Thanks for the patience. Regards, Regards, Adam -- Raúl Sánchez Siles -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110425155944.GG7550@trismegisto.universo
Re: [SRM] kvirc 4:4.0.4-1 for stable-proposed-updates [2nd attempt]
Hi Adam, Thanks for taking the time to tackle this. On Thu, Mar 31, 2011 at 01:29:01PM +0100, Adam D. Barratt wrote: Hi, On Thu, March 31, 2011 10:54, you wrote: I'm a co-maintainer of KVIrc and upstream has just released a bugfix release for their stable branch (4.0). Debian Stable has 4.0.2 but 4.0.4 fixes some serious problems: CRASH r4795 fix for a crash when opening join channels widget CRASH #878 Crash by fuzzing CRASH #879 Another crash through fuzzing REGR #1010 Channellist Background problem with Gnome CRASH r5289 fix for a crash in /exec (related to #0164) REGR #1068 Perl was updated to 5.12.2 +latest Kvirc (SVN) CRASH #1093 crash on /list CRASH r5476 fix for a crash in regchan.showlist() CRASH #1098 Crash while pasting new topic over old topic in topic bar REGR r5576 backported relevant patches to fix addon installation From a quick scan through the above list, many of the changes sound okay in principle although, for example, the perl 5.12 changes aren't really relevant as squeeze does not (and will not) contain perl 5.12. We'll analyse the situation as with perl regards, and several translation updates. No other changes (except a few updated meta files, like the splash screen, some Windows/Mac-OS-X-only stuff which isn't affecting us but I didn't feel would warrant a repacking and some formatting changes) where made, as the debdiff at [0] shows [...] [0] http://dev.carbon-project.org/debian/kvirc/kvirc_4.0.2-4.0.4.debdiff.xz Having excluded the .po and .pot files, I'm still left with a diff of 109 files changed, 1804 insertions(+), 1407 deletions(-) which is higher than we'd normally look at for a stable update. A good proportion of this is presumably the formatting changes which you referred to. However, many of these appear to be of this style: - KviEngineListBoxItem::KviEngineListBoxItem(KviTalListWidget * lb,KviCryptEngineDescription * d,const char * modName) - : KviTalListWidgetText(lb,d-szName) + KviEngineListBoxItem::KviEngineListBoxItem(KviTalListWidget * pList, KviCryptEngineDescription * pDesc, const char * pcModName) + : KviTalListWidgetText(pList,pDesc-m_szName) which is somewhat more than a formatting change, and makes the diff rather noisy and difficult to review. I appreciate that simply updating to upstream's new stable release makes things much easier for you but in this case I really would prefer a targetted update containing just the changes related to the issues that you believe should be fixed in stable. We assume that you agree or at least you will consider translation changes. Our plan is to work out a new diff that excludes these changes, we'll let you know as soon as we have it ready for review. It's probably expected before next week. Please, let us know if you have any comment on this. Regards, Adam Regards, -- Raúl -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110331131349.GD2523@trismegisto.universo
Re: Bug#502459: fixed in kdelibs 4:3.5.10.dfsg.1-1
Hello Mark: Thanks for caring about this. El Miércoles 29 Octubre 2008, Mark Purcell escribió: On Monday 27 October 2008 09:17:22 Debian Qt/KDE Maintainers wrote: kdelibs (4:3.5.10.dfsg.1-1) unstable; urgency=low +++ Changes by Ana Beatriz Guerrero Lopez: [...] +++ Changes by Raúl Sánchez Siles: * konqueror: Crash on eBay page (Closes: #502459) with recently added 63_fixed-layout-table.diff Ana, Raúl et al, While the RC bug (#502459) has been fixed in sid via the upload of kdelibs 4:3.5.10.dfsg.1-1, this still leaves open the resolution of this RC bug for lenny. (4:3.5.9.dfsg.1-6) Options for resolution in lenny: 1. Upload a new kdelibs 3.5.9, say -7, with 63_fixed-layout-table.diff targeted at testing-proposed-updates, or 2. Convince debian-release that lenny should be released with kdelibs 3.5.10 - currently in experimental. I suspect that option 1 maybe more successful. Mark As we all KDE users know, kdelibs plays a major role in the stability and usability of whole KDE3, the one to be released on Lenny. It is true that changing the released version from current Lenny's apparent 3.5.9 to sid's 3.5.10 may startle anyone, but there isn't that striking change. Lenny's kdelibs version includes a branch pull which makes it almost 3.5.10, except some minor details as, e.g.: version number. This was included before the freeze. You can check out that in the move some big patches had been removed by the fact of providing 3.5.10. I've done some work in order to show the differences between the lenny and sid versions. I took both sources, applied patches and analysed differences. The whole diffstat is attached as 9-10.diffstat where you can see all the file changes done. As you can see there changes haven't been very impressive. But after that, I refined the information, I used this command: ff -rNup kdelibs-3.5.9.dfsg.1/ kdelibs-3.5.10.dfsg.1/ | filterdiff -p1 -x '*debian*' |filterdiff -x '*.desktop' | filterdiff -x *Makefile.in |filterdiff -p1 -x kdeui/kdepackages.h 9-10.diff So I took out debian dir changes, desktop file changes, autotools generated Makefile.in and kdepackages.h file which is a file used as a helper to bug tracking, where versions and applications are defined. The result off all of this is easily readable and is attached as 9-10.diff. The changelog between sid and Lenny versions is also attached as 9-10.changelog. As well as the modifications implied when providing real 3.5.10 and not 3.5.10 pretending to be 3.5.9, there are 3 groups of changes we may break down: · Major: #502459 fix 62_fix_googlemaps_backport.diff, IMHO as serious the previous one. · Relevant: libcups build-deps update cups init script name fix, which prevented restarting cups from KDE buildprep fix which prevented double-compilation works (release goal). · Minor. The rest. Altough some of them quite interesting to have. In summary, I think not only #502459 should be provided in Lenny but also the rest of changes should be studied/included. Feel free to answer whatever doubt you may have about this issue. Comments are also welcome. Regards, -- Raúl Sánchez Siles -Proud Debian user- Linux registered user #416098 README |2 admin/cvs.sh |2 configure |2 configure.in |2 dcop/dcopidl/Makefile.in |2 dcop/dcopidl2cpp/Makefile.in |2 debian/changelog | 33 debian/control |6 debian/control.in |4 debian/control.tmp |6 debian/patches/01_kdelibs_branch_r828883.diff |19934 -- debian/patches/01_kdelibs_branch_r828883.diff.log | 492 debian/patches/02_kate_regression_r777286.diff | 14 debian/patches/02_kate_regression_r777286.diff.level-1.log |1 debian/patches/03_start_kdeinit_integer_overflow.diff | 117 debian/patches/03_start_kdeinit_integer_overflow.diff.level-1.log |1 debian/patches/05_kate_debianchangelog_default_context_r799980.diff | 106 debian/patches/05_kate_debianchangelog_default_context_r799980.diff.level-1.log |2 debian/patches/06_khtml_rendering_r786289.diff
