Bug#771195: Acknowledgement ((pre-approval) unblock: gcc-arm-none-eabi/4.8.3-13+12)
Ping? -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/002f01d00fe6$85f0cd30$91d26790$@arm.com
Bug#771196: Acknowledgement ((pre-approval) unblock: gdb-arm-none-eabi/7.7.1+dfsg-5+7)
Ping? -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/003101d00fe6$9b1f7850$d15e68f0$@arm.com
Bug#771194: Acknowledgement ((pre-approval) unblock: binutils-arm-none-eabi/2.24.90.20141124-1+6)
Ping? -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/003001d00fe6$8b7eebb0$a27cc310$@arm.com
Bug#771194: (pre-approval) unblock: binutils-arm-none-eabi/2.24.90.20141124-1+6
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Hi there, A new update release of the ARM embedded toolchain was released few days before the freeze but we missed the deadline due to various reasons (internal process, holidays, etc.). The update consists solely of important bugfixes and support for the recently announced Cortex-M7 ARM processors. I understand that this latter change is against the freeze policy which is why we haven't uploaded the package to unstable yet but please consider that it's a quite small change and isolated. It doesn't affect the current support of other processors and in the worst case it would only offer a broken support for this new processor. In addition, this is considered as a minor update by ARM and is rigorously tested on a wide range of devices. I would understand and respect any decision you would make but I would just ask you to consider the toolchain as a whole when making the decision, i.e. approve or reject the unblock for all 3 [1] packages that needs updating. [1] binutils-arm-none-eabi, gcc-arm-none-eabi, gdb-arm-none-eabi debdiff for the package attached. Also attached is the ARM embedded toolchain patch from debian/patches for easier review. unblock binutils-arm-none-eabi/2.24.90.20141124-1+6 -- System Information: Debian Release: jessie/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 3.13.0-38-generic (SMP w/8 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8) Shell: /bin/sh linked to /bin/dashdiff --git a/debian/changelog b/debian/changelog index 7f47731..55db5d4 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +binutils-arm-none-eabi (6) UNRELEASED; urgency=medium + + * New upstream release: 4.8-2014-q3-update. + * Add myself to Uploaders. + + -- Thomas Preud'homme thomas.preudho...@arm.com Thu, 21 Aug 2014 09:20:37 + + binutils-arm-none-eabi (5) unstable; urgency=medium * New upstream release (2.24.51) diff --git a/debian/control b/debian/control index 1cb4a18..0f2d31f 100644 --- a/debian/control +++ b/debian/control @@ -2,7 +2,8 @@ Source: binutils-arm-none-eabi Section: devel Priority: extra Maintainer: Agustin Henze t...@debian.org -Uploaders: Keith Packard kei...@keithp.com +Uploaders: Keith Packard kei...@keithp.com, + Thomas Preud'homme thomas.preudho...@arm.com Build-Depends: binutils-source, debhelper (= 8.0.0), diff --git a/debian/patches/0001-Add-GNU-ARM-embedded-toolchain-patches.patch b/debian/patches/0001-Add-GNU-ARM-embedded-toolchain-patches.patch new file mode 100644 index 000..fb7ad38 --- /dev/null +++ b/debian/patches/0001-Add-GNU-ARM-embedded-toolchain-patches.patch @@ -0,0 +1,533 @@ +diff --git a/bfd/ChangeLog.arm b/bfd/ChangeLog.arm +new file mode 100644 +index 000..d54d76d +--- /dev/null b/bfd/ChangeLog.arm +@@ -0,0 +1,74 @@ ++2014-01-02 Joey Ye joey...@arm.com ++ ++ Backport from mainline ++ 2013-03-30 Alan Modra amo...@gmail.com ++ ++ PR ld/15323 ++ * elf-m10300.c (mn10300_elf_check_relocs): Set non_ir_ref for ++ global symbols referenced by relocs. ++ * elf32-arm.c (elf32_arm_check_relocs): Likewise. ++ * elf32-bfin.c (bfin_check_relocs): Likewise. ++ * elf32-cr16.c (cr16_elf_check_relocs): Likewise. ++ * elf32-cris.c (cris_elf_check_relocs): Likewise. ++ * elf32-d10v.c (elf32_d10v_check_relocs): Likewise. ++ * elf32-dlx.c (elf32_dlx_check_relocs): Likewise. ++ * elf32-fr30.c (fr30_elf_check_relocs): Likewise. ++ * elf32-frv.c (elf32_frv_check_relocs): Likewise. ++ * elf32-hppa.c (elf32_hppa_check_relocs): Likewise. ++ * elf32-i370.c (i370_elf_check_relocs): Likewise. ++ * elf32-iq2000.c (iq2000_elf_check_relocs): Likewise. ++ * elf32-lm32.c (lm32_elf_check_relocs): Likewise. ++ * elf32-m32c.c (m32c_elf_check_relocs): Likewise. ++ * elf32-m32r.c (m32r_elf_check_relocs): Likewise. ++ * elf32-m68hc1x.c (elf32_m68hc11_check_relocs): Likewise. ++ * elf32-m68k.c (elf_m68k_check_relocs): Likewise. ++ * elf32-mcore.c (mcore_elf_check_relocs): Likewise. ++ * elf32-microblaze.c (microblaze_elf_check_relocs): Likewise. ++ * elf32-moxie.c (moxie_elf_check_relocs): Likewise. ++ * elf32-msp430.c (elf32_msp430_check_relocs): Likewise. ++ * elf32-mt.c (mt_elf_check_relocs): Likewise. ++ * elf32-openrisc.c (openrisc_elf_check_relocs): Likewise. ++ * elf32-ppc.c (ppc_elf_check_relocs): Likewise. ++ * elf32-rl78.c (rl78_elf_check_relocs): Likewise. ++ * elf32-s390.c (elf_s390_check_relocs): Likewise. ++ * elf32-score.c (s3_bfd_score_elf_check_relocs): Likewise. ++ * elf32-score7.c (s7_bfd_score_elf_check_relocs): Likewise. ++ * elf32-sh.c (sh_elf_check_relocs): Likewise. ++ * elf32-tic6x.c (elf32_tic6x_check_relocs): Likewise. ++ * elf32-tilepro.c (tilepro_elf_check_relocs): Likewise. ++ * elf32-v850.c (v850_elf_check_relocs): Likewise. ++ * elf32-vax.c (elf_vax_check_relocs): Likewise. ++ * elf32
Bug#771195: (pre-approval) unblock: gcc-arm-none-eabi/4.8.3-13+12
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Hi there, A new update release of the ARM embedded toolchain was released few days before the freeze but we missed the deadline due to various reasons (internal process, holidays, etc.). The update consists solely of important bugfixes and support for the recently announced Cortex-M7 ARM processors. I understand that this latter change is against the freeze policy which is why we haven't uploaded the package to unstable yet but please consider that it's a quite small change and isolated. It doesn't affect the current support of other processors and in the worst case it would only offer a broken support for this new processor. In addition, this is considered as a minor update by ARM and is rigorously tested on a wide range of devices. I would understand and respect any decision you would make but I would just ask you to consider the toolchain as a whole when making the decision, i.e. approve or reject the unblock for all 3 [1] packages that needs updating. [1] binutils-arm-none-eabi, gcc-arm-none-eabi, gdb-arm-none-eabi Since a typo in the name of the patch in debian/patches was fixed, the true debdiff is large. I thus attached a debdiff without the file renaming part. unblock gcc-arm-none-eabi/4.8.3-13+12 -- System Information: Debian Release: jessie/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 3.13.0-38-generic (SMP w/8 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8) Shell: /bin/sh linked to /bin/dashdiff --git a/debian/changelog b/debian/changelog index 50c3bd1..a261842 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +gcc-arm-none-eabi (12) UNRELEASED; urgency=medium + + * New upstream release: 4.8-2014-q3-update. + * Modify patching so that patches can be version independent. + + -- Thomas Preud'homme thomas.preudho...@arm.com Mon, 20 Oct 2014 10:01:25 + + gcc-arm-none-eabi (11) unstable; urgency=medium * Track GCC embedded branch. diff --git a/debian/patches/0001-Ad-GNU-ARM-embedded-toolchain-patches.patch b/debian/patches/0001-Ad-GNU-ARM-embedded-toolchain-patches.patch index 19be0f2..f1fed98 100644 --- a/debian/patches/0001-Ad-GNU-ARM-embedded-toolchain-patches.patch +++ b/debian/patches/0001-Ad-GNU-ARM-embedded-toolchain-patches.patch @@ -1,9 +1,25 @@ diff --git a/gcc/ChangeLog.arm b/gcc/ChangeLog.arm new file mode 100644 -index 000..8f04bc3 +index 000..0ef5a74 --- /dev/null -+++ b/gcc-4.8.3/gcc/ChangeLog.arm -@@ -0,0 +1,311 @@ b/gcc/ChangeLog.arm +@@ -0,0 +1,327 @@ ++2014-09-30 Terry Guo terry@arm.com ++ ++ Backport mainline r215711 ++ 2014-09-30 Terry Guo terry@arm.com ++ ++ * config/arm/arm-cores.def (cortex-m7): New core name. ++ * config/arm/arm-fpus.def (fpv5-sp-d16): New fpu name. ++ (fpv5-d16): Ditto. ++ * config/arm/arm-tables.opt: Regenerated. ++ * config/arm/arm-tune.md: Regenerated. ++ * config/arm/arm.h (TARGET_VFP5): New macro. ++ * config/arm/bpabi.h (BE8_LINK_SPEC): Include cortex-m7. ++ * config/arm/vfp.md (vrint_patternSDF:mode2, ++ smaxmode3, sminmode3): Enabled for FPU FPv5. ++ * doc/invoke.texi: Document new cpu and fpu names. ++ +2014-02-28 Joey Ye joey...@arm.com + + Backport mainline r208217 @@ -315,16 +331,10 @@ index 000..8f04bc3 + * configure: Regenerated. + * config/arm/t-mlibs: New files to define multilibs. + * config.gcc: Use above multilib fragment. -diff --git a/gcc/DEV-PHASE b/gcc/DEV-PHASE -index 373fbc6..d702569 100644 /dev/null -+++ b/gcc-4.8.3/gcc/DEV-PHASE -@@ -0,0 +1,1 @@ -+release diff --git a/gcc/Makefile.in b/gcc/Makefile.in index 2a4475b..56b7baa 100644 a/gcc-4.8.3/gcc/Makefile.in -+++ b/gcc-4.8.3/gcc/Makefile.in +--- a/gcc/Makefile.in b/gcc/Makefile.in @@ -526,6 +526,7 @@ lang_opt_files=@lang_opt_files@ $(srcdir)/c-family/c.opt $(srcdir)/common.opt lang_specs_files=@lang_specs_files@ lang_tree_files=@lang_tree_files@ @@ -337,7 +347,7 @@ diff --git a/gcc/c-family/ChangeLog.arm b/gcc/c-family/ChangeLog.arm new file mode 100644 index 000..056bf52 --- /dev/null -+++ b/gcc-4.8.3/gcc/c-family/ChangeLog.arm b/gcc/c-family/ChangeLog.arm @@ -0,0 +1,8 @@ +2014-07-29 Terry Guo terry@arm.com + @@ -349,8 +359,8 @@ index 000..056bf52 + * c.opt (fshort-wchar): Likewise. diff --git a/gcc/c-family/c.opt b/gcc/c-family/c.opt index 4da80b0..8dfa739 100644 a/gcc-4.8.3/gcc/c-family/c.opt -+++ b/gcc-4.8.3/gcc/c-family/c.opt +--- a/gcc/c-family/c.opt b/gcc/c-family/c.opt @@ -1121,11 +1121,11 @@ C ObjC C++ ObjC++ Optimization Var(flag_short_double) Use the same size for double as for float @@ -367,8 +377,8 @@ index 4da80b0..8dfa739 100644 fsigned-bitfields diff --git a/gcc/calls.c b/gcc/calls.c index bf0ba30..a066e52 100644 a/gcc-4.8.3/gcc/calls.c -+++ b/gcc-4.8.3/gcc/calls.c +--- a/gcc/calls.c
Bug#771196: (pre-approval) unblock: gdb-arm-none-eabi/7.7.1+dfsg-5+7
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
Hi there,
A new update release of the ARM embedded toolchain was released few days
before the freeze but we missed the deadline due to various reasons
(internal process, holidays, etc.). The update consists solely of
important bugfixes and support for the recently announced Cortex-M7
ARM processors.
I understand that this latter change is against the freeze policy which
is why we haven't uploaded the package to unstable yet but please
consider that it's a quite small change and isolated. It doesn't affect
the current support of other processors and in the worst case it would
only offer a broken support for this new processor. In addition, this is
considered as a minor update by ARM and is rigorously tested on a wide
range of devices.
Note that this package only contains bug fixes backported for this
version of gdb.
I would understand and respect any decision you would make but I would
just ask you to consider the toolchain as a whole when making the
decision, i.e. approve or reject the unblock for all 3 [1] packages that
needs updating.
[1] binutils-arm-none-eabi, gcc-arm-none-eabi, gdb-arm-none-eabi
debdiff for the package attached. Also attached is the ARM embedded
toolchain patch from debian/patches for easier review.
unblock gdb-arm-none-eabi/7.7.1+dfsg-5+7
-- System Information:
Debian Release: jessie/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 3.13.0-38-generic (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored:
LC_ALL set to en_US.UTF-8)
Shell: /bin/sh linked to /bin/dashdiff --git a/debian/changelog b/debian/changelog
index 0aab5b3..f78f7d6 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+gdb-arm-none-eabi (7) UNRELEASED; urgency=medium
+
+ * New upstream release: 4.8-2014-q3-update.
+ * Fix my email.
+
+ -- Thomas Preud'homme thomas.preudho...@arm.com Mon, 20 Oct 2014 15:38:58 +
+
gdb-arm-none-eabi (6) unstable; urgency=medium
* Workaround for upstream manpages stripped on the last gdb-source version
diff --git a/debian/control b/debian/control
index 0f2370b..8fa6261 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@ Section: devel
Priority: extra
Maintainer: Agustin Henze t...@debian.org
Uploaders: Keith Packard kei...@keithp.com,
- Thomas Preud'homme thomas.preud-ho...@arm.com
+ Thomas Preud'homme thomas.preudho...@arm.com
Build-Depends:
debhelper (= 8.0.0),
gdb-source,
diff --git a/debian/patches/0001-Add-GNU-ARM-embedded-toolchain-patches.patch b/debian/patches/0001-Add-GNU-ARM-embedded-toolchain-patches.patch
new file mode 100644
index 000..cce7b83
--- /dev/null
+++ b/debian/patches/0001-Add-GNU-ARM-embedded-toolchain-patches.patch
@@ -0,0 +1,383 @@
+diff --git a/gdb/ChangeLog.arm b/gdb/ChangeLog.arm
+new file mode 100644
+index 000..7f60687
+--- /dev/null
b/gdb/ChangeLog.arm
+@@ -0,0 +1,18 @@
++Backport from 9a9a76082919371f4ceb571f6c9892325b80a2e0
++
++2014-07-09 Andrew Burgess andrew.burg...@embecosm.com
++
++ * ada-varobj.c (ada_varobj_ops): Fill in is_path_expr_parent
++ field.
++ * c-varobj.c (c_is_path_expr_parent): New function, moved core
++ from varobj.c, with additional checks.
++ (c_varobj_ops): Fill in is_path_expr_parent field.
++ (cplus_varobj_ops): Fill in is_path_expr_parent field.
++ * jv-varobj.c (java_varobj_ops): Fill in is_path_expr_parent
++ field.
++ * varobj.c (is_path_expr_parent): Call is_path_expr_parent varobj
++ ops method.
++ (varobj_default_is_path_expr_parent): New function.
++ * varobj.h (lang_varobj_ops): Add is_path_expr_parent field.
++ (varobj_default_is_path_expr_parent): Declare new function.
++
+diff --git a/gdb/ada-varobj.c b/gdb/ada-varobj.c
+index 3da6018..b49eaf0 100644
+--- a/gdb/ada-varobj.c
b/gdb/ada-varobj.c
+@@ -1032,5 +1032,6 @@ const struct lang_varobj_ops ada_varobj_ops =
+ ada_type_of_child,
+ ada_value_of_variable,
+ ada_value_is_changeable_p,
+- ada_value_has_mutated
++ ada_value_has_mutated,
++ varobj_default_is_path_expr_parent
+ };
+diff --git a/gdb/c-varobj.c b/gdb/c-varobj.c
+index 9c2860d..f7bc52b 100644
+--- a/gdb/c-varobj.c
b/gdb/c-varobj.c
+@@ -126,6 +126,56 @@ adjust_value_for_child_access (struct value **value,
+ }
+ }
+
++/* Is VAR a path expression parent, i.e., can it be used to construct
++ a valid path expression? */
++
++static int
++c_is_path_expr_parent (struct varobj *var)
++{
++ struct type *type;
++
++ /* Fake children are not path_expr parents. */
++ if (CPLUS_FAKE_CHILD (var))
++return 0;
++
++ type = varobj_get_gdb_type (var);
++
++ /* Anonymous unions and structs are also not path_expr parents. */
++ if ((TYPE_CODE (type) == TYPE_CODE_STRUCT
++ || TYPE_CODE (type) == TYPE_CODE_UNION)
++ TYPE_NAME (type) == NULL
++ TYPE_TAG_NAME (type) == NULL
Re: Temporary solution for changelog problem in binNMUs
Le vendredi 17 mai 2013 13:40:13, Dominique Dumont a écrit : This may be a dumb question, but looking at this example of different binNMU changelogs [1], I wonder what is the point of having a log specific to each build system ... In other word, can't we have a binNMU log generated by *the* system that will trigger the rebuild ? So the log would be common for all binary packages. You would have to make the date in the trailline the same for all buildd. Also, it wouldn't help for the case of a binNMU on a subset of all arches since only some of them would have the entry. The solution proposed by ansgar cover this case. signature.asc Description: This is a digitally signed message part.
Re: Temporary solution for changelog problem in binNMUs
Le vendredi 17 mai 2013 15:36:02, Julien Cristau a écrit : On Fri, May 17, 2013 at 14:14:20 +0200, Thomas Preud'homme wrote: Also, it wouldn't help for the case of a binNMU on a subset of all arches since only some of them would have the entry. The solution proposed by ansgar cover this case. No it doesn't. dpkg will still refuse to install a m-a same package at different versions. Yeah, right. Thanks for correcting me. The sentence should instead be it would automatically cover this case if dpkg behavior was changed in this regards. But if I remember well there was some opposition to this idea. Cheers, Julien signature.asc Description: This is a digitally signed message part.
Bug#705552: unblock: subversion/1.6.17dfsg-4+deb7u2
Le jeudi 18 avril 2013 14:38:15, Adam D. Barratt a écrit :
Upstream appear to believe it {does,should}n't -
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=704940#32
Oh good. I hadn't time to look at that yet. Should I upload the NMU then?
Regards,
Adam
Best regards,
Thomas
signature.asc
Description: This is a digitally signed message part.
Bug#705552: unblock: subversion/1.6.17dfsg-4+deb7u2
Le jeudi 18 avril 2013 21:46:18, Adam D. Barratt a écrit :
Control: tags 705552 + confirmed
On Thu, 2013-04-18 at 14:54 +0200, Thomas Preud'homme wrote:
Le jeudi 18 avril 2013 14:38:15, Adam D. Barratt a écrit :
Upstream appear to believe it {does,should}n't -
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=704940#32
Oh good. I hadn't time to look at that yet. Should I upload the NMU then?
Please go ahead; thanks.
Done.
Regards,
Adam
Thanks.
Thomas
signature.asc
Description: This is a digitally signed message part.
Re: Bug#702293: unblock: dspam/3.10.1+dfsg-10
Le jeudi 4 avril 2013 22:22:34, Adam D. Barratt a écrit : Control: tags -1 + confirmed On Sun, 2013-03-17 at 17:42 +0100, Thomas Preud'homme wrote: Le jeudi 7 mars 2013 11:10:33, Thomas Preud'homme a écrit : After explaining my problem on IRC, formorer showed me an SQL expression that creates plpgsql only if needed. You'll notice that plpgsql is created with CREATE LANGUAGE because since PostgreSQL 9, plpgsql is created by default. Hence, if it needs to be created the old CREATE LANGUAGE construct should be used. I tried installing dspam with this patch with both PostgreSQL 8.4 from Squeeze and PostgreSQL 9.1 from Wheezy with success. Purging works fine too. If this diff suits you, should I rather upload to tpu with a new changelog entry as in the attached debdiff or merge the entry in the previous one so that only one upload appears to have been done? Forgive me for resending this, I thought maybe this issue had be forgotten. If this is merely a consequence of your work overload, then I send you my full apologize. Please go ahead. Regards, Adam Done. I just added a close for a bug created later about that plpgsql bug. Best regards, Thomas signature.asc Description: This is a digitally signed message part.
Bug#703499: unblock: soprano/2.7.6+dfsg.1-2wheezy1
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
Please unblock package soprano
I just uploaded version 2.7.6+dfsg.1-2wheezy1 which solves a bug where
virtuoso's postinst fails because of soprano. We (José Manuel and
myself) made the upload through tpu because the fixed version in
unstable depends on librdf0 = 1.0.16 (for !hppa) which is not available
in testing. The upload in tpu add the exact same patch as the fixed
package in unstable and has thus been throughly tested.
Below is the full explaination of the bug as found in the patch:
Soprano launches a Virtuoso server using an unix socket (/tmp/virt_
where is the tcp port specified in the configuration file). It tries
first with the /tmp/virt_ port if it's availaible, and if it's not, keeps
trying with above ports one by one until it finds an usuable /tmp/virt_.
Starting with is a very unfortunate choice, because if you start other
virtuoso server configured to use the same port (note that is the
default), then it would fail to start. It should fail and return, but currently
it hangs.
When installing virtuoso-opensource-6.1, the postinst script will try to start
Virtuoso using the default port in order to change the admin password. So
the problem is the following: since the unix socket /tmp/virt_ is (probably)
already being used by the Virtuoso instance started by Soprano, the Virtuoso
instance started by the postinst script would hang (as explained in the
paragraph above), breaking the installation.
Attached is the debdiff of the change.
Best regards,
Thomas Preud'homme
unblock soprano/2.7.6+dfsg.1-2wheezy1
-- System Information:
Debian Release: 7.0
APT prefers unstable
APT policy: (990, 'unstable'), (500, 'stable-updates'), (500, 'testing'),
(500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru soprano-2.7.6+dfsg.1/debian/changelog soprano-2.7.6+dfsg.1/debian/changelog
--- soprano-2.7.6+dfsg.1/debian/changelog 2012-11-27 22:34:30.0 +0100
+++ soprano-2.7.6+dfsg.1/debian/changelog 2013-03-01 16:57:01.0 +0100
@@ -1,3 +1,12 @@
+soprano (2.7.6+dfsg.1-2wheezy1) testing-proposed-updates; urgency=low
+
+ * Team upload.
+ * Upload to testing-proposed-updates.
+ * Add dont_use_virtuoso_default_port.diff, prevents hangs when installing or
+running virtuoso as a standalone server.
+
+ -- José Manuel Santamaría Lema panfa...@gmail.com Fri, 01 Mar 2013 16:56:04 +0100
+
soprano (2.7.6+dfsg.1-2) unstable; urgency=low
* Team upload.
diff -Nru soprano-2.7.6+dfsg.1/debian/patches/dont_use_virtuoso_default_port.diff soprano-2.7.6+dfsg.1/debian/patches/dont_use_virtuoso_default_port.diff
--- soprano-2.7.6+dfsg.1/debian/patches/dont_use_virtuoso_default_port.diff 1970-01-01 01:00:00.0 +0100
+++ soprano-2.7.6+dfsg.1/debian/patches/dont_use_virtuoso_default_port.diff 2013-03-01 16:55:13.0 +0100
@@ -0,0 +1,33 @@
+Author: José Manuel Santamaría Lema panfa...@gmail.com
+Forwarded: https://projects.kde.org/projects/kdesupport/soprano/repository/revisions/3482b5fe
+Description: If possible, don't use the default virtuso port ()
+ Soprano launches a Virtuoso server using an unix socket (/tmp/virt_ where
+ is the tcp port specified in the configuration file). It tries first with
+ the /tmp/virt_ port if it's availaible, and if it's not, keeps trying with
+ above ports one by one until it finds an usuable /tmp/virt_. Starting with
+ is a very unfortunate choice, because if you start other virtuoso server
+ configured to use the same port (note that is the default), then it would
+ fail to start. It should fail and return, but currently it hangs.
+ .
+ When installing virtuoso-opensource-6.1, the postinst script will try to start
+ Virtuoso using the default port in order to change the admin password. So
+ the problem is the following: since the unix socket /tmp/virt_ is
+ (probably) already being used by the Virtuoso instance started by Soprano, the
+ Virtuoso instance started by the postinst script would hang (as explained in
+ the paragraph above), breaking the installation.
+--- a/backends/virtuoso/virtuosocontroller.cpp
b/backends/virtuoso/virtuosocontroller.cpp
+@@ -56,11 +56,11 @@ namespace {
+ // }
+ #ifdef Q_OS_WIN
+ static QMutex portNumberMutex;
+-static quint16 p = ;
++static quint16 p = 1113;
+ QMutexLocker l(portNumberMutex);
+ return p++;
+ #else
+-int p = ;
++int p = 1113;
+ while ( QFile::exists( QString( /tmp/virt_%1 ).arg( p ) ) ) {
+ ++p;
+ }
diff -Nru soprano-2.7.6+dfsg.1/debian/patches/series soprano-2.7.6+dfsg.1/debian/patches/series
--- soprano-2.7.6+dfsg.1/debian
Bug#702293: unblock: dspam/3.10.1+dfsg-10
Le jeudi 7 mars 2013 11:10:33, Thomas Preud'homme a écrit : After explaining my problem on IRC, formorer showed me an SQL expression that creates plpgsql only if needed. You'll notice that plpgsql is created with CREATE LANGUAGE because since PostgreSQL 9, plpgsql is created by default. Hence, if it needs to be created the old CREATE LANGUAGE construct should be used. I tried installing dspam with this patch with both PostgreSQL 8.4 from Squeeze and PostgreSQL 9.1 from Wheezy with success. Purging works fine too. If this diff suits you, should I rather upload to tpu with a new changelog entry as in the attached debdiff or merge the entry in the previous one so that only one upload appears to have been done? Forgive me for resending this, I thought maybe this issue had be forgotten. If this is merely a consequence of your work overload, then I send you my full apologize. Best regards, Thomas diff -Nru dspam-3.10.1+dfsg/debian/changelog dspam-3.10.1+dfsg/debian/changelog --- dspam-3.10.1+dfsg/debian/changelog 2013-03-04 17:39:52.0 +0100 +++ dspam-3.10.1+dfsg/debian/changelog 2013-03-07 11:03:34.0 +0100 @@ -1,6 +1,12 @@ +dspam (3.10.1+dfsg-11) testing-proposed-updates; urgency=low + + * Create plpgsql only if it is not loaded yet. + + -- Thomas Preud'homme robo...@debian.org Thu, 07 Mar 2013 10:25:49 +0100 + dspam (3.10.1+dfsg-10) testing-proposed-updates; urgency=low - * Explicitely require legacy mode for string escaping in PostgreSQL since it + * Explicitly require legacy mode for string escaping in PostgreSQL since it now defaults to standard compliant mode (Closes: #694942). * Fix error when creating database in PostgreSQL by creating plpgsql as extension instead of language. diff -Nru dspam-3.10.1+dfsg/debian/sqlfiles/install-dbadmin/pgsql dspam-3.10.1+dfsg/debian/sqlfiles/install-dbadmin/pgsql --- dspam-3.10.1+dfsg/debian/sqlfiles/install-dbadmin/pgsql 2013-03-04 17:39:52.0 +0100 +++ dspam-3.10.1+dfsg/debian/sqlfiles/install-dbadmin/pgsql 2013-03-07 11:03:34.0 +0100 @@ -1 +1,19 @@ -CREATE EXTENSION IF NOT EXISTS plpgsql; +CREATE OR REPLACE FUNCTION public.create_plpgsql_language () +RETURNS TEXT +AS $$ +CREATE LANGUAGE plpgsql; +SELECT 'language plpgsql created'::TEXT; +$$ +LANGUAGE 'sql'; + +SELECT CASE WHEN + (SELECT true::BOOLEAN + FROM pg_language +WHERE lanname='plpgsql') +THEN + (SELECT 'language already installed'::TEXT) +ELSE + (SELECT public.create_plpgsql_language()) +END; + +DROP FUNCTION public.create_plpgsql_language (); signature.asc Description: This is a digitally signed message part.
Bug#702293: unblock: dspam/3.10.1+dfsg-10
After explaining my problem on IRC, formorer showed me an SQL expression that creates plpgsql only if needed. You'll notice that plpgsql is created with CREATE LANGUAGE because since PostgreSQL 9, plpgsql is created by default. Hence, if it needs to be created the old CREATE LANGUAGE construct should be used. I tried installing dspam with this patch with both PostgreSQL 8.4 from Squeeze and PostgreSQL 9.1 from Wheezy with success. Purging works fine too. If this diff suits you, should I rather upload to tpu with a new changelog entry as in the attached debdiff or merge the entry in the previous one so that only one upload appears to have been done? Best regards, Thomas diff -Nru dspam-3.10.1+dfsg/debian/changelog dspam-3.10.1+dfsg/debian/changelog --- dspam-3.10.1+dfsg/debian/changelog 2013-03-04 17:39:52.0 +0100 +++ dspam-3.10.1+dfsg/debian/changelog 2013-03-07 11:03:34.0 +0100 @@ -1,6 +1,12 @@ +dspam (3.10.1+dfsg-11) testing-proposed-updates; urgency=low + + * Create plpgsql only if it is not loaded yet. + + -- Thomas Preud'homme robo...@debian.org Thu, 07 Mar 2013 10:25:49 +0100 + dspam (3.10.1+dfsg-10) testing-proposed-updates; urgency=low - * Explicitely require legacy mode for string escaping in PostgreSQL since it + * Explicitly require legacy mode for string escaping in PostgreSQL since it now defaults to standard compliant mode (Closes: #694942). * Fix error when creating database in PostgreSQL by creating plpgsql as extension instead of language. diff -Nru dspam-3.10.1+dfsg/debian/sqlfiles/install-dbadmin/pgsql dspam-3.10.1+dfsg/debian/sqlfiles/install-dbadmin/pgsql --- dspam-3.10.1+dfsg/debian/sqlfiles/install-dbadmin/pgsql 2013-03-04 17:39:52.0 +0100 +++ dspam-3.10.1+dfsg/debian/sqlfiles/install-dbadmin/pgsql 2013-03-07 11:03:34.0 +0100 @@ -1 +1,19 @@ -CREATE EXTENSION IF NOT EXISTS plpgsql; +CREATE OR REPLACE FUNCTION public.create_plpgsql_language () +RETURNS TEXT +AS $$ +CREATE LANGUAGE plpgsql; +SELECT 'language plpgsql created'::TEXT; +$$ +LANGUAGE 'sql'; + +SELECT CASE WHEN + (SELECT true::BOOLEAN + FROM pg_language +WHERE lanname='plpgsql') +THEN + (SELECT 'language already installed'::TEXT) +ELSE + (SELECT public.create_plpgsql_language()) +END; + +DROP FUNCTION public.create_plpgsql_language (); signature.asc Description: This is a digitally signed message part.
Bug#702293: unblock: dspam/3.10.1+dfsg-10
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
Please unblock package dspam
dspam in version 3.10.1 uses legacy mode for string escaping in
PostgreSQL while PostgreSQL in wheezy defaults to standard-compliant
mode. This means insertion in the database fail and dspam cannot be
trained. While documenting it in the release notes, Julien Cristau
remarked that documenting the problem is ridiculous and this should be
fixed instead. He also kindly provided a patch, which after tests
compiles and works. I thus considered it as an indication the fix is
suitable for a tpu upload (since it can't go through unstable).
While doing the testing I noticed that installation of
libdspam7-drv-pgsql gives an error because it create the language
plpgsql while in PostgreSQL 9.1 it should be created as an extension.
The error can be ignored but it is misleading for the user. I thus took
the liberty to include the patch to save some email round trip time.
I'll be happy to reupload without that fix if you feel I was wrong.
Best regards.
unblock dspam/4.10.1+dfsg-10
-- System Information:
Debian Release: 7.0
APT prefers unstable
APT policy: (990, 'unstable'), (500, 'stable-updates'), (500, 'testing'),
(500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru dspam-3.10.1+dfsg/debian/changelog dspam-3.10.1+dfsg/debian/changelog
--- dspam-3.10.1+dfsg/debian/changelog 2013-02-28 21:34:52.0 +0100
+++ dspam-3.10.1+dfsg/debian/changelog 2013-03-04 17:39:52.0 +0100
@@ -1,3 +1,12 @@
+dspam (3.10.1+dfsg-10) testing-proposed-updates; urgency=low
+
+ * Explicitely require legacy mode for string escaping in PostgreSQL since it
+now defaults to standard compliant mode (Closes: #694942).
+ * Fix error when creating database in PostgreSQL by creating plpgsql as
+extension instead of language.
+
+ -- Thomas Preud'homme robo...@debian.org Mon, 04 Mar 2013 13:56:45 +0100
+
dspam (3.10.1+dfsg-9) testing-proposed-updates; urgency=low
* Add a new version of the patch fixing recipient corruption when releasing
diff -Nru dspam-3.10.1+dfsg/debian/patches/010_set_legacy_escape_strings.diff dspam-3.10.1+dfsg/debian/patches/010_set_legacy_escape_strings.diff
--- dspam-3.10.1+dfsg/debian/patches/010_set_legacy_escape_strings.diff 1970-01-01 01:00:00.0 +0100
+++ dspam-3.10.1+dfsg/debian/patches/010_set_legacy_escape_strings.diff 2013-03-04 17:39:52.0 +0100
@@ -0,0 +1,17 @@
+diff --git a/src/pgsql_drv.c b/src/pgsql_drv.c
+index eac2354..b110a3f 100644
+--- a/src/pgsql_drv.c
b/src/pgsql_drv.c
+@@ -3175,6 +3175,12 @@ PGconn *_pgsql_drv_connect(DSPAM_CTX *CTX)
+ return NULL;
+ }
+
++ if (PQserverVersion(dbh) = 90100)
++ {
++PGresult *result = PQexec(dbh, SET standard_conforming_strings TO off;);
++if (result)
++ PQclear(result);
++ }
+ return dbh;
+
+ FAILURE:
diff -Nru dspam-3.10.1+dfsg/debian/patches/series dspam-3.10.1+dfsg/debian/patches/series
--- dspam-3.10.1+dfsg/debian/patches/series 2013-02-28 21:34:52.0 +0100
+++ dspam-3.10.1+dfsg/debian/patches/series 2013-03-04 17:39:52.0 +0100
@@ -7,3 +7,4 @@
007_ctime.pl.diff
008_fix_exim_integration_doc.diff
009_fix_recipient_corruption_when_releasing_message_from_quarantine.diff
+010_set_legacy_escape_strings.diff
diff -Nru dspam-3.10.1+dfsg/debian/sqlfiles/install-dbadmin/pgsql dspam-3.10.1+dfsg/debian/sqlfiles/install-dbadmin/pgsql
--- dspam-3.10.1+dfsg/debian/sqlfiles/install-dbadmin/pgsql 2013-02-28 21:34:52.0 +0100
+++ dspam-3.10.1+dfsg/debian/sqlfiles/install-dbadmin/pgsql 2013-03-04 17:39:52.0 +0100
@@ -1 +1 @@
-CREATE LANGUAGE plpgsql;
+CREATE EXTENSION IF NOT EXISTS plpgsql;
Bug#702293: unblock: dspam/3.10.1+dfsg-10
Le lundi 4 mars 2013 22:15:36, Julien Cristau a écrit : On Mon, Mar 4, 2013 at 21:41:03 +0100, Thomas Preud'homme wrote: While doing the testing I noticed that installation of libdspam7-drv-pgsql gives an error because it create the language plpgsql while in PostgreSQL 9.1 it should be created as an extension. The error can be ignored but it is misleading for the user. I thus took the liberty to include the patch to save some email round trip time. I'll be happy to reupload without that fix if you feel I was wrong. What does that do on older pgsql? Same error as with CREATE LANGUAGE on Wheezy's PostgreSQL. Maybe the VERSION mentionned in [1] can be used as well for install-admin. If not, would an entry in the release notes be enough? A NEWS entry would be useless as it wouldn't give a way to cancel the installation. [1] http://people.debian.org/~seanius/policy/dbconfig-common.html/ch- develguide.html §3.2.3 Cheers, Julien Best regards, Thomas signature.asc Description: This is a digitally signed message part.
Bug#702293: unblock: dspam/3.10.1+dfsg-10
Le lundi 4 mars 2013 22:45:43, Thomas Preud'homme a écrit : Le lundi 4 mars 2013 22:15:36, Julien Cristau a écrit : On Mon, Mar 4, 2013 at 21:41:03 +0100, Thomas Preud'homme wrote: While doing the testing I noticed that installation of libdspam7-drv-pgsql gives an error because it create the language plpgsql while in PostgreSQL 9.1 it should be created as an extension. The error can be ignored but it is misleading for the user. I thus took the liberty to include the patch to save some email round trip time. I'll be happy to reupload without that fix if you feel I was wrong. What does that do on older pgsql? Same error as with CREATE LANGUAGE on Wheezy's PostgreSQL. Maybe the VERSION mentionned in [1] can be used as well for install-admin. Oups not it can't. It's a version in the package using dbconfig-common, not a version of the database. Do you know if a conditional SQL can be used depending on the version of postgresql? Regards, Thomas signature.asc Description: This is a digitally signed message part.
Bug#701178: preapproval unblock: dspam/dspam/3.10.1+dfsg-9
Le vendredi 1 mars 2013 14:00:07, Julien Cristau a écrit :
Actually...
Seems like ATX-recipient now points somewhere on the stack, and thus in
la-la-land at the end of the loop in process_users. Is there any
guarantee it's not reused after that? The scoping is kind of
non-obvious...
Indeed, it's not obvious. So ATX-recipient points to one of 3 buffers:
* args[1024] in deliver_message()
* recipient[256] in the main while loop of process_users()
* mailbox[256] in process_users()
I've checked all the place where recipient is used (grep -ERIn recipient |
grep ^src) and it's used only in 5 functions:
client_connect(), deliver_socket(), process_message(), deliver_message() and
process_users().
deliver_socket(), process_message and deliver_message() are called directly or
indirectly by process_users().
client_connect() can be called by deliver_socket() (and thus indirectly by
process_users()) but also by the main() of dspam.c or the main() of dspamc.c
in which case recipient is not set and should be NULL.
So when recipient points to recipient[256] or mailbox[256] there is no problem
as the buffer is still in the scope.
For args[1024], I'm not 100% sure because that would require to follow all the
use of ATX but looking at the code of deliver_message it's used to do some
temporary transformation on the text which is used later in the function.
Hence ATX-recipient always points to a valid buffer (not overwritten on the
stack by returing and then calling another function). Attached are my notes in
case you want to take a look.
Cheers,
Julien
Best regards,
Thomas
client_connect() src/client.c:318:if (ATX-recipient
ATX-recipient[0]) {
client_connect() src/client.c:319: char *domain = strchr(ATX-recipient,
'@');
client_connect() src/client.c:322:char
lcdomain[strlen(ATX-recipient)];
deliver_socket() src/client.c:844: snprintf(buf, sizeof(buf), RCPT
TO:%s, (ATX-recipient) ? ATX-recipient : );
process_message() src/dspam.c:503:strlcpy(ATX-recipient,
CTX-username, 256);
deliver_message() src/dspam.c:925:strlcpy(args, ATX-recipient,
sizeof(args));
deliver_message() src/dspam.c:937:arg=index(ATX-recipient, '@');
deliver_message() src/dspam.c:940:ATX-recipient=args;
deliver_message() src/dspam.c:998: if (ATX-recipient)
deliver_message() src/dspam.c:999:strlcpy(a, ATX-recipient,
sizeof(a));
process_users()src/dspam.c:1625:char recipient[256];
process_users()src/dspam.c:1664: strlcpy(recipient, node_rcpt-ptr,
sizeof(recipient));
process_users()src/dspam.c:1672: strlcpy(recipient, node_nt-ptr,
sizeof(recipient));
process_users()src/dspam.c:1674:ATX-recipient = recipient;
process_users()src/dspam.c:1684: ATX-recipient = mailbox;
*** in src/daemon.c ***
process_connection() calls:
process_users()
*** in src/dspamc.c ***
main() calls:
client_process()
*** in src/client.c ***
client_process() calls:
client_connect()
deliver_socket() calls:
client_connect()
*** in src/dspam.c ***
main() calls (in src/dspam.c):
process_users()
client_process()
process_users() calls:
process_message() 4 times
deliver_message() 5 times
send_notice() calls:
deliver_message()
deliver_message() calls:
deliver_socket()
src/dspam.c:503 in process_users
src/dspam.c:940 in deliver_message
src/dspam.c:1674 in process_users
src/dspam.c:1684 in process_users
signature.asc
Description: This is a digitally signed message part.
Bug#701178: preapproval unblock: dspam/dspam/3.10.1+dfsg-9
Le jeudi 28 février 2013 20:56:54, Julien Cristau a écrit :
That debdiff is for 3.10.2 in sid. Do you have one for 3.10.1?
Sure, sorry. Here you are.
Pretty much the same except for the offsets. :)
Thanks,
Julien
Best regards,
Thomas
diff -Nru dspam-3.10.1+dfsg/debian/changelog dspam-3.10.1+dfsg/debian/changelog
--- dspam-3.10.1+dfsg/debian/changelog 2013-01-22 13:38:35.0 +0100
+++ dspam-3.10.1+dfsg/debian/changelog 2013-02-28 21:34:52.0 +0100
@@ -1,3 +1,10 @@
+dspam (3.10.1+dfsg-9) testing-proposed-updates; urgency=low
+
+ * Add a new version of the patch fixing recipient corruption when releasing
+a message from quarantine (Closes: #698136).
+
+ -- Thomas Preud'homme robo...@debian.org Thu, 28 Feb 2013 21:33:50 +0100
+
dspam (3.10.1+dfsg-8) testing-proposed-updates; urgency=low
* Stop shipping ucf template as a conffile: this avoid unnecessary prompt
diff -Nru dspam-3.10.1+dfsg/debian/patches/009_fix_recipient_corruption_when_releasing_message_from_quarantine.diff dspam-3.10.1+dfsg/debian/patches/009_fix_recipient_corruption_when_releasing_message_from_quarantine.diff
--- dspam-3.10.1+dfsg/debian/patches/009_fix_recipient_corruption_when_releasing_message_from_quarantine.diff 1970-01-01 01:00:00.0 +0100
+++ dspam-3.10.1+dfsg/debian/patches/009_fix_recipient_corruption_when_releasing_message_from_quarantine.diff 2013-02-28 21:34:52.0 +0100
@@ -0,0 +1,55 @@
+Description: Fix recipient corruption when releasing a message from quarantine
+
+When releasing mail from quarantine, dspam corrupts the FROM part in the
+SMTP/LMTP handshake.
+
+Author: Allan Ievers aimail-dspam_us...@rearden.com
+Origin: vendor
+Bug-Debian: http://bugs.debian.org/698136
+Forwarded: ste...@bajic.ch
+Last-Update: 2013-02-28
+
+diff --git a/src/dspam.c b/src/dspam.c
+index 26266c9..68e1165 100644
+--- a/src/dspam.c
b/src/dspam.c
+@@ -498,8 +498,9 @@ process_message (
+ ATX-train_pristine = 1;
+ }
+
+-/* Change also the mail recipient */
+-ATX-recipient = CTX-username;
++/* Change also the mail recipient. ATX-recipient either points to
++ * recipient[] or mailbox[] in process_users, hence the size of 256 */
++strlcpy(ATX-recipient, CTX-username, 256);
+
+ }
+ }
+@@ -1621,6 +1622,7 @@ int process_users(AGENT_CTX *ATX, buffer *message) {
+ char filename[MAX_FILENAME_LENGTH];
+ int optin, optout;
+ char *username = NULL;
++char recipient[256];
+
+ /* If ServerParameters specifies a --user, there will only be one
+ * instance on the stack, but possible multiple recipients. So we
+@@ -1659,7 +1661,7 @@ int process_users(AGENT_CTX *ATX, buffer *message) {
+ username = node_nt-ptr;
+
+ if (node_rcpt) {
+- ATX-recipient = node_rcpt-ptr;
++ strlcpy(recipient, node_rcpt-ptr, sizeof(recipient));
+ node_rcpt = c_nt_next (ATX-recipients, c_rcpt);
+ } else {
+
+@@ -1667,8 +1669,9 @@ int process_users(AGENT_CTX *ATX, buffer *message) {
+ if (have_rcpts)
+ break;
+
+- ATX-recipient = node_nt-ptr;
++ strlcpy(recipient, node_nt-ptr, sizeof(recipient));
+ }
++ATX-recipient = recipient;
+
+ /* If support for +detail is enabled, save full mailbox name for
+ delivery and strip detail for processing */
diff -Nru dspam-3.10.1+dfsg/debian/patches/series dspam-3.10.1+dfsg/debian/patches/series
--- dspam-3.10.1+dfsg/debian/patches/series 2013-01-22 13:38:35.0 +0100
+++ dspam-3.10.1+dfsg/debian/patches/series 2013-02-28 21:34:52.0 +0100
@@ -6,3 +6,4 @@
006_default-daemon-port.diff
007_ctime.pl.diff
008_fix_exim_integration_doc.diff
+009_fix_recipient_corruption_when_releasing_message_from_quarantine.diff
signature.asc
Description: This is a digitally signed message part.
Bug#701178: preapproval unblock: dspam/dspam/3.10.1+dfsg-9
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
Please unblock package dspam
[Sorry Jonathan for the duplicate]
Current dspam is affected by a corruption of message headers when
releasing from quarantine. This has for effect that mails are lost when
releasing from quarantine. A patch has been commited upstream but there
is some concern about buffer overflow. Hence, although the patch was
initially backported in sid, it was subsequently removed. See [1] for
the previous discussion.
[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=698701#32
Today I've been working on a patch to solve the problem without security
concern. The patch is not pretty, I know it, but it should do its job.
The patch makes sure recipient points to an area of size at least 256
bytes. It wasn't always the case initially. The list of place where
recipient pointer is set is:
% egrep -RIn recipient[^s]*= src
src/dspam.c:503:ATX-recipient = CTX-username;
src/dspam.c:948:ATX-recipient=args;
src/dspam.c:1675: ATX-recipient = node_rcpt-ptr;
src/dspam.c:1683: ATX-recipient = node_nt-ptr;
src/dspam.c:1694: ATX-recipient = mailbox;
mailbox and args are of respective size 256 and 1024 bytes.
node_rcpt-ptr and node_nt-ptr on the other hand are exactly the size
of the string. They are allocated when calling nt_add (which call
nt_node_create).
Thus, the approach is to copy node_rcpt-ptr and node_nt-ptr into an
array of size 256 as well and this size can be used to limit the strlcpy
when copying CTX-username to ATX-recipient. I don't like to hardcode
the size but didn't find anything better for now. I'll forward upstream
and let him find a long term solution.
See attached debdiff for details.
Would you agree for an upload of this new package to tpu with sufficient
testing in unstable before?
unblock dspam/dspam/3.10.1+dfsg-9
-- System Information:
Debian Release: 7.0
APT prefers unstable
APT policy: (990, 'unstable'), (500, 'stable-updates'), (500, 'testing'),
(500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru dspam-3.10.2+dfsg/debian/changelog dspam-3.10.2+dfsg/debian/changelog
--- dspam-3.10.2+dfsg/debian/changelog 2013-02-11 14:55:20.0 +0100
+++ dspam-3.10.2+dfsg/debian/changelog 2013-02-22 11:54:57.0 +0100
@@ -1,3 +1,10 @@
+dspam (3.10.2+dfsg-7) unstable; urgency=low
+
+ * Add a new version of the patch fixing recipient corruption when releasing
+a message from quarantine (Closes: #698136).
+
+ -- Thomas Preud'homme robo...@debian.org Fri, 22 Feb 2013 11:28:17 +0100
+
dspam (3.10.2+dfsg-6) unstable; urgency=low
* Drop patch fixing recipient corruption when releasing a message from
diff -Nru dspam-3.10.2+dfsg/debian/patches/009_fix_recipient_corruption_when_releasing_message_from_quarantine.diff dspam-3.10.2+dfsg/debian/patches/009_fix_recipient_corruption_when_releasing_message_from_quarantine.diff
--- dspam-3.10.2+dfsg/debian/patches/009_fix_recipient_corruption_when_releasing_message_from_quarantine.diff 1970-01-01 01:00:00.0 +0100
+++ dspam-3.10.2+dfsg/debian/patches/009_fix_recipient_corruption_when_releasing_message_from_quarantine.diff 2013-02-22 11:54:57.0 +0100
@@ -0,0 +1,53 @@
+Description: Fix recipient corruption when releasing a message from quarantine
+
+When releasing mail from quarantine, dspam corrupts the FROM part in the
+SMTP/LMTP handshake.
+
+Author: Allan Ievers aimail-dspam_us...@rearden.com
+Origin: vendor
+Bug-Debian: http://bugs.debian.org/698136
+Forwarded: no
+Last-Update: 2013-01-14
+
+--- a/src/dspam.c
b/src/dspam.c
+@@ -499,8 +499,9 @@ process_message (
+ ATX-train_pristine = 1;
+ }
+
+-/* Change also the mail recipient */
+-ATX-recipient = CTX-username;
++/* Change also the mail recipient. ATX-recipient either points to
++ * recipient[] or mailbox[] in process_users, hence the size of 256 */
++strlcpy(ATX-recipient, CTX-username, 256);
+
+ }
+ }
+@@ -1634,6 +1635,7 @@ int process_users(AGENT_CTX *ATX, buffer *message) {
+ char filename[MAX_FILENAME_LENGTH];
+ int optin, optout;
+ char *username = NULL;
++char recipient[256];
+
+ /* If ServerParameters specifies a --user, there will only be one
+ * instance on the stack, but possible multiple recipients. So we
+@@ -1672,7 +1674,7 @@ int process_users(AGENT_CTX *ATX, buffer *message) {
+ username = node_nt-ptr;
+
+ if (node_rcpt) {
+- ATX-recipient = node_rcpt-ptr;
++ strlcpy(recipient, node_rcpt-ptr, sizeof(recipient));
+ node_rcpt = c_nt_next (ATX-recipients, c_rcpt);
+ } else {
+
+@@ -1680,8 +1682,9 @@ int process_users(AGENT_CTX *ATX, buffer *message) {
+ if (have_rcpts
Bug#698701: tpu: dspam/3.10.1+dfsg-8
Subject: unblock: dspam/3.10.1+dfsg-9
Package: release.debian.org
User: release.debian@packages.debian.org
Usertags: unblock
Severity: normal
This mail follow the discussion with Jonathan Wiltshire in bug #698701 [1],
hence the In-Reply-To.
[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=698701#32
Le lundi 11 février 2013 23:45:46, Thomas Preud'homme a écrit :
I'd rather have a fix though.
I came up with this patch.
% egrep -RIn recipient[^s]*= src
src/dspam.c:503:ATX-recipient = CTX-username;
src/dspam.c:948:ATX-recipient=args;
src/dspam.c:1675: ATX-recipient = node_rcpt-ptr;
src/dspam.c:1683: ATX-recipient = node_nt-ptr;
src/dspam.c:1694: ATX-recipient = mailbox;
mailbox and args are of respective size 256 and 1024 bytes. node_rcpt-ptr and
node_nt-ptr on the other hand are exactly the size of the string. They are
allocated when calling nt_add (which call nt_node_create).
Thus, the approach is to copy node_rcpt-ptr and node_nt-ptr into an array of
size 256 as well and this size can be used to limit the strlcpy when copying
CTX-username to ATX-recipient. I don't like to hardcode the size but didn't
find anything better for now. I'll forward upstream and let him find a long
term
solution.
Would you agree for an upload to tpu with sufficient testing in unstable before?
Best regards,
Thomas
diff -Nru dspam-3.10.2+dfsg/debian/changelog dspam-3.10.2+dfsg/debian/changelog
--- dspam-3.10.2+dfsg/debian/changelog 2013-02-11 14:55:20.0 +0100
+++ dspam-3.10.2+dfsg/debian/changelog 2013-02-22 11:54:57.0 +0100
@@ -1,3 +1,10 @@
+dspam (3.10.2+dfsg-7) unstable; urgency=low
+
+ * Add a new version of the patch fixing recipient corruption when releasing
+a message from quarantine (Closes: #698136).
+
+ -- Thomas Preud'homme robo...@debian.org Fri, 22 Feb 2013 11:28:17 +0100
+
dspam (3.10.2+dfsg-6) unstable; urgency=low
* Drop patch fixing recipient corruption when releasing a message from
diff -Nru dspam-3.10.2+dfsg/debian/patches/009_fix_recipient_corruption_when_releasing_message_from_quarantine.diff dspam-3.10.2+dfsg/debian/patches/009_fix_recipient_corruption_when_releasing_message_from_quarantine.diff
--- dspam-3.10.2+dfsg/debian/patches/009_fix_recipient_corruption_when_releasing_message_from_quarantine.diff 1970-01-01 01:00:00.0 +0100
+++ dspam-3.10.2+dfsg/debian/patches/009_fix_recipient_corruption_when_releasing_message_from_quarantine.diff 2013-02-22 11:54:57.0 +0100
@@ -0,0 +1,53 @@
+Description: Fix recipient corruption when releasing a message from quarantine
+
+When releasing mail from quarantine, dspam corrupts the FROM part in the
+SMTP/LMTP handshake.
+
+Author: Allan Ievers aimail-dspam_us...@rearden.com
+Origin: vendor
+Bug-Debian: http://bugs.debian.org/698136
+Forwarded: no
+Last-Update: 2013-01-14
+
+--- a/src/dspam.c
b/src/dspam.c
+@@ -499,8 +499,9 @@ process_message (
+ ATX-train_pristine = 1;
+ }
+
+-/* Change also the mail recipient */
+-ATX-recipient = CTX-username;
++/* Change also the mail recipient. ATX-recipient either points to
++ * recipient[] or mailbox[] in process_users, hence the size of 256 */
++strlcpy(ATX-recipient, CTX-username, 256);
+
+ }
+ }
+@@ -1634,6 +1635,7 @@ int process_users(AGENT_CTX *ATX, buffer *message) {
+ char filename[MAX_FILENAME_LENGTH];
+ int optin, optout;
+ char *username = NULL;
++char recipient[256];
+
+ /* If ServerParameters specifies a --user, there will only be one
+ * instance on the stack, but possible multiple recipients. So we
+@@ -1672,7 +1674,7 @@ int process_users(AGENT_CTX *ATX, buffer *message) {
+ username = node_nt-ptr;
+
+ if (node_rcpt) {
+- ATX-recipient = node_rcpt-ptr;
++ strlcpy(recipient, node_rcpt-ptr, sizeof(recipient));
+ node_rcpt = c_nt_next (ATX-recipients, c_rcpt);
+ } else {
+
+@@ -1680,8 +1682,9 @@ int process_users(AGENT_CTX *ATX, buffer *message) {
+ if (have_rcpts)
+ break;
+
+- ATX-recipient = node_nt-ptr;
++ strlcpy(recipient, node_nt-ptr, sizeof(recipient));
+ }
++ATX-recipient = recipient;
+
+ /* If support for +detail is enabled, save full mailbox name for
+ delivery and strip detail for processing */
diff -Nru dspam-3.10.2+dfsg/debian/patches/series dspam-3.10.2+dfsg/debian/patches/series
--- dspam-3.10.2+dfsg/debian/patches/series 2013-02-11 14:55:20.0 +0100
+++ dspam-3.10.2+dfsg/debian/patches/series 2013-02-22 11:54:57.0 +0100
@@ -5,3 +5,4 @@
006_default-daemon-port.diff
007_process_quarantine_if_spanish.diff
008_fix_exim_integration_doc.diff
+009_fix_recipient_corruption_when_releasing_message_from_quarantine.diff
signature.asc
Description: This is a digitally signed message part.
Bug#698701: tpu: dspam/3.10.1+dfsg-8
Le dimanche 3 février 2013 14:51:39, Thomas Preud'homme a écrit : Anyway, I tried to get certainty by reading the code to see any assumption the code is using but I couldn't understand enough of the code. So I reached upstream and he shall give me an explanation about wether it's safe or not and why in the next days. I pinged again upstream last wednesday without answer. Given the risk, I'm going to drop the patch for the recipient corruption. I don't like it but it's not a regression and the bug is only of severity important. Anyway, the package had around 3 weeks of testing in unstable so I proceeded with the upload to tpu. The changes only include the fix for the ucf RC bug issue. See attached debdiff. I'll get back to you asap. Best regards. Thomas By the way, my condolence for entering the RT ;-) Best regards, Thomas diff -Nru dspam-3.10.1+dfsg/debian/changelog dspam-3.10.1+dfsg/debian/changelog --- dspam-3.10.1+dfsg/debian/changelog 2013-01-19 21:11:32.0 +0100 +++ dspam-3.10.1+dfsg/debian/changelog 2013-01-22 13:38:35.0 +0100 @@ -1,3 +1,11 @@ +dspam (3.10.1+dfsg-8) testing-proposed-updates; urgency=low + + * Stop shipping ucf template as a conffile: this avoid unnecessary prompt +when upgrading if configuration files have not been modified by the user +(Closes: #698580). + + -- Thomas Preud'homme robo...@debian.org Mon, 21 Jan 2013 22:25:00 +0100 + dspam (3.10.1+dfsg-7) testing-proposed-updates; urgency=low * Disable multi-arch since it create many problems with regards to the diff -Nru dspam-3.10.1+dfsg/debian/libdspam7-drv-mysql.dirs dspam-3.10.1+dfsg/debian/libdspam7-drv-mysql.dirs --- dspam-3.10.1+dfsg/debian/libdspam7-drv-mysql.dirs 2013-01-19 21:11:32.0 +0100 +++ dspam-3.10.1+dfsg/debian/libdspam7-drv-mysql.dirs 2013-01-22 13:38:35.0 +0100 @@ -1,3 +1,4 @@ etc/dspam/dspam.d +usr/share/libdspam7-drv-mysql usr/share/dbconfig-common/data/libdspam7-drv-mysql/install usr/share/dbconfig-common/data/libdspam7-drv-mysql/upgrade diff -Nru dspam-3.10.1+dfsg/debian/libdspam7-drv-mysql.install.in dspam-3.10.1+dfsg/debian/libdspam7-drv-mysql.install.in --- dspam-3.10.1+dfsg/debian/libdspam7-drv-mysql.install.in 2013-01-19 21:11:32.0 +0100 +++ dspam-3.10.1+dfsg/debian/libdspam7-drv-mysql.install.in 2013-01-22 13:38:35.0 +0100 @@ -1,7 +1,7 @@ debian/sqlfiles/install/mysql usr/share/dbconfig-common/data/libdspam7-drv-mysql/install debian/sqlfiles/upgrade/mysql usr/share/dbconfig-common/data/libdspam7-drv-mysql/upgrade usr/lib/@DEB_HOST_MULTIARCH@/dspam/libmysql_drv.so* -src/mysql.confetc/dspam/dspam.d/ +src/mysql.confusr/share/libdspam7-drv-mysql src/tools.mysql_drv/mysql_objects-4.1.sql usr/share/doc/libdspam7-drv-mysql/sql/ src/tools.mysql_drv/purge-4.1.sql usr/share/doc/libdspam7-drv-mysql/sql/ src/tools.mysql_drv/virtual_user_aliases.sql usr/share/doc/libdspam7-drv-mysql/sql/ diff -Nru dspam-3.10.1+dfsg/debian/libdspam7-drv-mysql.postinst dspam-3.10.1+dfsg/debian/libdspam7-drv-mysql.postinst --- dspam-3.10.1+dfsg/debian/libdspam7-drv-mysql.postinst 2013-01-19 21:11:32.0 +0100 +++ dspam-3.10.1+dfsg/debian/libdspam7-drv-mysql.postinst 2013-01-22 13:38:35.0 +0100 @@ -9,7 +9,7 @@ # Set some variables dbc_generate_include=template:/etc/dspam/dspam.d/mysql.conf -dbc_generate_include_args=-U -o template_infile='/etc/dspam/dspam.d/mysql.conf' +dbc_generate_include_args=-U -o template_infile='/usr/share/libdspam7-drv-mysql/mysql.conf' # Run dbconfig dbc_go libdspam7-drv-mysql $@ diff -Nru dspam-3.10.1+dfsg/debian/libdspam7-drv-pgsql.dirs dspam-3.10.1+dfsg/debian/libdspam7-drv-pgsql.dirs --- dspam-3.10.1+dfsg/debian/libdspam7-drv-pgsql.dirs 2013-01-19 21:11:32.0 +0100 +++ dspam-3.10.1+dfsg/debian/libdspam7-drv-pgsql.dirs 2013-01-22 13:38:35.0 +0100 @@ -1,4 +1,5 @@ etc/dspam/dspam.d +usr/share/libdspam7-drv-pgsql usr/share/dbconfig-common/data/libdspam7-drv-pgsql/install usr/share/dbconfig-common/data/libdspam7-drv-pgsql/upgrade usr/share/dbconfig-common/data/libdspam7-drv-pgsql/install-dbadmin diff -Nru dspam-3.10.1+dfsg/debian/libdspam7-drv-pgsql.install.in dspam-3.10.1+dfsg/debian/libdspam7-drv-pgsql.install.in --- dspam-3.10.1+dfsg/debian/libdspam7-drv-pgsql.install.in 2013-01-19 21:11:32.0 +0100 +++ dspam-3.10.1+dfsg/debian/libdspam7-drv-pgsql.install.in 2013-01-22 13:38:35.0 +0100 @@ -2,7 +2,7 @@ debian/sqlfiles/install/pgsql usr/share/dbconfig-common/data/libdspam7-drv-pgsql/install debian/sqlfiles/upgrade/pgsql usr/share/dbconfig-common/data/libdspam7-drv-pgsql/upgrade usr/lib/@DEB_HOST_MULTIARCH@/dspam/libpgsql_drv.so* -src/pgsql.conf etc/dspam/dspam.d/ +src/pgsql.conf usr/share/libdspam7-drv-pgsql src/tools.pgsql_drv/pgsql_objects.sql usr/share/doc
Bug#698701: tpu: dspam/3.10.1+dfsg-8
Jonathan Wiltshire j...@debian.org wrote:
On Tue, Jan 22, 2013 at 04:23:43PM +, Jonathan Wiltshire wrote:
On 2013-01-22 13:15, Thomas Preud'homme wrote:
Sorry to come again with an issue on dspam again. This time it's
about
bug #698580 - useless prompting at upgrade when no configuration
file
have been modified. A mistake was made which made
/etc/dspam/dspam.d/{pgsql,mysql}.conf be conffiles and yet managed
by
ucf. This patch move ucf template from /etc to /usr/share
subdirectories
to avoid them being conffiles. See attached debdiff for the details
(avoid_useless_prompt.debdiff).
As before, the package being different in testing and sid, the fix
would
have to go through tpu. The fix has just been uploaded to sid for
more
testing.
I would also like to include the fix for #698136. I know it's only
of
severity important but it's a simple oneliner fix so maybe you'll
agree
for it anyway. See [1] for the patch.
[1]
http://patch-tracker.debian.org/patch/series/view/dspam/3.10.2+dfsg-4/009_fix_recipient_corruption_when_releasing_message_from_quarantine.diff
I'm happy with both these changes provided they have had sufficient
testing in unstable first. (I presume the destination in the
strcpy() call is large enough not to overflow?)
Ping?
Sorry, I've been busy recently. The overflow is a very good remark which I
should have wondered myself. I didn't because I took the patch upstream and it
was reviewed by the main upstream author. Also I was probably absent minded.
Anyway, I tried to get certainty by reading the code to see any assumption the
code is using but I couldn't understand enough of the code. So I reached
upstream and he shall give me an explanation about wether it's safe or not and
why in the next days.
I'll get back to you asap.
Best regards.
Thomas
By the way, my condolence for entering the RT ;-)
--
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/8db3f3b2-e6e9-48d6-a547-5dfad4084...@email.android.com
Bug#698701: tpu: dspam/3.10.1+dfsg-8
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
Please unblock package dspam
Sorry to come again with an issue on dspam again. This time it's about
bug #698580 - useless prompting at upgrade when no configuration file
have been modified. A mistake was made which made
/etc/dspam/dspam.d/{pgsql,mysql}.conf be conffiles and yet managed by
ucf. This patch move ucf template from /etc to /usr/share subdirectories
to avoid them being conffiles. See attached debdiff for the details
(avoid_useless_prompt.debdiff).
As before, the package being different in testing and sid, the fix would
have to go through tpu. The fix has just been uploaded to sid for more
testing.
I would also like to include the fix for #698136. I know it's only of
severity important but it's a simple oneliner fix so maybe you'll agree
for it anyway. See [1] for the patch.
[1]
http://patch-tracker.debian.org/patch/series/view/dspam/3.10.2+dfsg-4/009_fix_recipient_corruption_when_releasing_message_from_quarantine.diff
Best regards,
Thomas Preud'homme
unblock dspam/3.10.1+dfsg-8
-- System Information:
Debian Release: 7.0
APT prefers unstable
APT policy: (990, 'unstable'), (500, 'stable-updates'), (500, 'testing'),
(500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru dspam-3.10.1+dfsg/debian/changelog dspam-3.10.1+dfsg/debian/changelog
--- dspam-3.10.1+dfsg/debian/changelog 2013-01-19 21:11:32.0 +0100
+++ dspam-3.10.1+dfsg/debian/changelog 2013-01-22 13:38:35.0 +0100
@@ -1,3 +1,11 @@
+dspam (3.10.1+dfsg-8) testing-proposed-updates; urgency=low
+
+ * Stop shipping ucf template as a conffile: this avoid unnecessary prompt
+when upgrading if configuration files have not been modified by the user
+(Closes: #698580).
+
+ -- Thomas Preud'homme robo...@debian.org Mon, 21 Jan 2013 22:25:00 +0100
+
dspam (3.10.1+dfsg-7) testing-proposed-updates; urgency=low
* Disable multi-arch since it create many problems with regards to the
diff -Nru dspam-3.10.1+dfsg/debian/libdspam7-drv-mysql.dirs dspam-3.10.1+dfsg/debian/libdspam7-drv-mysql.dirs
--- dspam-3.10.1+dfsg/debian/libdspam7-drv-mysql.dirs 2013-01-19 21:11:32.0 +0100
+++ dspam-3.10.1+dfsg/debian/libdspam7-drv-mysql.dirs 2013-01-22 13:38:35.0 +0100
@@ -1,3 +1,4 @@
etc/dspam/dspam.d
+usr/share/libdspam7-drv-mysql
usr/share/dbconfig-common/data/libdspam7-drv-mysql/install
usr/share/dbconfig-common/data/libdspam7-drv-mysql/upgrade
diff -Nru dspam-3.10.1+dfsg/debian/libdspam7-drv-mysql.install.in dspam-3.10.1+dfsg/debian/libdspam7-drv-mysql.install.in
--- dspam-3.10.1+dfsg/debian/libdspam7-drv-mysql.install.in 2013-01-19 21:11:32.0 +0100
+++ dspam-3.10.1+dfsg/debian/libdspam7-drv-mysql.install.in 2013-01-22 13:38:35.0 +0100
@@ -1,7 +1,7 @@
debian/sqlfiles/install/mysql usr/share/dbconfig-common/data/libdspam7-drv-mysql/install
debian/sqlfiles/upgrade/mysql usr/share/dbconfig-common/data/libdspam7-drv-mysql/upgrade
usr/lib/@DEB_HOST_MULTIARCH@/dspam/libmysql_drv.so*
-src/mysql.confetc/dspam/dspam.d/
+src/mysql.confusr/share/libdspam7-drv-mysql
src/tools.mysql_drv/mysql_objects-4.1.sql usr/share/doc/libdspam7-drv-mysql/sql/
src/tools.mysql_drv/purge-4.1.sql usr/share/doc/libdspam7-drv-mysql/sql/
src/tools.mysql_drv/virtual_user_aliases.sql usr/share/doc/libdspam7-drv-mysql/sql/
diff -Nru dspam-3.10.1+dfsg/debian/libdspam7-drv-mysql.postinst dspam-3.10.1+dfsg/debian/libdspam7-drv-mysql.postinst
--- dspam-3.10.1+dfsg/debian/libdspam7-drv-mysql.postinst 2013-01-19 21:11:32.0 +0100
+++ dspam-3.10.1+dfsg/debian/libdspam7-drv-mysql.postinst 2013-01-22 13:38:35.0 +0100
@@ -9,7 +9,7 @@
# Set some variables
dbc_generate_include=template:/etc/dspam/dspam.d/mysql.conf
-dbc_generate_include_args=-U -o template_infile='/etc/dspam/dspam.d/mysql.conf'
+dbc_generate_include_args=-U -o template_infile='/usr/share/libdspam7-drv-mysql/mysql.conf'
# Run dbconfig
dbc_go libdspam7-drv-mysql $@
diff -Nru dspam-3.10.1+dfsg/debian/libdspam7-drv-pgsql.dirs dspam-3.10.1+dfsg/debian/libdspam7-drv-pgsql.dirs
--- dspam-3.10.1+dfsg/debian/libdspam7-drv-pgsql.dirs 2013-01-19 21:11:32.0 +0100
+++ dspam-3.10.1+dfsg/debian/libdspam7-drv-pgsql.dirs 2013-01-22 13:38:35.0 +0100
@@ -1,4 +1,5 @@
etc/dspam/dspam.d
+usr/share/libdspam7-drv-pgsql
usr/share/dbconfig-common/data/libdspam7-drv-pgsql/install
usr/share/dbconfig-common/data/libdspam7-drv-pgsql/upgrade
usr/share/dbconfig-common/data/libdspam7-drv-pgsql/install-dbadmin
diff -Nru dspam-3.10.1+dfsg/debian/libdspam7-drv-pgsql.install.in dspam-3.10.1+dfsg/debian/libdspam7-drv-pgsql.install.in
--- dspam-3.10.1
Bug#697691: preapproval unblock: dspam/3.10.1+dfsg-7
Le samedi 19 janvier 2013 13:31:59, vous avez écrit : On Tue, Jan 8, 2013 at 16:01:06 +0100, Thomas Preud'homme wrote: Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Please unblock package dspam [this is a preapproval unblock request] Bug #695275 harmful actions in multiple postrm scripts of M-A:same packages was not fixed completely by previous upload to t-p-u. Indeed, many more resources are shared between several architecture of a same package, for instance configuration file. As such, the least intrusive change now is to just disable multiarch. It's not even much a big loss since the libraries shipped by src:dspam are private libraries (plugins). ack. Since multi-arch is disabled, I decided to restore the old postinst script of libdspam7 which was in testing before last upload. Still not a fan of this. In fine you decide wether it's fine or not for tpu. If you don't want this I'll comply for the tpu upload. I put it back because I assumed it was the recommended procedure. It's mentionned several time in policy bug #621833 for instance. I'll wait for your answer about this (can I keep it or not) and then upload to tpu. Cheers, Julien Thanks for your hard work toward releasing Wheezy. Best regards, Thomas signature.asc Description: This is a digitally signed message part.
Bug#697691: preapproval unblock: dspam/3.10.1+dfsg-7
Le samedi 19 janvier 2013 18:10:22, Julien Cristau a écrit :
#621833 is still open, and I'm not aware of any other package doing this
lock thing. So yeah, I'd prefer if it didn't come back now. And then
you can get 621833 to a conclusion some time in the next two years and
do things differently in jessie.
Ack. Find attached the debdiff between the current testing version and the one
just uploaded in tpu.
Cheers,
Julien
Best regards,
Thomas
diff -Nru dspam-3.10.1+dfsg/debian/changelog dspam-3.10.1+dfsg/debian/changelog
--- dspam-3.10.1+dfsg/debian/changelog 2012-12-20 06:33:53.0 +0100
+++ dspam-3.10.1+dfsg/debian/changelog 2013-01-19 21:11:32.0 +0100
@@ -1,3 +1,11 @@
+dspam (3.10.1+dfsg-7) testing-proposed-updates; urgency=low
+
+ * Disable multi-arch since it create many problems with regards to the
+handling of shared resources when a package is installed for several
+architectures (Closes: #695275).
+
+ -- Thomas Preud'homme robo...@debian.org Tue, 08 Jan 2013 11:37:35 +0100
+
dspam (3.10.1+dfsg-6) testing-proposed-updates; urgency=low
* Do not lock dspam user account on purge since the package could be still
diff -Nru dspam-3.10.1+dfsg/debian/control dspam-3.10.1+dfsg/debian/control
--- dspam-3.10.1+dfsg/debian/control 2012-12-20 06:33:53.0 +0100
+++ dspam-3.10.1+dfsg/debian/control 2013-01-19 21:11:32.0 +0100
@@ -54,7 +54,6 @@
Pre-Depends: ${misc:Pre-Depends}
Depends: ${misc:Depends}, ${shlibs:Depends}, adduser
Suggests: libdspam7-drv (= ${binary:Version})
-Multi-Arch: ${misc:Multi-Arch}
Description: Core message processing and classification functionality for DSPAM
DSPAM is a dedicated statistical filter with minimal resources. It includes
many new algorithms to fight against spam including:
@@ -87,7 +86,6 @@
Replaces: dspam (= 3.9.1~rc1+git20110514.347379b+dfsg-1)
Breaks: dspam (= 3.9.1~rc1+git20110514.347379b+dfsg-1)
Provides: libdspam7-drv
-Multi-Arch: ${misc:Multi-Arch}
Description: Hash backend for DSPAM anti-spam filter
DSPAM is a dedicated statistical filter with minimal resources. It includes
many new algorithms to fight against spam including:
@@ -104,7 +102,6 @@
Depends: ${misc:Depends}, ${shlibs:Depends}, libdspam7 (= ${binary:Version}), dbconfig-common, ucf (= 0.28), postgresql-client
Recommends: postgresql
Provides: libdspam7-drv
-Multi-Arch: ${misc:Multi-Arch}
Description: PostgreSQL backend for DSPAM anti-spam filter
DSPAM is a dedicated statistical filter with minimal resources. It includes
many new algorithms to fight against spam including:
@@ -121,7 +118,6 @@
Depends: ${misc:Depends}, ${shlibs:Depends}, libdspam7 (= ${binary:Version}), dbconfig-common, ucf (= 0.28), mysql-client
Recommends: mysql-server
Provides: libdspam7-drv
-Multi-Arch: ${misc:Multi-Arch}
Description: MySQL backend for DSPAM anti-spam filter
DSPAM is a dedicated statistical filter with minimal resources. It includes
many new algorithms to fight against spam including:
@@ -137,7 +133,6 @@
Pre-Depends: ${misc:Pre-Depends}
Depends: ${misc:Depends}, ${shlibs:Depends}, sqlite3, libdspam7 (= ${binary:Version})
Provides: libdspam7-drv
-Multi-Arch: ${misc:Multi-Arch}
Description: sqlite3 backend for DSPAM anti-spam filter
DSPAM is a dedicated statistical filter with minimal resources. It includes
many new algorithms to fight against spam including:
@@ -184,7 +179,6 @@
Recommends: libdspam7-drv-hash (= ${binary:Version}), libdspam7-drv-mysql (= ${binary:Version}), libdspam7-drv-pgsql (= ${binary:Version}), libdspam7-drv-sqlite3 (= ${binary:Version})
Suggests: libc-dbg
Priority: extra
-Multi-Arch: ${misc:Multi-Arch}
Description: debugging symbols for DSPAM related libraries
DSPAM is a dedicated statistical filter with minimal resources. It includes
many new algorithms to fight against spam including:
Bug#697691: preapproval unblock: dspam/3.10.1+dfsg-7
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
Please unblock package dspam
[this is a preapproval unblock request]
Bug #695275 harmful actions in multiple postrm scripts of M-A:same
packages was not fixed completely by previous upload to t-p-u. Indeed,
many more resources are shared between several architecture of a same
package, for instance configuration file.
As such, the least intrusive change now is to just disable multiarch.
It's not even much a big loss since the libraries shipped by src:dspam
are private libraries (plugins).
Since multi-arch is disabled, I decided to restore the old postinst
script of libdspam7 which was in testing before last upload.
See attached debdiff.
unblock dspam/3.10.1+dfsg-7
-- System Information:
Debian Release: 7.0
APT prefers unstable
APT policy: (990, 'unstable'), (500, 'stable-updates'), (500, 'testing'),
(500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru dspam-3.10.1+dfsg/debian/changelog dspam-3.10.1+dfsg/debian/changelog
--- dspam-3.10.1+dfsg/debian/changelog 2012-12-20 06:33:53.0 +0100
+++ dspam-3.10.1+dfsg/debian/changelog 2013-01-08 11:40:36.0 +0100
@@ -1,3 +1,11 @@
+dspam (3.10.1+dfsg-7) testing-proposed-updates; urgency=low
+
+ * Disable multi-arch since it create many problems with regards to the
+handling of shared resources when a package is installed for several
+architectures (Closes: #695275).
+
+ -- Thomas Preud'homme robo...@debian.org Tue, 08 Jan 2013 11:37:35 +0100
+
dspam (3.10.1+dfsg-6) testing-proposed-updates; urgency=low
* Do not lock dspam user account on purge since the package could be still
diff -Nru dspam-3.10.1+dfsg/debian/control dspam-3.10.1+dfsg/debian/control
--- dspam-3.10.1+dfsg/debian/control 2012-12-20 06:33:53.0 +0100
+++ dspam-3.10.1+dfsg/debian/control 2013-01-08 11:40:36.0 +0100
@@ -54,7 +54,6 @@
Pre-Depends: ${misc:Pre-Depends}
Depends: ${misc:Depends}, ${shlibs:Depends}, adduser
Suggests: libdspam7-drv (= ${binary:Version})
-Multi-Arch: ${misc:Multi-Arch}
Description: Core message processing and classification functionality for DSPAM
DSPAM is a dedicated statistical filter with minimal resources. It includes
many new algorithms to fight against spam including:
@@ -87,7 +86,6 @@
Replaces: dspam (= 3.9.1~rc1+git20110514.347379b+dfsg-1)
Breaks: dspam (= 3.9.1~rc1+git20110514.347379b+dfsg-1)
Provides: libdspam7-drv
-Multi-Arch: ${misc:Multi-Arch}
Description: Hash backend for DSPAM anti-spam filter
DSPAM is a dedicated statistical filter with minimal resources. It includes
many new algorithms to fight against spam including:
@@ -104,7 +102,6 @@
Depends: ${misc:Depends}, ${shlibs:Depends}, libdspam7 (= ${binary:Version}), dbconfig-common, ucf (= 0.28), postgresql-client
Recommends: postgresql
Provides: libdspam7-drv
-Multi-Arch: ${misc:Multi-Arch}
Description: PostgreSQL backend for DSPAM anti-spam filter
DSPAM is a dedicated statistical filter with minimal resources. It includes
many new algorithms to fight against spam including:
@@ -121,7 +118,6 @@
Depends: ${misc:Depends}, ${shlibs:Depends}, libdspam7 (= ${binary:Version}), dbconfig-common, ucf (= 0.28), mysql-client
Recommends: mysql-server
Provides: libdspam7-drv
-Multi-Arch: ${misc:Multi-Arch}
Description: MySQL backend for DSPAM anti-spam filter
DSPAM is a dedicated statistical filter with minimal resources. It includes
many new algorithms to fight against spam including:
@@ -137,7 +133,6 @@
Pre-Depends: ${misc:Pre-Depends}
Depends: ${misc:Depends}, ${shlibs:Depends}, sqlite3, libdspam7 (= ${binary:Version})
Provides: libdspam7-drv
-Multi-Arch: ${misc:Multi-Arch}
Description: sqlite3 backend for DSPAM anti-spam filter
DSPAM is a dedicated statistical filter with minimal resources. It includes
many new algorithms to fight against spam including:
@@ -184,7 +179,6 @@
Recommends: libdspam7-drv-hash (= ${binary:Version}), libdspam7-drv-mysql (= ${binary:Version}), libdspam7-drv-pgsql (= ${binary:Version}), libdspam7-drv-sqlite3 (= ${binary:Version})
Suggests: libc-dbg
Priority: extra
-Multi-Arch: ${misc:Multi-Arch}
Description: debugging symbols for DSPAM related libraries
DSPAM is a dedicated statistical filter with minimal resources. It includes
many new algorithms to fight against spam including:
diff -Nru dspam-3.10.1+dfsg/debian/libdspam7.postrm dspam-3.10.1+dfsg/debian/libdspam7.postrm
--- dspam-3.10.1+dfsg/debian/libdspam7.postrm 2012-12-20 06:33:53.0 +0100
+++ dspam-3.10.1+dfsg/debian/libdspam7.postrm 2013-01-08 11:40:36.0 +0100
@@ -1,6 +1,11 @@
#!/bin/sh
set -e
+# Locks dspam system account on purge
+if [ $1 = purge ] ; then
+usermod -L -e 1 dspam /dev/null || true
+fi
Bug#696301: preapproval unblock: dspam/3.10.1+dfsg-6
Le mercredi 19 décembre 2012 04:35:55, Thomas Preud'homme a écrit :
See debdiff attached.
As Jakub Wilk pointed me out, dpkg-query got support for db:Status-Abbrev
later than in the version in squeeze. Fortunetely, this virtual field got added
before multiarch in dpkg, so I can do the check only if multiarch is present
and make everything work. See the new debdiff.
Best regards,
Thomas Preud'homme
diff --git a/debian/changelog b/debian/changelog
index b157048..1f05741 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+dspam (3.10.1+dfsg-6) unstable; urgency=medium
+
+ * Only lock dspam user account when the last libdspam7 package is purged
+(Thanks Jakub Wilk for the review, Closes: #695275).
+
+ -- Thomas Preud'homme robo...@celest.fr Wed, 19 Dec 2012 02:17:46 +0100
+
dspam (3.10.1+dfsg-5) testing-proposed-updates; urgency=low
[ Thomas Preud'homme ]
diff --git a/debian/libdspam7.postrm b/debian/libdspam7.postrm
index 3841a02..4608ac8 100644
--- a/debian/libdspam7.postrm
+++ b/debian/libdspam7.postrm
@@ -1,9 +1,16 @@
#!/bin/sh
set -e
+# Locks dspam system account on purge of last package
if [ $1 = purge ] ; then
-# locks dspam system account on purge
-usermod -L -e 1 dspam /dev/null || true
+# Multi-arch was added in dpkg in a later version than the db:Status-Abbrev
+# virtual field was added to dpkg-query. Hence, either this bug cannot be
+# encountered, or db:Status-Abbrev virtual field is available in dpkg-query.
+if ! dpkg --assert-multi-arch ||
+ ! dpkg-query '-f=${db:Status-Abbrev}\n' -W libdspam7 | grep -vE '(.n|pc)' /dev/null
+then
+usermod -L -e 1 dspam /dev/null || true
+fi
fi
#DEBHELPER#
Bug#696301: preapproval unblock: dspam/3.10.1+dfsg-6
Le mercredi 19 décembre 2012 19:12:18, Julien Cristau a écrit : I would rather see that 'lock user' code removed in the wheezy version. Ok, I'll upload to tpu a package which just remove the purge logic in libdspam7.postrm and this fix in unstable. Thanks for your quick answer. Cheers, Julien Thomas -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/201212200429.18326.robo...@celest.fr
Bug#696301: preapproval unblock: dspam/3.10.1+dfsg-6
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
Please unblock package dspam as it fixes bug #695275 of severity
serious:
src:dspam: harmful actions in multiple postrm scripts of M-A:same
packages
The proposed patch is to detect through dpkg-query if this is the last
instance of libdspam7 to be purged and only lock dspam user account if
it is the case. The detection is made by counting the number of packages
not purged (not installed are not considered) excluding the currently
being uninstalled package. See debdiff attached.
My proposition for more testing is to first upload the fix in unstable
and then after 10 days do the upload in tpu (version in unstable is not
the same as in testing). Is this procedure fine for you?
unblock dspam/3.10.1+dfsg-6
-- System Information:
Debian Release: 7.0
APT prefers unstable
APT policy: (990, 'unstable'), (500, 'stable-updates'), (500, 'testing'),
(500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff --git a/debian/changelog b/debian/changelog
index b157048..b8912a4 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+dspam (3.10.1+dfsg-6) unstable; urgency=medium
+
+ * Only lock dspam user account when the last libdspam7 package is purged
+(Closes: #695275).
+
+ -- Thomas Preud'homme robo...@celest.fr Wed, 19 Dec 2012 02:17:46 +0100
+
dspam (3.10.1+dfsg-5) testing-proposed-updates; urgency=low
[ Thomas Preud'homme ]
diff --git a/debian/libdspam7.postrm b/debian/libdspam7.postrm
index 3841a02..97b6f9d 100644
--- a/debian/libdspam7.postrm
+++ b/debian/libdspam7.postrm
@@ -2,8 +2,11 @@
set -e
if [ $1 = purge ] ; then
-# locks dspam system account on purge
-usermod -L -e 1 dspam /dev/null || true
+# locks dspam system account on purge of last package
+if ! dpkg-query '-f=${db:Status-Abbrev}\n' -W libdspam7 | grep -vE '(.n|pc)' /dev/null
+then
+usermod -L -e 1 dspam /dev/null || true
+fi
fi
#DEBHELPER#
Bug#691871: unblock: dancer-ircd/1.0.36-8.1
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
Please unblock package dancer-ircd
The upload in unstable fix the bug #689886 by creating
/var/run/dancer-ircd at runtime instead of shipping the folder in the
package. Debdiff attached
unblock dancer-ircd/1.0.36-8.1
-- System Information:
Debian Release: wheezy/sid
APT prefers unstable
APT policy: (990, 'unstable'), (500, 'stable-updates'), (500, 'testing'),
(500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -u dancer-ircd-1.0.36/debian/init.d dancer-ircd-1.0.36/debian/init.d
--- dancer-ircd-1.0.36/debian/init.d
+++ dancer-ircd-1.0.36/debian/init.d
@@ -16,31 +16,38 @@
DAEMON=/usr/sbin/dancer-ircd
NAME=dancer-ircd
DESC=dancer-ircd
+USER=dancer
+RUNDIR=/var/run/dancer-ircd
test -f $DAEMON || exit 0
set -e
+if [ ! -d ${RUNDIR} ] ; then
+ mkdir -m 0755 ${RUNDIR}
+ chown ${USER}:${USER} ${RUNDIR}
+fi
+
case $1 in
start)
echo -n Starting $DESC:
- start-stop-daemon --start --quiet --chuid dancer \
- --pidfile /var/run/dancer-ircd/$NAME.pid \
+ start-stop-daemon --start --quiet --chuid ${USER} \
+ --pidfile ${RUNDIR}/$NAME.pid \
--exec $DAEMON -- -d /
echo $NAME.
;;
stop)
echo -n Stopping $DESC:
start-stop-daemon --stop --quiet --oknodo \
- --pidfile /var/run/dancer-ircd/$NAME.pid \
+ --pidfile ${RUNDIR}/$NAME.pid \
--exec $DAEMON
- rm -f /var/run/dancer-ircd/$NAME.pid
+ rm -f ${RUNDIR}/$NAME.pid
echo $NAME.
;;
reload|force-reload)
echo Reloading $DESC configuration files.
start-stop-daemon --stop --quiet --signal 1 --oknodo \
- --pidfile /var/run/dancer-ircd/$NAME.pid \
+ --pidfile ${RUNDIR}/$NAME.pid \
--exec $DAEMON
;;
restart)
diff -u dancer-ircd-1.0.36/debian/dancer-ircd.dirs dancer-ircd-1.0.36/debian/dancer-ircd.dirs
--- dancer-ircd-1.0.36/debian/dancer-ircd.dirs
+++ dancer-ircd-1.0.36/debian/dancer-ircd.dirs
@@ -7 +6,0 @@
-var/run/dancer-ircd
diff -u dancer-ircd-1.0.36/debian/dancer-ircd.postinst dancer-ircd-1.0.36/debian/dancer-ircd.postinst
--- dancer-ircd-1.0.36/debian/dancer-ircd.postinst
+++ dancer-ircd-1.0.36/debian/dancer-ircd.postinst
@@ -21,7 +21,6 @@
# limitation. Someday it will be fixed
chown $USER:$USER /var/log/dancer-ircd
- chown $USER:$USER /var/run/dancer-ircd
chown $USER:$USER /var/lib/dancer-ircd
chown $USER:$USER /var/lib/dancer-ircd/dline.conf
chown $USER:$USER /var/lib/dancer-ircd/kline.conf
diff -u dancer-ircd-1.0.36/debian/changelog dancer-ircd-1.0.36/debian/changelog
--- dancer-ircd-1.0.36/debian/changelog
+++ dancer-ircd-1.0.36/debian/changelog
@@ -1,3 +1,11 @@
+dancer-ircd (1.0.36-8.1) unstable; urgency=low
+
+ * Non-maintainer upload.
+ * Create /var/run/dancer-ircd at runtime (Closes: #689886, thanks to Thomas
+Goirand).
+
+ -- Thomas Preud'homme robo...@debian.org Tue, 30 Oct 2012 15:12:29 +0100
+
dancer-ircd (1.0.36-8) unstable; urgency=medium
* Bump Standards-Version to 3.7.3.
Bug#684804: tpu: package dspam/3.10.1+dfsg-5
Package: release.debian.org Severity: normal As said before [0], I would like #644392 to get fixed and thus asked paultag to do an upload to tpu since I don't have my gpg key around. I also asked him to do an upload to unstable to fix the same bug. This way, some additional testing will be made by unstable users, as suggested by Adam D. Barratt. I guess you will want to accept the upload in 10 days or more to get enough testing through unstable users. [0] http://lists.debian.org/debian-release/2012/08/msg00523.html Thanks for everybody involved. Best regards. -- System Information: Debian Release: wheezy/sid Architecture: armhf (armv7l) Kernel: Linux 2.6.38-ac2-ac100 (SMP w/2 CPU cores) Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120814064255.4973.26693.reportbug@brano
Bug#684804: tpu: package dspam/3.10.1+dfsg-5
I forgot the debdiffs. Here they are.
Best regards.
diff -Nru dspam-3.10.1+dfsg/debian/changelog dspam-3.10.1+dfsg/debian/changelog
--- dspam-3.10.1+dfsg/debian/changelog 2012-02-10 16:05:38.0 -0500
+++ dspam-3.10.1+dfsg/debian/changelog 2012-08-13 20:22:02.0 -0400
@@ -1,3 +1,21 @@
+dspam (3.10.1+dfsg-5) testing-proposed-updates; urgency=low
+
+ [ Thomas Preud'homme ]
+ * Team upload.
+ * Upload via testing-proposed-updates as unstable contains a new upstream
+version.
+ * Cherry-pick patch from upstream to recommend using -oi when using dspam
+with exim (Closes: #644392).
+ * Remove multiarch support for libdspam7-dev as it contains an header with
+arch-specific contents (Closes: #669993).
+
+ [ Paul Tagliamonte ]
+ * Although this changelog is signed by Tom, this upload has been signed by
+me. Tom prepared this upload, but is remote (and without his GPG key),
+so these changes have been reviewed and uploaded by me.
+
+ -- Thomas Preud'homme robo...@celest.fr Mon, 13 Aug 2012 15:20:48 +0800
+
dspam (3.10.1+dfsg-4) unstable; urgency=low
* Apply patch from upstream to use POSIX::ctime() instead of deprecated
diff -Nru dspam-3.10.1+dfsg/debian/control dspam-3.10.1+dfsg/debian/control
--- dspam-3.10.1+dfsg/debian/control 2012-02-10 16:05:38.0 -0500
+++ dspam-3.10.1+dfsg/debian/control 2012-08-13 20:21:12.0 -0400
@@ -70,7 +70,6 @@
Architecture: any
Pre-Depends: ${misc:Pre-Depends}
Depends: ${misc:Depends}, libdspam7 (= ${binary:Version})
-Multi-Arch: ${misc:Multi-Arch}
Description: Development headers for libdspam
DSPAM is a dedicated statistical filter with minimal resources. It includes
many new algorithms to fight against spam including:
diff -Nru dspam-3.10.1+dfsg/debian/dspam-documents/exim4/dspam.conf dspam-3.10.1+dfsg/debian/dspam-documents/exim4/dspam.conf
--- dspam-3.10.1+dfsg/debian/dspam-documents/exim4/dspam.conf 2012-02-10 16:05:38.0 -0500
+++ dspam-3.10.1+dfsg/debian/dspam-documents/exim4/dspam.conf 2012-08-13 20:21:12.0 -0400
@@ -22,7 +22,7 @@
# Other popular configurations:
#TrustedDeliveryAgent /usr/cyrus/bin/deliver # Cyrus
#TrustedDeliveryAgent /bin/maildrop # Maildrop
-#TrustedDeliveryAgent /usr/sbin/exim -oMr spam-scanned $u # Exim
+#TrustedDeliveryAgent /usr/sbin/exim -oMr spam-scanned -oi $u # Exim
TrustedDeliveryAgent /usr/sbin/exim4 # Exim
#
#TrustedDeliveryAgent /usr/bin/procmail
diff -Nru dspam-3.10.1+dfsg/debian/patches/008_fix_exim_integration_doc.diff dspam-3.10.1+dfsg/debian/patches/008_fix_exim_integration_doc.diff
--- dspam-3.10.1+dfsg/debian/patches/008_fix_exim_integration_doc.diff 1969-12-31 19:00:00.0 -0500
+++ dspam-3.10.1+dfsg/debian/patches/008_fix_exim_integration_doc.diff 2012-08-13 20:21:12.0 -0400
@@ -0,0 +1,62 @@
+Description: Fix documentation about exim integration
+
+Using dspam with exim requires to call exim with option -oi to avoid mails
+from being truncated. This commit modify the documentation and configuration
+file to add the -oi option when calling exim.
+
+Author: Kenneth Marshall k...@rice.edu
+Origin: upstream, http://dspam.git.sourceforge.net/git/gitweb.cgi?p=dspam/dspam;a=commitdiff;h=e515570c74b0e48e714c5b45f11de2a5b3482459
+Bug-Debian: http://bugs.debian.org/644392
+Forwarded: http://sourceforge.net/mailarchive/forum.php?thread_name=20120802190055.GF15829%40aart.rice.eduforum_name=dspam-user
+Last-Update: 2012-08-13
+
+--- dspam-3.10.1+dfsg.orig/CHANGELOG
dspam-3.10.1+dfsg/CHANGELOG
+@@ -1,3 +1,5 @@
++[20121202:2115] sbajic: Update documentation for Exim integration.
++
+ Version 3.10.1
+ --
+
+--- dspam-3.10.1+dfsg.orig/doc/exim.txt
dspam-3.10.1+dfsg/doc/exim.txt
+@@ -1,4 +1,4 @@
+-$Id: exim.txt,v 1.1 2005/03/11 21:16:03 jonz Exp $
++$Id: exim.txt,v 1.2 2012/08/02 21:09:23 sbajic Exp $
+
+ EXIM 4 INTEGRATION
+
+@@ -40,11 +40,17 @@ domain as part of the username:
+
+ command = /usr/local/bin/dspam --deliver=innocent --user $local_part@$domain -- %u
+
+-Finally, you will need to configure and compile DSPAM. DSPAM will most likely
+-end up calling exim again for delivery, using the spam-scanned protocol to
+-identify scanned messages. The most common example is:
+-
+- ./configure --with-delivery-agent=/usr/sbin/exim -oMr spam-scanned
++Finally, you will need to configure and compile DSPAM. You can configure
++DSPAM with the appropriate LDA using --with-delivery-agent= at configure
++time or by specifying TrustedDeliveryAgent in dspam.conf. DSPAM will most
++likely end up calling exim again for delivery, using the spam-scanned
++protocol to identify scanned messages. The most common example is:
++
++ ./configure --with-delivery-agent=/usr/local/sbin/exim -oMr spam-scanned -oi
++
++Note: DSPAM expects the LDA to NOT provide the line with a single dot (.)
++processing to indicate the end of data that a MTA must provide to meet the
++SMTP RFC, hence the -oi option to exim above.
+
+ RUNNING WITHOUT
Re: Upload of dspam to testing-proposed-update
Le lundi 13 août 2012 02:21:51, Adam D. Barratt a écrit : Looking at the changes in unstable, it might be worth including the fix for #669993 too? Indeed, release goal and the changes are small. I forgot about fixes made along the packaging of the new version. I'll update the debdiff and look for someone to upload it. [0] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=644392#73 Is there a plan to get that fixed in unstable? Yes, absolutely. I focused on testing because the faster it's fixed here, the better for Debian. I'll prepare another debdiff for unstable. A bug would be preferable, as it makes it much easier to track. You can do that once the package has been uploaded though - britney won't attempt to migrate a tpu package until all architectures are available. Ack. Regards, Adam Best regards, Thomas Preud'homme -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/201208131501.55907.robo...@celest.fr
Upload of dspam to testing-proposed-update
Greetings Release Team, I'm writing to you as I would like your approval to upload dspam package to testing-proposed-update in order to fix bug #644392. As you can see, the version in unstable contains to many change for an unblock request and an upload via testing-proposed-updates is necessary. The patch comes from upstream and consist of fixing a commented command line to call exim in dspam configuration. If users uncomment the current command line, data loss can result from it, as explain the message [0]. [0] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=644392#73 Except for the upload via testing-proposed-update, I think the upload respect the criterias: minor changes to fix an RC bug. You'll find attached the debdiff. As soon as I get your approval I'll ask a DD to upload the package (I don't have my gpg key where I am right now) and will come back to you once all architectures have build the package to ask you to approve the upload. By the way, is this step done via BTS or via mail to the ML? Best regards, Thomas Preud'homme diff -Nru dspam-3.10.1+dfsg/debian/changelog dspam-3.10.1+dfsg/debian/changelog --- dspam-3.10.1+dfsg/debian/changelog 2012-02-11 05:05:38.0 +0800 +++ dspam-3.10.1+dfsg/debian/changelog 2012-08-12 01:01:23.0 +0800 @@ -1,3 +1,13 @@ +dspam (3.10.1+dfsg-5) testing-proposed-updates; urgency=low + + * Team upload. + * Upload via testing-proposed-updates as unstable contains a new upstream +version. + * Cherry-pick patch from upstream to recommend using -oi when using dspam +with exim (Closes: #644392). + + -- Thomas Preud'homme robo...@celest.fr Sat, 11 Aug 2012 22:25:43 +0800 + dspam (3.10.1+dfsg-4) unstable; urgency=low * Apply patch from upstream to use POSIX::ctime() instead of deprecated diff -Nru dspam-3.10.1+dfsg/debian/dspam-documents/exim4/dspam.conf dspam-3.10.1+dfsg/debian/dspam-documents/exim4/dspam.conf --- dspam-3.10.1+dfsg/debian/dspam-documents/exim4/dspam.conf 2012-02-11 05:05:38.0 +0800 +++ dspam-3.10.1+dfsg/debian/dspam-documents/exim4/dspam.conf 2012-08-12 01:01:23.0 +0800 @@ -22,7 +22,7 @@ # Other popular configurations: #TrustedDeliveryAgent /usr/cyrus/bin/deliver # Cyrus #TrustedDeliveryAgent /bin/maildrop # Maildrop -#TrustedDeliveryAgent /usr/sbin/exim -oMr spam-scanned $u # Exim +#TrustedDeliveryAgent /usr/sbin/exim -oMr spam-scanned -oi $u # Exim TrustedDeliveryAgent /usr/sbin/exim4 # Exim # #TrustedDeliveryAgent /usr/bin/procmail diff -Nru dspam-3.10.1+dfsg/debian/patches/fix_exim_integration_doc dspam-3.10.1+dfsg/debian/patches/fix_exim_integration_doc --- dspam-3.10.1+dfsg/debian/patches/fix_exim_integration_doc 1970-01-01 08:00:00.0 +0800 +++ dspam-3.10.1+dfsg/debian/patches/fix_exim_integration_doc 2012-08-12 01:01:07.0 +0800 @@ -0,0 +1,62 @@ +Description: Fix documentation about exim integration + +Using dspam with exim requires to call exim with option -oi to avoid mails +from being truncated. This commit modify the documentation and configuration +file to add the -oi option when calling exim. + +Author: Kenneth Marshall k...@rice.edu +Origin: upstream, http://sourceforge.net/mailarchive/message.php?msg_id=29626440 +Bug-Debian: http://bugs.debian.org/644392 +Forwarded: http://sourceforge.net/mailarchive/forum.php?thread_name=20120802190055.GF15829%40aart.rice.eduforum_name=dspam-user +Last-Update: 2012-08-12 + +--- dspam-3.10.1+dfsg.orig/CHANGELOG dspam-3.10.1+dfsg/CHANGELOG +@@ -1,3 +1,5 @@ ++[20121202:2115] sbajic: Update documentation for Exim integration. ++ + Version 3.10.1 + -- + +--- dspam-3.10.1+dfsg.orig/doc/exim.txt dspam-3.10.1+dfsg/doc/exim.txt +@@ -1,4 +1,4 @@ +-$Id: exim.txt,v 1.1 2005/03/11 21:16:03 jonz Exp $ ++$Id: exim.txt,v 1.2 2012/08/02 21:09:23 sbajic Exp $ + + EXIM 4 INTEGRATION + +@@ -40,11 +40,17 @@ domain as part of the username: + + command = /usr/local/bin/dspam --deliver=innocent --user $local_part@$domain -- %u + +-Finally, you will need to configure and compile DSPAM. DSPAM will most likely +-end up calling exim again for delivery, using the spam-scanned protocol to +-identify scanned messages. The most common example is: +- +- ./configure --with-delivery-agent=/usr/sbin/exim -oMr spam-scanned ++Finally, you will need to configure and compile DSPAM. You can configure ++DSPAM with the appropriate LDA using --with-delivery-agent= at configure ++time or by specifying TrustedDeliveryAgent in dspam.conf. DSPAM will most ++likely end up calling exim again for delivery, using the spam-scanned ++protocol to identify scanned messages. The most common example is: ++ ++ ./configure --with-delivery-agent=/usr/local/sbin/exim -oMr spam-scanned -oi ++ ++Note: DSPAM expects the LDA to NOT provide the line with a single dot (.) ++processing to indicate the end of data that a MTA must provide to meet the ++SMTP RFC, hence the -oi option to exim above. + + RUNNING WITHOUT PRIVILEGED EXIM USERS + +--- dspam-3.10.1
Bug#682367: unblock: tcc/0.9.26~git20120612.ad5f375-6
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: freeze-exception
Please unblock package tcc
This new version fixes a bug where a long long value is not correctly
read from memory into the registers. This leads to unexpected behavior
of correctly written programs and could have security issue for these
programs. People are warned in tcc's description that the compiler is not
ready for production because it could have security problems but it
would still be good to have a fixed version when a bug is known.
The patch is small and only the fix for the bug has been included in
this upload. The relevant bug number is #681281 and is of severity
important. Attached to this mail the debdiff from the previous version.
unblock tcc/0.9.26~git20120612.ad5f375-6
-- System Information:
Debian Release: wheezy/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: armhf (armv7l)
Kernel: Linux 2.6.38-ac2-ac100 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru tcc-0.9.26~git20120612.ad5f375/debian/changelog tcc-0.9.26~git20120612.ad5f375/debian/changelog
--- tcc-0.9.26~git20120612.ad5f375/debian/changelog 2012-07-09 21:30:35.0 +0800
+++ tcc-0.9.26~git20120612.ad5f375/debian/changelog 2012-07-22 00:41:21.0 +0800
@@ -1,3 +1,17 @@
+tcc (0.9.26~git20120612.ad5f375-6) unstable; urgency=low
+
+ [Paul Tagliamonte]
+* Uploading Tom's fixes on his behalf. Although he's signed this upload
+ (he issued a debdiff), I've prepared this upload. Fix verified on
+ i386.
+
+ [Thomas Preud'homme]
+* debian/patches:
+ + Fix incorrect reading of long long values on architecture with 32bits
+registers like i386 and armel (Closes: #681281).
+
+ -- Thomas Preud'homme robo...@celest.fr Sat, 21 Jul 2012 03:43:35 +0200
+
tcc (0.9.26~git20120612.ad5f375-5) unstable; urgency=low
* debian/patches:
diff -Nru tcc-0.9.26~git20120612.ad5f375/debian/patches/0006-get_reg-try-to-free-r2-for-an-SValue-first.patch tcc-0.9.26~git20120612.ad5f375/debian/patches/0006-get_reg-try-to-free-r2-for-an-SValue-first.patch
--- tcc-0.9.26~git20120612.ad5f375/debian/patches/0006-get_reg-try-to-free-r2-for-an-SValue-first.patch 1970-01-01 08:00:00.0 +0800
+++ tcc-0.9.26~git20120612.ad5f375/debian/patches/0006-get_reg-try-to-free-r2-for-an-SValue-first.patch 2012-07-22 00:31:29.0 +0800
@@ -0,0 +1,51 @@
+From 315185fe1db1296e511bec15894dad22432c9a7f Mon Sep 17 00:00:00 2001
+From: Thomas Preud'homme robo...@celest.fr
+Date: Sat, 21 Jul 2012 03:36:51 +0200
+Subject: get_reg(): try to free r2 for an SValue first
+
+To be able to load a long long value correctly on i386, gv() rely on the
+fact that when get_reg() look at an SValue it tries first to free the
+register in r2 and then r. More information about the context can be
+found at
+http://lists.nongnu.org/archive/html/tinycc-devel/2012-06/msg00017.html
+and later at
+http://lists.nongnu.org/archive/html/tinycc-devel/2012-07/msg00021.html
+
+Origin: upstream,http://repo.or.cz/w/tinycc.git/commit/d1694f7d7e6d96f64d1330c9b43491b613272b1e
+Bug-Debian: http://bugs.debian.org/681281
+Forwarded: http://lists.nongnu.org/archive/html/tinycc-devel/2012-06/msg00017.html
+Last-Updated: 2012-07-21
+Applied-Upstream: commit:d1694f7d7e6d96f64d1330c9b43491b613272b1e
+---
+ tccgen.c |9 +
+ 1 file changed, 5 insertions(+), 4 deletions(-)
+
+diff --git a/tccgen.c b/tccgen.c
+index d27bdba..71d0809 100644
+--- a/tccgen.c
b/tccgen.c
+@@ -589,11 +589,11 @@ ST_FUNC int get_reg(int rc)
+IMPORTANT to start from the bottom to ensure that we don't
+spill registers used in gen_opi()) */
+ for(p=vstack;p=vtop;p++) {
+-r = p-r VT_VALMASK;
++/* look at second register (if long long) */
++r = p-r2 VT_VALMASK;
+ if (r VT_CONST (reg_classes[r] rc))
+ goto save_found;
+-/* also look at second register (if long long) */
+-r = p-r2 VT_VALMASK;
++r = p-r VT_VALMASK;
+ if (r VT_CONST (reg_classes[r] rc)) {
+ save_found:
+ save_reg(r);
+@@ -812,7 +812,8 @@ ST_FUNC int gv(int rc)
+ vtop[-1].r = r; /* save register value */
+ vtop-r = vtop[-1].r2;
+ }
+-/* allocate second register */
++/* Allocate second register. Here we rely on the fact that
++ get_reg() tries first to free r2 of an SValue. */
+ r2 = get_reg(rc2);
+ load(r2, vtop);
+ vpop();
diff -Nru tcc-0.9.26~git20120612.ad5f375/debian/patches/series tcc-0.9.26~git20120612.ad5f375/debian/patches/series
--- tcc-0.9.26~git20120612.ad5f375/debian/patches/series 2012-07-09 21:30:35.0 +0800
+++ tcc-0.9.26~git20120612.ad5f375/debian/patches/series 2012-07-22 00:31:29.0 +0800
@@ -3,3 +3,4
Bug#680967: unblock: tcc/0.9.26~git20120612.ad5f375-5
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: freeze-exception
Greetings Release Team,
Please unblock package tcc. I've just uploaded a new version of tcc in
unstable which fix a bug of severity important (#679123) about the type
of an integer shift. I also removed the old maintainer as requested by
MIA team (#677782). If you think this extra change is too much I'd be
happy to upload a new version reverting it.
Debdiff is attached.
unblock tcc/0.9.26~git20120612.ad5f375-5
-- System Information:
Debian Release: wheezy/sid
APT prefers unstable
APT policy: (990, 'unstable'), (500, 'stable-updates'), (500, 'testing'),
(500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.2.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru tcc-0.9.26~git20120612.ad5f375/debian/changelog tcc-0.9.26~git20120612.ad5f375/debian/changelog
--- tcc-0.9.26~git20120612.ad5f375/debian/changelog 2012-06-27 15:14:30.0 +0200
+++ tcc-0.9.26~git20120612.ad5f375/debian/changelog 2012-07-09 15:30:35.0 +0200
@@ -1,3 +1,14 @@
+tcc (0.9.26~git20120612.ad5f375-5) unstable; urgency=low
+
+ * debian/patches:
++ Correctly handle integer promotion in patch fixing incorrect shift
+ result type (Closes: #679123).
+ * debian/control:
++ Set myself as Maintainer instead of Aurélien Gérôme as a result of him
+ being MIA (Closes: #677782).
+
+ -- Thomas Preud'homme robo...@celest.fr Sun, 08 Jul 2012 17:36:15 +0200
+
tcc (0.9.26~git20120612.ad5f375-4) unstable; urgency=low
* debian/patches:
diff -Nru tcc-0.9.26~git20120612.ad5f375/debian/control tcc-0.9.26~git20120612.ad5f375/debian/control
--- tcc-0.9.26~git20120612.ad5f375/debian/control 2012-06-27 15:14:30.0 +0200
+++ tcc-0.9.26~git20120612.ad5f375/debian/control 2012-07-09 15:30:35.0 +0200
@@ -1,8 +1,8 @@
Source: tcc
Section: devel
Priority: optional
-Maintainer: Aurélien GÉRÔME a...@debian.org
-Uploaders: Thomas Preud'homme robo...@celest.fr, Arthur Loiret arthur.loi...@gmail.com
+Maintainer: Thomas Preud'homme robo...@celest.fr
+Uploaders: Arthur Loiret arthur.loi...@gmail.com
Build-Depends: debhelper (= 9), texi2html, texinfo, perl
Standards-Version: 3.9.3
Homepage: http://www.tinycc.org/
diff -Nru tcc-0.9.26~git20120612.ad5f375/debian/patches/0005-Incorrect-shift-result-type-with-64-bit-ABI.patch tcc-0.9.26~git20120612.ad5f375/debian/patches/0005-Incorrect-shift-result-type-with-64-bit-ABI.patch
--- tcc-0.9.26~git20120612.ad5f375/debian/patches/0005-Incorrect-shift-result-type-with-64-bit-ABI.patch 2012-06-27 15:14:30.0 +0200
+++ tcc-0.9.26~git20120612.ad5f375/debian/patches/0005-Incorrect-shift-result-type-with-64-bit-ABI.patch 2012-07-09 15:30:35.0 +0200
@@ -1,4 +1,4 @@
-From 25def4fa7488f8bcf621155d3b2725fca711b7a1 Mon Sep 17 00:00:00 2001
+From 16ab20b1893c2f5b5462f8568444609c3b49f882 Mon Sep 17 00:00:00 2001
From: Vincent Lefevre vinc...@vinc17.net
Date: Wed, 27 Jun 2012 13:31:44 +0200
Subject: Incorrect shift result type with 64-bit ABI
@@ -19,25 +19,27 @@
100% accessible validated (X)HTML - Blog: http://www.vinc17.net/blog/
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
-Origin: upstream, http://repo.or.cz/w/tinycc.git/commit/240064c03bbc4264ff972f4dbd2d0e2f6d4222c7
+Origin: upstream, http://repo.or.cz/w/tinycc.git/commit/d27a0b35482b907357d76a9db4e0b18ec89cf979
Bug-Debian: http://bugs.debian.org/679123
-Forwarded: http://lists.nongnu.org/archive/html/tinycc-devel/2012-06/msg00038.html
-Last-Update: 2012-06-27
-Applied-Upstream: commit: 240064c03bbc4264ff972f4dbd2d0e2f6d4222c7
+Forwarded: http://lists.nongnu.org/archive/html/tinycc-devel/2012-07/msg00011.html
+Last-Update: 2012-07-06
+Applied-Upstream: commit: d27a0b35482b907357d76a9db4e0b18ec89cf979
---
- tccgen.c |3 +++
- 1 file changed, 3 insertions(+)
+ tccgen.c |5 +
+ 1 file changed, 5 insertions(+)
diff --git a/tccgen.c b/tccgen.c
-index 7295267..26a5781 100644
+index 7295267..d27bdba 100644
--- a/tccgen.c
+++ b/tccgen.c
-@@ -1678,6 +1678,9 @@ ST_FUNC void gen_op(int op)
+@@ -1678,6 +1678,11 @@ ST_FUNC void gen_op(int op)
(op TOK_ULT || op TOK_GT))
tcc_error(invalid operands for binary operation);
goto std_op;
+} else if (op == TOK_SHR || op == TOK_SAR || op == TOK_SHL) {
-+t = (bt1 == VT_LLONG ? VT_LLONG : VT_INT) | (t1 VT_UNSIGNED);
++t = bt1 == VT_LLONG ? VT_LLONG : VT_INT;
++if ((t1 (VT_BTYPE | VT_UNSIGNED)) == (t | VT_UNSIGNED))
++ t |= VT_UNSIGNED;
+goto std_op;
} else if (bt1 == VT_LLONG || bt2 == VT_LLONG) {
/* cast to biggest op */
Bug#676671: RM: ultracopier/0.2.0.16-1 -- RoM; non-free files
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: rm Greetings Release Team members, please remove ultracopier 0.2.0.16-1 from testing and unstable. This version contains non free material and fails to provide some source for some GPL licensed image (they are generated from SVG) as noted in bug #676668. Version 0.3 solve this problem but the packaging will most likely not be ready before the freeze happens. Best regards. -- System Information: Debian Release: wheezy/sid APT prefers unstable APT policy: (990, 'unstable'), (500, 'stable-updates'), (500, 'testing'), (500, 'stable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.2.0-2-amd64 (SMP w/4 CPU cores) Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120608174053.3697.43419.report...@cerclon.rsr.lip6.fr
Bug#656232: nmu: dspam_dspam_3.10.1+dfsg-3
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: binnmu As Moritz Muehlenhoff explains in #655189, dspam needs a rebuild to benefit from hardening flags on. nmu dspam_dspam_3.10.1+dfsg-3 . ALL . -m Rebuild with hardening flags on (Closes: #655189) Best regards. -- System Information: Debian Release: wheezy/sid APT prefers unstable APT policy: (990, 'unstable'), (500, 'stable-updates'), (500, 'testing'), (500, 'stable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 3.1.0-1-amd64 (SMP w/4 CPU cores) Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120117161426.13142.79036.reportbug@cerclon
Bug#599625: unblock: tcc/0.9.25-5
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: freeze-exception Please unblock package tcc tcc in squeeze is unable to link a program into an executable on amd64 when it uses string functions (strlen and co). As almost all C program use string functions, I consider this bug serious. The version in unstable contains a fix and it consists of just a few lines. The fix was introduced in tcc 0.9.25-4 which stayed in unstable for almost 2 months without bringing any new bug. Version 0.9.25-5 is there only for a few days but the only change is to drop armel architecture as tcc doesn't build on armel because of a failure in the test suite. Changes between version 0.9.25-3 are: tcc (0.9.25-5) unstable; urgency=low * Drop support for armel arch. = tcc has never built on armel tcc (0.9.25-4) unstable; urgency=low * Fix bashims in configure and gcctestsuite.sh. = This is a release goal. * Add support for indirect functions as externals. = This is the few line fix. * Bump Standard-Version from 3.8.4 to 3.9.1 (no changes needed). * debian/control: - Improve package description for libtcc-dev. = If this last change causes a problem with regards to the translations I can make a new upload without the improved description Best regards and good luck for the squeeze release. unblock tcc/0.9.25-5 -- System Information: Debian Release: squeeze/sid APT prefers unstable APT policy: (990, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental') Architecture: i386 (i686) Kernel: Linux 2.6.32-5-686 (SMP w/1 CPU core) Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101009174729.2967.15261.report...@olivaw.celest.fr
Bug#595765: unblock: mrd6/0.9.6-3
Le lundi 06 septembre 2010 20:43:34, vous avez écrit : On Mon, Sep 6, 2010 at 15:41:05 +0200, Thomas Preud'homme wrote: Please unblock package mrd6 as it contains a FTBFS fix for Debian/kFreeBSD. The full changelog is: * Make dl* functions available on all archs (Fix FTBFS on *BSD). Pretty ugly, there are (non-debian) platforms with dlopen in libc. I didn't know there was some platform including dlopen in libc. I'll find a way to link with dlopen whenever necessary in a proper way for after squeeze release. * debian/control: + Bumps Standards-Version to 3.9.1 (no changes needed). This version also adds a typo fix in debian/rules and remove build file at clean. This version is in unstable for 24 days and no new bug has been filled. Why didn't you just add the rm -f build to override_dh_auto_clean? And why was this not documented in the changelog? I've just been a bit too strict in following the policy §4.9 (If a build file is touched at the end of the build target, as suggested above, it should be removed as the first action that clean performs). Indeed I could have put this in override_dh_auto_clean. I don't remember why I didn't document that modification in the changelog, but It's likely an oblivion. Apologize for that. Unblocked. Thanks. Cheers, Julien Best regards, Thomas Preud'homme signature.asc Description: This is a digitally signed message part.
Bug#595705: unblock: pstack/1.2-2
Le lundi 06 septembre 2010 12:22:31, Julien Cristau a écrit : On Mon, Sep 6, 2010 at 00:55:15 +0200, Thomas Preud'homme wrote: Please unblock package pstack as it fixes bug #360922 that makes pstack useless. This bug has severity important and pstack satisfy the unblock rules by being of priority optional. The severity for 'makes this package useless' is 'grave', not 'important'. Which is it? To be honnest I'm not sure. In the program I tested pstack with there was an object with no name in the list of loaded objects and that is what makes pstack fail without the fix. I don't know why the list of loaded objects contains an object with no name so I can't be sure this happens with all programs. Therefore I'm not sure whether this bug has a major effect on the usability of a package or makes the package in question unusable or mostly so. Along with this fix, the package contains minor changes like a new maintainer, bumped compatibility and Standard-Version (both without any additional change needed) The full changelog is: * New maintainer. (Closes: #568574) * Fix fails to open object file error. (Closes: #360922) * debian/control - Remove reference to upstream repository from package description - Bump Standard-Version from 3.6.1 to 3.8.4 (no changes needed). - Set Vcs-Browser and Vcs-Git fields. * debian/compat - Bump debhelper compatibility from 4 to 7 (no changes needed) How do you figure the previous compat level was 4? There was no debian/compat before afaict. Indeed. Probably a copy/paste error. Should I upload a new version to change the compat changelog entry to Set debhelper compatibility to 7? Cheers, Julien Cheers, Thomas Preud'homme signature.asc Description: This is a digitally signed message part.
Bug#595765: unblock: mrd6/0.9.6-3
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: freeze-exception Please unblock package mrd6 as it contains a FTBFS fix for Debian/kFreeBSD. The full changelog is: * Make dl* functions available on all archs (Fix FTBFS on *BSD). * debian/control: + Bumps Standards-Version to 3.9.1 (no changes needed). This version also adds a typo fix in debian/rules and remove build file at clean. This version is in unstable for 24 days and no new bug has been filled. unblock mrd6/0.9.6-3 -- System Information: Debian Release: squeeze/sid APT prefers unstable APT policy: (990, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 2.6.32-5-amd64 (SMP w/4 CPU cores) Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20100906134105.22462.72266.report...@cerclon
Bug#595705: unblock: pstack/1.2-2
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: freeze-exception Please unblock package pstack as it fixes bug #360922 that makes pstack useless. This bug has severity important and pstack satisfy the unblock rules by being of priority optional. Along with this fix, the package contains minor changes like a new maintainer, bumped compatibility and Standard-Version (both without any additional change needed) The full changelog is: * New maintainer. (Closes: #568574) * Fix fails to open object file error. (Closes: #360922) * debian/control - Remove reference to upstream repository from package description - Bump Standard-Version from 3.6.1 to 3.8.4 (no changes needed). - Set Vcs-Browser and Vcs-Git fields. * debian/compat - Bump debhelper compatibility from 4 to 7 (no changes needed) unblock pstack/1.2-2 -- System Information: Debian Release: squeeze/sid APT prefers unstable APT policy: (990, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental') Architecture: i386 (i686) Kernel: Linux 2.6.32-5-686 (SMP w/1 CPU core) Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20100905225515.8326.1733.report...@olivaw.celest.fr
