Bug#1032986: unblock fdroidserver/2.2.1-1

2023-03-21 Thread Hans-Christoph Steiner



Paul Gevers:

Hi,

On 20-03-2023 17:16, Hans-Christoph Steiner wrote:
I haven't really ever been able to troubleshoot it.  I don't have access to a 
s390x box.  And:


  ~ $ ssh zelenka.debian.org
ssh: connect to host zelenka.debian.org port 22: Connection timed out
  ~ $

That's the only porterbox I could find.


It works for me (now). Can you try again?


I got in.

Also, you don't strictly need to troubleshoot it. Obviously it depends on how 
sure you are it's in your dependency, but you said it quite convinced.


I'm 100% sure its the dependency, and I just confirmed it on the porterbox and 
filed a bug upstream:

https://github.com/androguard/androguard/issues/928

Normally we expect a debdiff attached to an unblock. This is mostly to 
trigger the submitter to look at it and make sure that all changes are 
explained. Can you please elaborate on the changes in ./debian/?

   ^


* zipalign is no longer used by fdroidserver

* these patches were upstreamed:
  debian/patches/0005-handle-str-and-pathlib.Path-in-getvcs.patch was upstreamed
  debian/patches/0006-Fix-openjdk-detection-on-different-architectures.patch
  debian/patches/fix-java-paths-for-non-amd64.patch


The debdiff is large because we were working upstream on 2.2.x as the release 
that is tied to Debian/bookworm (attached).


Sure, I already used some tooling on our side to inspect it. It would help if 
you took a look and see if you spot things worth mentioning (e.g. some patches 
being dropped, I don't want to assume things). To reduce the diff you could 
ignore the tests and translations.


There were changes related to have I mentioned above, like purging dead code 
related to zipalign, buildozer, and bug fixes related to a recent port to use 
pathlib.


Also, there were methods added to support verifying JARs and APKs signed by 
SHA1, which are still considered valid by the Android apksigner tool, though 
Java has dropped support for verifying SHA1 signatures.


The download_repo_index_v2() function was to finalize the whole "index-v2" work 
that was completed in fdroidserver 2.2.x.  That was the one last key missing bit.




Bug#1032986: unblock fdroidserver/2.2.1-1

2023-03-20 Thread Paul Gevers

Hi,

On 20-03-2023 17:16, Hans-Christoph Steiner wrote:
I haven't really ever been able to troubleshoot it.  I don't have access 
to a s390x box.  And:


  ~ $ ssh zelenka.debian.org
ssh: connect to host zelenka.debian.org port 22: Connection timed out
  ~ $

That's the only porterbox I could find.


It works for me (now). Can you try again?

Also, you don't strictly need to troubleshoot it. Obviously it depends 
on how sure you are it's in your dependency, but you said it quite 
convinced.


Normally we expect a debdiff attached to an unblock. This is mostly to 
trigger the submitter to look at it and make sure that all changes are 
explained. Can you please elaborate on the changes in ./debian/?

  ^

The debdiff is large because we were working upstream on 2.2.x as the 
release that is tied to Debian/bookworm (attached).


Sure, I already used some tooling on our side to inspect it. It would 
help if you took a look and see if you spot things worth mentioning 
(e.g. some patches being dropped, I don't want to assume things). To 
reduce the diff you could ignore the tests and translations.


And that was 
uploaded before the freeze with passing autopkgtest, besides this s390x 
issue.


Paul


OpenPGP_signature
Description: OpenPGP digital signature


Bug#1032986: unblock fdroidserver/2.2.1-1

2023-03-20 Thread Jochen Sprickerhof

* Hans-Christoph Steiner  [2023-03-20 17:16]:
I haven't really ever been able to troubleshoot it.  I don't have 
access to a s390x box.  And:


~ $ ssh zelenka.debian.org
ssh: connect to host zelenka.debian.org port 22: Connection timed out
~ $


We resolved this with:

https://lists.debian.org/debian-devel-announce/2018/11/msg3.html

(i.e. ssh jumphost)

Cheers Jochen


signature.asc
Description: PGP signature


Bug#1032986: unblock fdroidserver/2.2.1-1

2023-03-19 Thread Paul Gevers

Control: tags -1 moreinfo

Hi,

On 15-03-2023 09:40, Hans-Christoph Steiner wrote:
The current failure on s390x is caused by endian 
issues in androguard, a dependency.


Has that issue been reported? Please add a link.

Normally we expect a debdiff attached to an unblock. This is mostly to 
trigger the submitter to look at it and make sure that all changes are 
explained. Can you please elaborate on the changes in ./debian/?


Paul (who is leaning to unblocking this).


OpenPGP_signature
Description: OpenPGP digital signature


Processed: Re: Bug#1032986: unblock fdroidserver/2.2.1-1

2023-03-19 Thread Debian Bug Tracking System
Processing control commands:

> tags -1 moreinfo
Bug #1032986 [release.debian.org] unblock fdroidserver/2.2.1-1
Added tag(s) moreinfo.

-- 
1032986: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1032986
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#1032986: unblock fdroidserver/2.2.1-1

2023-03-15 Thread Hans-Christoph Steiner

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Please unblock package: fdroidserver

It is blocked due to a autopkgtest failure only on s390x, this failure is not a 
regression.  Since bullseye, we have fixed the issues in fdroidserver that 
caused autopkgtest to fail on ppc64el and s390x.  ppc64el passes now.  The 
current failure on s390x is caused by endian issues in androguard, a dependency. 
 fdroidserver still mostly works on s390x despite these test failures.