Bug#1033442: unblock: golang-go.opencensus/0.24.0-1

[Anthony Fok]

On Fri, Mar 24, 2023 at 3:33 PM Anthony Fok  wrote:

> ratt finds 89 packages with direct or indirect dependency on
> golang-go.opencensus and is able to build all of them with
> with golang-go.opencensus/0.24.0-1 smoothly with no hiccup.

Clarification: Out of the 89 packages, 4 failed but not due to
golang-go.opencensus:

  FAILED: cadvisor (see buildlogs/cadvisor_0.38.7+ds1-2)
  FAILED: golang-github-prometheus-common
(see buildlogs/golang-github-prometheus-common_0.15.0-2)
  FAILED: nomad (see buildlogs/nomad_0.12.10+dfsg1-3)
  FAILED: nomad-driver-podman (see buildlogs/nomad-driver-podman_0.1.0-2)

3 of them, cadvisor, nomad and nomad-driver-podman are currently FTBFS
in the archive and are not in "testing".

As for golang-github-prometheus-common_0.15.0-2, ratt picked the wrong
version in stable (bullseye) instead of 0.39.0-2 in sid.
Apparently, ratt's dependency dose-ceve does not handle the multiple
"same Package, different Version" entries in the source list
and simply picks the first one:

  $ grep -A2 '^Package: golang-github-prometheus-common' \
/var/lib/apt/lists/deb.debian.org_debian_dists_sid_main_source_Sources
  Package: golang-github-prometheus-common
  Binary: golang-github-prometheus-common-dev
  Version: 0.15.0-2
  --
  Package: golang-github-prometheus-common
  Binary: golang-github-prometheus-common-dev
  Version: 0.39.0-2

So, while this erroneous sbuild command fails:
  sbuild --arch-all --dist=unstable --nolog \
  golang-github-prometheus-common_0.15.0-2 \
  --extra-package=../golang-go.opencensus-dev_0.24.0-1_all.deb

the correct sbuild command pointing to the correct version in sid passes:
  sbuild --arch-all --dist=unstable --nolog \
  golang-github-prometheus-common_0.39.0-2 \
  --extra-package=../golang-go.opencensus-dev_0.24.0-1_all.deb

So, yes, it is perfectly safe to upgrade golang-go.opencensus 0.23.0-4
to 0.24.0-1.

Many thanks!

Cheers,
Anthony Fok

Bug#1033442: unblock: golang-go.opencensus/0.24.0-1

[Anthony Fok]

On Fri, Mar 24, 2023 at 3:33 PM Anthony Fok  wrote:
> [ Checklist ]
>   [x] all changes are documented in the d/changelog
>   [x] I reviewed all changes and I approve them
>   [x] attach debdiff against the package in testing

Sorry, I forgot to actually attach the debdiff file.  Attached in this
follow-up message.  :-)

Cheers,
Anthony Fok
diff -Nru golang-go.opencensus-0.23.0/debian/changelog golang-go.opencensus-0.24.0/debian/changelog
--- golang-go.opencensus-0.23.0/debian/changelog	2023-01-04 15:26:48.0 -0700
+++ golang-go.opencensus-0.24.0/debian/changelog	2023-03-09 02:33:15.0 -0700
@@ -1,3 +1,14 @@
+golang-go.opencensus (0.24.0-1) unstable; urgency=medium
+
+  * New upstream version 0.24.0
+  * Reorder fields in debian/control and debian/copyright
+  * Bump versioned dependencies as per go.mod:
+- golang-github-google-go-cmp-dev (>= 0.5.3)
+- golang-github-stretchr-testify-dev (>= 1.8.1)
+- golang-google-grpc-dev (>= 1.33.2)
+
+ -- Anthony Fok   Thu, 09 Mar 2023 02:33:15 -0700
+
 golang-go.opencensus (0.23.0-4) unstable; urgency=medium
 
   * Team upload
diff -Nru golang-go.opencensus-0.23.0/debian/control golang-go.opencensus-0.24.0/debian/control
--- golang-go.opencensus-0.23.0/debian/control	2023-01-02 09:30:05.0 -0700
+++ golang-go.opencensus-0.24.0/debian/control	2023-03-09 02:32:16.0 -0700
@@ -1,36 +1,36 @@
 Source: golang-go.opencensus
+Section: golang
+Priority: optional
 Maintainer: Debian Go Packaging Team 
 Uploaders: Stephen Gelman ,
Anthony Fok 
-Section: golang
-Testsuite: autopkgtest-pkg-go
-Priority: optional
+Rules-Requires-Root: no
 Build-Depends: debhelper-compat (= 13),
dh-golang,
golang-any,
-   golang-github-google-go-cmp-dev (>= 0.3.0),
+   golang-github-google-go-cmp-dev (>= 0.5.3),
golang-github-golang-groupcache-dev,
-   golang-github-stretchr-testify-dev (>= 1.4.1),
+   golang-github-stretchr-testify-dev (>= 1.8.1),
golang-golang-x-net-dev,
-   golang-google-grpc-dev (>= 1.20.1),
+   golang-google-grpc-dev (>= 1.33.2),
golang-github-golang-protobuf-1-3-dev
+Testsuite: autopkgtest-pkg-go
 Standards-Version: 4.6.2
 Vcs-Browser: https://salsa.debian.org/go-team/packages/golang-go.opencensus
 Vcs-Git: https://salsa.debian.org/go-team/packages/golang-go.opencensus.git
 Homepage: https://github.com/census-instrumentation/opencensus-go
-Rules-Requires-Root: no
 XS-Go-Import-Path: go.opencensus.io
 
 Package: golang-go.opencensus-dev
 Architecture: all
 Multi-Arch: foreign
-Depends: ${misc:Depends},
- golang-github-google-go-cmp-dev (>= 0.3.0),
+Depends: golang-github-google-go-cmp-dev (>= 0.5.3),
  golang-github-golang-groupcache-dev,
- golang-github-stretchr-testify-dev (>= 1.4.1),
+ golang-github-stretchr-testify-dev (>= 1.8.1),
  golang-golang-x-net-dev,
- golang-google-grpc-dev (>= 1.20.1),
- golang-github-golang-protobuf-1-3-dev | golang-github-golang-protobuf-1-5-dev
+ golang-google-grpc-dev (>= 1.33.2),
+ golang-github-golang-protobuf-1-3-dev | golang-github-golang-protobuf-1-5-dev,
+ ${misc:Depends}
 Description: Stats collection and distributed tracing framework
  OpenCensus Go is a Go implementation of OpenCensus, a toolkit for
  collecting application performance and behavior monitoring data.
diff -Nru golang-go.opencensus-0.23.0/debian/copyright golang-go.opencensus-0.24.0/debian/copyright
--- golang-go.opencensus-0.23.0/debian/copyright	2022-12-31 17:30:47.0 -0700
+++ golang-go.opencensus-0.24.0/debian/copyright	2023-03-09 02:30:39.0 -0700
@@ -1,9 +1,9 @@
 Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
-Upstream-Name: go.opencensus.io
 Source: https://github.com/census-instrumentation/opencensus-go
+Upstream-Name: go.opencensus.io
 
 Files: *
-Copyright: 2017-2019 OpenCensus
+Copyright: 2017-2022 OpenCensus
 License: Apache-2.0
 
 Files: debian/*
@@ -23,6 +23,6 @@
  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  See the License for the specific language governing permissions and
  limitations under the License.
- .
+Comment:
  On Debian systems, the complete text of the Apache version 2.0 license
  can be found in "/usr/share/common-licenses/Apache-2.0".
diff -Nru golang-go.opencensus-0.23.0/examples/derived_gauges/derived_gauge.go golang-go.opencensus-0.24.0/examples/derived_gauges/derived_gauge.go
--- golang-go.opencensus-0.23.0/examples/derived_gauges/derived_gauge.go	2021-02-12 09:50:36.0 -0700
+++ golang-go.opencensus-0.24.0/examples/derived_gauges/derived_gauge.go	2022-11-03 14:13:50.0 -0600
@@ -20,7 +20,7 @@
 // items. Consumer randomly consumes 1-5 items in each attempt. It then sleeps randomly
 // between 1-10 seconds before the next attempt. Two metrics collected to monitor the queue.
 

Bug#1033442: unblock: golang-go.opencensus/0.24.0-1

[Anthony Fok]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: golang-go.opencen...@packages.debian.org, 
debian...@lists.debian.org, f...@debian.org
Control: affects -1 + src:golang-go.opencensus

Please unblock package golang-go.opencensus/0.24.0-1

packer/1.6.6+ds1-7 in testing has an RC bug (#1032525) and is scheduled
for autoremoval on 2023-04-06.  The fix was uploaded by its maintainer
Shengjing Zhu in packer/1.6.6+ds2-1 on 2023-03-13, but it is currently
prevented from migrating to testing to due to being blocked by its
indirect dependency on golang-go.opencensus.

My apologies for my untimely upload of golang-go.opencensus/0.24.0-1
on 2023-03-09, assuming that it would enter testing automatically
after 20 days, not knowing that it is a key package that would require
a manual unblock.

Risks of upgrading from 0.23.0 to 0.24.0 is minimal, as the changes
consist of minor bug fixes with a small addition to the API.
ratt finds 89 packages with direct or indirect dependency on
golang-go.opencensus and is able to build all of them with
with golang-go.opencensus/0.24.0-1 smoothly with no hiccup.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

unblock golang-go.opencensus/0.24.0-1

Thanks for your help!

Cheers,

Anthony Fok