Processed: Re: Bug#1061774: nmu: pngcheck_3.0.3-1
Processing control commands: > reassign -1 fitspng 2.0-1 Bug #1061774 [release.debian.org] nmu: pngcheck_3.0.3-1 Bug reassigned from package 'release.debian.org' to 'fitspng'. Ignoring request to alter found versions of bug #1061774 to the same values previously set Ignoring request to alter fixed versions of bug #1061774 to the same values previously set Bug #1061774 [fitspng] nmu: pngcheck_3.0.3-1 Marked as found in versions fitspng/2.0-1. > retitle -1 fitspng: prints warnings on zlib updates Bug #1061774 [fitspng] nmu: pngcheck_3.0.3-1 Changed Bug title to 'fitspng: prints warnings on zlib updates' from 'nmu: pngcheck_3.0.3-1'. -- 1061774: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1061774 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#1061774: nmu: pngcheck_3.0.3-1
Control: reassign -1 fitspng 2.0-1 Control: retitle -1 fitspng: prints warnings on zlib updates On 2024-01-29 13:56:14 -0300, David da Silva Polverari wrote: > On Mon, Jan 29, 2024 at 04:45:59PM +0100, Filip Hroch wrote: > > Dear Release Team, > > > > may I ask you to rebuild pngcheck package against to > > the current version of zlib? > > > > I'm maintainer of fitspng package having bug #1059970, > > and I found that the bug is not related on fitspng itself. > > Actually, it is caused by pngcheck during CI tests > > verification. The current binary of pngcheck is compiled > > against an old zlib yet, and needs a recompilation. > > > In my opinion, there is no need for a rebuild. This is just a warning > that upstream deemed useful to include on the program. If tests are > failing because of that, I believe that fitspng tests are the ones that > should be updated to take that behaviour into account (using > allow-stderr and grepping for the 'OK', for example). If zlib's SONAME > hasn't changed, there's not need to link against a newer version. The warning is mostly pointless for Debian. Minimum requirements are expressed via dependencies and if zlib's ABI breaks it has to change its SONAME. Reassinging to fitspng. Cheers -- Sebastian Ramacher
Bug#1061774: nmu: pngcheck_3.0.3-1
On Mon, Jan 29, 2024 at 04:45:59PM +0100, Filip Hroch wrote: > Dear Release Team, > > may I ask you to rebuild pngcheck package against to > the current version of zlib? > > I'm maintainer of fitspng package having bug #1059970, > and I found that the bug is not related on fitspng itself. > Actually, it is caused by pngcheck during CI tests > verification. The current binary of pngcheck is compiled > against an old zlib yet, and needs a recompilation. > In my opinion, there is no need for a rebuild. This is just a warning that upstream deemed useful to include on the program. If tests are failing because of that, I believe that fitspng tests are the ones that should be updated to take that behaviour into account (using allow-stderr and grepping for the 'OK', for example). If zlib's SONAME hasn't changed, there's not need to link against a newer version. Regards, David
Bug#1061774: nmu: pngcheck_3.0.3-1
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: binnmu
X-Debbugs-Cc: pngch...@packages.debian.org
Control: affects -1 + src:pngcheck
Dear Release Team,
may I ask you to rebuild pngcheck package against to
the current version of zlib?
I'm maintainer of fitspng package having bug #1059970,
and I found that the bug is not related on fitspng itself.
Actually, it is caused by pngcheck during CI tests
verification. The current binary of pngcheck is compiled
against an old zlib yet, and needs a recompilation.
A test run under sid (as well as trixie) has revealed:
x@trixiesid:/tmp/xxx$ pngcheck hippo.png
zlib warning: different version (expected 1.2.13, using 1.3)
OK: hippo.png (139x152, 24-bit RGB, non-interlaced, 38.7%).
The string can be identified as the part of the source of pngcheck.c
(https://salsa.debian.org/debian/pngcheck/-/blob/debian/master/pngcheck.c)
which compares versions of the run-time zlib and the zlib compiled in:
...
} else if (strcmp(zlib_version, ZLIB_VERSION) != 0) {
fprintf(stderr, "zlib warning: different version (expected %s,"
" using %s)\n\n", ZLIB_VERSION, zlib_version);
}
..
In my opinion, the test on a zlib version is greatly valuable,
although it may create doubts during those transitional phases.
Thank you,
FH
nmu pngcheck_3.0.3-1 . ANY . -m "Rebuild against a new version of zlib."
