Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian@packages.debian.org
Usertags: pu
X-Debbugs-Cc: David Steele
Control: block 1041447 with -1
Control: tag -1 + src:comitup
[ Reason ]
On certain upgrade paths installation/upgrade will fail if a masked
service file from a previous installation is still present.
[ Impact ]
This is mostly triggered by QA tests.
[ Tests ]
Local piuparts tests of the affected upgrade path.
[ Risks ]
Low. Unmasking a not masked service is a no-op.
[ Checklist ]
[x] *all* changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in (old)stable
[x] the issue is verified as fixed in unstable
[ Changes ]
-comitup (1.38-1.1) unstable; urgency=medium
+comitup (1.38-2~deb12u1) bookworm; urgency=medium
* Non-maintainer upload.
- * No source change upload to rebuild with debhelper 13.10.
+ * Rebuild for bookworm.
- -- Michael Biebl Sat, 15 Oct 2022 11:57:26 +0200
+ -- Andreas Beckmann Fri, 19 Apr 2024 14:56:56 +0200
+
+comitup (1.38-2) unstable; urgency=medium
+
+ * Ensure service is unmasked in post install (Closes: #1041447).
+
+ -- David Steele Fri, 28 Jul 2023 17:12:44 -0400
There is also a new autopkgtest, but it is unrelated to this issue.
[ Other info ]
This is a rebuild of the package that has been in sid and testing for 5
months before it got superseded by a new upstream release.
Andreas
diff -Nru comitup-1.38/debian/changelog comitup-1.38/debian/changelog
--- comitup-1.38/debian/changelog 2022-10-15 11:57:26.0 +0200
+++ comitup-1.38/debian/changelog 2024-04-19 14:56:56.0 +0200
@@ -1,9 +1,15 @@
-comitup (1.38-1.1) unstable; urgency=medium
+comitup (1.38-2~deb12u1) bookworm; urgency=medium
* Non-maintainer upload.
- * No source change upload to rebuild with debhelper 13.10.
+ * Rebuild for bookworm.
- -- Michael Biebl Sat, 15 Oct 2022 11:57:26 +0200
+ -- Andreas Beckmann Fri, 19 Apr 2024 14:56:56 +0200
+
+comitup (1.38-2) unstable; urgency=medium
+
+ * Ensure service is unmasked in post install (Closes: #1041447).
+
+ -- David Steele Fri, 28 Jul 2023 17:12:44 -0400
comitup (1.38-1) unstable; urgency=medium
diff -Nru comitup-1.38/debian/comitup.postinst
comitup-1.38/debian/comitup.postinst
--- comitup-1.38/debian/comitup.postinst2022-07-08 04:51:57.0
+0200
+++ comitup-1.38/debian/comitup.postinst2023-07-28 21:02:12.0
+0200
@@ -12,6 +12,7 @@
rm -f /etc/NetworkManager/dnsmasq-shared.d/nm-dns-sabotage.conf
fi
+systemctl unmask comitup
systemctl enable comitup
python3 /usr/share/comitup/comitup/wificheck.py || true
diff -Nru comitup-1.38/debian/tests/control comitup-1.38/debian/tests/control
--- comitup-1.38/debian/tests/control 2022-07-08 04:51:57.0 +0200
+++ comitup-1.38/debian/tests/control 2023-07-28 03:54:33.0 +0200
@@ -1,4 +1,5 @@
Test-Command: py.test-3 test/test_config.py test/test_persist.py test/test_web*
+Features: test-name=pytest
Depends:
@,
@builddeps@,
@@ -8,3 +9,6 @@
python3-dev,
libdbus-glib-1-dev,
libdbus-1-dev
+
+Tests: fileloc
+Depends: @, bash
diff -Nru comitup-1.38/debian/tests/fileloc comitup-1.38/debian/tests/fileloc
--- comitup-1.38/debian/tests/fileloc 1970-01-01 01:00:00.0 +0100
+++ comitup-1.38/debian/tests/fileloc 2023-07-28 03:54:33.0 +0200
@@ -0,0 +1,20 @@
+#!/bin/bash
+
+declare -a Paths=("/etc/comitup.conf" \
+ "/etc/dbus-1/system.d/comitup-dbus.conf" \
+ "/lib/systemd/system/comitup.service" \
+ "/usr/share/comitup/comitup-cmd" \
+ "/usr/share/comitup/web/comitupweb.py"\
+ "/usr/sbin/comitup" \
+ "/var/lib/comitup" \
+ "/usr/share/comitup/comitup/comitup.py")
+
+retval=0
+for path in ${Paths[@]}; do
+if [ ! -e $path ]; then
+echo "Not found - $path"
+retval=1
+fi
+done
+
+exit $retval
