Bug#1070761: bullseye-pu: package bart-cuda/0.6.00-1+deb11u1

2024-05-14 Thread Santiago Vila

Nevermind. I see that the upload was already accepted, and what is
missing is a binary-only upload matching the already existing source.



Yes, sorry if I wasn't clear enough about that.


No problem. I've now done the additional binary-only upload.

Thanks a lot.



Bug#1070761: bullseye-pu: package bart-cuda/0.6.00-1+deb11u1

2024-05-14 Thread Adam D. Barratt
On Tue, 2024-05-14 at 20:51 +0200, Santiago Vila wrote:
> > > As bart-cuda build-depends on nvidia-cuda-toolkit, which is in
> > > non-
> > > free, bart-cuda is not buildable on the buildd network, so this
> > > will
> > > also need a binary upload to be performed.
> > 
> > Ok, what's the best way to solve this? Can you reject the upload
> > so that I do it again including .debs?
> 
> Nevermind. I see that the upload was already accepted, and what is
> missing is a binary-only upload matching the already existing source.
> 

Yes, sorry if I wasn't clear enough about that.

> I'll make the missing binary upload.

Thanks.

Regards,

Adam



Bug#1070761: bullseye-pu: package bart-cuda/0.6.00-1+deb11u1

2024-05-14 Thread Santiago Vila

As bart-cuda build-depends on nvidia-cuda-toolkit, which is in non-
free, bart-cuda is not buildable on the buildd network, so this will
also need a binary upload to be performed.


Ok, what's the best way to solve this? Can you reject the upload
so that I do it again including .debs?


Nevermind. I see that the upload was already accepted, and what is missing
is a binary-only upload matching the already existing source.

I'll make the missing binary upload.

Thanks.



Bug#1070761: bullseye-pu: package bart-cuda/0.6.00-1+deb11u1

2024-05-14 Thread Santiago Vila

El 14/5/24 a las 20:24, Adam D. Barratt escribió:

On Wed, 2024-05-08 at 17:18 +0200, Santiago Vila wrote:

This upload fixes Bug #1070757 FTBFS in bullseye.
Note: A similar request for a similar bug has been made for package
"bart".

[ Impact ]
Anybody who try to build the package from source may find
that the package FTBFS unexpectedly.


As bart-cuda build-depends on nvidia-cuda-toolkit, which is in non-
free, bart-cuda is not buildable on the buildd network, so this will
also need a binary upload to be performed.


Ok, what's the best way to solve this? Can you reject the upload
so that I do it again including .debs?

Thanks.



Bug#1070761: bullseye-pu: package bart-cuda/0.6.00-1+deb11u1

2024-05-14 Thread Adam D. Barratt
On Wed, 2024-05-08 at 17:18 +0200, Santiago Vila wrote:
> This upload fixes Bug #1070757 FTBFS in bullseye.
> Note: A similar request for a similar bug has been made for package
> "bart".
> 
> [ Impact ]
> Anybody who try to build the package from source may find
> that the package FTBFS unexpectedly.

As bart-cuda build-depends on nvidia-cuda-toolkit, which is in non-
free, bart-cuda is not buildable on the buildd network, so this will
also need a binary upload to be performed.

Regards,

Adam



Bug#1070761: bullseye-pu: package bart-cuda/0.6.00-1+deb11u1

2024-05-08 Thread Santiago Vila

Package: release.debian.org
Severity: normal
Tags: bullseye
User: release.debian@packages.debian.org
Usertags: pu
X-Debbugs-Cc: bart-c...@packages.debian.org, sanv...@debian.org
Control: affects -1 + src:bart-cuda

[ Reason ]
This upload fixes Bug #1070757 FTBFS in bullseye.
Note: A similar request for a similar bug has been made for package "bart".

[ Impact ]
Anybody who try to build the package from source may find
that the package FTBFS unexpectedly.

[ Tests ]
I've tested the fixed package in the AWS instances where it
used to fail, and it does not fail anymore.

[ Risks ]
Very low risk, as the change merely increases the tolerance for
a floating point comparison in the tests. The program itself
does not really change.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
See debdiff.

[ Other info ]
I'm going to upload the package after sending this report,
but I'll wait for approval before pushing changes to salsa.diff -Nru bart-cuda-0.6.00/debian/changelog bart-cuda-0.6.00/debian/changelog
--- bart-cuda-0.6.00/debian/changelog   2020-12-18 21:23:31.0 +0100
+++ bart-cuda-0.6.00/debian/changelog   2024-05-08 16:40:00.0 +0200
@@ -1,3 +1,11 @@
+bart-cuda (0.6.00-1+deb11u1) bullseye; urgency=medium
+
+  * Team upload.
+  * Cherry-pick relax-failing-unit-test.patch from release 0.7.00-1.
+Fixes FTBFS bug. Closes: #1070757.
+
+ -- Santiago Vila   Wed, 08 May 2024 16:40:00 +0200
+
 bart-cuda (0.6.00-1) unstable; urgency=medium
 
   * Initial upload of this cuda enabled bart version
diff -Nru bart-cuda-0.6.00/debian/patches/0005-relax-failing-unit-test.patch 
bart-cuda-0.6.00/debian/patches/0005-relax-failing-unit-test.patch
--- bart-cuda-0.6.00/debian/patches/0005-relax-failing-unit-test.patch  
1970-01-01 01:00:00.0 +0100
+++ bart-cuda-0.6.00/debian/patches/0005-relax-failing-unit-test.patch  
2024-05-08 16:40:00.0 +0200
@@ -0,0 +1,19 @@
+From: Martin Uecker 
+Date: Mon, 25 Oct 2021 18:59:03 +0200
+Subject: relax failing unit test
+
+---
+ utests/test_nufft.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/utests/test_nufft.c
 b/utests/test_nufft.c
+@@ -114,7 +114,7 @@
+ 
+   debug_printf(DP_DEBUG1, "adjoint diff: %f\n", diff);
+ 
+-  bool ret = (diff < 1.E-6f);
++  bool ret = (diff < 1.E-5f);
+ 
+   linop_free(op);
+ 
diff -Nru bart-cuda-0.6.00/debian/patches/series 
bart-cuda-0.6.00/debian/patches/series
--- bart-cuda-0.6.00/debian/patches/series  2020-12-18 21:23:31.0 
+0100
+++ bart-cuda-0.6.00/debian/patches/series  2024-05-08 16:40:00.0 
+0200
@@ -2,3 +2,4 @@
 0002-remove-empty-directory.patch
 0003-deactivate-ode-unit-tests.patch
 0004-change-cuda-library.patch
+0005-relax-failing-unit-test.patch