Bug#769323: unblock: libaudio-mpd-perl/2.000-2

2014-11-15 Thread intrigeri
Hi,

gregor herrmann wrote (12 Nov 2014 20:13:24 GMT) :
 libaudio-mpd-perl (2.000-2) unstable; urgency=medium

   * Add patch to make tests work with mpd = 0.19.

 One tests checks for the accumulated playtime of the audio samples.
 Test::Corpus::Audio::MPD contains 5 tracks just over 1.8 seconds each.
 mpd  0.19 rounded each track up to 2 seconds then added the lengths in
 seconds to get 10s, but mpd = 0.19 adds up the lengths in ms and then
 rounds it down to 9s.
 Change this test to look for = 9 and = 10 seconds.

 Thanks to Simon McVittie for the patch. (Closes: #768692)

  -- gregor herrmann gre...@debian.org  Wed, 12 Nov 2014 20:52:49 +0100

Looks good to me: the patch is minimal, the code makes sense, and
I confirm it fixes the FTBFS it's supposed to fix.

(No reply from upstream, to whom the bug was submitted, yet.)

 unblock libaudio-mpd-perl/2.000-2

Yay.

Cheers,
--
intrigeri


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/85mw7see8z@boum.org



Bug#769323: unblock: libaudio-mpd-perl/2.000-2

2014-11-15 Thread gregor herrmann
On Sat, 15 Nov 2014 15:21:16 +0100, intrigeri wrote:

 gregor herrmann wrote (12 Nov 2014 20:13:24 GMT) :
  libaudio-mpd-perl (2.000-2) unstable; urgency=medium
 
* Add patch to make tests work with mpd = 0.19.

 Looks good to me: the patch is minimal, the code makes sense, and
 I confirm it fixes the FTBFS it's supposed to fix.
 
 (No reply from upstream, to whom the bug was submitted, yet.)

Thanks for double-checking!

(The patch is BTW the same as in libpoe-component-client-mpd-perl
which was already ACKed in #769324)
 

Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT  SPI, fellow of the Free Software Foundation Europe
   `-   NP: Bettina Wegner: Traurig bin ich sowieso


signature.asc
Description: Digital Signature


Bug#769323: unblock: libaudio-mpd-perl/2.000-2

2014-11-12 Thread gregor herrmann
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Please unblock package libaudio-mpd-perl:

2.000-2 adds a patch to fix #768692

Changelog with the explanation for the changes:


libaudio-mpd-perl (2.000-2) unstable; urgency=medium

  * Add patch to make tests work with mpd = 0.19.

One tests checks for the accumulated playtime of the audio samples.
Test::Corpus::Audio::MPD contains 5 tracks just over 1.8 seconds each.
mpd  0.19 rounded each track up to 2 seconds then added the lengths in
seconds to get 10s, but mpd = 0.19 adds up the lengths in ms and then
rounds it down to 9s.
Change this test to look for = 9 and = 10 seconds.

Thanks to Simon McVittie for the patch. (Closes: #768692)

 -- gregor herrmann gre...@debian.org  Wed, 12 Nov 2014 20:52:49 +0100


Full debdiff attached.


unblock libaudio-mpd-perl/2.000-2


Cheers,
gregor

-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQJ8BAEBCgBmBQJUY79kXxSAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREMUUxMzE2RTkzQTc2MEE4MTA0RDg1RkFC
QjNBNjgwMTg2NDlBQTA2AAoJELs6aAGGSaoGINQP/RDJKIpSXFwvJ6ypki5TVsAv
HQkGC3L2WFkTJ1+ph4ql95xENmWM767NUIk4wQpX+wyNDFDGwmYLtpMruziV29eS
k0iZRgctsVYiilERjgNkZbLSRPJ+7zVLdaqFERrOKTZDR0HOvPbUwureAavOpw3J
E9Z7jGJ51YUvZb7Al5gCnyUKOs78kYSYvekhHSSvQip0DIsrfBuTXpEWz0YcR5PI
0xnOe8jIurh3P0hokD4Yp+DAWZTfM3tbXnkszHo6jm1P8cvcax5+/OeWQLOcFw/g
FFFVku5pn4jjIbqP/RkeUGzlb2lfFi0yJ0uLmxmAgBcbAqc5fldai1c16/pR/YjY
iZyvB9xnuQMNXe84neobjylbEQG57PLFcqZyZ6Afr6EDRU7lAq4Afi+IPFgol9k9
Zuff2sl1zZZPO7fNVehS46sujpYB0IwnV0wxDwcFNkuFo1v19U6AG811aZh+1NY7
bupcFraI6l346RMjVxYBpbs094jrewlerpWiPDJNwPOq0SOojGXKhwC+UMpkxXnY
39/r6HwZ6ePiZDriHj2FF70dG9h5ZkgKNFGQ9ZbHm9sTbFn0iU4MJxxZHJMcxKSX
iN9ZrLBaACHm43mtLkekTO5+wvvRS6kGKYxDNXcgkKUDA9LIolGGq9s1gRDUSEOv
XDoL0Mb7zTJy/inNogDh
=mZoZ
-END PGP SIGNATURE-
diff -Nru libaudio-mpd-perl-2.000/debian/changelog libaudio-mpd-perl-2.000/debian/changelog
--- libaudio-mpd-perl-2.000/debian/changelog	2014-06-11 19:40:31.0 +0200
+++ libaudio-mpd-perl-2.000/debian/changelog	2014-11-12 20:55:48.0 +0100
@@ -1,3 +1,18 @@
+libaudio-mpd-perl (2.000-2) unstable; urgency=medium
+
+  * Add patch to make tests work with mpd = 0.19.
+
+One tests checks for the accumulated playtime of the audio samples.
+Test::Corpus::Audio::MPD contains 5 tracks just over 1.8 seconds each.
+mpd  0.19 rounded each track up to 2 seconds then added the lengths in
+seconds to get 10s, but mpd = 0.19 adds up the lengths in ms and then
+rounds it down to 9s.
+Change this test to look for = 9 and = 10 seconds.
+
+Thanks to Simon McVittie for the patch. (Closes: #768692)
+
+ -- gregor herrmann gre...@debian.org  Wed, 12 Nov 2014 20:52:49 +0100
+
 libaudio-mpd-perl (2.000-1) unstable; urgency=low
 
   [ Alessandro Ghedini ]
diff -Nru libaudio-mpd-perl-2.000/debian/patches/mpd-0.19.patch libaudio-mpd-perl-2.000/debian/patches/mpd-0.19.patch
--- libaudio-mpd-perl-2.000/debian/patches/mpd-0.19.patch	1970-01-01 01:00:00.0 +0100
+++ libaudio-mpd-perl-2.000/debian/patches/mpd-0.19.patch	2014-11-12 20:55:48.0 +0100
@@ -0,0 +1,34 @@
+Description: Adjust test to mpd = 0.19
+ Test::Corpus::Audio::MPD contains 5 tracks just over 1.8 seconds each.
+ mpd  0.19 rounded each track up to 2 seconds then added the lengths
+ in seconds to get 10s, but mpd = 0.19 adds up the lengths in ms and then
+ rounds it down to 9s.
+Bug-Debian: https://bugs.debian.org/768692
+Origin: vendor
+Author: Simon McVittie s...@debian.org
+Reviewed-by: gregor herrmann gre...@debian.org
+Last-Update: 2014-11-12
+Forwarded: https://rt.cpan.org/Ticket/Display.html?id=100300
+Bug: https://rt.cpan.org/Ticket/Display.html?id=100300
+
+--- a/t/24-info.t
 b/t/24-info.t
+@@ -18,7 +18,7 @@
+ eval 'use Test::Corpus::Audio::MPD';
+ plan skip_all = $@ if $@ =~ s/\n+Compilation failed.*//s;
+ 
+-plan tests = 16;
++plan tests = 17;
+ my $mpd = Audio::MPD-new;
+ my $song;
+ 
+@@ -34,7 +34,8 @@
+ is( $stats-albums,   1, 'one album in the database' );
+ is( $stats-songs,5, '5 songs in the database' );
+ is( $stats-playtime, 0, 'already played 0 seconds' );
+-is( $stats-db_playtime, 10, '10 seconds worth of music in the db' );
++cmp_ok( $stats-db_playtime, '=', 9, '= 9 seconds worth of music in the db' );
++cmp_ok( $stats-db_playtime, '=', 10, '= 10 seconds worth of music in the db' );
+ isnt( $stats-uptime, undef, 'uptime is defined' );
+ isnt( $stats-db_update,  0, 'database has been updated' );
+ 
diff -Nru libaudio-mpd-perl-2.000/debian/patches/series libaudio-mpd-perl-2.000/debian/patches/series
--- libaudio-mpd-perl-2.000/debian/patches/series	1970-01-01 01:00:00.0 +0100
+++ libaudio-mpd-perl-2.000/debian/patches/series	2014-11-12 20:55:48.0 +0100
@@ -0,0 +1 @@
+mpd-0.19.patch