Processed: Re: Bug#862173: jessie-pu: package offlineimap/6.3.4-1

[Debian Bug Tracking System]

Processing control commands:

> tags -1 + pending
Bug #862173 [release.debian.org] jessie-pu: package offlineimap/6.3.4-1
Added tag(s) pending.

-- 
862173: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=862173
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#862173: jessie-pu: package offlineimap/6.3.4-1

[Adam D. Barratt]

Control: tags -1 + pending

On Sat, 2017-07-15 at 11:46 +0100, Adam D. Barratt wrote:
> Control: tags -1 + confirmed
> 
> On Tue, 2017-05-09 at 15:29 +0300, Ilias Tsitsimpis wrote:
> > I would like to update OfflineIMAP in jessie, to fix the #859478 RC bug.
> > Backporting the fix from newer versions of the software is too invasive,
> > so instead I have added a WARNING message, that will prevent users from
> > using the broken functionality. For more information, please see the
> > related bug report.
> 
> +offlineimap (6.3.4-1+deb8u1) stable-proposed-updates; urgency=medium
> 
> That wants a distribution of "jessie", please (not least because right
> now the proposed version wouldn't reach jessie at all).
> 
> Please go ahead.

Uploaded and flagged for acceptance.

Regards,

Adam

Processed: Re: Bug#862173: jessie-pu: package offlineimap/6.3.4-1

[Debian Bug Tracking System]

Processing control commands:

> tags -1 + confirmed
Bug #862173 [release.debian.org] jessie-pu: package offlineimap/6.3.4-1
Added tag(s) confirmed.

-- 
862173: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=862173
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#862173: jessie-pu: package offlineimap/6.3.4-1

[Adam D. Barratt]

Control: tags -1 + confirmed

On Tue, 2017-05-09 at 15:29 +0300, Ilias Tsitsimpis wrote:
> I would like to update OfflineIMAP in jessie, to fix the #859478 RC bug.
> Backporting the fix from newer versions of the software is too invasive,
> so instead I have added a WARNING message, that will prevent users from
> using the broken functionality. For more information, please see the
> related bug report.

+offlineimap (6.3.4-1+deb8u1) stable-proposed-updates; urgency=medium

That wants a distribution of "jessie", please (not least because right
now the proposed version wouldn't reach jessie at all).

Please go ahead.

Regards,

Adam

Bug#862173: jessie-pu: package offlineimap/6.3.4-1

[Cyril Brulebois]

Hi Ilias,

Ilias Tsitsimpis  (2017-05-09):
> Dear Release Team,
> 
> I would like to update OfflineIMAP in jessie, to fix the #859478 RC bug.
> Backporting the fix from newer versions of the software is too invasive,
> so instead I have added a WARNING message, that will prevent users from
> using the broken functionality. For more information, please see the
> related bug report.

The patch looks good to me, except you want to be targetting “jessie”.

I feel uneasy about approving this change myself since I'm the one having
filed the original bug report, and I think it would make sense to let
someone else from the release team double check this update.


KiBi.


signature.asc
Description: Digital signature

Bug#862173: jessie-pu: package offlineimap/6.3.4-1

[Ilias Tsitsimpis]

Package: release.debian.org
Severity: normal
Tags: jessie
User: release.debian@packages.debian.org
Usertags: pu

Dear Release Team,

I would like to update OfflineIMAP in jessie, to fix the #859478 RC bug.
Backporting the fix from newer versions of the software is too invasive,
so instead I have added a WARNING message, that will prevent users from
using the broken functionality. For more information, please see the
related bug report.

Best,

-- 
Ilias
diff -Nru offlineimap-6.3.4/debian/changelog offlineimap-6.3.4/debian/changelog
--- offlineimap-6.3.4/debian/changelog	2011-08-23 17:27:40.0 +0300
+++ offlineimap-6.3.4/debian/changelog	2017-05-09 15:14:10.0 +0300
@@ -1,3 +1,15 @@
+offlineimap (6.3.4-1+deb8u1) stable-proposed-updates; urgency=medium
+
+  * Prevent the usage of maxage.
+The implementation of maxage is broken in this version of OfflineIMAP
+(v6.3.4) and may even result in data loss. Document the above behavior in
+the example conf file and also warn the user every time this feature is
+being used (Closes: #859478).
+  * Set myself as the maintainer.
+Package has already been adopted in unstable.
+
+ -- Ilias Tsitsimpis   Tue, 09 May 2017 15:14:10 +0300
+
 offlineimap (6.3.4-1) unstable; urgency=low
 
   * New upstream release.
diff -Nru offlineimap-6.3.4/debian/control offlineimap-6.3.4/debian/control
--- offlineimap-6.3.4/debian/control	2011-08-23 17:27:40.0 +0300
+++ offlineimap-6.3.4/debian/control	2017-04-11 13:08:40.0 +0300
@@ -1,7 +1,7 @@
 Source: offlineimap
 Section: mail
 Priority: optional
-Maintainer: John Francesco Ferlito 
+Maintainer: Ilias Tsitsimpis 
 Build-Depends: debhelper (>= 7.0.50~)
 Build-Depends-Indep: python-support (>= 0.4.0), python-docutils, quilt
 Standards-Version: 3.9.1
diff -Nru offlineimap-6.3.4/debian/patches/Prevent-usage-of-maxage.patch offlineimap-6.3.4/debian/patches/Prevent-usage-of-maxage.patch
--- offlineimap-6.3.4/debian/patches/Prevent-usage-of-maxage.patch	1970-01-01 02:00:00.0 +0200
+++ offlineimap-6.3.4/debian/patches/Prevent-usage-of-maxage.patch	2017-04-11 16:52:45.0 +0300
@@ -0,0 +1,43 @@
+Description: Prevent the usage of maxage
+ The implementation of maxage is broken in this version of OfflineIMAP (v6.3.4)
+ and may even result in data loss. Document the above behavior in the example
+ conf file and also warn the user every time this feature is being used.
+Author: Ilias Tsitsimpis 
+Bug-Debian: https://bugs.debian.org/859478
+Forwarded: no, fixed in newer versions
+
+Index: b/offlineimap.conf
+===
+--- a/offlineimap.conf
 b/offlineimap.conf
+@@ -237,6 +237,10 @@ remoterepository = RemoteExample
+ # calculate the earliest day that would be included in the search and include all 
+ # messages from that day until today.   e.g. maxage = 3 to sync only the last 3 days mail
+ 
++# WARNING: The implementation of maxage is broken in this version of OfflineIMAP
++# and may result in data loss. You should avoid its use, or update to a newer
++# version. For more information, please see https://bugs.debian.org/859478.
++
+ # maxage = 3
+ 
+ 
+Index: b/offlineimap/accounts.py
+===
+--- a/offlineimap/accounts.py
 b/offlineimap/accounts.py
+@@ -169,6 +169,15 @@ class SyncableAccount(Account):
+ self.localrepos  = Repository(self, 'local')
+ self.statusrepos = Repository(self, 'status')
+ 
++# Warn if maxage is being used, since it is broken on this version.
++# For more information, see https://bugs.debian.org/859478.
++maxage = self.getconfint("maxage", -1)
++if maxage != -1:
++self.ui.warn("maxage has been enabled for account `%s'."
++" This feature is broken in the current version of OfflineIMAP"
++" and may result in data loss. You should avoid its use,"
++" or update to a newer version." % self.name)
++
+ # Loop account sync if needed (bail out after 3 failures)
+ looping = 3
+ while looping:
diff -Nru offlineimap-6.3.4/debian/patches/series offlineimap-6.3.4/debian/patches/series
--- offlineimap-6.3.4/debian/patches/series	2011-08-23 17:27:40.0 +0300
+++ offlineimap-6.3.4/debian/patches/series	2017-04-11 13:08:08.0 +0300
@@ -1 +1,2 @@
 0001-Fix-manpage-build-failures-from-inconsistent-heading.patch
+Prevent-usage-of-maxage.patch