Bug#863093: jessie-pu: package libwnckmm/0.1.1-1+deb8u1

[Samuel Thibault]

Hello,

Cyril Brulebois, on sam. 02 déc. 2017 20:08:50 +0100, wrote:
> Following a poke from Julien, I've just checked this issue again

Thanks!

(This was still lying in my mbox for me to find time to look at the
details)
Samuel

Bug#863093: jessie-pu: package libwnckmm/0.1.1-1+deb8u1

[Adam D. Barratt]

Control: tags -1 + pending

On Sat, 2017-12-02 at 20:08 +0100, Cyril Brulebois wrote:
> Hi Samuel,
> 
> Cyril Brulebois  (2017-06-28):
> > Samuel Thibault  (2017-06-28):
> > > Cyril Brulebois, on mer. 28 juin 2017 04:11:05 +0200, wrote:
> > > > Wait a minute, this adds a symlink and a dependency, but
> > > > doesn't
> > > > remove anything; this doesn't look like a duplication fix?
> > > 
> > > ln -sf replaces the existing file with the symlink.
> > 
> > Sure, I know what ln -sf does. But the said file was never shipped
> > in
> > the first place:
> > 
> > kibi@armor:/tmp/binary-libwnckmm-1.0-0-dev$ dpkg --contents
> > libwnckmm-1.0-0-dev_0.1.1-1_amd64.deb | grep jquery.js
> > kibi@armor:/tmp/binary-libwnckmm-1.0-0-dev$ 
> > 
> > Indeed, after a build in a jessie chroot, there are plenty of
> > references
> > to jquery.js in HTML files, but there's no jquery.js in the build
> > tree.
> 
> Following a poke from Julien, I've just checked this issue again: it
> seems the changelog is correct, but the (o)pu request wasn't. This
> isn't
> about fixing jquery.js duplication, rather about fixing a missing
> file
> referenced by so many HTML files:
> 
> $ grep 'src="jquery.js"' -rl debian/libwnckmm-1.0-0*|wc -l
> 64
> 
> So the 'confirmed' tag stands, even if a follow-up would have been
> nice.

Thanks; flagged for acceptance.

Regards,

Adam

Processed: Re: Bug#863093: jessie-pu: package libwnckmm/0.1.1-1+deb8u1

[Debian Bug Tracking System]

Processing control commands:

> tags -1 + pending
Bug #863093 [release.debian.org] jessie-pu: package libwnckmm/0.1.1-1+deb8u1
Added tag(s) pending.

-- 
863093: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=863093
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#863093: jessie-pu: package libwnckmm/0.1.1-1+deb8u1

[Cyril Brulebois]

Hi Samuel,

Cyril Brulebois  (2017-06-28):
> Samuel Thibault  (2017-06-28):
> > Cyril Brulebois, on mer. 28 juin 2017 04:11:05 +0200, wrote:
> > > Wait a minute, this adds a symlink and a dependency, but doesn't
> > > remove anything; this doesn't look like a duplication fix?
> > 
> > ln -sf replaces the existing file with the symlink.
> 
> Sure, I know what ln -sf does. But the said file was never shipped in
> the first place:
> 
> kibi@armor:/tmp/binary-libwnckmm-1.0-0-dev$ dpkg --contents 
> libwnckmm-1.0-0-dev_0.1.1-1_amd64.deb | grep jquery.js
> kibi@armor:/tmp/binary-libwnckmm-1.0-0-dev$ 
> 
> Indeed, after a build in a jessie chroot, there are plenty of references
> to jquery.js in HTML files, but there's no jquery.js in the build tree.

Following a poke from Julien, I've just checked this issue again: it
seems the changelog is correct, but the (o)pu request wasn't. This isn't
about fixing jquery.js duplication, rather about fixing a missing file
referenced by so many HTML files:

$ grep 'src="jquery.js"' -rl debian/libwnckmm-1.0-0*|wc -l
64

So the 'confirmed' tag stands, even if a follow-up would have been nice.


KiBi.


signature.asc
Description: PGP signature

Bug#863093: jessie-pu: package libwnckmm/0.1.1-1+deb8u1

[Cyril Brulebois]

Hi,

Samuel Thibault  (2017-06-28):
> Cyril Brulebois, on mer. 28 juin 2017 04:11:05 +0200, wrote:
> > Wait a minute, this adds a symlink and a dependency, but doesn't
> > remove anything; this doesn't look like a duplication fix?
> 
> ln -sf replaces the existing file with the symlink.

Sure, I know what ln -sf does. But the said file was never shipped in
the first place:

kibi@armor:/tmp/binary-libwnckmm-1.0-0-dev$ dpkg --contents 
libwnckmm-1.0-0-dev_0.1.1-1_amd64.deb | grep jquery.js
kibi@armor:/tmp/binary-libwnckmm-1.0-0-dev$ 

Indeed, after a build in a jessie chroot, there are plenty of references
to jquery.js in HTML files, but there's no jquery.js in the build tree.


KiBi.


signature.asc
Description: Digital signature

Bug#863093: jessie-pu: package libwnckmm/0.1.1-1+deb8u1

[Samuel Thibault]

Hello,

Cyril Brulebois, on mer. 28 juin 2017 04:11:05 +0200, wrote:
> Samuel Thibault  (2017-05-21):
> > Jessie is still affected by this serious Bug#796530, Adrian Bunk
> > requested it to be fixed there. In the attached changes that I have
> > uploaded to tpu, I have also fixed the duplication of jquery.js, also
> > a serious issue.
> 
> Wait a minute, this adds a symlink and a dependency, but doesn't remove
> anything; this doesn't look like a duplication fix?

ln -sf replaces the existing file with the symlink.

Samuel

Bug#863093: jessie-pu: package libwnckmm/0.1.1-1+deb8u1

[Cyril Brulebois]

Hi again,

Samuel Thibault  (2017-05-21):
> Jessie is still affected by this serious Bug#796530, Adrian Bunk
> requested it to be fixed there. In the attached changes that I have
> uploaded to tpu, I have also fixed the duplication of jquery.js, also
> a serious issue.

Wait a minute, this adds a symlink and a dependency, but doesn't remove
anything; this doesn't look like a duplication fix?


KiBi.


signature.asc
Description: Digital signature

Bug#863093: jessie-pu: package libwnckmm/0.1.1-1+deb8u1

[Cyril Brulebois]

Control: tag -1 confirmed

Hi Samuel,

Samuel Thibault  (2017-05-21):
> libwnckmm did not have correct versioned dependency before its version
> 0.1.1-2, leading to /usr/lib/*/libwnckmm-1.0.so potentially being a
> dangling link to an outdated .so filename.

OK for the change.

> Jessie is still affected by this serious Bug#796530, Adrian Bunk
> requested it to be fixed there. In the attached changes that I have
> uploaded to tpu, I have also fixed the duplication of jquery.js, also
> a serious issue.

OK for the change.

From a process point of view, you're supposed to be getting an ACK from
the release team before upload to one of the proposed-updates suites…

I'll look at libwnckmm in jessie-new later.


KiBi.


signature.asc
Description: Digital signature

Processed: Re: Bug#863093: jessie-pu: package libwnckmm/0.1.1-1+deb8u1

[Debian Bug Tracking System]

Processing control commands:

> tag -1 confirmed
Bug #863093 [release.debian.org] jessie-pu: package libwnckmm/0.1.1-1+deb8u1
Added tag(s) confirmed.

-- 
863093: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=863093
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#863093: jessie-pu: package libwnckmm/0.1.1-1+deb8u1

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: jessie
User: release.debian@packages.debian.org
Usertags: pu

libwnckmm did not have correct versioned dependency before its version
0.1.1-2, leading to /usr/lib/*/libwnckmm-1.0.so potentially being a
dangling link to an outdated .so filename.

Jessie is still affected by this serious Bug#796530, Adrian Bunk
requested it to be fixed there. In the attached changes that I have
uploaded to tpu, I have also fixed the duplication of jquery.js, also a
serious issue.

Samuel

-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'stable'), 
(500, 'oldstable'), (1, 'experimental-debug'), (1, 'buildd-experimental'), (1, 
'experimental')
Architecture: amd64
 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.11.0 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- 
Samuel
"How should I know if it works?  That's what beta testers are for.  I only
coded it."
(Attributed to Linus Torvalds, somewhere in a posting)
diff -Nru libwnckmm-0.1.1/debian/changelog libwnckmm-0.1.1/debian/changelog
--- libwnckmm-0.1.1/debian/changelog2014-10-14 02:17:26.0 +0200
+++ libwnckmm-0.1.1/debian/changelog2015-08-22 14:29:25.0 +0200
@@ -1,3 +1,11 @@
+libwnckmm (0.1.1-1+deb8u1) jessie; urgency=medium
+
+  * Make libwnckmm-1.0-0-dev depend on the same version of libwnckmm-1.0-0.
+(closes: #796530)
+  * Use jquery.js from libjs-jquery.
+
+ -- Samuel Thibault   Sat, 22 Aug 2015 14:29:25 +0200
+
 libwnckmm (0.1.1-1) unstable; urgency=medium
 
   [ Jean-Philippe MENGUAL ]
diff -Nru libwnckmm-0.1.1/debian/control libwnckmm-0.1.1/debian/control
--- libwnckmm-0.1.1/debian/control  2014-10-14 02:00:51.0 +0200
+++ libwnckmm-0.1.1/debian/control  2015-08-22 14:29:25.0 +0200
@@ -23,7 +23,7 @@
 Package: libwnckmm-1.0-0-dev
 Architecture: any
 Section: libdevel
-Depends: ${shlibs:Depends}, ${misc:Depends}, libwnck-dev (>= 2.30.0~), 
libgtkmm-2.4-dev (>= 1:2.24.0~)
+Depends: ${shlibs:Depends}, ${misc:Depends}, libwnck-dev (>= 2.30.0~), 
libwnckmm-1.0-0 (= ${binary:Version}), libgtkmm-2.4-dev (>= 1:2.24.0~), 
libjs-jquery
 Description: Development files for the C++ wrapper to libwnck
  This library is a gmmproc-based wrapper around the WNCK library.
  This package is a depency for packages such as Emerald.
diff -Nru libwnckmm-0.1.1/debian/rules libwnckmm-0.1.1/debian/rules
--- libwnckmm-0.1.1/debian/rules2014-10-14 01:41:38.0 +0200
+++ libwnckmm-0.1.1/debian/rules2015-08-22 14:29:25.0 +0200
@@ -10,6 +10,10 @@
 override_dh_auto_configure:
dh_auto_configure -- --enable-maintainer-mode --enable-static 
--libdir=\$${prefix}/lib/$(DEB_HOST_MULTIARCH)
 
+override_dh_installdocs:
+   ln -sf /usr/share/javascript/jquery/jquery.js 
doc/reference/html/jquery.js
+   dh_installdocs
+
 override_dh_auto_clean:
dh_auto_clean
rm -fr doc/reference/html