Bug#863862: jessie-pu: package multipath-tools/0.5.0-6+deb8u2

2018-06-13 Thread Adam D. Barratt 
On Wed, 2017-06-28 at 02:04 +0200, Cyril Brulebois wrote:
[...]
> The patches themselves look reasonable to me though.
> 
> 
> To sum it up: please adjust metadata for both bug reports in the BTS,
> and send a cleaner debdiff for a second look.
> 

Ping? We're a few days away from closing the window for the final
jessie point release before it becomes LTS.

Regards,

Adam

Bug#863862: jessie-pu: package multipath-tools/0.5.0-6+deb8u2

2017-06-27 Thread Cyril Brulebois 
Control: tag -1 moreinfo

Hi,

Ritesh Raj Sarraf  (2017-06-01):
> I am filing this bug report and reivew request, now, just to keep it
> in the queue. I completely had forgotten to queue it for the next
> Jessie update.
> 
> Attached debdiff fixes 2 annoying issues with multipath-tools.
> 
> 1. Fixes a crash where the vendor or product id for the scsi block
> device is missing.
> 
> 2. Fixes a locking issue which got introduced because of udev's way of
> behaving.
> 
> Both fixes are in upstream's repository and also already part of
> Stretch.

It seems the BTS doesn't reflect the proper status for those bugs, then?
 - #751993 is still open, tagged moreinfo and pending; but not fixed in
   any suites?
 - #799781 is still open, tagged patch and pending; but not fixed in any
   suites.

A few versioned -done@ should do the trick to update the BTS though.

> diff -Nru multipath-tools-0.5.0/debian/changelog 
> multipath-tools-0.5.0/debian/changelog
> --- multipath-tools-0.5.0/debian/changelog2015-10-21 15:23:45.0 
> +0545
> +++ multipath-tools-0.5.0/debian/changelog2017-06-01 11:45:39.0 
> +0545
> @@ -1,3 +1,13 @@
> +multipath-tools (0.5.0-6+deb8u3) jessie; urgency=medium

Version number and target distribution are good…

> +  * Refresh patches

… but it would be great if we could avoid such noise in a stable upload.
AFAICT that serves no practical purposes, so better skip it.

> +  * Fix segfault is either of vid/pid is missing in blacklist
> +(Closes: #751993)
> +  * Add patch to fix device locking issue in between multipath and udev
> +(Closes: #799781)

The patches themselves look reasonable to me though.


To sum it up: please adjust metadata for both bug reports in the BTS,
and send a cleaner debdiff for a second look.


KiBi.


signature.asc
Description: Digital signature

Processed: Re: Bug#863862: jessie-pu: package multipath-tools/0.5.0-6+deb8u2

2017-06-27 Thread Debian Bug Tracking System 
Processing control commands:

> tag -1 moreinfo
Bug #863862 [release.debian.org] jessie-pu: package 
multipath-tools/0.5.0-6+deb8u2
Added tag(s) moreinfo.

-- 
863862: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=863862
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#863862: jessie-pu: package multipath-tools/0.5.0-6+deb8u2

2017-06-01 Thread Ritesh Raj Sarraf 
Package: release.debian.org
Severity: normal
Tags: jessie
User: release.debian@packages.debian.org
Usertags: pu

Dear Release Team,

I am filing this bug report and reivew request, now, just to keep it in
the queue. I completely had forgotten to queue it for the next Jessie
update.

Attached debdiff fixes 2 annoying issues with multipath-tools.

1. Fixes a crash where the vendor or product id for the scsi block
device is missing.

2. Fixes a locking issue which got introduced because of udev's way of
behaving.

Both fixes are in upstream's repository and also already part of
Stretch.

Please give me an acknowledgement for the go ahead to upload. I have not
uploaded it yet.


Thanks

-- System Information:
Debian Release: 9.0
  APT prefers testing-debug
  APT policy: (990, 'testing-debug'), (990, 'testing'), (500, 
'unstable-debug'), (500, 'unstable'), (101, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.10.17+ (SMP w/4 CPU cores)
Locale: LANG=en_IN.UTF-8, LC_CTYPE=en_IN.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_IN:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru multipath-tools-0.5.0/debian/changelog 
multipath-tools-0.5.0/debian/changelog
--- multipath-tools-0.5.0/debian/changelog  2015-10-21 15:23:45.0 
+0545
+++ multipath-tools-0.5.0/debian/changelog  2017-06-01 11:45:39.0 
+0545
@@ -1,3 +1,13 @@
+multipath-tools (0.5.0-6+deb8u3) jessie; urgency=medium
+
+  * Refresh patches
+  * Fix segfault is either of vid/pid is missing in blacklist
+(Closes: #751993)
+  * Add patch to fix device locking issue in between multipath and udev
+(Closes: #799781)
+
+ -- Ritesh Raj Sarraf   Thu, 01 Jun 2017 11:45:39 +0545
+
 multipath-tools (0.5.0-6+deb8u2) jessie; urgency=medium
 
   * fix discovery of devices with blank rev
diff -Nru multipath-tools-0.5.0/debian/patches/0009-hardened-build-flags.patch 
multipath-tools-0.5.0/debian/patches/0009-hardened-build-flags.patch
--- multipath-tools-0.5.0/debian/patches/0009-hardened-build-flags.patch
2015-10-21 15:22:21.0 +0545
+++ multipath-tools-0.5.0/debian/patches/0009-hardened-build-flags.patch
2017-06-01 11:36:41.0 +0545
@@ -1,8 +1,6 @@
 Multipath Hardening Patch
-Index: multipath-tools/kpartx/Makefile
-===
 multipath-tools.orig/kpartx/Makefile   2014-03-09 16:01:42.676339807 
+0530
-+++ multipath-tools/kpartx/Makefile2014-03-09 16:02:48.380338649 +0530
+--- a/kpartx/Makefile
 b/kpartx/Makefile
 @@ -12,7 +12,7 @@
CFLAGS += -DLIBDM_API_COOKIE
  endif
@@ -12,11 +10,9 @@
  OBJS = bsd.o dos.o kpartx.o solaris.o unixware.o dasd.o sun.o \
 gpt.o mac.o ps3.o crc32.o lopart.o xstrncpy.o devmapper.o
  EXEC = kpartx
-Index: multipath-tools/Makefile.inc
-===
 multipath-tools.orig/Makefile.inc  2014-03-09 16:01:42.676339807 +0530
-+++ multipath-tools/Makefile.inc   2014-03-09 16:01:42.672339807 +0530
-@@ -49,7 +49,8 @@
+--- a/Makefile.inc
 b/Makefile.inc
+@@ -52,7 +52,8 @@
  endif
  
  OPTFLAGS = $(RPM_OPT_FLAGS) -Wunused -Wstrict-prototypes
diff -Nru 
multipath-tools-0.5.0/debian/patches/0015-libmultipath-property-whitelist-SCSI_IDENT.patch
 
multipath-tools-0.5.0/debian/patches/0015-libmultipath-property-whitelist-SCSI_IDENT.patch
--- 
multipath-tools-0.5.0/debian/patches/0015-libmultipath-property-whitelist-SCSI_IDENT.patch
  2015-10-21 15:22:21.0 +0545
+++ 
multipath-tools-0.5.0/debian/patches/0015-libmultipath-property-whitelist-SCSI_IDENT.patch
  2017-06-01 11:36:41.0 +0545
@@ -14,11 +14,9 @@
 Signed-off-by: Hannes Reinecke 
 ---
 
-diff --git a/libmultipath/blacklist.c b/libmultipath/blacklist.c
-index cea128c..30c5031 100644
 --- a/libmultipath/blacklist.c
 +++ b/libmultipath/blacklist.c
-@@ -196,7 +196,7 @@ setup_default_blist (struct config * conf)
+@@ -176,7 +176,7 @@
if (store_ble(conf->blist_devnode, str, ORIGIN_DEFAULT))
return 1;
  
diff -Nru 
multipath-tools-0.5.0/debian/patches/0016-multipath-vid-pid-crash.patch 
multipath-tools-0.5.0/debian/patches/0016-multipath-vid-pid-crash.patch
--- multipath-tools-0.5.0/debian/patches/0016-multipath-vid-pid-crash.patch 
1970-01-01 05:30:00.0 +0530
+++ multipath-tools-0.5.0/debian/patches/0016-multipath-vid-pid-crash.patch 
2017-06-01 11:36:41.0 +0545
@@ -0,0 +1,47 @@
+From 5195abd56cdfbc12c32c0ad3127a32643d11db4b Mon Sep 17 00:00:00 2001
+From: Benjamin Marzinski 
+Date: Sat, 7 Mar 2015 21:31:39 -0600
+Subject: libmutipath: allow blanks in device blacklist
+
+As Brian De Wolf noticed, multipath crashes if you don't have both
+vendor and product specified in a device blacklist entry. This patch
+makes device blacklists work when either the vendor or the product is
+blank. If both are