Bug#927199: unblock: gnome-shell/3.30.2-6

2019-04-16 Thread Simon McVittie 
On Tue, 16 Apr 2019 at 11:37:31 +0200, Ivo De Decker wrote:
> Also, are you aware of these bugs:
> 
> https://bugs.debian.org/926212 gnome-shell crashed (segfault)
> https://bugs.debian.org/927162 gnome-shell segfaults in libst-1.0.so
> 
> It would probably be good to have a fix for that.

If I knew how to fix them, I would, but fixing crashes that I've never
seen myself is not something that I can do instantly.

smcv

Bug#927199: unblock: gnome-shell/3.30.2-6

2019-04-16 Thread Ivo De Decker 
Hi,

On Tue, Apr 16, 2019 at 08:08:00AM +, Niels Thykier wrote:
> > unblock gnome-shell/3.30.2-6
> > 
> 
> There is a bug in d/clean.  The "debian/home" line is a directory and
> therefore needs a trailing slash (otherwise, dh_clean will refuse to
> remove it - see "man dh_clean").
> 
> Otherwise, it looks fine.

Also, are you aware of these bugs:

https://bugs.debian.org/926212 gnome-shell crashed (segfault)
https://bugs.debian.org/927162 gnome-shell segfaults in libst-1.0.so

It would probably be good to have a fix for that.

Thanks,

Ivo

Processed: Re: Bug#927199: unblock: gnome-shell/3.30.2-6

2019-04-16 Thread Debian Bug Tracking System 
Processing control commands:

> tags -1 moreinfo
Bug #927199 [release.debian.org] unblock: gnome-shell/3.30.2-6
Added tag(s) moreinfo.

-- 
927199: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=927199
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#927199: unblock: gnome-shell/3.30.2-6

2019-04-16 Thread Niels Thykier 
Control: tags -1 moreinfo

intrigeri:
> Package: release.debian.org
> Severity: normal
> User: release.debian@packages.debian.org
> Usertags: unblock
> 
> Please unblock package gnome-shell.
> 
> Changes are:
> 
> 1. Vcs-Git, gbp.conf: point to the correct, Buster-specific, branches.
> 
> 2. Avoid test failures on buildd environments where HOME, XDG_RUNTIME_DIR 
> might
>be invalid. This allows the tests to run a bit further on s390x. The 
> package
>still FTBFS there but as Simon McVittie wrote, "The remaining test failures
>on s390x look to me more like a bug in mozjs60 or gjs than a bug in
>gnome-shell" — which I guess is #927081.
> 
> 3. Add missing French layouts to on screen keyboard (Closes: #926452)
> 
>Due to a bug in the code that generates on screen keyboard layouts, the
>French layout ends up being generated from the French-Canadian layout 
> (which
>is qwerty rather than azerty). This is a regression compared to Stretch.
> 
>Fixed by cherry-picking the relevant upstream (3.32.0) commit.
> 
> 4. Fix on screen keyboard language's menu closing the keyboard (Closes: 
> #926453)
> 
>GNOME Shell 3.30's on screen keyboard now offers a menu that allows 
> selecting
>among the supported keyboard layouts. But moving the pointer over this menu
>closes the keyboard. This is a regression from Stretch, where that menu did
>not exist yet.
> 
>Fixed by cherry-picking the relevant upstream (3.32.0) commits.
> 
> unblock gnome-shell/3.30.2-6
> 

There is a bug in d/clean.  The "debian/home" line is a directory and
therefore needs a trailing slash (otherwise, dh_clean will refuse to
remove it - see "man dh_clean").

Otherwise, it looks fine.

Thanks,
~Niels

Bug#927199: unblock: gnome-shell/3.30.2-6

2019-04-16 Thread intrigeri 
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Please unblock package gnome-shell.

Changes are:

1. Vcs-Git, gbp.conf: point to the correct, Buster-specific, branches.

2. Avoid test failures on buildd environments where HOME, XDG_RUNTIME_DIR might
   be invalid. This allows the tests to run a bit further on s390x. The package
   still FTBFS there but as Simon McVittie wrote, "The remaining test failures
   on s390x look to me more like a bug in mozjs60 or gjs than a bug in
   gnome-shell" — which I guess is #927081.

3. Add missing French layouts to on screen keyboard (Closes: #926452)

   Due to a bug in the code that generates on screen keyboard layouts, the
   French layout ends up being generated from the French-Canadian layout (which
   is qwerty rather than azerty). This is a regression compared to Stretch.

   Fixed by cherry-picking the relevant upstream (3.32.0) commit.

4. Fix on screen keyboard language's menu closing the keyboard (Closes: #926453)

   GNOME Shell 3.30's on screen keyboard now offers a menu that allows selecting
   among the supported keyboard layouts. But moving the pointer over this menu
   closes the keyboard. This is a regression from Stretch, where that menu did
   not exist yet.

   Fixed by cherry-picking the relevant upstream (3.32.0) commits.

unblock gnome-shell/3.30.2-6
diff -Nru gnome-shell-3.30.2/debian/changelog 
gnome-shell-3.30.2/debian/changelog
--- gnome-shell-3.30.2/debian/changelog 2019-02-06 10:46:52.0 +0100
+++ gnome-shell-3.30.2/debian/changelog 2019-04-15 13:23:31.0 +0200
@@ -1,3 +1,33 @@
+gnome-shell (3.30.2-6) unstable; urgency=medium
+
+  * Team upload
+  * d/p/keyboard-Make-items-in-language-menu-unfocusable.patch,
+d/p/popupMenu-Respect-items-can-focus-property.patch:
+Add patches from upstream to fix the on-screen keyboard language's menu
+closing said keyboard (Closes: #926453)
+  * d/p/osk-layouts-Fix-French-layout.patch:
+Add patches from upstream to add missing French layouts to
+the on-screen keyboard (Closes: #926452)
+
+ -- intrigeri   Mon, 15 Apr 2019 11:23:31 +
+
+gnome-shell (3.30.2-5) unstable; urgency=medium
+
+  * Team upload
+  * Really create a suitable temporary XDG_RUNTIME_DIR for the unit tests
+  * Clean up debian/home with d/clean, not a dh_clean override
+
+ -- Simon McVittie   Sun, 14 Apr 2019 15:33:47 +0100
+
+gnome-shell (3.30.2-4) unstable; urgency=medium
+
+  * Team upload
+  * d/rules: Create a temporary HOME, XDG_RUNTIME_DIR for the unit tests.
+This hopefully fixes test failures and FTBFS on the s390x buildd.
+  * d/.gitignore: Add
+
+ -- Simon McVittie   Sun, 14 Apr 2019 10:40:33 +0100
+
 gnome-shell (3.30.2-3) unstable; urgency=medium
 
   * Team upload
diff -Nru gnome-shell-3.30.2/debian/clean gnome-shell-3.30.2/debian/clean
--- gnome-shell-3.30.2/debian/clean 1970-01-01 01:00:00.0 +0100
+++ gnome-shell-3.30.2/debian/clean 2019-04-15 13:23:31.0 +0200
@@ -0,0 +1 @@
+debian/home
diff -Nru gnome-shell-3.30.2/debian/control gnome-shell-3.30.2/debian/control
--- gnome-shell-3.30.2/debian/control   2019-02-06 10:46:52.0 +0100
+++ gnome-shell-3.30.2/debian/control   2019-04-15 13:23:31.0 +0200
@@ -55,7 +55,7 @@
 Rules-Requires-Root: no
 Standards-Version: 4.3.0
 Homepage: https://wiki.gnome.org/Projects/GnomeShell
-Vcs-Git: https://salsa.debian.org/gnome-team/gnome-shell.git
+Vcs-Git: https://salsa.debian.org/gnome-team/gnome-shell.git -b debian/buster
 Vcs-Browser: https://salsa.debian.org/gnome-team/gnome-shell
 
 Package: gnome-shell
diff -Nru gnome-shell-3.30.2/debian/control.in 
gnome-shell-3.30.2/debian/control.in
--- gnome-shell-3.30.2/debian/control.in2019-02-06 10:46:52.0 
+0100
+++ gnome-shell-3.30.2/debian/control.in2019-04-15 13:23:31.0 
+0200
@@ -51,7 +51,7 @@
 Rules-Requires-Root: no
 Standards-Version: 4.3.0
 Homepage: https://wiki.gnome.org/Projects/GnomeShell
-Vcs-Git: https://salsa.debian.org/gnome-team/gnome-shell.git
+Vcs-Git: https://salsa.debian.org/gnome-team/gnome-shell.git -b debian/buster
 Vcs-Browser: https://salsa.debian.org/gnome-team/gnome-shell
 
 Package: gnome-shell
diff -Nru gnome-shell-3.30.2/debian/gbp.conf gnome-shell-3.30.2/debian/gbp.conf
--- gnome-shell-3.30.2/debian/gbp.conf  2019-02-06 10:46:52.0 +0100
+++ gnome-shell-3.30.2/debian/gbp.conf  2019-04-15 13:23:31.0 +0200
@@ -1,7 +1,7 @@
 [DEFAULT]
 pristine-tar = True
-debian-branch = debian/master
-upstream-branch = upstream/latest
+debian-branch = debian/buster
+upstream-branch = upstream/3.30.x
 upstream-vcs-tag = %(version)s
 
 [buildpackage]
diff -Nru 
gnome-shell-3.30.2/debian/patches/keyboard-Make-items-in-language-menu-unfocusable.patch
 
gnome-shell-3.30.2/debian/patches/keyboard-Make-items-in-language-menu-unfocusable.patch
--- 
gnome-shell-3.30.2/debian/patches/keyboard-Make-items-in-language-menu-unfocusable.patch