Processed: Re: Bug#990500: unblock: lxml/4.6.3+dfsg-0.1
Processing control commands: > tags -1 - moreinfo Bug #990500 [release.debian.org] unblock: lxml/4.6.3+dfsg-0.1 Removed tag(s) moreinfo. -- 990500: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=990500 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#990500: unblock: lxml/4.6.3+dfsg-0.1
Control: tags -1 - moreinfo Hi Sebastian, On 04-07-2021 22:01, Sebastian Ramacher wrote: >> diff -Nru lxml-4.6.3/debian/control lxml-4.6.3+dfsg/debian/control >> --- lxml-4.6.3/debian/control2020-12-07 14:42:24.0 +0100 >> +++ lxml-4.6.3+dfsg/debian/control 2021-06-26 19:40:37.0 +0200 >> @@ -9,6 +9,7 @@ >>python3-setuptools (>= 0.6.29), >>python3-bs4, >>python3-html5lib, >> + python3-lxml , >>cython3, cython3-dbg, >>python3-sphinx-autoapi, >> X-Python-Version: all >> diff -Nru lxml-4.6.3/debian/rules lxml-4.6.3+dfsg/debian/rules >> --- lxml-4.6.3/debian/rules 2020-07-17 11:16:59.0 +0200 >> +++ lxml-4.6.3+dfsg/debian/rules 2021-06-26 19:40:37.0 +0200 >> @@ -24,6 +24,9 @@ >> touch $@ >> build3-python%: prebuild >> python$* setup.py build >> +ifeq (,$(filter nodoc,$(DEB_BUILD_OPTIONS))) >> +python$* doc/mkhtml.py doc/html . $(UPSTREAMVER) >> +endif > > Shouldn't this use the just built version of lxml, e.g., by setting the > appropriate PYTHONPATH, instead of the old packaged lxml in python3-lxml? Oh, yes. But as I don't do Python packaging (just didn't happen, I don't object), I didn't know how to do that and I didn't want to spend too much time on it to figure it out (and potentially getting it wrong). Paul OpenPGP_signature Description: OpenPGP digital signature
Processed: Re: Bug#990500: unblock: lxml/4.6.3+dfsg-0.1
Processing control commands: > tags -1 moreinfo Bug #990500 [release.debian.org] unblock: lxml/4.6.3+dfsg-0.1 Added tag(s) moreinfo. -- 990500: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=990500 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#990500: unblock: lxml/4.6.3+dfsg-0.1
Control: tags -1 moreinfo On 2021-06-30 23:02:33 +0200, Paul Gevers wrote: > Package: release.debian.org > User: release.debian@packages.debian.org > Usertags: unblock > Severity: normal > > Please unblock package lxml > > [ Reason ] > The source of lxml contained a file that's marked as unacceptable by > ftp-master and as such a future upload of lxml would hit the > auto-reject list. To avoid problems with security uploads, I prefer to > fix the issue now. The file was a image shipped with the > documentation, which wasn't even used. > > In the process of fixing this issue, I discovered that the > documentation package was nearly empty and didn't contain any > documentation. This is fixed by enabling the build of the > documentation. > > [ Impact ] > If not unblocked, security or plain pu uploads will have to take > remove the file at that time. > > [ Tests ] > The removed file is just an unlinked image. I have checked that the > package now contains the documentation files. > > [ Risks ] > Close to 0 risk as it's just removing an image and building > documentation files. > > [ Checklist ] > [x] all changes are documented in the d/changelog > [x] I reviewed all changes and I approve them > [x] attach debdiff against the package in testing > > unblock lxml/4.6.3+dfsg-0.1 > diff -Nru lxml-4.6.3/debian/changelog lxml-4.6.3+dfsg/debian/changelog > --- lxml-4.6.3/debian/changelog 2021-03-22 14:31:55.0 +0100 > +++ lxml-4.6.3+dfsg/debian/changelog 2021-06-26 19:40:37.0 +0200 > @@ -1,3 +1,11 @@ > +lxml (4.6.3+dfsg-0.1) unstable; urgency=medium > + > + * Non-maintainer upload > + * Repack upstream to drop non-free and unused file (Closes: #988717) > + * Build and ship documentation (Closes: #799334) > + > + -- Paul Gevers Sat, 26 Jun 2021 19:40:37 +0200 > + > lxml (4.6.3-1) unstable; urgency=high > >* New upstream version. > diff -Nru lxml-4.6.3/debian/control lxml-4.6.3+dfsg/debian/control > --- lxml-4.6.3/debian/control 2020-12-07 14:42:24.0 +0100 > +++ lxml-4.6.3+dfsg/debian/control2021-06-26 19:40:37.0 +0200 > @@ -9,6 +9,7 @@ >python3-setuptools (>= 0.6.29), >python3-bs4, >python3-html5lib, > + python3-lxml , >cython3, cython3-dbg, >python3-sphinx-autoapi, > X-Python-Version: all > diff -Nru lxml-4.6.3/debian/rules lxml-4.6.3+dfsg/debian/rules > --- lxml-4.6.3/debian/rules 2020-07-17 11:16:59.0 +0200 > +++ lxml-4.6.3+dfsg/debian/rules 2021-06-26 19:40:37.0 +0200 > @@ -24,6 +24,9 @@ > touch $@ > build3-python%: prebuild > python$* setup.py build > +ifeq (,$(filter nodoc,$(DEB_BUILD_OPTIONS))) > + python$* doc/mkhtml.py doc/html . $(UPSTREAMVER) > +endif Shouldn't this use the just built version of lxml, e.g., by setting the appropriate PYTHONPATH, instead of the old packaged lxml in python3-lxml? Cheers > touch $@ > dbg-build3-python%: prebuild > python$*-dbg setup.py build > Binary files /tmp/nGluINxi3b/lxml-4.6.3/doc/html/flattr-badge-large.png and > /tmp/DP0ayk9l1g/lxml-4.6.3+dfsg/doc/html/flattr-badge-large.png differ -- Sebastian Ramacher signature.asc Description: PGP signature
Bug#990500: unblock: lxml/4.6.3+dfsg-0.1
Package: release.debian.org User: release.debian@packages.debian.org Usertags: unblock Severity: normal Please unblock package lxml [ Reason ] The source of lxml contained a file that's marked as unacceptable by ftp-master and as such a future upload of lxml would hit the auto-reject list. To avoid problems with security uploads, I prefer to fix the issue now. The file was a image shipped with the documentation, which wasn't even used. In the process of fixing this issue, I discovered that the documentation package was nearly empty and didn't contain any documentation. This is fixed by enabling the build of the documentation. [ Impact ] If not unblocked, security or plain pu uploads will have to take remove the file at that time. [ Tests ] The removed file is just an unlinked image. I have checked that the package now contains the documentation files. [ Risks ] Close to 0 risk as it's just removing an image and building documentation files. [ Checklist ] [x] all changes are documented in the d/changelog [x] I reviewed all changes and I approve them [x] attach debdiff against the package in testing unblock lxml/4.6.3+dfsg-0.1 diff -Nru lxml-4.6.3/debian/changelog lxml-4.6.3+dfsg/debian/changelog --- lxml-4.6.3/debian/changelog 2021-03-22 14:31:55.0 +0100 +++ lxml-4.6.3+dfsg/debian/changelog2021-06-26 19:40:37.0 +0200 @@ -1,3 +1,11 @@ +lxml (4.6.3+dfsg-0.1) unstable; urgency=medium + + * Non-maintainer upload + * Repack upstream to drop non-free and unused file (Closes: #988717) + * Build and ship documentation (Closes: #799334) + + -- Paul Gevers Sat, 26 Jun 2021 19:40:37 +0200 + lxml (4.6.3-1) unstable; urgency=high * New upstream version. diff -Nru lxml-4.6.3/debian/control lxml-4.6.3+dfsg/debian/control --- lxml-4.6.3/debian/control 2020-12-07 14:42:24.0 +0100 +++ lxml-4.6.3+dfsg/debian/control 2021-06-26 19:40:37.0 +0200 @@ -9,6 +9,7 @@ python3-setuptools (>= 0.6.29), python3-bs4, python3-html5lib, + python3-lxml , cython3, cython3-dbg, python3-sphinx-autoapi, X-Python-Version: all diff -Nru lxml-4.6.3/debian/rules lxml-4.6.3+dfsg/debian/rules --- lxml-4.6.3/debian/rules 2020-07-17 11:16:59.0 +0200 +++ lxml-4.6.3+dfsg/debian/rules2021-06-26 19:40:37.0 +0200 @@ -24,6 +24,9 @@ touch $@ build3-python%: prebuild python$* setup.py build +ifeq (,$(filter nodoc,$(DEB_BUILD_OPTIONS))) + python$* doc/mkhtml.py doc/html . $(UPSTREAMVER) +endif touch $@ dbg-build3-python%: prebuild python$*-dbg setup.py build Binary files /tmp/nGluINxi3b/lxml-4.6.3/doc/html/flattr-badge-large.png and /tmp/DP0ayk9l1g/lxml-4.6.3+dfsg/doc/html/flattr-badge-large.png differ OpenPGP_signature Description: OpenPGP digital signature
