Re: Please allow util-vserver 0.30.212-1 into etch
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Micah Anderson wrote:
> If I remove all the useless stuff (.svn stuff that crept in, upstream
> Changelog which for some reason had a number of changes, autotools
> noise, debian patches that have been incorporated into upstream, NOOP
> RCS header date changes, fedora yum repo gpg key change (unrelated to
> debian) gentoo initscript changes (unrelated to debian), redhat initpost
> changes (unrelated to debian), documentation changes
> (doc/configuration.html, configuration-xhtml.xsl, configuration.xml),
> redhat spec file changes (unrelated to debian) and the THANKS change,
> leaves:
>
> 58 files changed, 189 insertions(+), 446 deletions(-)
>
> Removing the 20+ trivial fixes of:
>
> - WRITE_MSG(2, " --help\" for more information.\n");
> + WRITE_MSG(2, " --help' for more information.\n");
>
> Leaves 40 changes, 169 insertions(+), 426 deletions, not that much when
> you consider a new kernel API is supported.
Attached cleaned up patch for review.
Micah
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFF6yja9n4qXRzy1ioRAlujAKC3QtqSi/DRuJFO6GMohmfq3JVFBwCgtCkI
L+cG5Vhu2AytJvADG2LPALc=
=/4wu
-END PGP SIGNATURE-
diff -ur ./config.h.in ../0.30.212-1/config.h.in
--- ./config.h.in 2006-10-07 13:32:22.0 -0600
+++ ../0.30.212-1/config.h.in 2006-12-09 11:56:07.0 -0700
@@ -232,6 +232,9 @@
/* Enable support for some obsoleted API of vserver 1.3.x */
#undef VC_ENABLE_API_V13OBS
+/* Enable support for API of vserver 2.1.x */
+#undef VC_ENABLE_API_V21
+
/* Version number of package */
#undef VERSION
diff -ur ./ensc_wrappers/wrappers-vserver.hc
../0.30.212-1/ensc_wrappers/wrappers-vserver.hc
--- ./ensc_wrappers/wrappers-vserver.hc 2007-03-04 12:25:45.0 -0700
+++ ../0.30.212-1/ensc_wrappers/wrappers-vserver.hc 2006-12-09
11:56:07.0 -0700
@@ -132,15 +132,15 @@
}
inline static WRAPPER_DECL void
-Evc_set_namespace()
+Evc_set_namespace(xid_t xid, uint_least64_t mask)
{
- FatalErrnoError(vc_set_namespace()==-1, "vc_set_namespace()");
+ FatalErrnoError(vc_set_namespace(xid, mask)==-1, "vc_set_namespace()");
}
inline static WRAPPER_DECL void
-Evc_enter_namespace(xid_t xid)
+Evc_enter_namespace(xid_t xid, uint_least64_t mask)
{
- FatalErrnoError(vc_enter_namespace(xid)==-1, "vc_enter_namespace()");
+ FatalErrnoError(vc_enter_namespace(xid, mask)==-1, "vc_enter_namespace()");
}
inline static WRAPPER_DECL xid_t
diff -ur ./kernel/cacct_cmd.h ../0.30.212-1/kernel/cacct_cmd.h
--- ./kernel/cacct_cmd.h2007-03-04 12:25:45.0 -0700
+++ ../0.30.212-1/kernel/cacct_cmd.h2006-12-09 11:56:07.0 -0700
@@ -13,11 +13,4 @@
};
-#ifdef __KERNEL__
-
-#include
-
-extern int vc_sock_stat(struct vx_info *, void __user *);
-
-#endif /* __KERNEL__ */
#endif /* _VX_CACCT_CMD_H */
diff -ur ./kernel/context_cmd.h ../0.30.212-1/kernel/context_cmd.h
--- ./kernel/context_cmd.h 2007-03-04 12:25:45.0 -0700
+++ ../0.30.212-1/kernel/context_cmd.h 2006-12-09 11:56:07.0 -0700
@@ -6,10 +6,6 @@
#define VCMD_task_xid VC_CMD(VINFO, 1, 0)
-#ifdef __KERNEL__
-extern int vc_task_xid(uint32_t, void __user *);
-
-#endif /* __KERNEL__ */
#define VCMD_vx_info VC_CMD(VINFO, 5, 0)
@@ -19,10 +15,6 @@
/* more to come */
};
-#ifdef __KERNEL__
-extern int vc_vx_info(struct vx_info *, void __user *);
-
-#endif /* __KERNEL__ */
#define VCMD_ctx_stat VC_CMD(VSTAT, 0, 0)
@@ -32,10 +24,6 @@
/* more to come */
};
-#ifdef __KERNEL__
-extern int vc_ctx_stat(struct vx_info *, void __user *);
-
-#endif /* __KERNEL__ */
/* context commands */
@@ -53,11 +41,6 @@
uint64_t flagword;
};
-#ifdef __KERNEL__
-extern int vc_ctx_create(uint32_t, void __user *);
-extern int vc_ctx_migrate(struct vx_info *, void __user *);
-
-#endif /* __KERNEL__ */
/* flag commands */
@@ -70,11 +53,6 @@
uint64_t mask;
};
-#ifdef __KERNEL__
-extern int vc_get_cflags(struct vx_info *, void __user *);
-extern int vc_set_cflags(struct vx_info *, void __user *);
-
-#endif /* __KERNEL__ */
/* context caps commands */
@@ -96,13 +74,6 @@
uint64_t cmask;
};
-#ifdef __KERNEL__
-extern int vc_get_ccaps_v0(struct vx_info *, void __user *);
-extern int vc_set_ccaps_v0(struct vx_info *, void __user *);
-extern int vc_get_ccaps(struct vx_info *, void __user *);
-extern int vc_set_ccaps(struct vx_info *, void __user *);
-
-#endif /* __KERNEL__ */
/* bcaps commands */
@@ -115,9 +86,4 @@
uint64_t bmask;
};
-#ifdef __KERNEL__
-extern int vc_get_bcaps(struct vx_info *, void __user *);
-extern int vc_set_bcaps(struct vx_info *, void __user *);
-
-#endif /* __KERNEL__ */
#endif /* _VX_CONTEXT_CMD_H */
diff -ur ./kernel/cvirt_cmd.h ../0.30.212-1/kernel/cvirt_cmd.h
--- ./kernel/cvirt_cmd.h2007-03-04 12:25:45.0 -0700
+++ ../0.30.212-1/kernel/cvirt_cmd.h2006-12-09 11:56:07.0 -
Re: Please allow util-vserver 0.30.212-1 into etch
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Micah Anderson <[EMAIL PROTECTED]> writes: >> Due to changes in the vserver patch necessary for 2.6.19+, changes in >> the user-space util-vserver package were required. The changes >> between 0.30.211-6 and 0.30.212-1 are important. Marc 'HE' Brockschmidt wrote: > 161 files changed, 5326 insertions(+), 10685 deletions(-) If I remove all the useless stuff (.svn stuff that crept in, upstream Changelog which for some reason had a number of changes, autotools noise, debian patches that have been incorporated into upstream, NOOP RCS header date changes, fedora yum repo gpg key change (unrelated to debian) gentoo initscript changes (unrelated to debian), redhat initpost changes (unrelated to debian), documentation changes (doc/configuration.html, configuration-xhtml.xsl, configuration.xml), redhat spec file changes (unrelated to debian) and the THANKS change, leaves: 58 files changed, 189 insertions(+), 446 deletions(-) Removing the 20+ trivial fixes of: - - WRITE_MSG(2, " --help\" for more information.\n"); + WRITE_MSG(2, " --help' for more information.\n"); Leaves 40 changes, 169 insertions(+), 426 deletions, not that much when you consider a new kernel API is supported. >This is simply not reviewable and we don't have kernels >= 2.6.19 in >etch, so I'm really not convinced that letting this trought at this >point of the freeze is a good idea. The reason for requesting this is to make etch+.5 transition smoother, and as I understand it, a newer kernel is expected to be introduced in etch+.5, and anything newer than 2.6.18 will break all vserver support. Additionally, any user who installs a backported kernel, or a hand-rolled one, will be unable to use vservers with 0.30.211-6. Micah -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFF6yf+9n4qXRzy1ioRAo3nAKCIIwP0Rnb2Ds+m5UA3isgjCMxuAQCeOkpI J5Z3C1tHQ3nelrXPv44cFNE= =nJyM -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Re: Please allow util-vserver 0.30.212-1 into etch
Hi I fully agree with Micah that this should be part of stable. Regards, // Ola On Fri, Mar 02, 2007 at 06:35:20PM -0700, Micah Anderson wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > Dearest release team, > > Due to changes in the vserver patch necessary for 2.6.19+, changes in > the user-space util-vserver package were required. The changes between > 0.30.211-6 and 0.30.212-1 are important. > > Version 0.30.212-1, which is in unstable, works for both 2.6.18 and > 2.6.19+, and has been in unstable for nearly 90 days now without any > regression problems reported specific to this version. > > As such I would humbly request that it be unblocked and allowed to > migrate to etch to make our lives a hair easier down the line. If > 0.30.211-6 is left in etch, anyone upgrading to a newer kernel will find > some significant weirdness. > > Micah > > ps - although I am not listed officially as the maintainer of the > package, I am listed as the co-maintainer and you will see that I have > done a significant number of the uploads of this package in the last > year and commits to the svn repository. Nevertheless, I am CC'ing the > maintainer as a courtesy, I believe he will not disagree with this > request. :) > -BEGIN PGP SIGNATURE- > Version: GnuPG v1.4.6 (GNU/Linux) > > iD8DBQFF6NDY9n4qXRzy1ioRAiPoAKCiy9PDpdrn+cP92Ag/46nbC84MpQCdEgWm > gXomXyGKuFj6HASW6Iv+1pw= > =hUAl > -END PGP SIGNATURE- > -- - Ola Lundqvist --- / [EMAIL PROTECTED] Annebergsslingan 37 \ | [EMAIL PROTECTED] 654 65 KARLSTAD | | +46 (0)54-10 14 30 +46 (0)70-332 1551 | | http://opalsys.net/ UIN/icq: 4912500 | \ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 / --- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Re: Please allow util-vserver 0.30.212-1 into etch
Micah Anderson <[EMAIL PROTECTED]> writes: > Due to changes in the vserver patch necessary for 2.6.19+, changes in > the user-space util-vserver package were required. The changes between > 0.30.211-6 and 0.30.212-1 are important. 161 files changed, 5326 insertions(+), 10685 deletions(-) This is simply not reviewable and we don't have kernels >= 2.6.19 in etch, so I'm really not convinced that letting this trought at this point of the freeze is a good idea. Marc -- BOFH #190: Proprietary Information. pgpCehLHR3wfR.pgp Description: PGP signature
Please allow util-vserver 0.30.212-1 into etch
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dearest release team, Due to changes in the vserver patch necessary for 2.6.19+, changes in the user-space util-vserver package were required. The changes between 0.30.211-6 and 0.30.212-1 are important. Version 0.30.212-1, which is in unstable, works for both 2.6.18 and 2.6.19+, and has been in unstable for nearly 90 days now without any regression problems reported specific to this version. As such I would humbly request that it be unblocked and allowed to migrate to etch to make our lives a hair easier down the line. If 0.30.211-6 is left in etch, anyone upgrading to a newer kernel will find some significant weirdness. Micah ps - although I am not listed officially as the maintainer of the package, I am listed as the co-maintainer and you will see that I have done a significant number of the uploads of this package in the last year and commits to the svn repository. Nevertheless, I am CC'ing the maintainer as a courtesy, I believe he will not disagree with this request. :) -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFF6NDY9n4qXRzy1ioRAiPoAKCiy9PDpdrn+cP92Ag/46nbC84MpQCdEgWm gXomXyGKuFj6HASW6Iv+1pw= =hUAl -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
