Re: Please unblock: lua5.1/5.1.5-4
On Thu, Jul 26, 2012 at 4:24 PM, Julien Cristau jcris...@debian.org wrote: On Thu, Jul 26, 2012 at 16:21:10 +0800, Aron Xu wrote: On Thu, Jul 26, 2012 at 4:15 PM, Julien Cristau jcris...@debian.org wrote: On Thu, Jul 26, 2012 at 16:03:46 +0800, Aron Xu wrote: I'd like to see lua5.1/5.1.5-4 can be unblocked so I can upload fcitx to unstable, which depends on lua5.1 and has already been pre-granted an unblock. I don't see the connection. I have not tested whether building against Multiarched version of lua5.1 will affect the usability of fcitx (theoretically won't), but I think to be safe I will wait for it if an unblock can be granted to lua5.1. Sounds like something that should be tested in any case? And if it *does* impact fcitx then that would be a reason to *not* unblock lua5.1. I have tested it and the package works, I'll upload fcitx very soon. -- Regards, Aron Xu -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAMr=8w4wn54Vu1=k2ifzq+f1ek41qxsafnnpmwxb+d+fiun...@mail.gmail.com
Re: Please unblock: lua5.1/5.1.5-4
Hi, As I've already replied to #682183, I've done a full rebuild of the reverse dependencies of lua5.1/5.1.5-4 and all of the builds have no regressions found. Build logs can be found at: http://people.debian.org/~aron/rebuild/lua5.1/20120723/ I'd like to see lua5.1/5.1.5-4 can be unblocked so I can upload fcitx to unstable, which depends on lua5.1 and has already been pre-granted an unblock. -- Regards, Aron Xu signature.asc Description: This is a digitally signed message part.
Re: Please unblock: lua5.1/5.1.5-4
On Thu, Jul 26, 2012 at 16:03:46 +0800, Aron Xu wrote: I'd like to see lua5.1/5.1.5-4 can be unblocked so I can upload fcitx to unstable, which depends on lua5.1 and has already been pre-granted an unblock. I don't see the connection. Cheers, Julien signature.asc Description: Digital signature
Re: Please unblock: lua5.1/5.1.5-4
On Thu, Jul 26, 2012 at 4:15 PM, Julien Cristau jcris...@debian.org wrote: On Thu, Jul 26, 2012 at 16:03:46 +0800, Aron Xu wrote: I'd like to see lua5.1/5.1.5-4 can be unblocked so I can upload fcitx to unstable, which depends on lua5.1 and has already been pre-granted an unblock. I don't see the connection. Cheers, Julien I have not tested whether building against Multiarched version of lua5.1 will affect the usability of fcitx (theoretically won't), but I think to be safe I will wait for it if an unblock can be granted to lua5.1. -- Regards, Aron Xu -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAMr=8w4f0BSMD2Dpufok=4YJOmtg32Uy7aWebWy=fptyhat...@mail.gmail.com
Re: Please unblock: lua5.1/5.1.5-4
On Thu, Jul 26, 2012 at 16:21:10 +0800, Aron Xu wrote: On Thu, Jul 26, 2012 at 4:15 PM, Julien Cristau jcris...@debian.org wrote: On Thu, Jul 26, 2012 at 16:03:46 +0800, Aron Xu wrote: I'd like to see lua5.1/5.1.5-4 can be unblocked so I can upload fcitx to unstable, which depends on lua5.1 and has already been pre-granted an unblock. I don't see the connection. I have not tested whether building against Multiarched version of lua5.1 will affect the usability of fcitx (theoretically won't), but I think to be safe I will wait for it if an unblock can be granted to lua5.1. Sounds like something that should be tested in any case? And if it *does* impact fcitx then that would be a reason to *not* unblock lua5.1. Cheers, Julien signature.asc Description: Digital signature
Re: Please unblock: lua5.1/5.1.5-4
On Thu, Jul 26, 2012 at 04:21:10PM +0800, Aron Xu wrote: I have not tested whether building against Multiarched version of lua5.1 will affect the usability of fcitx (theoretically won't), but I The version of lua5.1 in weezy is already multiarched. What this upload fixes is that all macros from lua.h can now be used in the C side of your application, while with the version in weezy LUA_CPATH_DEFAULT is broken unless you compile with the cflags computed by pkg-config. think to be safe I will wait for it if an unblock can be granted to lua5.1. I understand release manager can be quite suspicious, since my last upload was totally crap and cause many FTBFS. I believe this one is OK, and your rebuild tests just confirm that. Cheers -- Enrico Tassi -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120726082936.GA31304@birba
Re: Please unblock: lua5.1/5.1.5-4
On Thu, Jul 26, 2012 at 10:29:36AM +0200, Enrico Tassi wrote: On Thu, Jul 26, 2012 at 04:21:10PM +0800, Aron Xu wrote: I have not tested whether building against Multiarched version of lua5.1 will affect the usability of fcitx (theoretically won't), but I The version of lua5.1 in weezy is already multiarched. What this upload fixes is that all macros from lua.h can now be used in the C side of your application, while with the version in weezy LUA_CPATH_DEFAULT is broken unless you compile with the cflags computed by pkg-config. And for the records, no package in debian uses this macro, since using it (with the version of the package in weezy, and without pkg-config) causes a compiler error. But of course it would be nice if the released version had this little problem solved, hence my 5.1.5-4 upload. Cheers -- Enrico Tassi -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120726083337.GA31760@birba
Re: Please unblock: lua5.1/5.1.5-4
On Thu, Jul 26, 2012 at 10:24:28AM +0200, Julien Cristau wrote: On Thu, Jul 26, 2012 at 16:21:10 +0800, Aron Xu wrote: On Thu, Jul 26, 2012 at 4:15 PM, Julien Cristau jcris...@debian.org wrote: On Thu, Jul 26, 2012 at 16:03:46 +0800, Aron Xu wrote: I'd like to see lua5.1/5.1.5-4 can be unblocked so I can upload fcitx to unstable, which depends on lua5.1 and has already been pre-granted an unblock. I don't see the connection. I have not tested whether building against Multiarched version of lua5.1 will affect the usability of fcitx (theoretically won't), but I think to be safe I will wait for it if an unblock can be granted to lua5.1. Sounds like something that should be tested in any case? And if it *does* impact fcitx then that would be a reason to *not* unblock lua5.1. I won't since the lua5.1 available in weezy is already multiarch. And It has been so since the last debconf (2011). Cheers -- Enrico Tassi -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120726105110.GA6909@birba
Please unblock: lua5.1/5.1.5-4
This version of lua5.1 fixes a nasty multiarch related issue (bug #676695)
and the mess my previous attempt made (#682234, #682183, #682299).
Debdiff attached (w.r.t the version in weezy).
diff -Nru lua5.1-5.1.5/debian/changelog lua5.1-5.1.5/debian/changelog
--- lua5.1-5.1.5/debian/changelog 2012-05-03 15:12:32.0 +0200
+++ lua5.1-5.1.5/debian/changelog 2012-07-23 11:41:06.0 +0200
@@ -1,3 +1,18 @@
+lua5.1 (5.1.5-4) unstable; urgency=low
+
+ * Rename lua-deb-multiarch.h into lua5.1-deb-multiarch.h and install it in
+/usr/include/$DEB_HOST_MULTIARCH/ to make it available with no extra
+-I directive (Closes: #682234, #682183, #682299)
+
+ -- Enrico Tassi gareuselesi...@debian.org Wed, 18 Jul 2012 18:43:50 +0200
+
+lua5.1 (5.1.5-3) unstable; urgency=low
+
+ * Install architecture dependent .h file in /usr/lib and fix .pc files
+accordingly to fix multiarch issues (Closes: #676695)
+
+ -- Enrico Tassi gareuselesi...@debian.org Mon, 16 Jul 2012 12:48:01 +0200
+
lua5.1 (5.1.5-2) unstable; urgency=low
* Put in the pkg-config .pc file -DDEB_HOST_MULTIARCH so that including
diff -Nru lua5.1-5.1.5/debian/lua-c++.pc.in lua5.1-5.1.5/debian/lua-c++.pc.in
--- lua5.1-5.1.5/debian/lua-c++.pc.in 2012-05-03 15:13:13.0 +0200
+++ lua5.1-5.1.5/debian/lua-c++.pc.in 2012-07-23 11:41:06.0 +0200
@@ -22,4 +22,4 @@
Requires:
Libs: -L${libdir} -l${lib_name}
Libs.private: -lm -ldl
-Cflags: -I${includedir}/${lib_name_include}
-DDEB_HOST_MULTIARCH=\${deb_host_multiarch}\
+Cflags: -I${includedir}/${lib_name_include}
diff -Nru lua5.1-5.1.5/debian/lua.pc.in lua5.1-5.1.5/debian/lua.pc.in
--- lua5.1-5.1.5/debian/lua.pc.in 2012-05-03 15:13:28.0 +0200
+++ lua5.1-5.1.5/debian/lua.pc.in 2012-07-23 11:41:06.0 +0200
@@ -22,4 +22,4 @@
Requires:
Libs: -L${libdir} -l${lib_name}
Libs.private: -lm -ldl
-Cflags: -I${includedir}/${lib_name_include}
-DDEB_HOST_MULTIARCH=\${deb_host_multiarch}\
+Cflags: -I${includedir}/${lib_name_include}
diff -Nru lua5.1-5.1.5/debian/patches/debian_make.patch
lua5.1-5.1.5/debian/patches/debian_make.patch
--- lua5.1-5.1.5/debian/patches/debian_make.patch 2011-12-24
15:35:45.0 +0100
+++ lua5.1-5.1.5/debian/patches/debian_make.patch 2012-07-23
11:41:06.0 +0200
@@ -1,9 +1,9 @@
Author: John V. Belmonte jbelmo...@debian.org
Description: Add support for Debian package to makefiles.
-Index: lua5.1-5.1.4/Makefile
+Index: lua5.1-5.1.5/Makefile
===
lua5.1-5.1.4.orig/Makefile 2008-08-12 02:40:48.0 +0200
-+++ lua5.1-5.1.4/Makefile 2011-07-25 22:26:28.0 +0200
+--- lua5.1-5.1.5.orig/Makefile 2012-02-10 10:50:23.0 +0100
lua5.1-5.1.5/Makefile 2012-07-16 12:25:26.0 +0200
@@ -12,7 +12,7 @@
INSTALL_TOP= /usr/local
INSTALL_BIN= $(INSTALL_TOP)/bin
@@ -13,7 +13,7 @@
INSTALL_MAN= $(INSTALL_TOP)/man/man1
#
# You probably want to make INSTALL_LMOD and INSTALL_CMOD consistent with
-@@ -126,3 +126,31 @@
+@@ -126,3 +126,30 @@
.PHONY: all $(PLATS) clean test install local none dummy echo pecho lecho
# (end of Makefile)
@@ -43,12 +43,11 @@
+# ISSUE: MYCFLAGS not honored in the case of a CFLAGS override
+debian_linux:
+ cd src; $(MAKE) debian_all CFLAGS+=-DLUA_USE_LINUX \
-+ CFLAGS+=-DDEB_HOST_MULTIARCH=\\\$(DEB_HOST_MULTIARCH)\\\ \
+ LIB_LIBS=-lm -ldl LUA_LIBS=-lreadline LDFLAGS=$(LDFLAGS)
-Index: lua5.1-5.1.4/src/Makefile
+Index: lua5.1-5.1.5/src/Makefile
===
lua5.1-5.1.4.orig/src/Makefile 2008-01-19 20:37:58.0 +0100
-+++ lua5.1-5.1.4/src/Makefile 2011-07-25 22:25:52.0 +0200
+--- lua5.1-5.1.5.orig/src/Makefile 2012-02-13 21:41:22.0 +0100
lua5.1-5.1.5/src/Makefile 2012-07-16 12:24:40.0 +0200
@@ -180,3 +180,36 @@
ltm.h lzio.h lmem.h lopcodes.h lundump.h
diff -Nru lua5.1-5.1.5/debian/patches/module_paths.patch
lua5.1-5.1.5/debian/patches/module_paths.patch
--- lua5.1-5.1.5/debian/patches/module_paths.patch 2011-07-19
16:28:43.0 +0200
+++ lua5.1-5.1.5/debian/patches/module_paths.patch 2012-07-23
11:41:06.0 +0200
@@ -1,12 +1,15 @@
Author: John V. Belmonte jbelmo...@debian.org
Description: Set Lua's default PATH and CPATH.
-Index: lua5.1-5.1.4/src/luaconf.h
+Index: lua5.1-5.1.5/src/luaconf.h
===
lua5.1-5.1.4.orig/src/luaconf.h2008-02-11 17:25:08.0 +0100
-+++ lua5.1-5.1.4/src/luaconf.h 2011-07-19 15:19:57.0 +0200
-@@ -95,13 +95,18 @@
+--- lua5.1-5.1.5.orig/src/luaconf.h2008-02-11 17:25:08.0 +0100
lua5.1-5.1.5/src/luaconf.h 2012-07-16 12:23:12.0 +0200
+@@ -94,14 +94,21 @@
+ .\\?.dll; LUA_CDIR?.dll; LUA_CDIRloadall.dll
#else
++/* This defines DEB_HOST_MULTIARCH */
++#include
