Re: OCaml support for mcl (Was: Help with mcl needed: util/rand.h missing)
Hi Nilesh, Am Mon, Nov 28, 2022 at 01:44:16PM +0530 schrieb Nilesh Patra: > > I'm in favour of droping the OCaml patch. > > I guess the Ocaml patch was needed for pplacer. Now pplacer FTBFS due to > removed > ocaml patch/binpkg. See Bug#1024889 Ah, yes, sure, I'm blaming my very bad memory. :-( > We need to fix this before the cruft removal happens. Unfortunately I have no idea how to fix old, unmaintained OCaml code. Thus I include debian-ocaml-ma...@lists.debian.org for potential helpers. For its readers I shortly the situation: Shayan Doust took the challenge and successfully ported an unmaintained patch for mcl which provides OCaml support which is needed for the package pplacer. I decided to deactivate the patch[1] since its not maintained upstream any more. It would be really great if you could lend some helping hand to upgrade the patch to mcl version 22-282. Unfortunately Salsa CI does not contain the log of the failures any more but if it helps I could easily create the errors in the build process. Kind regards Andreas. > [1] > https://salsa.debian.org/med-team/mcl/-/blob/master/debian/patches/OCamlSupport.patch > [2] https://salsa.debian.org/med-team/mcl/-/jobs/3428232 -- http://fam-tille.de
Re: MRs on salsa and letting janitor automate things
Stuart Prescott writes: > On 27/11/2022 19:30, Julien Puydt wrote: >> Perhaps people didn't get notified they had MRs ? > > Entirely possible, hence the suggestions in my message were that we should: > > a) automate what can be automated so that attention is not needed > > b) check our individual salsa notification settings for repos we care about I, too, miss MRs until I stumble across them months later, usually by seeing that little exclamation mark stand out on my DDPO page. It's a shame that there doesn't seem to be a setting along the lines of "email me about MRs (and issues) in any project that I am an owner of or that a team I am a member of owns". Or does it, and I just missed it? Best, Gard signature.asc Description: PGP signature
Re: MRs on salsa and letting janitor automate things
On 28/11/2022 18:22, Nilesh Patra wrote: On Mon, Nov 28, 2022 at 05:45:02PM +1100, Stuart Prescott wrote: On 28/11/2022 10:55, Dima Kogan wrote: Hi. I've been manually checking the merge requests, and have been accepting most of them. There is one thing the janitor does that I don't agree with, and I'd be against any automated merging of those patches. This is adding Build-Depends: debhelper-compat (=WHATEVER). Such dependencies break building of the package on anything other than sid, and are thus unhelpful. If you can stop the janitor from making this change, that'd probably be good. Can you expand on this a bit? There are plenty of packages with B-D on debhelper-compat (= 13) that are backported to the current stable and oldstable releases without any changes. I _suppose_ this is their use-case: https://lists.debian.org/debian-devel/2022/07/msg00304.html I short, Dima maintains apt repos for packages that are used in many distributions and setting compat as 13 or whatever breaks the build for them. Sounds like throwing a backport of debhelper into the local repos for backports would be a good idea too. It's a trivially backportable package which then lets everything else backport more easily. (Dima, please let me know if I can help with that) Thanks for the extra context, Nilesh! cheers Stuart -- Stuart Prescotthttp://www.nanonanonano.net/ stu...@nanonanonano.net Debian Developer http://www.debian.org/ stu...@debian.org GPG fingerprint90E2 D2C1 AD14 6A1B 7EBB 891D BBC1 7EBB 1396 F2F7
Re: MRs on salsa and letting janitor automate things
On Mon, Nov 28, 2022 at 08:42:59AM +0530, Nilesh Patra wrote: > On Sun, Nov 27, 2022 at 03:55:05PM -0800, Dima Kogan wrote: > > Hi. I've been manually checking the merge requests, and have been > > accepting most of them. There is one thing the janitor does that I don't > > agree with, and I'd be against any automated merging of those patches. > > This is adding Build-Depends: debhelper-compat (=WHATEVER). Such > > dependencies break building of the package on anything other than sid, > > and are thus unhelpful. If you can stop the janitor from making this > > change, that'd probably be good. > > > > That sounds reasonable. I am adding in Jelmer to the thread, so they could > help tweak it for debian-science@ commits/MRs Done, see https://salsa.debian.org/jelmer/janitor.debian.net/-/commit/465c8a43ad2e70f2acd0f8f8928f80771ed6d483 Please let me know if I should tweak that further, e.g. exclude certain packages or keep certain packages backportable to oldstable. debhelper-c
Re: OCaml support for mcl (Was: Help with mcl needed: util/rand.h missing)
On Fri, Oct 28, 2022 at 10:47:01PM +0200, Andreas Tille wrote: > Am Sat, Oct 29, 2022 at 01:32:59AM +0530 schrieb Nilesh Patra: > > > > > On Wed, Oct 26, 2022 at 11:17:38AM +0200, Andreas Tille wrote: > > > Shayan, do you think you can fix this patch you once obtained from some > > > project that seems to have stalled since 9 years? Otherwise I'd tend to > > > remove the patch and thus the OCaml support again. > > > > I am interested in knowing as to why are we keeping ocaml support in the > > first place? > > In other words, what is the purpose of the patch? > > (Upstream project seems to be written in C) > > I'm in favour of droping the OCaml patch. I guess the Ocaml patch was needed for pplacer. Now pplacer FTBFS due to removed ocaml patch/binpkg. See Bug#1024889 We need to fix this before the cruft removal happens. > > > [1] > > > https://salsa.debian.org/med-team/mcl/-/blob/master/debian/patches/OCamlSupport.patch > > > [2] https://salsa.debian.org/med-team/mcl/-/jobs/3428232 -- Best, Nilesh signature.asc Description: PGP signature
