Re: build-depends on atlas, which is obsolete and scheduled for removal

2023-12-22 Thread Sébastien Villemot 
Control: tags -1 + patch

Hi Andreas,

Le mercredi 29 novembre 2023 à 11:53 +0100, Andreas Tille a écrit :
> Control: tags -1 help
> 
> [Ritika Ramani in CC to inform that Debian tries to get rid of Atlas
>  which also affects phast. see https://bugs.debian.org/1056681]
> 
> Hi,
> 
> I tried to replace clapack by LAPACKE.  Unfortunately this is not a
> drop-in replacement.  As you can see in the raw(! normal log is to
> long!) build log on Salsa[1] when seeking for the string
>   too few arguments to function
> you see
> 
> ...
> phast_eigen.c: In function 'mat_diagonalize':
> phast_eigen.c:62:3: error: too few arguments to function 'dgeev_'
>62 |   dgeev_(, , , tmp, , wr, wi, vl,
>   |   ^~
> In file included from /usr/include/lapack.h:11,
>  from 
> /builds/med-team/phast/debian/output/source_dir/src/../include/phast/external_libs.h:43,
>  from 
> /builds/med-team/phast/debian/output/source_dir/src/../include/phast/vector.h:19,
>  from 
> /builds/med-team/phast/debian/output/source_dir/src/../include/phast/matrix.h:18,
>  from 
> /builds/med-team/phast/debian/output/source_dir/src/../include/phast/eigen.h:18,
>  from phast_eigen.c:18:
> /usr/include/lapack.h:1828:6: note: declared here
>  1828 | void LAPACK_dgeev_base(
>   |  ^
> phast_eigen.c: In function 'mat_eigenvals':
> phast_eigen.c:199:3: error: too few arguments to function 'dgeev_'
>   199 |   dgeev_(, , , tmp, , wr, wi, NULL,
>   |   ^~
> ...

Actually we had already completed the migration away from the old
CLAPACK in clapack.patch.

Only a minor cleanup was still needed to remove ATLAS. I opened a merge
request that seems to do the job:

 https://salsa.debian.org/med-team/phast/-/merge_requests/1

Best,

-- 
⢀⣴⠾⠻⢶⣦⠀  Sébastien Villemot
⣾⠁⢠⠒⠀⣿⡁  Debian Developer
⢿⡄⠘⠷⠚⠋⠀  https://sebastien.villemot.name
⠈⠳⣄  https://www.debian.org



signature.asc
Description: This is a digitally signed message part

Re: build-depends on atlas, which is obsolete and scheduled for removal

2023-11-29 Thread Andreas Tille 
Control: tags -1 help

[Ritika Ramani in CC to inform that Debian tries to get rid of Atlas
 which also affects phast. see https://bugs.debian.org/1056681]

Hi,

I tried to replace clapack by LAPACKE.  Unfortunately this is not a
drop-in replacement.  As you can see in the raw(! normal log is to
long!) build log on Salsa[1] when seeking for the string
  too few arguments to function
you see

...
phast_eigen.c: In function 'mat_diagonalize':
phast_eigen.c:62:3: error: too few arguments to function 'dgeev_'
   62 |   dgeev_(, , , tmp, , wr, wi, vl,
  |   ^~
In file included from /usr/include/lapack.h:11,
 from 
/builds/med-team/phast/debian/output/source_dir/src/../include/phast/external_libs.h:43,
 from 
/builds/med-team/phast/debian/output/source_dir/src/../include/phast/vector.h:19,
 from 
/builds/med-team/phast/debian/output/source_dir/src/../include/phast/matrix.h:18,
 from 
/builds/med-team/phast/debian/output/source_dir/src/../include/phast/eigen.h:18,
 from phast_eigen.c:18:
/usr/include/lapack.h:1828:6: note: declared here
 1828 | void LAPACK_dgeev_base(
  |  ^
phast_eigen.c: In function 'mat_eigenvals':
phast_eigen.c:199:3: error: too few arguments to function 'dgeev_'
  199 |   dgeev_(, , , tmp, , wr, wi, NULL,
  |   ^~
...


Seems the LAPACKE function is differently defined than the clapack
function.  Any help is really appreciated.

Note: There might be a chance to define SKIP_LAPACK and by doing so do
not build with some performance drain.  However, I'd prefer if we could
provide phast with the speed users might expect.

Kind regards
   Andreas.
[1] https://salsa.debian.org/med-team/phast/-/jobs/4979980/raw

-- 
http://fam-tille.de