Bug#850027: libfreeimage3: freeimage 3.17.0+ds1-4 makes rviz unusable

[Ghislain Vaillant]

On Thu, 2017-01-12 at 12:27 +, James Cowgill wrote:
> Hi,
> 
> On 12/01/17 12:11, Ghislain Vaillant wrote:
> > On Wed, 11 Jan 2017 11:37:47 +0100 Jochen Sprickerhof  
> > wrote:
> > > Package: libfreeimage3
> > > Followup-For: Bug #850027
> > > 
> > > Hi,
> > > 
> > > is there anything I can do to speed this up? Would be nice to get rviz 
> > > back ;).
> > > 
> > > Cheers Jochen
> > 
> > I now have very limited time for this and there is yet to be a
> > definitive agreement on how to proceed.
> > 
> > I believe Anton proposed to upload to experimental first, test
> > the rdepends and attempt a transition to unstable, although time may be
> > short.
> > 
> > Another solution could be to just make the upload to unstable, monitor
> > the autopkgtests of the rdepends and cross our fingers? I don't know.
> 
> Most packages don't have autopkgtests so manual testing is going to be
> required anyway.
> 
> I think you should just upload it to unstable. Experimental is useful if
> you want to test the rdeps, but if you do not have a lot of time then
> unstable is better since other people will test it a lot more.
> 
> > You guys have much more experience than I have so you are in a better
> > position to advise and act, I guess.
> > 
> > Please CC me in the future as I am not automatically subscribed for
> > some reason.
> 
> Unfortunately uploaders don't get automatically subscribed to the BTS (I
> think that should be improved at some point). To subscribe manually, go
> to this page and hit "Subscribe" in the top-right corner:
> https://tracker.debian.org/pkg/freeimage
> 
> Thanks,
> James

If there is no objections by the end of the day, I will prepare an
upload to unstable with James' patch.

Cheers,
Ghis

-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Bug#850027: libfreeimage3: freeimage 3.17.0+ds1-4 makes rviz unusable

[James Cowgill]

Hi,

On 12/01/17 12:11, Ghislain Vaillant wrote:
> On Wed, 11 Jan 2017 11:37:47 +0100 Jochen Sprickerhof  
> wrote:
>> Package: libfreeimage3
>> Followup-For: Bug #850027
>>
>> Hi,
>>
>> is there anything I can do to speed this up? Would be nice to get rviz back 
>> ;).
>>
>> Cheers Jochen
> 
> I now have very limited time for this and there is yet to be a
> definitive agreement on how to proceed.
> 
> I believe Anton proposed to upload to experimental first, test
> the rdepends and attempt a transition to unstable, although time may be
> short.
> 
> Another solution could be to just make the upload to unstable, monitor
> the autopkgtests of the rdepends and cross our fingers? I don't know.

Most packages don't have autopkgtests so manual testing is going to be
required anyway.

I think you should just upload it to unstable. Experimental is useful if
you want to test the rdeps, but if you do not have a lot of time then
unstable is better since other people will test it a lot more.

> You guys have much more experience than I have so you are in a better
> position to advise and act, I guess.
> 
> Please CC me in the future as I am not automatically subscribed for
> some reason.

Unfortunately uploaders don't get automatically subscribed to the BTS (I
think that should be improved at some point). To subscribe manually, go
to this page and hit "Subscribe" in the top-right corner:
https://tracker.debian.org/pkg/freeimage

Thanks,
James



signature.asc
Description: OpenPGP digital signature
-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Bug#850027: libfreeimage3: freeimage 3.17.0+ds1-4 makes rviz unusable

[Ghislain Vaillant]

On Wed, 11 Jan 2017 11:37:47 +0100 Jochen Sprickerhof  
wrote:
> Package: libfreeimage3
> Followup-For: Bug #850027
> 
> Hi,
> 
> is there anything I can do to speed this up? Would be nice to get rviz back 
> ;).
> 
> Cheers Jochen

I now have very limited time for this and there is yet to be a
definitive agreement on how to proceed.

I believe Anton proposed to upload to experimental first, test
the rdepends and attempt a transition to unstable, although time may be
short.

Another solution could be to just make the upload to unstable, monitor
the autopkgtests of the rdepends and cross our fingers? I don't know.

You guys have much more experience than I have so you are in a better
position to advise and act, I guess.

Please CC me in the future as I am not automatically subscribed for
some reason.

Ghis

-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Bug#850027: libfreeimage3: freeimage 3.17.0+ds1-4 makes rviz unusable

[Jochen Sprickerhof]

Package: libfreeimage3
Followup-For: Bug #850027

Hi,

is there anything I can do to speed this up? Would be nice to get rviz back ;).

Cheers Jochen

-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Bug#850027: libfreeimage3: freeimage 3.17.0+ds1-4 makes rviz unusable

[Ghislain Vaillant]

I believe it is worth trying, since neither the situation before nor 
after freeimage 3.17.0+ds1-4 is ideal. Before, a set of plugins were no 
longer loaded correctly (#841089) and after, the API was somewhat 
changed (because of the dummy node introduced by the updated patch).


Besides, I am now wondering whether we actually did a rebuild of all 
rdepends with 3.17.0+ds1-4?


Ghis


On 08/01/17 12:26, Anton Gladky wrote:

Hmm, I would then make an upoad to experimental first,
build all depends against this new version to detect
possible FTBFS and then upload to sid.

Not sure, whether we have enough time for now.

Cheers

Anton


2017-01-08 11:16 GMT+01:00 Ghislain Vaillant :

On Thu, 5 Jan 2017 21:57:53 + James Cowgill  wrote:


Control: block 849696 by -1
Control: tags -1 patch

Hi,

This is of course the same bug as #849696 in OGRE, but I still think it
should be fixed in freeimage.

I'd like to propose this patch (a new version of
Disable-vendored-dependencies.patch is also attached):


https://anonscm.debian.org/cgit/users/jcowgill/freeimage.git/commit/?h=bug-850027=b5f51dbe600e475a6bfc8e0f52335136b57ca123

My patch reverts the one applied in #841089 which broke the API, and
instead of removing the G3 plugin, it includes a G3 plugin which does
nothing (trying to load a G3 file will always fail). The advantage of
this is that the API is identical to upstream and it should also fix
the issue in #841089 as well.



I like this. I'll roll an update in the next few days.

Thanks to everyone who were involved.

Ghis


--
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers


--
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Bug#850027: libfreeimage3: freeimage 3.17.0+ds1-4 makes rviz unusable

[Anton Gladky]

Hmm, I would then make an upoad to experimental first,
build all depends against this new version to detect
possible FTBFS and then upload to sid.

Not sure, whether we have enough time for now.

Cheers

Anton


2017-01-08 11:16 GMT+01:00 Ghislain Vaillant :
> On Thu, 5 Jan 2017 21:57:53 + James Cowgill  wrote:
>>
>> Control: block 849696 by -1
>> Control: tags -1 patch
>>
>> Hi,
>>
>> This is of course the same bug as #849696 in OGRE, but I still think it
>> should be fixed in freeimage.
>>
>> I'd like to propose this patch (a new version of
>> Disable-vendored-dependencies.patch is also attached):
>>
>>
>> https://anonscm.debian.org/cgit/users/jcowgill/freeimage.git/commit/?h=bug-850027=b5f51dbe600e475a6bfc8e0f52335136b57ca123
>>
>> My patch reverts the one applied in #841089 which broke the API, and
>> instead of removing the G3 plugin, it includes a G3 plugin which does
>> nothing (trying to load a G3 file will always fail). The advantage of
>> this is that the API is identical to upstream and it should also fix
>> the issue in #841089 as well.
>
>
> I like this. I'll roll an update in the next few days.
>
> Thanks to everyone who were involved.
>
> Ghis
>
>
> --
> debian-science-maintainers mailing list
> debian-science-maintainers@lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Bug#850027: libfreeimage3: freeimage 3.17.0+ds1-4 makes rviz unusable

[Ghislain Vaillant]

On Thu, 5 Jan 2017 21:57:53 + James Cowgill  wrote:

Control: block 849696 by -1
Control: tags -1 patch

Hi,

This is of course the same bug as #849696 in OGRE, but I still think it
should be fixed in freeimage.

I'd like to propose this patch (a new version of
Disable-vendored-dependencies.patch is also attached):

https://anonscm.debian.org/cgit/users/jcowgill/freeimage.git/commit/?h=bug-850027=b5f51dbe600e475a6bfc8e0f52335136b57ca123

My patch reverts the one applied in #841089 which broke the API, and
instead of removing the G3 plugin, it includes a G3 plugin which does
nothing (trying to load a G3 file will always fail). The advantage of
this is that the API is identical to upstream and it should also fix
the issue in #841089 as well.


I like this. I'll roll an update in the next few days.

Thanks to everyone who were involved.

Ghis

--
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Bug#850027: libfreeimage3: freeimage 3.17.0+ds1-4 makes rviz unusable

[Erik Andresen]

Hi,

Agreed, sounds less intrusive. Confirmed working.

greetings,
Erik

--
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Bug#850027: libfreeimage3: freeimage 3.17.0+ds1-4 makes rviz unusable

[Boris Lesner]

Hi,

This is a much better fix indeed.

Boris

On 05/01/2017 22:57, James Cowgill wrote:

Control: block 849696 by -1
Control: tags -1 patch

Hi,

This is of course the same bug as #849696 in OGRE, but I still think it
should be fixed in freeimage.

I'd like to propose this patch (a new version of
Disable-vendored-dependencies.patch is also attached):

https://anonscm.debian.org/cgit/users/jcowgill/freeimage.git/commit/?h=bug-850027=b5f51dbe600e475a6bfc8e0f52335136b57ca123

My patch reverts the one applied in #841089 which broke the API, and
instead of removing the G3 plugin, it includes a G3 plugin which does
nothing (trying to load a G3 file will always fail). The advantage of
this is that the API is identical to upstream and it should also fix
the issue in #841089 as well.

Thanks,
James


--
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Processed: Bug#850027: libfreeimage3: freeimage 3.17.0+ds1-4 makes rviz unusable

[Debian Bug Tracking System]

Processing control commands:

> block 849696 by -1
Bug #849696 [libogre-1.9.0v5] libogre-1.9.0v5: Ogre games abort on startup with 
“basic_string::_M_construct null not valid”
849696 was not blocked by any bugs.
849696 was not blocking any bugs.
Added blocking bug(s) of 849696: 850027
> tags -1 patch
Bug #850027 [libfreeimage3] libfreeimage3: freeimage 3.17.0+ds1-4 makes rviz 
unusable
Added tag(s) patch.

-- 
849696: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=849696
850027: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=850027
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Bug#850027: libfreeimage3: freeimage 3.17.0+ds1-4 makes rviz unusable

[James Cowgill]

Control: block 849696 by -1
Control: tags -1 patch

Hi,

This is of course the same bug as #849696 in OGRE, but I still think it
should be fixed in freeimage.

I'd like to propose this patch (a new version of
Disable-vendored-dependencies.patch is also attached):

https://anonscm.debian.org/cgit/users/jcowgill/freeimage.git/commit/?h=bug-850027=b5f51dbe600e475a6bfc8e0f52335136b57ca123

My patch reverts the one applied in #841089 which broke the API, and
instead of removing the G3 plugin, it includes a G3 plugin which does
nothing (trying to load a G3 file will always fail). The advantage of
this is that the API is identical to upstream and it should also fix
the issue in #841089 as well.

Thanks,
James
From: Ghislain Antony Vaillant 
Date: Tue, 3 Nov 2015 14:39:33 +
Subject: Disable vendored dependencies.

This commit disables usage of the embedded dependencies for building
FreeImage and FreeImagePlus. Functionalities which could not use the
packaged dependencies are delibarately disabled for security reasons.

This patch is based on Fedora's FreeImage-3.17.0_unbundle patch.
---
 Source/FreeImage.h |  9 -
 Source/FreeImage/J2KHelper.cpp |  2 +-
 Source/FreeImage/PluginEXR.cpp | 20 +-
 Source/FreeImage/PluginG3.cpp  |  9 +++--
 Source/FreeImage/PluginJ2K.cpp |  2 +-
 Source/FreeImage/PluginJP2.cpp |  2 +-
 Source/FreeImage/PluginJPEG.cpp|  6 +--
 Source/FreeImage/PluginJXR.cpp |  2 +-
 Source/FreeImage/PluginPNG.cpp |  4 +-
 Source/FreeImage/PluginRAW.cpp |  2 +-
 Source/FreeImage/PluginTIFF.cpp|  4 +-
 Source/FreeImage/PluginWebP.cpp|  8 ++--
 Source/FreeImage/ZLibInterface.cpp |  5 +--
 Source/Metadata/XTIFF.cpp  | 80 +++---
 genfipsrclist.sh   |  9 +
 gensrclist.sh  | 11 ++
 16 files changed, 85 insertions(+), 90 deletions(-)

diff --git a/Source/FreeImage.h b/Source/FreeImage.h
index e2d1c5a..ac35bec 100644
--- a/Source/FreeImage.h
+++ b/Source/FreeImage.h
@@ -473,6 +473,9 @@ FI_ENUM(FREE_IMAGE_DITHER) {
 	FID_BAYER16x16	= 6		//! Bayer ordered dispersed dot dithering (order 4 dithering matrix)
 };
 
+/* Debian: The JPEGTransform functions are deliberately disabled in our build
+   of FreeImage, since they require usage of the vendored copy of libjpeg. */
+#if 0
 /** Lossless JPEG transformations
 Constants used in FreeImage_JPEGTransform
 */
@@ -486,6 +489,7 @@ FI_ENUM(FREE_IMAGE_JPEG_OPERATION) {
 	FIJPEG_OP_ROTATE_180	= 6,	//! 180-degree rotation
 	FIJPEG_OP_ROTATE_270	= 7		//! 270-degree clockwise (or 90 ccw)
 };
+#endif
 
 /** Tone mapping operators.
 Constants used in FreeImage_ToneMapping.
@@ -1076,7 +1080,9 @@ DLL_API const char* DLL_CALLCONV FreeImage_TagToString(FREE_IMAGE_MDMODEL model,
 // --
 // JPEG lossless transformation routines
 // --
-
+/* Debian: The JPEGTransform functions are deliberately disabled in our build
+   of FreeImage, since they require usage of the vendored copy of libjpeg. */
+#if 0
 DLL_API BOOL DLL_CALLCONV FreeImage_JPEGTransform(const char *src_file, const char *dst_file, FREE_IMAGE_JPEG_OPERATION operation, BOOL perfect FI_DEFAULT(TRUE));
 DLL_API BOOL DLL_CALLCONV FreeImage_JPEGTransformU(const wchar_t *src_file, const wchar_t *dst_file, FREE_IMAGE_JPEG_OPERATION operation, BOOL perfect FI_DEFAULT(TRUE));
 DLL_API BOOL DLL_CALLCONV FreeImage_JPEGCrop(const char *src_file, const char *dst_file, int left, int top, int right, int bottom);
@@ -1085,6 +1091,7 @@ DLL_API BOOL DLL_CALLCONV FreeImage_JPEGTransformFromHandle(FreeImageIO* src_io,
 DLL_API BOOL DLL_CALLCONV FreeImage_JPEGTransformCombined(const char *src_file, const char *dst_file, FREE_IMAGE_JPEG_OPERATION operation, int* left, int* top, int* right, int* bottom, BOOL perfect FI_DEFAULT(TRUE));
 DLL_API BOOL DLL_CALLCONV FreeImage_JPEGTransformCombinedU(const wchar_t *src_file, const wchar_t *dst_file, FREE_IMAGE_JPEG_OPERATION operation, int* left, int* top, int* right, int* bottom, BOOL perfect FI_DEFAULT(TRUE));
 DLL_API BOOL DLL_CALLCONV FreeImage_JPEGTransformCombinedFromMemory(FIMEMORY* src_stream, FIMEMORY* dst_stream, FREE_IMAGE_JPEG_OPERATION operation, int* left, int* top, int* right, int* bottom, BOOL perfect FI_DEFAULT(TRUE));
+#endif
 
 
 // --
diff --git a/Source/FreeImage/J2KHelper.cpp b/Source/FreeImage/J2KHelper.cpp
index 1776c3b..538f1c5 100644
--- a/Source/FreeImage/J2KHelper.cpp
+++ b/Source/FreeImage/J2KHelper.cpp
@@ -21,7 +21,7 @@
 
 #include "FreeImage.h"
 #include "Utilities.h"
-#include "../LibOpenJPEG/openjpeg.h"
+#include 
 #include "J2KHelper.h"
 
 // --
diff --git a/Source/FreeImage/PluginEXR.cpp 

Bug#850027: libfreeimage3: freeimage 3.17.0+ds1-4 makes rviz unusable

[Ghislain Vaillant]

Hi Erik, thanks for reporting this issue,

freeimage/3.17.0+ds1-4 fixed an issue with the patch used to remove the
vendored dependencies and use the system one instead. See #841089 [1].

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=841089

The updated patch introduces a null-node for plugins which have been
disabled (here the G3 fax format). Before this patch, all nodes stored
in the plugin map were guaranteed to be non-null but all plugins with
IDs over FIF_FAXG3 were wrongly indexed.

A fix for your issue in rviz would be to filter the plugin map from
non-null nodes prior to registering the codecs.

Hope this helps,
Ghis

-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Bug#850027: libfreeimage3: freeimage 3.17.0+ds1-4 makes rviz unusable

[Erik Andresen]

Package: libfreeimage3
Version: 3.17.0+ds1-3
Severity: important

Hi,

the recent libfreeimage update from 3.17.0+ds1-3 to to 3.17.0+ds1-4
breaks rviz. The application fails to start with:

terminate called after throwing an instance of 'std::logic_error'
  what():  basic_string::_M_construct null not valid
  zsh: abort  rviz

reverting freeimage to ds1-3 fixes the problem. Relevant upstream rviz
bug is:
https://github.com/ros-visualization/rviz/issues/1071

greetings,
Erik

-- 
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers