Re: 5.10.0-4-sparc64-smp #1 Debian 5.10.19-1 crashes on T2000

2021-03-17 Thread Frank Scheiner

Hi Adrian,

On 17.03.21 13:39, John Paul Adrian Glaubitz wrote:

On 3/17/21 1:22 PM, Frank Scheiner wrote:

```
johndoe@x4270:~/git-projects/torvalds/linux$ git bisect bad
028abd9222df0cf5855dab5014a5ebaf06f90565 is the first bad commit
[...]

Did you verify that reverting this commit or - if reverting is not possible - 
testing
out the revision just before the commit?


I did not yet revert the bad commit in a current kernel and test it, but
from my understanding the parent commit of the first bad one must have
been a good one and indeed, [67e306c6906137020267eb9bbdbc127034da3627]
is the parent of [028abd9222df0cf5855dab5014a5ebaf06f90565] and was
working for me on my T1000:


```
johndoe@x4270:~/git-projects/torvalds/linux$ git bisect log
[...]
# good: [67e306c6906137020267eb9bbdbc127034da3627] fs,nfs: lift compat
nfs4 mount data handling into the nfs code
git bisect good 67e306c6906137020267eb9bbdbc127034da3627
# bad: [028abd9222df0cf5855dab5014a5ebaf06f90565] fs: remove
compat_sys_mount
git bisect bad 028abd9222df0cf5855dab5014a5ebaf06f90565
# first bad commit: [028abd9222df0cf5855dab5014a5ebaf06f90565] fs:
remove compat_sys_mount
```


[67e306c6906137020267eb9bbdbc127034da3627]:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=67e306c6906137020267eb9bbdbc127034da3627

[028abd9222df0cf5855dab5014a5ebaf06f90565]:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=028abd9222df0cf5855dab5014a5ebaf06f90565


Just to be safe you found the correct commit.

If that has been verified, please report the issue to the sparclinux LKML and 
CC Christoph.


Will do that soon-ish but maybe also try to revert that commit in
Debian's 5.10.0-4 and test it for additional assurance (then not so
soon-ish - maybe this weekend). I'll put you and Riccardo in CC, too.

Hopefully this will be easier to fix than the kernel breakage on the
rx2800 i2 - assuming that problem is still there ([1], [2]).

[1]: https://marc.info/?l=linux-ia64=156114769908890=2
[2]: https://marc.info/?l=linux-ia64=156144480821712=2

Cheers and thanks for the pointers,
Frank



Re: 5.10.0-4-sparc64-smp #1 Debian 5.10.19-1 crashes on T2000

2021-03-17 Thread John Paul Adrian Glaubitz
Hi Frank!

On 3/17/21 1:22 PM, Frank Scheiner wrote:
> Hi Adrian, Riccardo
> 
> so I'm finished with bisecting and it points to the following commit as
> first bad commit:
> 
> ```
> johndoe@x4270:~/git-projects/torvalds/linux$ git bisect bad
> 028abd9222df0cf5855dab5014a5ebaf06f90565 is the first bad commit
> commit 028abd9222df0cf5855dab5014a5ebaf06f90565
> Author: Christoph Hellwig 
> Date:   Thu Sep 17 10:22:34 2020 +0200
> 
> fs: remove compat_sys_mount
> 
> compat_sys_mount is identical to the regular sys_mount now, so
> remove it
> and use the native version everywhere.

Did you verify that reverting this commit or - if reverting is not possible - 
testing
out the revision just before the commit? Just to be safe you found the correct 
commit.

If that has been verified, please report the issue to the sparclinux LKML and 
CC Christoph.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913



Re: 5.10.0-4-sparc64-smp #1 Debian 5.10.19-1 crashes on T2000

2021-03-17 Thread Frank Scheiner

Hi Adrian, Riccardo

so I'm finished with bisecting and it points to the following commit as
first bad commit:

```
johndoe@x4270:~/git-projects/torvalds/linux$ git bisect bad
028abd9222df0cf5855dab5014a5ebaf06f90565 is the first bad commit
commit 028abd9222df0cf5855dab5014a5ebaf06f90565
Author: Christoph Hellwig 
Date:   Thu Sep 17 10:22:34 2020 +0200

fs: remove compat_sys_mount

compat_sys_mount is identical to the regular sys_mount now, so
remove it
and use the native version everywhere.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Al Viro 

 arch/arm64/include/asm/unistd32.h  |  2 +-
 arch/mips/kernel/syscalls/syscall_n32.tbl  |  2 +-
 arch/mips/kernel/syscalls/syscall_o32.tbl  |  2 +-
 arch/parisc/kernel/syscalls/syscall.tbl|  2 +-
 arch/powerpc/kernel/syscalls/syscall.tbl   |  2 +-
 arch/s390/kernel/syscalls/syscall.tbl  |  2 +-
 arch/sparc/kernel/syscalls/syscall.tbl |  2 +-
 arch/x86/entry/syscalls/syscall_32.tbl |  2 +-
 fs/Makefile|  1 -
 fs/compat.c| 57
--
 fs/internal.h  |  3 --
 fs/namespace.c |  4 +-
 include/linux/compat.h |  6 ---
 include/uapi/asm-generic/unistd.h  |  2 +-
 tools/include/uapi/asm-generic/unistd.h|  2 +-
 tools/perf/arch/powerpc/entry/syscalls/syscall.tbl |  2 +-
 tools/perf/arch/s390/entry/syscalls/syscall.tbl|  2 +-
 17 files changed, 14 insertions(+), 81 deletions(-)
 delete mode 100644 fs/compat.c
```

Seems to be indeed related to mounting (the root FS). Why it only
affects UltraSPARC T1 CPUs is another question. I don't have any other
UltraSPARC II, IIi, IIe, III and IIIi driven machines at hand now for
checking those.

So what now?

Cheers,
Frank

P.S.

Here's the log for reference:

```
johndoe@x4270:~/git-projects/torvalds/linux$ git bisect log
git bisect start
# good: [bbf5c979011a099af5dc76498918ed7df445635b] Linux 5.9
git bisect good bbf5c979011a099af5dc76498918ed7df445635b
# bad: [3650b228f83adda7e5ee532e2b90429c03f7b9ec] Linux 5.10-rc1
git bisect bad 3650b228f83adda7e5ee532e2b90429c03f7b9ec
# bad: [c48b75b7271db23c1b2d1204d6e8496d91f27711] Merge tag
'sound-5.10-rc1' of
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound
git bisect bad c48b75b7271db23c1b2d1204d6e8496d91f27711
# bad: [7fafb54c7d390e9b273a1d7d377e38d9c408046e] Merge tag
'leds-5.10-rc1' of
git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds
git bisect bad 7fafb54c7d390e9b273a1d7d377e38d9c408046e
# bad: [fd5c32d80884268a381ed0e67cccef0b3d37750b] Merge tag
'media/v5.10-1' of
git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media
git bisect bad fd5c32d80884268a381ed0e67cccef0b3d37750b
# bad: [865c50e1d279671728c2936cb7680eb89355eeea] x86/uaccess: utilize
CONFIG_CC_HAS_ASM_GOTO_OUTPUT
git bisect bad 865c50e1d279671728c2936cb7680eb89355eeea
# good: [13cb73490f475f8e7669f9288be0bcfa85399b1f] Merge tag
'x86-entry-2020-10-12' of
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
git bisect good 13cb73490f475f8e7669f9288be0bcfa85399b1f
# good: [dd502a81077a5f3b3e19fa9a1accffdcab5ad5bc] Merge tag
'core-static_call-2020-10-12' of
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
git bisect good dd502a81077a5f3b3e19fa9a1accffdcab5ad5bc
# good: [ced3a9eb3cd0d07462cdbaa8a0f3d46e5aaeadec] Merge tag
'ia64_for_5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux
git bisect good ced3a9eb3cd0d07462cdbaa8a0f3d46e5aaeadec
# good: [fc67d5bc876b6b224538c8848fc02e70f269ec99]
Documentation/admin-guide: README & svga: remove use of "rdev"
git bisect good fc67d5bc876b6b224538c8848fc02e70f269ec99
# good: [c90578360c92c71189308ebc71087197080e94c3] Merge branch
'work.csum_and_copy' of
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
git bisect good c90578360c92c71189308ebc71087197080e94c3
# good: [85ed13e78dbedf9433115a62c85429922bc5035c] Merge branch
'work.iov_iter' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
git bisect good 85ed13e78dbedf9433115a62c85429922bc5035c
# bad: [22230cd2c55bd27ee2c3a3def97c0d5577a75b82] Merge branch
'compat.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
git bisect bad 22230cd2c55bd27ee2c3a3def97c0d5577a75b82
# good: [e18afa5bfa4a2f0e07b0864370485df701dacbc1] Merge branch
'work.quota-compat' of
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
git bisect good e18afa5bfa4a2f0e07b0864370485df701dacbc1
# good: [67e306c6906137020267eb9bbdbc127034da3627] fs,nfs: lift compat
nfs4 mount data handling into the nfs code
git bisect good 67e306c6906137020267eb9bbdbc127034da3627
# bad: [028abd9222df0cf5855dab5014a5ebaf06f90565] fs: remove
compat_sys_mount
git bisect bad 028abd9222df0cf5855dab5014a5ebaf06f90565
# first bad commit: [028abd9222df0cf5855dab5014a5ebaf06f90565] fs: