Re: Bug#806837: qtwebkit: FTBFS on sparc64
On Wednesday 02 December 2015 14:27:08 John Paul Adrian Glaubitz wrote: > On 12/02/2015 02:23 PM, Lisandro Damián Nicanor Pérez Meyer wrote: > > The change is already pushed to our repo. > > Thanks! > > Could you also apply David's patch [1] which is required to fix the > build on sparc64? Disabling the JIT on sparc64 unfortunately > isn't enough. Good catch! Indeed I missed it. The patch looks fine and qt4's upstream status is "no more changes", so I'm applying it as a Debian delta. -- Why should I care about posterity? What's posterity ever done for me? -- Groucho Marx Lisandro Damián Nicanor Pérez Meyer http://perezmeyer.com.ar/ http://perezmeyer.blogspot.com/ signature.asc Description: This is a digitally signed message part.
Re: Bug#806837: qtwebkit: FTBFS on sparc64
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 12/02/2015 11:18 PM, Lisandro Damián Nicanor Pérez Meyer wrote: >> Could you also apply David's patch [1] which is required to fix >> the build on sparc64? Disabling the JIT on sparc64 unfortunately >> isn't enough. > > Good catch! Indeed I missed it. The patch looks fine and qt4's > upstream status is "no more changes", so I'm applying it as a > Debian delta. Awesome, thank you very much! Adrian - -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQIcBAEBCAAGBQJWX27gAAoJEHQmOzf1tfkTdsQQALPWdtGtSn8XepnzzWTvsqgW lgt/3ldb/haoqnGeqdfN53dGHwecCeYUkp7Jrc7B82gzQNaH0KUWcqyRYIpjJZ9j 7pVmjNkDvF8w9p3DZzZiMEB9N48u7nQIlQvUw2fMJJBknUCvzpJ333woB/Q1Z1Ft FtFx+BCWvlzyp1Ua9FmhFJew7vEGXQu3GhpG4naitbPxYkmp/V3W0Y5hDfH5Weg+ gl/3fb0rDLnIqO3Wh9Zgq5hEpWmD1exKeciwn+d+/P882VxhIkaVjvBMnK7uHacp vgclKD1wQW4oajw6P4X5aSygWE7o67JTTnK2BQMVNymL0O4G4y3c/un3V7t2+9w5 lEWimOSBU+skpEXGk5NtqRl9hMEXTTm6mBuhXsSPA2+S8Z9mTPNIjIc2lZhyFEEZ fX0+c2vlbxEIP6mWCRvgKmWrnr1qEDfG+GpOxc3R41ehWcQeC7H3GOvbkPXo/mTx 8eb5I7ydZxM8iZLYTNs6dtXXkP739ujg04a7kx0QEvZAAVY3F0EFiPgWwpWdU7R/ aWwyT8NzjeUZqlJDQSypqJAgS4vSWmeHYZ03hmdRvUtQoUUIrF0r2q0gci5jw+zp LIihlBPurH/k3hLLn5KUNg+u/YGd2xY2Ts8RDIImrVVr/lMqDfI9JS9iHNOsyaA4 8UuU4sPtwm3T2oW1+xqq =chUB -END PGP SIGNATURE-
Re: Bug#806837: qtwebkit: FTBFS on sparc64
On 12/02/2015 02:26 AM, David Matthew Mattli wrote: > qtwebkit currently fails to build for sparc64. I was able to > fix the build by adding sparc64 to the list of non-JIT archs > in debian/rules FWIW, please add m68k and sh4 to this list, too! Building a patched version for 'unreleased' now in any case. Thanks, Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Re: Bug#806837: qtwebkit: FTBFS on sparc64
On 12/02/2015 10:32 AM, John Paul Adrian Glaubitz wrote: > On 12/02/2015 02:26 AM, David Matthew Mattli wrote: >> qtwebkit currently fails to build for sparc64. I was able to >> fix the build by adding sparc64 to the list of non-JIT archs >> in debian/rules > > FWIW, please add m68k and sh4 to this list, too! Make it alpha and ppc64 as well. Thus, please add alpha m68k ppc64 sh4 sparc64 to the list of architectures where the JIT should be disabled. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Re: Bug#806837: qtwebkit: FTBFS on sparc64
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 12/02/2015 02:23 PM, Lisandro Damián Nicanor Pérez Meyer wrote: > The change is already pushed to our repo. Thanks! Could you also apply David's patch [1] which is required to fix the build on sparc64? Disabling the JIT on sparc64 unfortunately isn't enough. Cheers, Adrian > [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;msg=5;bug=806837;fil ename=fix-sparc64.diff - -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQIcBAEBCAAGBQJWXvGlAAoJEHQmOzf1tfkT8/wQAMNXDtiU/cI8yRbRRNSO8l3F yXzAxmdzPqB5pR84NtpKP8NIbutQFeyw5tn3id628flMwaVkejwZDEvI8DpdA1BY UEhof/5jExsDo+nyUVjhxxb4MzRTrbUopw7my1XnJu5KadjG07K7dbdsvTngxZXU iB8xWIydiIlmyMAdWK7raN2EOSPbbfPtGwblK+HQXAJXXl/B7qewWzWIvsZGuBxm 8xiaohZ2bDZVFrp9F+Fp9XSIegpbJ2xUV67GgdtPkpK/FoJR1QPKECQxCtLyebQR 5Ogfyxho8K6VO14+0CXe42G1Jk51wdrdsb+KY63ZGYV6xZWu/BeCqTGPIMv2tcs+ W5OOBWLY2ifdF4RS4hU/lcj6HVCO0IC6frlN94aA7J63RNH9fF0KF49IhXU3Ej8r ebMeFWrCPgPf6eYnffk2F2iOHnEAQS62sD7xSQbTGaL2RjxtJEO0EZoeiwo7wcGi t0cfnjUcQO+Y5uwPdKtvde7XO+mhSFpinBaFbHmek/TPA9tNOrkN21r2AhSa2RF4 FqN4UtWZ3jDYcxH2pRYjC7+bhDpkOJ7MYyn73hbfjX9yzWJh+CmvnW0UMVJNOtHq DbOhVNQ3q5wVA0z28oduQYdYDaWAuTbarYhhgQ2/HHnpRvFY1mJVjSttEdEBWCj7 hnp2LkIuQ0CNtq3NrKwT =gYx2 -END PGP SIGNATURE-
Re: Bug#806837: qtwebkit: FTBFS on sparc64
tag 806837 pending thanks The change is already pushed to our repo. -- me cago en el gato, es como la tercera vez que me apreta backspace mientras tengo apretados ctrl y alt Visto en #lugfi, irc.freenode.net Lisandro Damián Nicanor Pérez Meyer http://perezmeyer.com.ar/ http://perezmeyer.blogspot.com/ signature.asc Description: This is a digitally signed message part.
Bug#806837: qtwebkit: FTBFS on sparc64
Source: qtwebkit
Severity: normal
Tags: patch
User: debian-sparc@lists.debian.org
Usertags: sparc64
Dear Maintainer,
qtwebkit currently fails to build for sparc64. I was able to
fix the build by adding sparc64 to the list of non-JIT archs
in debian/rules, fixing a declaration of UChar32, and removing
a condition disabling atomics on sparc64. Newer versions of gcc
implement builtin atomic operations for all integer types.
Below is the change to debian/rules and I've attached the patch
that changes the two headers. The changes are simple and shouldn't
affect other archs.
Similar changes have already been made upstream in newer versions
of webkit but they seem to implement an incompatible qt api.
--- a/debian/rules2015-09-15 08:05:20.0 -0500
+++ b/debian/rules2015-12-01 10:18:33.501211135 -0600
@@ -50,7 +50,7 @@
#disable JIT assembler on archs where it doesn't compile
#disable WTF_USE_3D_GRAPHICS on ARM where it doesn't compile
#disable forcing SSE2 on all other platforms
-ifneq (,$(filter arm64 armel hppa mips mipsel mips64 mips64el powerpc ppc64el
s390x x32,$(DEB_HOST_ARCH)))
+ifneq (,$(filter arm64 armel hppa mips mipsel mips64 mips64el powerpc ppc64el
s390x sparc64 x32,$(DEB_HOST_ARCH)))
./Tools/Scripts/build-webkit --qt DEFINES+=ENABLE_JIT=0
DEFINES+=ENABLE_YARR_JIT=0 DEFINES+=ENABLE_ASSEMBLER=0 $(QMAKE_ARGS)
$(MAKE_ARGS)
else ifeq ($(DEB_HOST_ARCH),armhf)
./Tools/Scripts/build-webkit --qt DEFINES+=WTF_USE_3D_GRAPHICS=0
DEFINES+=ENABLE_JIT=0 DEFINES+=ENABLE_YARR_JIT=0 DEFINES+=ENABLE_ASSEMBLER=0
$(QMAKE_ARGS) $(MAKE_ARGS)
-- System Information:
Debian Release: stretch/sid
APT prefers unreleased
APT policy: (500, 'unreleased'), (500, 'unstable')
Architecture: sparc64
Kernel: Linux 4.3.0-gentoo (SMP w/1 CPU core)
Locale: LANG=en_SG.UTF-8, LC_CTYPE=en_SG.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: unable to detect
--- a/Source/WTF/wtf/unicode/qt4/UnicodeQt4.h
+++ b/Source/WTF/wtf/unicode/qt4/UnicodeQt4.h
@@ -69,8 +69,12 @@
#endif
#if !USE(ICU_UNICODE)
+#ifdef __sparc_v9__
+typedef int32_t UChar32;
+#else
typedef uint32_t UChar32;
#endif
+#endif
namespace WTF {
namespace Unicode {
--- a/Source/WTF/wtf/Atomics.h
+++ b/Source/WTF/wtf/Atomics.h
@@ -98,7 +98,7 @@
inline int atomicIncrement(int volatile* addend) { return __atomic_inc(addend) + 1; }
inline int atomicDecrement(int volatile* addend) { return __atomic_dec(addend) - 1; }
-#elif COMPILER(GCC) && !CPU(SPARC64) // sizeof(_Atomic_word) != sizeof(int) on sparc64 gcc
+#elif COMPILER(GCC)
#define WTF_USE_LOCKFREE_THREADSAFEREFCOUNTED 1
inline int atomicIncrement(int volatile* addend) { return __sync_add_and_fetch(addend, 1); }
