Bug#772823: ITP: kimchi -- HTML5 baseITP: kimchi -- HTML5 based management tool for KVM.d management tool for KVM.
Hi Julien, thanks for this one. I added it to the lastest packaging I pushed on mentors.debian.net . I also added a patch that I sent for review on @kimchi-devel which should make possible to use http://server/kimchi with a sub-site configuration file in nginx based on commentis of Robie Basak to comply better with : http://webapps-common.alioth.debian.org/draft/html/ch-httpd.html F. On Sun, 22 Mar 2015 23:37:44 +1100, Julien Goodwin jgood...@studio442.com.au wrote: One more missing dep that slipped through, novnc is missing from the package deps. -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20150325110119.gf29...@kin.lab.toulouse-stg.fr.ibm.com
Bug#772823: ITP: kimchi -- HTML5 baseITP: kimchi -- HTML5 based management tool for KVM.d management tool for KVM.
On 25/03/15 21:01, Frederic Bonnard wrote: Hi Julien, thanks for this one. I added it to the lastest packaging I pushed on mentors.debian.net . I also added a patch that I sent for review on @kimchi-devel which should make possible to use http://server/kimchi with a sub-site configuration file in nginx based on commentis of Robie Basak to comply better with : http://webapps-common.alioth.debian.org/draft/html/ch-httpd.html Yep, been seeing those come through. On Sun, 22 Mar 2015 23:37:44 +1100, Julien Goodwin jgood...@studio442.com.au wrote: One more missing dep that slipped through, novnc is missing from the package deps. signature.asc Description: OpenPGP digital signature
Bug#772823: ITP: kimchi -- HTML5 baseITP: kimchi -- HTML5 based management tool for KVM.d management tool for KVM.
One more missing dep that slipped through, novnc is missing from the package deps. signature.asc Description: OpenPGP digital signature
Bug#772823: ITP: kimchi -- HTML5 baseITP: kimchi -- HTML5 based management tool for KVM.d management tool for KVM.
Hi Julien, In the latest packaging draft, I fixed a few lintians. For some of which I opened upstream ; for reference : - I wrote a manpage which I submitted upstream : https://github.com/kimchi-project/kimchi/issues/587 - we would need non minified javascript : https://github.com/kimchi-project/kimchi/issues/588 but overriden for now. Also I added a pam service for kimchi, so that only root and libvirt users can login to kimchi. It seems to work as I wanted, but I'm not a pam export so if anybody can review that :) F. -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20150210120536.gc22...@kin.lab.toulouse-stg.fr.ibm.com
Bug#772823: ITP: kimchi -- HTML5 baseITP: kimchi -- HTML5 based management tool for KVM.d management tool for KVM.
I updated the package with some of your points : 1. For some reason kimchid didn't start on boot, systemd decided not to load it. This may well be a problem on my machine, not a generic one, but perhaps worth testing. Got the same :) I added --with systemd so that postinstall script does the job. Looks good now. 2. The dependency on qemu-system is fairly broad, unless kimchi actually supports foreign architecture VMs then depending on the local version per-arch would be nice. I changed this, now we should drag only the current arch qemu-system. ... [ ] 3. Websocksify listens on IPv4 only, this will be unreliable for people who have both v4 v6 in DNS, and break for any v6 only users : no bug so far : I checked kimchi for configuration options but that seems to be changed deeper. Should I file a bug for this one ? With 1.4 websockify is now an external dependency so it's now a bug in it (although fixed upstream, but there's not been a release, I've filed debian bug #??? for this). For the record here : https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=775963 -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20150122105240.gn17...@kin.lab.toulouse-stg.fr.ibm.com
Bug#772823: ITP: kimchi -- HTML5 baseITP: kimchi -- HTML5 based management tool for KVM.d management tool for KVM.
On 19/01/15 21:49, Frederic Bonnard wrote: Thank you Julien for looking at this and already filing bugs upstream. I've uploaded a new package for 1.4.0 with a batch of small fixes (issues from you, misc I found and from lintian) : http://mentors.debian.net/package/kimchi That's a nice set of improvements. My only new issues are: 1. For some reason kimchid didn't start on boot, systemd decided not to load it. This may well be a problem on my machine, not a generic one, but perhaps worth testing. 2. The dependency on qemu-system is fairly broad, unless kimchi actually supports foreign architecture VMs then depending on the local version per-arch would be nice. ... [ ] 3. Websocksify listens on IPv4 only, this will be unreliable for people who have both v4 v6 in DNS, and break for any v6 only users : no bug so far : I checked kimchi for configuration options but that seems to be changed deeper. Should I file a bug for this one ? With 1.4 websockify is now an external dependency so it's now a bug in it (although fixed upstream, but there's not been a release, I've filed debian bug #??? for this). [ ] 6. I don't see a pam service being created for kimchi, nor an obvious way to restrict who has rights to login. (Upstream bug #571 filed) A sensible default would probably be members of the libvirt group. I need to look into that. Actually in our lab we avoided use of kimchi because we felt it was not well suited at the moment for fine grained access rights. If I'm right, a user that can login to the machine (pam) as access to kimchi and also access to firmware updating tabs. Did we miss something on that ? What's your opinion on Julien's point ? Per debian convention kimchi should get its own service, even if not generically. My plan is to allow the use of external auth which solves my case. [X] 8. /robots.txt is missing. (Patch sent) This is now merged for the next release. signature.asc Description: OpenPGP digital signature
Bug#772823: ITP: kimchi -- HTML5 baseITP: kimchi -- HTML5 based management tool for KVM.d management tool for KVM.
Thank you Julien for looking at this and already filing bugs upstream. I've uploaded a new package for 1.4.0 with a batch of small fixes (issues from you, misc I found and from lintian) : http://mentors.debian.net/package/kimchi About what you pointed out that has no bug opened yet, I forwarded that to a kimchi dev (maybe I should have done that publicly on the mailing list). Here is what I gathered here and forwarded : --- [X] 1. It appears this package is missing a dependency on libvirt-bin : updated in the updated package 1.4.0 that I did [ ] 2. Please make use of nginx proxy optional (and drop dependency down to recommends), I'm aware this will require changes to kimchi to add an option : bug #570 reported upstream [ ] 3. Websocksify listens on IPv4 only, this will be unreliable for people who have both v4 v6 in DNS, and break for any v6 only users : no bug so far : I checked kimchi for configuration options but that seems to be changed deeper. Should I file a bug for this one ? [X] 4. Missing a short description for the package, the first line of the long description is getting used. : updated in my 1.4.0 packaging [X] 5. I hit the gettext issue mentioned in: http://lists.ovirt.org/pipermail/kimchi-devel/2014-November/008801.html However, this appears to be fixed at head. : OK [ ] 6. I don't see a pam service being created for kimchi, nor an obvious way to restrict who has rights to login. (Upstream bug #571 filed) A sensible default would probably be members of the libvirt group. I need to look into that. Actually in our lab we avoided use of kimchi because we felt it was not well suited at the moment for fine grained access rights. If I'm right, a user that can login to the machine (pam) as access to kimchi and also access to firmware updating tabs. Did we miss something on that ? What's your opinion on Julien's point ? [X] 8. /robots.txt is missing. (Patch sent) [X] 9. A new upstream version (1.4) has been released, so would like to see a package update. --- About kimchi login rights, atm, authentication relies on system login with pam, meaning that any user on the system has access to kimchi. I'm going to look into that on the packaging side while waiting for kimchi devs opinion. Fred. On Sat, 17 Jan 2015 15:04:33 +1300, Julien Goodwin jgood...@studio442.com.au wrote: I filed an upstream bug (#570) to make nginx optional as I mentioned in my last mail. Missing a short description for the package, the first line of the long description is getting used. I hit the gettext issue mentioned in: http://lists.ovirt.org/pipermail/kimchi-devel/2014-November/008801.html However, this appears to be fixed at head. I don't see a pam service being created for kimchi, nor an obvious way to restrict who has rights to login. (Upstream bug #571 filed) A sensible default would probably be members of the libvirt group. /robots.txt is missing. (Patch sent) A new upstream version (1.4) has been released, so would like to see a package update. -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20150119114913.gb9...@kin.lab.toulouse-stg.fr.ibm.com
Bug#772823: ITP: kimchi -- HTML5 baseITP: kimchi -- HTML5 based management tool for KVM.d management tool for KVM.
I filed an upstream bug (#570) to make nginx optional as I mentioned in my last mail. Missing a short description for the package, the first line of the long description is getting used. I hit the gettext issue mentioned in: http://lists.ovirt.org/pipermail/kimchi-devel/2014-November/008801.html However, this appears to be fixed at head. I don't see a pam service being created for kimchi, nor an obvious way to restrict who has rights to login. (Upstream bug #571 filed) A sensible default would probably be members of the libvirt group. /robots.txt is missing. (Patch sent) A new upstream version (1.4) has been released, so would like to see a package update. signature.asc Description: OpenPGP digital signature
Bug#772823: ITP: kimchi -- HTML5 baseITP: kimchi -- HTML5 based management tool for KVM.d management tool for KVM.
Gave the proposed packages a try. Couple of things: 1. It appears this package is missing a dependency on libvirt-bin 2. Please make use of nginx proxy optional (and drop dependency down to recommends), I'm aware this will require changes to kimchi to add an option. 3. Websocksify listens on IPv4 only, this will be unreliable for people who have both v4 v6 in DNS, and break for any v6 only users. signature.asc Description: OpenPGP digital signature
