Bug#861128: RFP: elpa-markdown-toc -- Generate a TOC in markdown file with Emacs

2018-09-24 Thread Antoine Beaupré
On 2018-09-23 21:53:27, Nicholas D Steeves wrote:
> On Fri, Sep 21, 2018 at 04:15:21PM -0400, Antoine Beaupré wrote:
>> On 2018-09-17 22:40:10, Nicholas D Steeves wrote:
>> > Re: a couple of markdown-toc bugs:
>> >
>> > https://github.com/ardumont/markdown-toc/issues/29
>> >   * Solve in Debian with a hard depends on >= markdown-mode 2.2?
>> >   * You mentioned markdown-mode 2.1 is bad, 20161222.1416 is good,
>> > and 2.2 is from 20170526, thus 2.2 should be good.
>> >   * possibly fixed in markdown-toc?
>> 
>> I can't reproduce this with the markdown-mode version in Debian. It
>> might still occur with the version in stable, but then the bugfix is
>> just an upgrade away.
>
> Cool.  And I've patched in a hard ELPA dep on 2.2 so anyone who bpos
> or installs the unstable dep to stable will have a hint about what's
> going wrong.  Sounds like it will be automatically dropped with the
> next upstream release :-)

[...]

>> > https://github.com/ardumont/markdown-toc/issues/35
>> >   * "Lines starting with # in code sections are treated as headings"
>> >   * I imagine this one will frustrate many users.
>> 
>> I can't reproduce this one, but this may be because of the version of
>> markdown.el in Debian (2.3snapshot154).
>
> Interesting!  I'm happy to hear that, and I'll add a manual hard dep
> (for the next release) on >=2.3snapshot154 for the potential benefit
> of anyone installing this package to stable.  'just a "nice to have"
> thing, you know?

While the 2.2 dep makes sense to me because it completely breaks the toc
package, this one seems less relevant. It's only a small bug - the thing
still generally works and we don't know for sure where the problem
lies. So I would keep the dependency minimal. But it doesn't change much
because 2.2 is not in debian anyways...

>> So, conclusion: I'd be happy to sponsor the package as is any time. Just
>> let me know when you're ready and let's get this one out the door!
>
> Sweet.  Thank you for also addressing the two points I mentioned on
> #debian-emacs.  I've already finalised the changelog.  Ready to
> sponsor from git or mentors.
>
>   git clone g...@salsa.debian.org:emacsen-team/markdown-toc-el.git
>   # gbp will get orig tarball from upstream tag
>   # alternatively: git deborig
>
>   dget 
> https://mentors.debian.net/debian/pool/main/m/markdown-toc-el/markdown-toc-el_0.1.2-1.dsc

I'll build and test and upload this shortly.

A.

-- 
Growth for the sake of growth is the ideology of the cancer cell.
- Edward Abbey



Bug#861128: RFP: elpa-markdown-toc -- Generate a TOC in markdown file with Emacs

2018-09-23 Thread Nicholas D Steeves
On Fri, Sep 21, 2018 at 04:15:21PM -0400, Antoine Beaupré wrote:
> On 2018-09-17 22:40:10, Nicholas D Steeves wrote:
> > Re: a couple of markdown-toc bugs:
> >
> > https://github.com/ardumont/markdown-toc/issues/29
> >   * Solve in Debian with a hard depends on >= markdown-mode 2.2?
> >   * You mentioned markdown-mode 2.1 is bad, 20161222.1416 is good,
> > and 2.2 is from 20170526, thus 2.2 should be good.
> >   * possibly fixed in markdown-toc?
> 
> I can't reproduce this with the markdown-mode version in Debian. It
> might still occur with the version in stable, but then the bugfix is
> just an upgrade away.

Cool.  And I've patched in a hard ELPA dep on 2.2 so anyone who bpos
or installs the unstable dep to stable will have a hint about what's
going wrong.  Sounds like it will be automatically dropped with the
next upstream release :-)

> > https://github.com/ardumont/markdown-toc/issues/15
> >   * "Don't assume that a document has an h1"
> >   * How serious is this one?  Seems like it could be annoying.
> 
> I just tested this and can confirm the bug happens with your version of
> the package as well.
> 
> It's not a big deal: the generated TOC can be modified by hand so extra
> content or errors can be easily fixed. In fact, I very often tweak the
> TOC by hand myself because it's easier than changing the settings
> (e.g. to remove a subsection and so on).

Thank you for confirming this one, and that confirming it's not a big deal.

> > https://github.com/ardumont/markdown-toc/issues/35
> >   * "Lines starting with # in code sections are treated as headings"
> >   * I imagine this one will frustrate many users.
> 
> I can't reproduce this one, but this may be because of the version of
> markdown.el in Debian (2.3snapshot154).

Interesting!  I'm happy to hear that, and I'll add a manual hard dep
(for the next release) on >=2.3snapshot154 for the potential benefit
of anyone installing this package to stable.  'just a "nice to have"
thing, you know?

> So, conclusion: I'd be happy to sponsor the package as is any time. Just
> let me know when you're ready and let's get this one out the door!

Sweet.  Thank you for also addressing the two points I mentioned on
#debian-emacs.  I've already finalised the changelog.  Ready to
sponsor from git or mentors.

  git clone g...@salsa.debian.org:emacsen-team/markdown-toc-el.git
  # gbp will get orig tarball from upstream tag
  # alternatively: git deborig

  dget 
https://mentors.debian.net/debian/pool/main/m/markdown-toc-el/markdown-toc-el_0.1.2-1.dsc


Cheers,
Nicholas


signature.asc
Description: PGP signature


Bug#861128: RFP: elpa-markdown-toc -- Generate a TOC in markdown file with Emacs

2018-09-21 Thread Antoine Beaupré
On 2018-09-17 22:40:10, Nicholas D Steeves wrote:
> Re: a couple of markdown-toc bugs:
>
> https://github.com/ardumont/markdown-toc/issues/29
>   * Solve in Debian with a hard depends on >= markdown-mode 2.2?
>   * You mentioned markdown-mode 2.1 is bad, 20161222.1416 is good,
> and 2.2 is from 20170526, thus 2.2 should be good.
>   * possibly fixed in markdown-toc?

I can't reproduce this with the markdown-mode version in Debian. It
might still occur with the version in stable, but then the bugfix is
just an upgrade away.

> https://github.com/ardumont/markdown-toc/issues/15
>   * "Don't assume that a document has an h1"
>   * How serious is this one?  Seems like it could be annoying.

I just tested this and can confirm the bug happens with your version of
the package as well.

It's not a big deal: the generated TOC can be modified by hand so extra
content or errors can be easily fixed. In fact, I very often tweak the
TOC by hand myself because it's easier than changing the settings
(e.g. to remove a subsection and so on).

> https://github.com/ardumont/markdown-toc/issues/35
>   * "Lines starting with # in code sections are treated as headings"
>   * I imagine this one will frustrate many users.

I can't reproduce this one, but this may be because of the version of
markdown.el in Debian (2.3snapshot154).

So, conclusion: I'd be happy to sponsor the package as is any time. Just
let me know when you're ready and let's get this one out the door!

A.
-- 
People in glass houses shouldn't throw stones.
People in glass cities shouldn't fire missiles.
- Banksy



Bug#861128: RFP: elpa-markdown-toc -- Generate a TOC in markdown file with Emacs

2018-09-21 Thread Antoine Beaupré
On 2018-09-18 18:14:04, Nicholas D Steeves wrote:
> Hey Antoine,
>
> Package ready for testing from:
>   dget -x 
> https://mentors.debian.net/debian/pool/main/m/markdown-toc-el/markdown-toc-el_0.1.2-1.dsc
>
> Upstream included an autoload cookie so 'markdown-toc-generate-toc'
> works out of the box.  I can provide a deb and signed changes if that
> would be more convenient.  In particular someone needs to test
> 'markdown-toc-user-toc-structure-manipulation-fn' before I can
> responsibly file an RFS bug.

I actually got time to look into the packaging more.

It seems to me the release-notes.md could be shipped with
dh_installchangelogs instead of as is, because it is effectively a
changelog.

I'm testing the package now but the source looks good otherwise.

A.
-- 
We are discreet sheep; we wait to see how the drove is going, and then go
with the drove.
- Mark Twain



Bug#861128: RFP: elpa-markdown-toc -- Generate a TOC in markdown file with Emacs

2018-09-18 Thread Nicholas D Steeves

Hey Antoine,

Package ready for testing from:
  dget -x 
https://mentors.debian.net/debian/pool/main/m/markdown-toc-el/markdown-toc-el_0.1.2-1.dsc

Upstream included an autoload cookie so 'markdown-toc-generate-toc'
works out of the box.  I can provide a deb and signed changes if that
would be more convenient.  In particular someone needs to test
'markdown-toc-user-toc-structure-manipulation-fn' before I can
responsibly file an RFS bug.

Cheers,
Nicholas


signature.asc
Description: PGP signature


Bug#861128: RFP: elpa-markdown-toc -- Generate a TOC in markdown file with Emacs

2018-09-18 Thread Nicholas D Steeves
Control: tag -1 - moreinfo
Control: retitle -1 ITP: elpa-markdown-toc -- Generate a TOC in markdown file 
with Emacs
Control: owner -1 !

Hi Antoine,

On Tue, Sep 18, 2018 at 09:44:19AM -0400, Antoine Beaupré wrote:
> On 2018-09-17 22:40:10, Nicholas D Steeves wrote:
> >
> > Re: a couple of markdown-toc bugs:
> >
> > https://github.com/ardumont/markdown-toc/issues/29
> >   * Solve in Debian with a hard depends on >= markdown-mode 2.2?
> >   * You mentioned markdown-mode 2.1 is bad, 20161222.1416 is good,
> > and 2.2 is from 20170526, thus 2.2 should be good.
> >   * possibly fixed in markdown-toc?
> >
> > https://github.com/ardumont/markdown-toc/issues/15
> >   * "Don't assume that a document has an h1"
> >   * How serious is this one?  Seems like it could be annoying.
> >
> > https://github.com/ardumont/markdown-toc/issues/35
> >   * "Lines starting with # in code sections are treated as headings"
> >   * I imagine this one will frustrate many users.
> 
> I'm not sure how that's relevant to this RFP. Sure, like any other
> software, markdown-toc has bugs. :) Those are not critical and the thing
> generally works in my use cases. I think it can be packaged as is.

Ok, will do!  Yes, all software has bugs...when considering
maintaining a pkg I ask myself "is this something will have to fix,
and will a lot of people be unhappy if I don't?" vs "I've got a
year's old back queue of stuff that's important to me".  Thinking
optimistically, maybe a Debian user will submit a patch for #15 and
#35? ;-)

> > By the way, if you'd like I'd be happy to give you an intro on dh-elpa
> > packaging.  With the exception of a couple of autopkgtest on LXC
> > workarounds it's easy stuff--the trickiest bit is identifying why an
> > upstream self-test doesn't work on buildd.  Also, we're working on
> > improving dh-elpa's documentation, so alternatively it would be nice
> > to hear about your experiences with it--and than make improvements if
> > necessary!  dh_elpa(1), dh_elpa_test(1), dh-make-elpa(1), plus 
> 
> I'm sure you guys did a great job and it's nice to see so many ELPA
> packages being added into Debian. Unfortunately, I don't have much time
> to handle the packaging myself so if you do not mind I'll stay on this
> side of the packaging for now. :) If I do find the time, you'll be the
> first to know (here) that I can work on a package of course.

Cool :-)

Cheers,
Nicholas


signature.asc
Description: PGP signature


Processed: Re: Bug#861128: RFP: elpa-markdown-toc -- Generate a TOC in markdown file with Emacs

2018-09-18 Thread Debian Bug Tracking System
Processing control commands:

> tag -1 - moreinfo
Bug #861128 [wnpp] RFP: elpa-markdown-toc -- Generate a TOC in markdown file 
with Emacs
Removed tag(s) moreinfo.
> retitle -1 ITP: elpa-markdown-toc -- Generate a TOC in markdown file with 
> Emacs
Bug #861128 [wnpp] RFP: elpa-markdown-toc -- Generate a TOC in markdown file 
with Emacs
Changed Bug title to 'ITP: elpa-markdown-toc -- Generate a TOC in markdown file 
with Emacs' from 'RFP: elpa-markdown-toc -- Generate a TOC in markdown file 
with Emacs'.
> owner -1 !
Bug #861128 [wnpp] ITP: elpa-markdown-toc -- Generate a TOC in markdown file 
with Emacs
Owner recorded as Nicholas D Steeves .

-- 
861128: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=861128
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#861128: RFP: elpa-markdown-toc -- Generate a TOC in markdown file with Emacs

2018-09-18 Thread Antoine Beaupré
On 2018-09-17 22:40:10, Nicholas D Steeves wrote:
> Control: tag -1 + moreinfo
>
> Hi Antoine,
>
> On Mon, Apr 24, 2017 at 04:22:35PM -0400, Antoine Beaupre wrote:
>> Package: wnpp
>> Severity: wishlist
>> 
>> * Package name: elpa-markdown-toc
>>   Version : 0.1.2
>>   Upstream Author : Antoine R. Dumont
>> * URL : https://github.com/ardumont/markdown-toc/
>> * License : GPL-3+
>>   Programming Lang: Elisp
>>   Description : Generate a TOC in markdown file
> [...]
>> 
>> I use this when I write markdown reports that get translated in
>> standalone HTML documents that I ship to clients. I used to rely on
>> pandoc's --toc functionality, but that was too limited: I couldn't
>> control output levels and fix headings the way I wanted.
>> 
>> It depends on markdown-mode, certain versions:
>> 
>> https://github.com/ardumont/markdown-toc/issues/29
>> 
>> Happy to comaintain...
>
> Re: a couple of markdown-toc bugs:
>
> https://github.com/ardumont/markdown-toc/issues/29
>   * Solve in Debian with a hard depends on >= markdown-mode 2.2?
>   * You mentioned markdown-mode 2.1 is bad, 20161222.1416 is good,
> and 2.2 is from 20170526, thus 2.2 should be good.
>   * possibly fixed in markdown-toc?
>
> https://github.com/ardumont/markdown-toc/issues/15
>   * "Don't assume that a document has an h1"
>   * How serious is this one?  Seems like it could be annoying.
>
> https://github.com/ardumont/markdown-toc/issues/35
>   * "Lines starting with # in code sections are treated as headings"
>   * I imagine this one will frustrate many users.

I'm not sure how that's relevant to this RFP. Sure, like any other
software, markdown-toc has bugs. :) Those are not critical and the thing
generally works in my use cases. I think it can be packaged as is.

> By the way, if you'd like I'd be happy to give you an intro on dh-elpa
> packaging.  With the exception of a couple of autopkgtest on LXC
> workarounds it's easy stuff--the trickiest bit is identifying why an
> upstream self-test doesn't work on buildd.  Also, we're working on
> improving dh-elpa's documentation, so alternatively it would be nice
> to hear about your experiences with it--and than make improvements if
> necessary!  dh_elpa(1), dh_elpa_test(1), dh-make-elpa(1), plus 

I'm sure you guys did a great job and it's nice to see so many ELPA
packages being added into Debian. Unfortunately, I don't have much time
to handle the packaging myself so if you do not mind I'll stay on this
side of the packaging for now. :) If I do find the time, you'll be the
first to know (here) that I can work on a package of course.

> Failing that I think I'd like to package this one :-)

Please be my guest!

a.
-- 
I believe that if someone choose arts as their subject but do not
criticize the issues of their society, they have have betrayed
themselves, their conscience, and their society.
- Atena Farghadani



Processed: Re: Bug#861128: RFP: elpa-markdown-toc -- Generate a TOC in markdown file with Emacs

2018-09-17 Thread Debian Bug Tracking System
Processing control commands:

> tag -1 + moreinfo
Bug #861128 [wnpp] RFP: elpa-markdown-toc -- Generate a TOC in markdown file 
with Emacs
Added tag(s) moreinfo.

-- 
861128: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=861128
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Processed: Re: Bug#861128: RFP: elpa-markdown-toc -- Generate a TOC in markdown file with Emacs

2018-09-17 Thread Debian Bug Tracking System
Processing control commands:

> tag -1 + moreinfo
Bug #861128 [wnpp] RFP: elpa-markdown-toc -- Generate a TOC in markdown file 
with Emacs
Ignoring request to alter tags of bug #861128 to the same tags previously set

-- 
861128: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=861128
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#861128: RFP: elpa-markdown-toc -- Generate a TOC in markdown file with Emacs

2018-09-17 Thread Nicholas D Steeves
Control: tag -1 + moreinfo

Hi Antoine,

On Mon, Apr 24, 2017 at 04:22:35PM -0400, Antoine Beaupre wrote:
> Package: wnpp
> Severity: wishlist
> 
> * Package name: elpa-markdown-toc
>   Version : 0.1.2
>   Upstream Author : Antoine R. Dumont
> * URL : https://github.com/ardumont/markdown-toc/
> * License : GPL-3+
>   Programming Lang: Elisp
>   Description : Generate a TOC in markdown file
[...]
> 
> I use this when I write markdown reports that get translated in
> standalone HTML documents that I ship to clients. I used to rely on
> pandoc's --toc functionality, but that was too limited: I couldn't
> control output levels and fix headings the way I wanted.
> 
> It depends on markdown-mode, certain versions:
> 
> https://github.com/ardumont/markdown-toc/issues/29
> 
> Happy to comaintain...

Re: a couple of markdown-toc bugs:

https://github.com/ardumont/markdown-toc/issues/29
  * Solve in Debian with a hard depends on >= markdown-mode 2.2?
  * You mentioned markdown-mode 2.1 is bad, 20161222.1416 is good,
and 2.2 is from 20170526, thus 2.2 should be good.
  * possibly fixed in markdown-toc?

https://github.com/ardumont/markdown-toc/issues/15
  * "Don't assume that a document has an h1"
  * How serious is this one?  Seems like it could be annoying.

https://github.com/ardumont/markdown-toc/issues/35
  * "Lines starting with # in code sections are treated as headings"
  * I imagine this one will frustrate many users.

By the way, if you'd like I'd be happy to give you an intro on dh-elpa
packaging.  With the exception of a couple of autopkgtest on LXC
workarounds it's easy stuff--the trickiest bit is identifying why an
upstream self-test doesn't work on buildd.  Also, we're working on
improving dh-elpa's documentation, so alternatively it would be nice
to hear about your experiences with it--and than make improvements if
necessary!  dh_elpa(1), dh_elpa_test(1), dh-make-elpa(1), plus 

Failing that I think I'd like to package this one :-)


Cheers,
Nicholas


signature.asc
Description: PGP signature


Bug#861128: RFP: elpa-markdown-toc -- Generate a TOC in markdown file with Emacs

2017-04-24 Thread Antoine Beaupre
Package: wnpp
Severity: wishlist

* Package name: elpa-markdown-toc
  Version : 0.1.2
  Upstream Author : Antoine R. Dumont
* URL : https://github.com/ardumont/markdown-toc/
* License : GPL-3+
  Programming Lang: Elisp
  Description : Generate a TOC in markdown file

This is a simple plugin that parses a Markdown buffer and creates a
handy table of contents. Useful if you're writing a standalone
markdown document and can't rely on external tools to generate table
of contents.



I use this when I write markdown reports that get translated in
standalone HTML documents that I ship to clients. I used to rely on
pandoc's --toc functionality, but that was too limited: I couldn't
control output levels and fix headings the way I wanted.

It depends on markdown-mode, certain versions:

https://github.com/ardumont/markdown-toc/issues/29

Happy to comaintain...