Re: [PATCH/RFC libpciaccess/debian-unstable 0/6] build system nitpicks
On Sat, Feb 5, 2011 at 14:54:59 -0600, Jonathan Nieder wrote: > Hi, > > Cyril Brulebois wrote: > > > thanks for the patches. > > Thanks for looking them over. A small clarification: > > > Jonathan Nieder (05/02/2011): > > >> Patch 3 writes "7" to debian/compat, since debhelper 7 is needed > >> for patch 2 anyway. > > > > it's not a single character change, 5→7 might lead to some changes > > which might not be spotted through debdiff. > > None of the constructs listed as affected in debhelper(7) are used in > this debian/rules. But I don’t mind if you want to delay this for > consistency between the library repos. > I think we should do that for all libs at once if we're going to bump to 7. Not sure if that should be in the same step as a switch to dh, or done independently. Cheers, Julien signature.asc Description: Digital signature
Re: [PATCH/RFC libpciaccess/debian-unstable 0/6] build system nitpicks
Hi, Cyril Brulebois wrote: > thanks for the patches. Thanks for looking them over. A small clarification: > Jonathan Nieder (05/02/2011): >> Patch 3 writes "7" to debian/compat, since debhelper 7 is needed >> for patch 2 anyway. > > it's not a single character change, 5→7 might lead to some changes > which might not be spotted through debdiff. None of the constructs listed as affected in debhelper(7) are used in this debian/rules. But I don’t mind if you want to delay this for consistency between the library repos. > I've just performed a switch to dh in all drivers. Not sure I want to > do so in the libraries as well. Yes, I can understand. The benefit is not immediate. I’d be interested in writing and testing careful series to switch to dh in all the libraries fwiw (for experimental, naturally). Jonathan -- To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110205205459.GC19486@elie
Re: [PATCH/RFC libpciaccess/debian-unstable 0/6] build system nitpicks
Hi, Jonathan Nieder (05/02/2011): > Looking into packaging the API docs described by src/Doxyfile, I got > sidetracked by simplifying debian/rules using dh and generating the > upstream changelog automatically from the git repo (all of which > seem to work well). This patch series does none of those things --- > it just carries out some minor cleanups. thanks for the patches. > Patch 1 makes "debian/rules clean" work without fakeroot (which is a > pet peeve of mine and how "dh clean" works, anyway). need to think about it. > Patch 2 uses dh_prep in place of dh_clean -k, since the latter > makes some noise about being deprecated nowadays. (and bumps the build-dep.) > Patch 3 writes "7" to debian/compat, since debhelper 7 is needed > for patch 2 anyway. it's not a single character change, 5→7 might lead to some changes which might not be spotted through debdiff. > Patch 4 adds a debian/.gitignore. no. > Patch 5 uses dpkg-buildflags to retrieve CFLAGS. maybe. > Patch 6 removes some noise from the ./configure compile line. maybe. > No change noticed in the binary packages with debdiff. These are > just nitpicks, so please feel free to take what looks good and > discard the rest. I've just performed a switch to dh in all drivers. Not sure I want to do so in the libraries as well. Will see once I'm done with the ongoing preparation of X11R7.6 in sid. Thanks. KiBi. signature.asc Description: Digital signature
[PATCH/RFC libpciaccess/debian-unstable 0/6] build system nitpicks
Hi, Looking into packaging the API docs described by src/Doxyfile, I got sidetracked by simplifying debian/rules using dh and generating the upstream changelog automatically from the git repo (all of which seem to work well). This patch series does none of those things --- it just carries out some minor cleanups. Patch 1 makes "debian/rules clean" work without fakeroot (which is a pet peeve of mine and how "dh clean" works, anyway). Patch 2 uses dh_prep in place of dh_clean -k, since the latter makes some noise about being deprecated nowadays. Patch 3 writes "7" to debian/compat, since debhelper 7 is needed for patch 2 anyway. Patch 4 adds a debian/.gitignore. Patch 5 uses dpkg-buildflags to retrieve CFLAGS. Patch 6 removes some noise from the ./configure compile line. No change noticed in the binary packages with debdiff. These are just nitpicks, so please feel free to take what looks good and discard the rest. Thoughts? Jonathan Nieder (6): debian/rules: do not require (fake) root privileges to clean debian/rules: avoid deprecated dh_clean --keep syntax debian/rules: adopt debhelper v7 semantics debian: avoid tracking build products debian/rules: let build machine admins tweak build flags debian/rules: omit unnecessary settings for ./configure debian/.gitignore | 10 ++ debian/changelog | 14 ++ debian/compat |2 +- debian/control|3 ++- debian/rules | 12 ++-- 5 files changed, 29 insertions(+), 12 deletions(-) create mode 100644 debian/.gitignore -- To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110205124846.GA17584@elie
