[jira] [Updated] (DERBY-6945) Re-package Derby as a collection of jigsaw modules

[Rick Hillegas (JIRA)]

 [ 
https://issues.apache.org/jira/browse/DERBY-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rick Hillegas updated DERBY-6945:
-
Attachment: derby-6945-06-aa-removeOtherSharedDuplicates.diff

Attaching derby-6945-06-aa-removeOtherSharedDuplicates.diff. This patch deletes 
some other classes which were cloned in two places in derbyshared.jar. I am 
running regression tests now.

Deletes the following files and adjusts imports across the product accordingly:

D java/engine/org/apache/derby/iapi/error/ExceptionSeverity.java
D java/engine/org/apache/derby/iapi/error/ExceptionUtil.java
D java/engine/org/apache/derby/iapi/reference/JDBC40Translation.java
D java/engine/org/apache/derby/iapi/reference/MessageId.java
D java/engine/org/apache/derby/iapi/error/ThreadDump.java


> Re-package Derby as a collection of jigsaw modules
> --
>
> Key: DERBY-6945
> URL: https://issues.apache.org/jira/browse/DERBY-6945
> Project: Derby
>  Issue Type: Improvement
>Affects Versions: 10.13.1.2
>Reporter: Rick Hillegas
> Attachments: derby-6945-01-aa-remove_derbyPreBuild_dep.diff, 
> derby-6945-02-ab-newDerbySharedJar.diff, 
> derby-6945-02-ac-newDerbySharedJar.diff, derby-6945-03-aa-partitionTest.diff, 
> derby-6945-04-aa-moveRunClass.diff, 
> derby-6945-05-aa-removeRedundant_Attribute_SQLState.diff, 
> derby-6945-06-aa-removeOtherSharedDuplicates.diff, jdeps.out.tar
>
>
> Once we commit to building with Java 9 (see DERBY-6856), we should consider 
> re-packaging Derby as a set of jigsaw modules. This would result in a 
> different set of release artifacts. This might be a good opportunity to 
> address the Tomcat artifactory issues raised by issue DERBY-6944.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Build failed in Jenkins: Derby-trunk #2522

[Apache Jenkins Server]

See 


Changes:

[rhillegas] DERBY-6945: Remove redundant copies of Attribute.java and 
SQLState.java; commit derby-6945-05-aa-removeRedundant_Attribute_SQLState.diff.

--
[...truncated 139.67 KB...]

init:

setissane:

sanitynamesane:

sanitynameinsane:

setsanityname:

getsvnversion:
 [echo] Revision number set to 1819309.

initjars:

derbyjar:
 [echo] Beginning derby.jar sane build
 [echo]  creating derby.jar class list 
 [echo]  creating new DBMS.properties file

infowriter:
[propertyfile] Updating property file: 


meta-inf-common:
 [copy] Copying 2 files to 


declare-autoloadable-driver:

make-core-derbyjar-manifest:

make-locale-classpath-manifest:
  [jar] Building jar: 


derbytoolsjar:
 [echo] Beginning derbytools.jar sane build
 [echo]  creating tools.list 
 [echo]  creating new tools.properties file 

infowriter:
[propertyfile] Updating property file: 


meta-inf-common:
 [copy] Copying 2 files to 


make-locale-classpath-manifest:
   [delete] Deleting: 

  [jar] Building jar: 


derbynetjar:
 [echo] Beginning derbynet.jar sane build
 [echo]  creating net.list
 [echo]  creating new net.properties file 

infowriter:
[propertyfile] Updating property file: 


meta-inf-common:
 [copy] Copying 2 files to 

   [delete] Deleting: 

  [jar] Building jar: 


derbyclientjar:
 [echo] Beginning derbyclient.jar sane build
 [copy] Copying 1 file to 


derbyclientjar.1.8:
 [echo]  creating new dnc.properties file 

infowriter:
[propertyfile] Updating property file: 


meta-inf-common:
 [copy] Copying 2 files to 


make-core-derbyjar-manifest:

make-locale-classpath-manifest:

declare-autoloadable-driver:
   [delete] Deleting: 

  [jar] Building jar: 


derbyoptionaltoolsjar:
 [echo] Beginning derbyoptionaltools.jar sane build
 [echo]  creating new tools.properties file 

infowriter:
[propertyfile] Creating new property file: 


meta-inf-common:
 [copy] Copying 2 files to 


make-locale-classpath-manifest:
   [delete] Deleting: 

  [jar] Building jar: 


derbysharedjar:
 [echo] Beginning derbyshared.jar sane build
 [echo]  creating new shared.properties file 

infowriter:
[propertyfile] Updating property file: 


meta-inf-common:
 [copy] Copying 2 files to 


make-locale-classpath-manifest:
   [delete] Deleting: 

  [jar] Building jar: 


derbyrunjar:
 [echo] Beginning derbyrun.jar build

meta-inf-common:
 [copy] Copying 2 files to 

  [jar] Updating jar: 


derbywar:
 [echo] Beginning derby.war  build
   [delete] Deleting: 

  [zip] Building zip: 

[jira] [Commented] (DERBY-6945) Re-package Derby as a collection of jigsaw modules

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/DERBY-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304087#comment-16304087
 ] 

ASF subversion and git services commented on DERBY-6945:


Commit 1819309 from [~rhillegas] in branch 'code/trunk'
[ https://svn.apache.org/r1819309 ]

DERBY-6945: Remove redundant copies of Attribute.java and SQLState.java; commit 
derby-6945-05-aa-removeRedundant_Attribute_SQLState.diff.

> Re-package Derby as a collection of jigsaw modules
> --
>
> Key: DERBY-6945
> URL: https://issues.apache.org/jira/browse/DERBY-6945
> Project: Derby
>  Issue Type: Improvement
>Affects Versions: 10.13.1.2
>Reporter: Rick Hillegas
> Attachments: derby-6945-01-aa-remove_derbyPreBuild_dep.diff, 
> derby-6945-02-ab-newDerbySharedJar.diff, 
> derby-6945-02-ac-newDerbySharedJar.diff, derby-6945-03-aa-partitionTest.diff, 
> derby-6945-04-aa-moveRunClass.diff, 
> derby-6945-05-aa-removeRedundant_Attribute_SQLState.diff, jdeps.out.tar
>
>
> Once we commit to building with Java 9 (see DERBY-6856), we should consider 
> re-packaging Derby as a set of jigsaw modules. This would result in a 
> different set of release artifacts. This might be a good opportunity to 
> address the Tomcat artifactory issues raised by issue DERBY-6944.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DERBY-6945) Re-package Derby as a collection of jigsaw modules

[Rick Hillegas (JIRA)]

[ 
https://issues.apache.org/jira/browse/DERBY-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304078#comment-16304078
 ] 

Rick Hillegas commented on DERBY-6945:
--

Thanks for thinking through these issues, Bryan.

BP> Rick, in these reflection/delegation approaches you're considering, is the 
indirection and reflection limited to "startup" activities like constructors 
and initialization?

I think that reflection should only be necessary at construction/initialization 
time. After that, the original (now wrapper) classes would just forward their 
calls to already instantiated objects.

BP> You're right, this is a pretty big mess. I think we need to find some way 
to escalate the visibility of this, and think about it some more, because 
frankly I don't really like any of your three proposals (five proposals if you 
count the two variants on #2). 

Any suggestions about how to attract more eyes to this issue?

Thanks,
-Rick


> Re-package Derby as a collection of jigsaw modules
> --
>
> Key: DERBY-6945
> URL: https://issues.apache.org/jira/browse/DERBY-6945
> Project: Derby
>  Issue Type: Improvement
>Affects Versions: 10.13.1.2
>Reporter: Rick Hillegas
> Attachments: derby-6945-01-aa-remove_derbyPreBuild_dep.diff, 
> derby-6945-02-ab-newDerbySharedJar.diff, 
> derby-6945-02-ac-newDerbySharedJar.diff, derby-6945-03-aa-partitionTest.diff, 
> derby-6945-04-aa-moveRunClass.diff, 
> derby-6945-05-aa-removeRedundant_Attribute_SQLState.diff, jdeps.out.tar
>
>
> Once we commit to building with Java 9 (see DERBY-6856), we should consider 
> re-packaging Derby as a set of jigsaw modules. This would result in a 
> different set of release artifacts. This might be a good opportunity to 
> address the Tomcat artifactory issues raised by issue DERBY-6944.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DERBY-6945) Re-package Derby as a collection of jigsaw modules

[Bryan Pendleton (JIRA)]

[ 
https://issues.apache.org/jira/browse/DERBY-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303982#comment-16303982
 ] 

Bryan Pendleton commented on DERBY-6945:


Rick, in these reflection/delegation approaches you're considering, is the 
indirection and reflection limited to "startup" activities like constructors 
and initialization?

Or does it affect the commonly-used methods like those on Connection, 
Statement, ResultSet, etc.?

BTW, I agree with you that we simply cannot change the package names of either 
the client driver or the embedded driver, and I think that's true of the data 
sources as well.

But some of the other classes in org.apache.derby.jdbc are really internal 
classes, and probably never should have been in such a "public" package in the 
first place.

Yet I can't see that fiddling with package renaming for some of those internal 
classes buys us very much.

So it seems like your idea #3 is simply a non-starter.

You're right, this is a pretty big mess. I think we need to find some way to 
escalate the visibility of this, and think about it some more, because frankly 
I don't really like any of your three proposals (five proposals if you count 
the two variants on #2).

Of the 3 (5?) proposals, I'm honestly inclined to choose #1 (combine engine, 
client, and shared into a single giant "shared" jar).

Sorry for the downer, but I felt like I had to put it out there.

> Re-package Derby as a collection of jigsaw modules
> --
>
> Key: DERBY-6945
> URL: https://issues.apache.org/jira/browse/DERBY-6945
> Project: Derby
>  Issue Type: Improvement
>Affects Versions: 10.13.1.2
>Reporter: Rick Hillegas
> Attachments: derby-6945-01-aa-remove_derbyPreBuild_dep.diff, 
> derby-6945-02-ab-newDerbySharedJar.diff, 
> derby-6945-02-ac-newDerbySharedJar.diff, derby-6945-03-aa-partitionTest.diff, 
> derby-6945-04-aa-moveRunClass.diff, 
> derby-6945-05-aa-removeRedundant_Attribute_SQLState.diff, jdeps.out.tar
>
>
> Once we commit to building with Java 9 (see DERBY-6856), we should consider 
> re-packaging Derby as a set of jigsaw modules. This would result in a 
> different set of release artifacts. This might be a good opportunity to 
> address the Tomcat artifactory issues raised by issue DERBY-6944.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)