[Bug 1288182]
You are wasting previous time of people working on poppler doing such a useless comment, please refrain from commenting on the future unless you can add something useful to the discussion. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1288182 Title: Cyrillic not displayed in the input field To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1288182/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 371618]
Actaully I think we should close this bug. We already export the Javascript from the poppler side and for example Okular supports it partially https://www.youtube.com/watch?v=S-zmHc3WUhs I don't think we could actually do that from within the core of poppler since it needs to know things as edit/validate/undo/redo. So from what i can see we already "support" Javascript, i.e. extract its contents. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug assignee. https://bugs.launchpad.net/bugs/371618 Title: evince does not calculate total sum in application form To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/371618/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1590462] Re: Wizard city search should do searches in the middle of names
** Changed in: unity8 (Ubuntu) Status: Incomplete => Triaged ** Changed in: ubuntu-ux Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to geonames in Ubuntu. https://bugs.launchpad.net/bugs/1590462 Title: Wizard city search should do searches in the middle of names To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-ux/+bug/1590462/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1630725] Re: Bluetooth settings are showed but my pc doesn't have the bluetooth
** Also affects: indicator-bluetooth (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to indicator-bluetooth in Ubuntu. https://bugs.launchpad.net/bugs/1630725 Title: Bluetooth settings are showed but my pc doesn't have the bluetooth To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/indicator-bluetooth/+bug/1630725/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1582936] Re: /usr/bin/unity8:11:malloc_consolidate:_int_malloc:__GI___libc_malloc:operator:__gnu_cxx::new_allocator
** Also affects: dbus-cpp (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to dbus-cpp in Ubuntu. https://bugs.launchpad.net/bugs/1582936 Title: /usr/bin/unity8:11:malloc_consolidate:_int_malloc:__GI___libc_malloc:operator:__gnu_cxx::new_allocator To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/dbus-cpp/+bug/1582936/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1524131] Re: /usr/bin/mediaplayer-app:11:__memcpy_neon:std::char_traits:std::basic_streambuf:std::basic_streambuf:std::__ostream_write
** Changed in: dbus-cpp (Ubuntu) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to dbus-cpp in Ubuntu. https://bugs.launchpad.net/bugs/1524131 Title: /usr/bin/mediaplayer- app:11:__memcpy_neon:std::char_traits:std::basic_streambuf:std::basic_streambuf:std::__ostream_write To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1524131/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1404645]
Great, work on it! -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1404645 Title: Evince opens attached PDF file as locked To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1404645/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1404645]
Will be fixed in next release. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1404645 Title: Evince opens attached PDF file as locked To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1404645/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1404645]
If you're speaking about Google Summer of Code, that's not how it works, the application period is not even started. If you're speaking about answering questions you may have. There's a poppler development mailing list. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1404645 Title: Evince opens attached PDF file as locked To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1404645/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
I've opened these bugs https://bugs.freedesktop.org/show_bug.cgi?id=94376 https://bugs.freedesktop.org/show_bug.cgi?id=94377 https://bugs.freedesktop.org/show_bug.cgi?id=94378 Closing this one -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
Pushed \o/ Now, this is not "all the work". We still need to do the glib/qt/cpp frontend work, and that will probably mean some changes to the new code, but getting this merged is an important step. Wonder how to proceed, this bug has 122 comments. Should we close this one and open different ones for the frontends api? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
Pushed \o/ Now, this is not "all the work". We still need to do the glib/qt/cpp frontend work, and that will probably mean some changes to the new code, but getting this merged is an important step. Wonder how to proceed, this bug has 122 comments. Should we close this one and open different ones for the frontends api? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
I've opened these bugs https://bugs.freedesktop.org/show_bug.cgi?id=94376 https://bugs.freedesktop.org/show_bug.cgi?id=94377 https://bugs.freedesktop.org/show_bug.cgi?id=94378 Closing this one -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
Anyone against merging attachment 120992 and then merging the branch to master? I'll do it next week if noone complains. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
Anyone against merging attachment 120992 and then merging the branch to master? I'll do it next week if noone complains. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
Andre and Andre what do you think of Adrian's patch? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
Ok, good, so Adrian can you commit your patch? After that we have attachment 120992 "Load NSS root certs module" that honestly I don't understand at all but some googleing seems to confirm it's needed. And that would be it to try to merge it into master? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
Ok, good, so Adrian can you commit your patch? After that we have attachment 120992 "Load NSS root certs module" that honestly I don't understand at all but some googleing seems to confirm it's needed. And that would be it to try to merge it into master? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
Andre and Andre what do you think of Adrian's patch? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1293629] Re: [Regression] [Trusty] Unity can't be started from kdm
This doesn't seem like it's getting any traction after 2 years and kdm is not even shipped anymore so as reporter i'm closing this bug to have a cleaner "reported bugs" view in launchpad. ** Changed in: gnome-session (Ubuntu) Status: Confirmed => Won't Fix -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-session in Ubuntu. https://bugs.launchpad.net/bugs/1293629 Title: [Regression] [Trusty] Unity can't be started from kdm To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-session/+bug/1293629/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
(In reply to Markus Kilås from comment #108) > Created attachment 120760 [details] [review] > Considering offset 0 and signature only covering part of PDF > > Note that this patch has not been tested with a non-zero first offset > document. Adrian what do you think of this patch? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
(In reply to Markus Kilås from comment #106) > Created attachment 120758 [details] [review] > Fix printf for unsigned int > > In pdfsig.cc the NetBeans IDE gave warning: > Mismatching the argument type "unsigned int" and conversion specifier "d" > > The attached patch changes from %d to %u in the printf. Pushed -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
(In reply to Markus Kilås from comment #108) > Created attachment 120760 [details] [review] > Considering offset 0 and signature only covering part of PDF > > Note that this patch has not been tested with a non-zero first offset > document. Adrian what do you think of this patch? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
(In reply to Markus Kilås from comment #106) > Created attachment 120758 [details] [review] > Fix printf for unsigned int > > In pdfsig.cc the NetBeans IDE gave warning: > Mismatching the argument type "unsigned int" and conversion specifier "d" > > The attached patch changes from %d to %u in the printf. Pushed -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
(In reply to Adrian Johnson from comment #112) > Created attachment 120889 [details] [review] > Check in ranges in ByteRange array > > This is an alternative to the patch in comment 108. It checks all ranges in > the ByteRange array. I'm not very convinced by the naming of GBool isInteger() { return type == objInt || type == objInt64; } what do you think of isIntOrInt64() ? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
(In reply to Adrian Johnson from comment #112) > Created attachment 120889 [details] [review] > Check in ranges in ByteRange array > > This is an alternative to the patch in comment 108. It checks all ranges in > the ByteRange array. I'm not very convinced by the naming of GBool isInteger() { return type == objInt || type == objInt64; } what do you think of isIntOrInt64() ? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1524130] Re: /usr/bin/unity8:11:__memcpy_neon:std::char_traits:std::basic_streambuf:std::basic_streambuf:std::__ostream_write
** Also affects: dbus-cpp (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to dbus-cpp in Ubuntu. https://bugs.launchpad.net/bugs/1524130 Title: /usr/bin/unity8:11:__memcpy_neon:std::char_traits:std::basic_streambuf:std::basic_streambuf:std::__ostream_write To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/dbus-cpp/+bug/1524130/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
So we're stuck on "need to use the offset" part, right? Could someone try to do make the code use it even if we don't have any pdf that needs it? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
So we're stuck on "need to use the offset" part, right? Could someone try to do make the code use it even if we don't have any pdf that needs it? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
(In reply to Adrian Johnson from comment #94) > I suggest we change the pdfsig "-c" switch to "-nocert". We can easily add a > single character option if we find it is needed. But we can't get rid of it > if we later regret it. > > I'm still waiting for an answer to comment 79. As said please let's not spend too much time on arguing over switch names, if you really really want -nocert, just push a patch to the signatureHandling branch that switches to it. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
(In reply to Adrian Johnson from comment #94) > I suggest we change the pdfsig "-c" switch to "-nocert". We can easily add a > single character option if we find it is needed. But we can't get rid of it > if we later regret it. > > I'm still waiting for an answer to comment 79. As said please let's not spend too much time on arguing over switch names, if you really really want -nocert, just push a patch to the signatureHandling branch that switches to it. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
(In reply to Markus Kilås from comment #93) > Created attachment 119174 [details] > Handle SEC_ERROR_UNTRUSTED_ISSUER I pushed this and also some code to differentiate between an unknown and an untrusted issuer (no idea what's the difference but if nss has this difference i feel we also have to) -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
(In reply to Markus Kilås from comment #93) > Created attachment 119174 [details] > Handle SEC_ERROR_UNTRUSTED_ISSUER I pushed this and also some code to differentiate between an unknown and an untrusted issuer (no idea what's the difference but if nss has this difference i feel we also have to) -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
(In reply to Adrian Johnson from comment #80) > (In reply to Albert Astals Cid from comment #70) > > For the pdfsigverify it seems we kind of agreeed on the compromise to call > > it pdfsig that only does verification right now but in the future may > > suppport signing? > > This is the only thing left that I think needs fixing before the initial > release. A couple of questions: > > - Given that we want to keep the option open for using pdfsig to perform > other signature operations, should the default behavior when only a pdf file > is specified be to verify the signature? Or should we just indicate whether > the pdf is signed and use an option to enable verification? I think defaulting to verification makes sense as the "non destructive thing to do". > - Is '-c' the best option name for "don't perform certificate validation"? Honestly i don't think spending much time on discussing the option name makes much sense, we just need to document it properly and that's it. > > We also need a man page. Yep. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
(In reply to Adam Reichold from comment #81) > (In reply to Adrian Johnson from comment #78) > > I agree that the two calls to doGetChars and updateHash should be merged but > > I don't think a for loop is the best way to process loops where the > > increment is not exactly the same on each iteration. Maybe something like > > this: > > > > void FormFieldSignature::hashSignedByteRange(SignatureHandler *handler, > > Goffset start, Goffset len) > > { > > const int CHUNK_SIZE = 4096; > > unsigned char buffer[CHUNK_SIZE]; > > Goffset i = 0; > > int byte_count = CHUNK_SIZE; > > > > doc->getBaseStream()->setPos(start); > > while (i < len) > > { > > if (i + CHUNK_SIZE > len) > > byte_count = len - i; > > > > doc->getBaseStream()->doGetChars(byte_count, buffer); > > handler->updateHash(buffer, byte_count); > > i += byte_count; > > } > > } > > I was thinking of something like > > doc->getBaseStream()->setPos(start); > for (Goffset offset = 0; offset < len; offset += CHUNK_SIZE) > { > const int byte_count = min(CHUNK_SIZE, len - offset); > > doc->getBaseStream()->doGetChars(byte_count, buffer); > handler->updateHash(buffer, byte_count); > } > > to make the loop more regular as we don't care if offset > len instead of > offset == len after the last iteration. (That code was not tested or even > compiled.) > > > I don't mind if we fix all this later. It doesn't have to hold up the > > initial release. > > Maybe if there is some external pressure to release this, but otherwise I'd > propose polishing it now, since there is a certain momentum not to touch > working code once it is released. If we're too picky it may just die in this branch and never be merged :D > > Best regards, Adam. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
(In reply to Andre Guerreiro from comment #76) > Created attachment 118745 [details] [review] > Incremental hashing + large file support > > With this patch I've implemented the incremental hashing plus the large file > support. > > This is still untested with files larger than 2GB but is correct for all the > regular test cases I gathered before. I've pushed this, Adrian, Adam please suggest your improvements over it with a patch if you reached an agreement. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
(In reply to Adrian Johnson from comment #80) > (In reply to Albert Astals Cid from comment #70) > > For the pdfsigverify it seems we kind of agreeed on the compromise to call > > it pdfsig that only does verification right now but in the future may > > suppport signing? > > This is the only thing left that I think needs fixing before the initial > release. A couple of questions: > > - Given that we want to keep the option open for using pdfsig to perform > other signature operations, should the default behavior when only a pdf file > is specified be to verify the signature? Or should we just indicate whether > the pdf is signed and use an option to enable verification? I think defaulting to verification makes sense as the "non destructive thing to do". > - Is '-c' the best option name for "don't perform certificate validation"? Honestly i don't think spending much time on discussing the option name makes much sense, we just need to document it properly and that's it. > > We also need a man page. Yep. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
(In reply to Adam Reichold from comment #81) > (In reply to Adrian Johnson from comment #78) > > I agree that the two calls to doGetChars and updateHash should be merged but > > I don't think a for loop is the best way to process loops where the > > increment is not exactly the same on each iteration. Maybe something like > > this: > > > > void FormFieldSignature::hashSignedByteRange(SignatureHandler *handler, > > Goffset start, Goffset len) > > { > > const int CHUNK_SIZE = 4096; > > unsigned char buffer[CHUNK_SIZE]; > > Goffset i = 0; > > int byte_count = CHUNK_SIZE; > > > > doc->getBaseStream()->setPos(start); > > while (i < len) > > { > > if (i + CHUNK_SIZE > len) > > byte_count = len - i; > > > > doc->getBaseStream()->doGetChars(byte_count, buffer); > > handler->updateHash(buffer, byte_count); > > i += byte_count; > > } > > } > > I was thinking of something like > > doc->getBaseStream()->setPos(start); > for (Goffset offset = 0; offset < len; offset += CHUNK_SIZE) > { > const int byte_count = min(CHUNK_SIZE, len - offset); > > doc->getBaseStream()->doGetChars(byte_count, buffer); > handler->updateHash(buffer, byte_count); > } > > to make the loop more regular as we don't care if offset > len instead of > offset == len after the last iteration. (That code was not tested or even > compiled.) > > > I don't mind if we fix all this later. It doesn't have to hold up the > > initial release. > > Maybe if there is some external pressure to release this, but otherwise I'd > propose polishing it now, since there is a certain momentum not to touch > working code once it is released. If we're too picky it may just die in this branch and never be merged :D > > Best regards, Adam. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
(In reply to Andre Guerreiro from comment #76) > Created attachment 118745 [details] [review] > Incremental hashing + large file support > > With this patch I've implemented the incremental hashing plus the large file > support. > > This is still untested with files larger than 2GB but is correct for all the > regular test cases I gathered before. I've pushed this, Adrian, Adam please suggest your improvements over it with a patch if you reached an agreement. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
(In reply to Adrian Johnson from comment #71) > (In reply to Albert Astals Cid from comment #70) > > So we have two things missing, right? > > * Enabling the use of other keystores > > * The name of the pdfsigverify tool > > > > > > I think the enabling the use of other keystores is important but maybe not > > critical for the first release. > > > > For the pdfsigverify it seems we kind of agreeed on the compromise to call > > it pdfsig that only does verification right now but in the future may > > suppport signing? > > > > > > Did i forget something? > > Large file support. Do you think this should be a blocker for the initial release or something we can improve later? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
(In reply to Adrian Johnson from comment #73) > (In reply to Albert Astals Cid from comment #72) > > > Large file support. > > > > Do you think this should be a blocker for the initial release or something > > we can improve later? > > I think it should be included. Do you have any file like that or a way to create it so the guys can test it? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
(In reply to Adrian Johnson from comment #73) > (In reply to Albert Astals Cid from comment #72) > > > Large file support. > > > > Do you think this should be a blocker for the initial release or something > > we can improve later? > > I think it should be included. Do you have any file like that or a way to create it so the guys can test it? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
(In reply to Adrian Johnson from comment #71) > (In reply to Albert Astals Cid from comment #70) > > So we have two things missing, right? > > * Enabling the use of other keystores > > * The name of the pdfsigverify tool > > > > > > I think the enabling the use of other keystores is important but maybe not > > critical for the first release. > > > > For the pdfsigverify it seems we kind of agreeed on the compromise to call > > it pdfsig that only does verification right now but in the future may > > suppport signing? > > > > > > Did i forget something? > > Large file support. Do you think this should be a blocker for the initial release or something we can improve later? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
(In reply to Andre Guerreiro from comment #67) > Created attachment 118449 [details] [review] > Support for adbe.pkcs7.sha1 signatures > > This patch, to be applied over the previous one, adds support for > adbe.pkcs7.sha1 signatures so now we should have a more complete coverage of > actual signed PDFs. I have a few adbe.x509.rsa_sha1 in case you need them for testing. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
So we have two things missing, right? * Enabling the use of other keystores * The name of the pdfsigverify tool I think the enabling the use of other keystores is important but maybe not critical for the first release. For the pdfsigverify it seems we kind of agreeed on the compromise to call it pdfsig that only does verification right now but in the future may suppport signing? Did i forget something? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
(In reply to Andre Guerreiro from comment #66) > Created attachment 118446 [details] [review] > NSS conditional build > > This patch makes the NSS dependency optional in the CMake and Autotools > build systems. Commited too to the signatureHandling branch with some minor changes on my side to have fewer -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
(In reply to Andre Guerreiro from comment #67) > Created attachment 118449 [details] [review] > Support for adbe.pkcs7.sha1 signatures > > This patch, to be applied over the previous one, adds support for > adbe.pkcs7.sha1 signatures so now we should have a more complete coverage of > actual signed PDFs. I have a few adbe.x509.rsa_sha1 in case you need them for testing. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
(In reply to Andre Guerreiro from comment #66) > Created attachment 118446 [details] [review] > NSS conditional build > > This patch makes the NSS dependency optional in the CMake and Autotools > build systems. Commited too to the signatureHandling branch with some minor changes on my side to have fewer -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
So we have two things missing, right? * Enabling the use of other keystores * The name of the pdfsigverify tool I think the enabling the use of other keystores is important but maybe not critical for the first release. For the pdfsigverify it seems we kind of agreeed on the compromise to call it pdfsig that only does verification right now but in the future may suppport signing? Did i forget something? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
I've commited the overflow patch, please Adrian's check if it makes you happy. I also like the pdfsig idea. What do we think it's missing before we cna merge this to the mainline? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
Andre*2, answers to the comments from Adam, Adrian and Mantas? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
I've commited the overflow patch, please Adrian's check if it makes you happy. I also like the pdfsig idea. What do we think it's missing before we cna merge this to the mainline? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
Andre*2, answers to the comments from Adam, Adrian and Mantas? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
I've pushed your patch with some fixlets from my side to http://cgit.freedesktop.org/poppler/poppler/log/?h=signatureHandling I have three questions we need to answer before i merge it to master: * Do we really want to make NSS mandatory? * Do we want to provide a way for frontends to give their own path to a nss database? * Do we want to first support other signatures like adbe.x509.rsa_sha1 ? Also i've no clue if the implementation is correct, it seems to do nice things with some files i have laying around. Comments? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
I've pushed your patch with some fixlets from my side to http://cgit.freedesktop.org/poppler/poppler/log/?h=signatureHandling I have three questions we need to answer before i merge it to master: * Do we really want to make NSS mandatory? * Do we want to provide a way for frontends to give their own path to a nss database? * Do we want to first support other signatures like adbe.x509.rsa_sha1 ? Also i've no clue if the implementation is correct, it seems to do nice things with some files i have laying around. Comments? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
I've had look at the code (in poppler/ not glib/ i'll leave that to the glib/ experts) and have some minor and some major comments. Minor: * There's 3 use of malloc i could find, for completion i guess it's better if you use gmalloc * SigStatusStruct should be a C++ class Medium: * I'm not convinced getSigningTime should return a char *, i'd very much prefer it returning an integer and shifting the responsability to turn it into a string to upper layers, since allows for translations, etc. Major: * There's lots of repeated code (the loops searching for "Annot"+"Sig" some of these with more checks for nulls than others) and some functions that make no sense in PDFDoc like Object *getByteRange(int index); If you see in Form::Form we're already parsing "Fields" and creating FormFieldSignature for each "Sig" object. My suggestion is that you expand FormFieldSignature with your implementation. That also solves API issues like for for example getSignerName should not be in PDFDoc since you need to have called validateSignature before and then it returns the signer name for the signature of that index, so it should be part of a signature object, i.e. FormFieldSignature. Do you think it makes sense? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
I've had look at the code (in poppler/ not glib/ i'll leave that to the glib/ experts) and have some minor and some major comments. Minor: * There's 3 use of malloc i could find, for completion i guess it's better if you use gmalloc * SigStatusStruct should be a C++ class Medium: * I'm not convinced getSigningTime should return a char *, i'd very much prefer it returning an integer and shifting the responsability to turn it into a string to upper layers, since allows for translations, etc. Major: * There's lots of repeated code (the loops searching for "Annot"+"Sig" some of these with more checks for nulls than others) and some functions that make no sense in PDFDoc like Object *getByteRange(int index); If you see in Form::Form we're already parsing "Fields" and creating FormFieldSignature for each "Sig" object. My suggestion is that you expand FormFieldSignature with your implementation. That also solves API issues like for for example getSignerName should not be in PDFDoc since you need to have called validateSignature before and then it returns the signer name for the signature of that index, so it should be part of a signature object, i.e. FormFieldSignature. Do you think it makes sense? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
Another file that aborts https://bugs.freedesktop.org/attachment.cgi?id=12982 Also +/* Build against libcurl. */ +#cmakedefine ENABLE_OPENSSL 1 + i guess just sneaked in to the patch and is not needed? Also please use our own error() function instead of perror Also one question, does pdfsigverify exercise all the codepaths you're adding? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
Another file that aborts https://bugs.freedesktop.org/attachment.cgi?id=12982 Also +/* Build against libcurl. */ +#cmakedefine ENABLE_OPENSSL 1 + i guess just sneaked in to the patch and is not needed? Also please use our own error() function instead of perror Also one question, does pdfsigverify exercise all the codepaths you're adding? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 33288]
I just realized we never really followed up on the last two patches. My concern is that they change the pdftotext output. I though they where for a) speed b) text selection so i'd prefer if they did not change pdftotext output. I've checked a few files of the changed ones and the changes can be argued not to be for better or worse, but then again the problem is that 1 out of 3 files i have has a changed output in pdftotext and having 1600 files in the test suite it makes it impossible for me to go over them all and verify the changes are "not better nor worse". Is there any chance we get patches that don't influence pdftotext output or at least not such drastically? And yes, i know it's ages ago since you wrote the patches, sorry. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/33288 Title: Evince doesn't handle columns properly To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/33288/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
Nice work. Some small things that need fixing. the cmake way of using pkgconfig is very simple, see ./cmake/modules/FindGTK.cmake for example You need to free more Objects, every time you do a get object an object you have to free it, e.g. in countSignatures you need to free fields, f, type, obj1 The indentation is a bit broken, i know poppler indentation (2 soft spaces, 8 hard tabs) is a crazy, but at least it'd be cool if your own functions were consistent, in validateSignature you mix tabs and spaces. Also running valgrind it shows some memory leaks, one example ==27912==by 0x657248F: CERT_NewTempCertificate (in /usr/lib/x86_64-linux-gnu/libnss3.so) ==27912==by 0x4F9C4A1: SignatureHandler::CMS_SignedDataCreate(NSSCMSMessageStr*) (SignatureHandler.cc:172) ==27912==by 0x4F9C561: SignatureHandler::SignatureHandler(unsigned char*, int) (SignatureHandler.cc:122) ==27912==by 0x4F9383F: PDFDoc::validateSignature(int, bool) (PDFDoc.cc:534) The file in https://bugs.kde.org/attachment.cgi?id=91442 aborts -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
Nice work. Some small things that need fixing. the cmake way of using pkgconfig is very simple, see ./cmake/modules/FindGTK.cmake for example You need to free more Objects, every time you do a get object an object you have to free it, e.g. in countSignatures you need to free fields, f, type, obj1 The indentation is a bit broken, i know poppler indentation (2 soft spaces, 8 hard tabs) is a crazy, but at least it'd be cool if your own functions were consistent, in validateSignature you mix tabs and spaces. Also running valgrind it shows some memory leaks, one example ==27912==by 0x657248F: CERT_NewTempCertificate (in /usr/lib/x86_64-linux-gnu/libnss3.so) ==27912==by 0x4F9C4A1: SignatureHandler::CMS_SignedDataCreate(NSSCMSMessageStr*) (SignatureHandler.cc:172) ==27912==by 0x4F9C561: SignatureHandler::SignatureHandler(unsigned char*, int) (SignatureHandler.cc:122) ==27912==by 0x4F9383F: PDFDoc::validateSignature(int, bool) (PDFDoc.cc:534) The file in https://bugs.kde.org/attachment.cgi?id=91442 aborts -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 116453]
Pushed. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/116453 Title: evince can not find ü in attached PDF To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/116453/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 116453]
I think it looks good as it is. If noone disagrees i'll commit in a week. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/116453 Title: evince can not find ü in attached PDF To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/116453/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1438094] [NEW] indicator-network aborts when trying to run unexistant dbus method
Public bug reported: Run qdbus com.ubuntu.connectivity1 /com/ubuntu/connectivity1/NetworkingStatus Status in the phone, indicator-network will crash. Attaching backtrace ** Affects: dbus-cpp (Ubuntu) Importance: Undecided Status: New ** Affects: indicator-network (Ubuntu) Importance: Undecided Status: New ** Attachment added: backtrace https://bugs.launchpad.net/bugs/1438094/+attachment/4360678/+files/backtrace ** Also affects: dbus-cpp (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to dbus-cpp in Ubuntu. https://bugs.launchpad.net/bugs/1438094 Title: indicator-network aborts when trying to run unexistant dbus method To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/dbus-cpp/+bug/1438094/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1111646]
Thomas did you ever get a new poppler version? Is this fixed? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/646 Title: Syntax Error: Invalid encryption key length To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/646/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1393438] Re: Enable location data string displays untranslated
** Changed in: unity8 (Ubuntu) Assignee: Andrea Cimitan (cimi) = Albert Astals Cid (aacid) ** Changed in: unity8 (Ubuntu) Status: Triaged = In Progress ** Branch linked: lp:~aacid/unity8/hack_location_data_i18n -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to location-service in Ubuntu. https://bugs.launchpad.net/bugs/1393438 Title: Enable location data string displays untranslated To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1393438/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 116453]
I certainly remember we already did that combination somewhere, either in okular or in poppler, but i can't find it and of course the document does not work, so it may be a fake memory :D I think this may make sense, though then again preserving the old behaviour via a flag (even if not default) in the TextOutputDev may make sense if someone (not sure who though) would be depending on it. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/116453 Title: evince can not find ü in attached PDF To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/116453/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1085526]
The bug importance doesn't matter, what matters is that if there's someone with the time to work on this. I'd say there's not much people (or noone) in the current team with such amount of time. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1085526 Title: ubuntu pdf doc viewer will not let me sign a document To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1085526/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
The bug importance doesn't matter, what matters is that if there's someone with the time to work on this. I'd say there's not much people (or noone) in the current team with such amount of time. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 116453]
I'm with Adrian, don't think changing this at such low level is a good idea. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/116453 Title: evince can not find ü in attached PDF To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/116453/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 247113]
I'm closing this bug, please try to use a version newer than what madbiologist suggests and if the problem still happens please reopen the bug. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/247113 Title: Bars show with wrong thickness To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/247113/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 127732]
Because there's no patch for it. alex has proven he can't provide a valid patch. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug assignee. https://bugs.launchpad.net/bugs/127732 Title: Searching Hebrew text works in reverse order To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/127732/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1300659]
Does pdftops produce a file with boxes you can print? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1300659 Title: printed pdf file lacks item boxes To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1300659/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1300659]
looks like a cairo backend bug to me then -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1300659 Title: printed pdf file lacks item boxes To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/1300659/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1293629] Re: [Regression] [Trusty] Unity can't be started from kdm
It works fine here without the DM setting it. Note that the variable is set, probably by something else. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-session in Ubuntu. https://bugs.launchpad.net/bugs/1293629 Title: [Regression] [Trusty] Unity can't be started from kdm To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-session/+bug/1293629/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1293629] Re: [Regression] [Trusty] Unity can't be started from kdm
Ok, feel free to mark this as invalid if you don't care that Unity fails to start from other DM than lightdm. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-session in Ubuntu. https://bugs.launchpad.net/bugs/1293629 Title: [Regression] [Trusty] Unity can't be started from kdm To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-session/+bug/1293629/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1293629] [NEW] [Regression] [Trusty] Unity can't be started from kdm
Public bug reported: Because of https://launchpadlibrarian.net/169426095/gnome- session_3.9.90-0ubuntu11_3.9.90-0ubuntu12.diff.gz i can't log in into an Unity session from kdm ** Affects: gnome-session (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-session in Ubuntu. https://bugs.launchpad.net/bugs/1293629 Title: [Regression] [Trusty] Unity can't be started from kdm To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-session/+bug/1293629/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1293629] Re: [Regression] [Trusty] Unity can't be started from kdm
Is there anything in a spec somewhere that says kdm is at wrong here and that it should indeed define XDG_CURRENT_DESKTOP ? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-session in Ubuntu. https://bugs.launchpad.net/bugs/1293629 Title: [Regression] [Trusty] Unity can't be started from kdm To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-session/+bug/1293629/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1243484]
Ok, regtest finished, all looks good, please commit! -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/1243484 Title: Incorrect handling of orientation when printing PDF files To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1243484/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1243484]
Not a biggie since it's a broken file, but when running pdftops on page 30 of https://bugs.freedesktop.org/attachment.cgi?id=9910 the unpatched version creates something that gs can read (even if ends up beign empty) while the patched version creates something that makes gs unhappy. Can you have a quick look to see how hard would it be to get doesn't make gs hate the output ps file? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/1243484 Title: Incorrect handling of orientation when printing PDF files To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1243484/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1243484]
While running pdftops -f 30 -l 30 over https://bugs.freedesktop.org/attachment.cgi?id=9910 the patched version segfaults while the old one does not. Can you have a look? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/1243484 Title: Incorrect handling of orientation when printing PDF files To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1243484/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1243484]
ok, if adobe does the same maybe it makes sense. Are you making the qt- ps-converters do the same too? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/1243484 Title: Incorrect handling of orientation when printing PDF files To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1243484/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1263490] [NEW] Stop applying Binary and Source incompatible patches to ubuntu packages
Public bug reported: Ubuntu is not packaging poppler 0.24.4 because it carries Source and Binary incompatible changes and thus upstream increased the soversion. Meanwhile Ubuntu has decided to apply pdftops-origpagesizes-fixes.diff that is Source and Binary incompatible without caring if it breaks Source and Binary compatibility and has not cared either about updating the soversion. Seems that there is some kind of weird logic here that i do not understand and Source and Binary compatible changes. ** Affects: poppler (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/1263490 Title: Stop applying Binary and Source incompatible patches to ubuntu packages To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/poppler/+bug/1263490/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1159931]
That's been fixed upstream, we can probably close this bug and just hope distros patch their stuff -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/1159931 Title: Evince not rendering Postscript files To manage notifications about this bug go to: https://bugs.launchpad.net/gs-gpl/+bug/1159931/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 667752]
Adrian do you think this needs to go in? What about the comments by Germán? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to evince in Ubuntu. https://bugs.launchpad.net/bugs/667752 Title: Non-embedded standard fonts in PDF files are not displayed/rendered correctly To manage notifications about this bug go to: https://bugs.launchpad.net/evince/+bug/667752/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 127732]
Adding the depends for the current patch dependency, the bug itself is not dependent but current solution by alex is. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug assignee. https://bugs.launchpad.net/bugs/127732 Title: Searching Hebrew text works in reverse order To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/127732/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 710137]
So should we close this one? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/710137 Title: evince badly mis-renders gradients in pdf To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/710137/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1020162]
Will be fixed in poppler 0.22 -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/1020162 Title: some characters not displayed in a PDF file To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/1020162/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 321720]
*** Bug 56913 has been marked as a duplicate of this bug. *** -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/321720 Title: PDF v1.7 asks to upgrade Adobe Reader To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/321720/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 740506]
weibo? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/740506 Title: verify digital signatures To manage notifications about this bug go to: https://bugs.launchpad.net/poppler/+bug/740506/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1053670] Re: nautilus crashed with SIGSEGV in g_type_check_instance_cast(), from settings_notify_cb(), in dbusmenu's parser.c
** Changed in: dbusmenu Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to nautilus in Ubuntu. https://bugs.launchpad.net/bugs/1053670 Title: nautilus crashed with SIGSEGV in g_type_check_instance_cast(), from settings_notify_cb(), in dbusmenu's parser.c To manage notifications about this bug go to: https://bugs.launchpad.net/dbusmenu/+bug/1053670/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1064992] Re: Unity menubar crashes when activating a submenu in LibreOffice while using Orca screen reader
As said, gtk bug, patch reported at https://bugzilla.gnome.org/show_bug.cgi?id=686152 ** Also affects: gtk+3.0 (Ubuntu) Importance: Undecided Status: New ** Changed in: gtk+3.0 (Ubuntu) Status: New = In Progress ** Changed in: gtk+3.0 (Ubuntu) Assignee: (unassigned) = Albert Astals Cid (aacid) ** Changed in: unity Assignee: Albert Astals Cid (aacid) = (unassigned) ** Changed in: unity Status: In Progress = Invalid -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gtk+3.0 in Ubuntu. https://bugs.launchpad.net/bugs/1064992 Title: Unity menubar crashes when activating a submenu in LibreOffice while using Orca screen reader To manage notifications about this bug go to: https://bugs.launchpad.net/indicator-appmenu/+bug/1064992/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1043349] Re: User Accounts reports wrong Automatic Login status when upgading from 12.04
It's actually an accountsservice bug ** Changed in: gnome-control-center (Ubuntu) Status: Confirmed = In Progress ** Also affects: accountsservice (Ubuntu) Importance: Undecided Status: New ** Changed in: gnome-control-center (Ubuntu) Status: In Progress = Invalid ** Changed in: accountsservice (Ubuntu) Status: New = In Progress ** Changed in: accountsservice (Ubuntu) Assignee: (unassigned) = Albert Astals Cid (aacid) -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1043349 Title: User Accounts reports wrong Automatic Login status when upgading from 12.04 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/accountsservice/+bug/1043349/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1043349] Re: User Accounts reports wrong Automatic Login status when upgading from 12.04
Diff over the existing 0007-add-lightdm-support.patch You can create almost any dbus proxy and it will be non null even if there is nothing there, that's why i added the check that there is an owner ** Attachment added: DIFF https://bugs.launchpad.net/ubuntu/+source/accountsservice/+bug/1043349/+attachment/3394478/+files/DIFF -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1043349 Title: User Accounts reports wrong Automatic Login status when upgading from 12.04 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/accountsservice/+bug/1043349/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1043349] Re: User Accounts reports wrong Automatic Login status when upgading from 12.04
Whole new 0007-add-lightdm-support.patch (result of applying the patch in the previous comment to the existing 0007-add-lightdm-support.patch) ** Patch added: 0007-add-lightdm-support.patch https://bugs.launchpad.net/ubuntu/+source/accountsservice/+bug/1043349/+attachment/3394479/+files/0007-add-lightdm-support.patch -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1043349 Title: User Accounts reports wrong Automatic Login status when upgading from 12.04 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/accountsservice/+bug/1043349/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1043349] Re: User Accounts reports wrong Automatic Login status when upgading from 12.04
New partial diff, old one is wrong ** Attachment added: DIFF https://bugs.launchpad.net/ubuntu/+source/accountsservice/+bug/1043349/+attachment/3394689/+files/DIFF ** Patch removed: DIFF https://bugs.launchpad.net/ubuntu/+source/accountsservice/+bug/1043349/+attachment/3394478/+files/DIFF ** Patch removed: 0007-add-lightdm-support.patch https://bugs.launchpad.net/ubuntu/+source/accountsservice/+bug/1043349/+attachment/3394479/+files/0007-add-lightdm-support.patch -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1043349 Title: User Accounts reports wrong Automatic Login status when upgading from 12.04 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/accountsservice/+bug/1043349/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1043349] Re: User Accounts reports wrong Automatic Login status when upgading from 12.04
New full diff, the old one was wrong ** Patch added: 0007-add-lightdm-support.patch https://bugs.launchpad.net/ubuntu/+source/accountsservice/+bug/1043349/+attachment/3394690/+files/0007-add-lightdm-support.patch -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1043349 Title: User Accounts reports wrong Automatic Login status when upgading from 12.04 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/accountsservice/+bug/1043349/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 896740] Re: With appmenus context-menu shortcut options in nautilus do not work properly. E.g. I need to press R twice to select Rename and then hit Return to select it.
Fixed in Quantal in gtk-3 3.5.18-0ubuntu2 ** Also affects: gtk+3.0 (Ubuntu) Importance: Undecided Status: New ** Changed in: appmenu-gtk (Ubuntu Precise) Status: Confirmed = Invalid ** Changed in: appmenu-gtk (Ubuntu) Status: Confirmed = Invalid ** Changed in: nautilus (Ubuntu) Status: Triaged = Invalid ** Changed in: nautilus (Ubuntu Precise) Status: Triaged = Invalid ** Changed in: appmenu-gtk Status: In Progress = Invalid ** Changed in: appmenu-gtk Assignee: Albert Astals Cid (aacid) = (unassigned) ** Changed in: gtk+3.0 (Ubuntu) Status: New = Fix Released -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to nautilus in Ubuntu. https://bugs.launchpad.net/bugs/896740 Title: With appmenus context-menu shortcut options in nautilus do not work properly. E.g. I need to press R twice to select Rename and then hit Return to select it. To manage notifications about this bug go to: https://bugs.launchpad.net/appmenu-gtk/+bug/896740/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 896740] Re: With appmenus context-menu shortcut options in nautilus do not work properly. E.g. I need to press R twice to select Rename and then hit Return to select it.
** Changed in: gtk+3.0 (Ubuntu) Assignee: (unassigned) = Albert Astals Cid (aacid) -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to nautilus in Ubuntu. https://bugs.launchpad.net/bugs/896740 Title: With appmenus context-menu shortcut options in nautilus do not work properly. E.g. I need to press R twice to select Rename and then hit Return to select it. To manage notifications about this bug go to: https://bugs.launchpad.net/appmenu-gtk/+bug/896740/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs