[Bug 2020782] Re: Xdcv: Changing display scale setting and reverting it fails

2023-06-13 Thread Mustafa Kemal Gilor
I've also tested the "vv5" package in a fresh VM and can confirm that
zero hz is now supported, and now facing the same scenario where
multiple monitors are automatically enabled.

Another issue that still stands is the "config history" issue I've
mentioned. If you exclusively change the resolution from gnome display
settings, it can apply a new resolution and revert to a previous config
(via the timeout prompt) without any issue. But when the resolution is
changed via the NICE DCV client's options (or via `xrandr` for that
matter), mutter does not register that resolution change in
`config_history`, and cannot revert back to the previous config when
prompted. This is reproducible with just the default gnome desktop
environment and the `xrandr`

The reproducer is as follows:

(assume that the initial resolution is 1920x1080)

- Set a resolution via `xrandr`, e.g. (1366x768)
- Open gnome display settings, and try to set the resolution to 1024x768
- Press "revert back" when prompted
- The resolution will not go back to 1366x768 as it should and will stay at 
1024x768

I've debugged this and noticed that gnome display settings use mutter's
org.gnome.Mutter.DisplayConfig DBus interface and calls
ApplyMonitorsConfig for resolution changes, whereas neither NICE DCV nor
xrandr does that, so mutter is not notified about the change.

I guess this will need a separate issue.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to mutter in Ubuntu.
https://bugs.launchpad.net/bugs/2020782

Title:
  Xdcv: Changing display scale setting and reverting it fails

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2020782/+subscriptions


-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 2020782] Re: Xdcv: Changing display scale setting and reverting it fails

2023-06-09 Thread Mustafa Kemal Gilor
Hello Daniel,

I've also been debugging this issue and noticed something weird while
reproducing it. It seems that resizing the screen via resizing the NICE
DCV client does not invoke the `meta_monitor_config_manager_set_current`
method, so the current config and the history are untouched.

Let's say we have an initial resolution of QxZ@T hz, sf 1(scale factor). The 
NICE DCV client screen resize changes it to WxH@F sf 1.5, but libmutter still 
thinks the screen is at QxZ@T sf 1. At this point, 
 `xrandr` output no longer shows QxZ@T hz as a supported resolution. When the 
user tries to change the scale, the change is registered as both the resolution 
change and the scale change as per the perspective of "libmutter", and if the 
user proceeds to accept this configuration, everything is fine because the Xdcv 
already lists `WxH@F` as a supported resolution, but if not (i.e. user tries to 
revert back to the previous) it fails because QxZ@T hz is no longer on the 
supported resolution set. 

Therefore, I think one of the problems we're facing here is
libmutter/Xdcv being out-of-sync when the screen resolution is changed
via the NICE DCV client. I'm currently looking into how we can reflect
the client resolutions to libmutter (I'm not well-versed in mutter
codebase so progressing a little bit slow)

I'll continue to post my findings as I progress.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to mutter in Ubuntu.
https://bugs.launchpad.net/bugs/2020782

Title:
  Xdcv: Changing display scale setting and reverting it fails

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2020782/+subscriptions


-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 2020782] Re: Changing display scale setting and reverting it, causes gnome-shell to error with "Failed to restore previous configuration" and other error messages

2023-05-30 Thread Mustafa Kemal Gilor
Reproducer:

-- Grab a fresh Ubuntu 22.04 VM, then install NICE DCV Server & NICE
Xdcv --

# Exit graphical mode
sudo systemctl isolate multi-user.target
# Install `ssh` & import id (optional)
sudo apt -y install openssh-server
ssh-import-id 
# Disable wayland
sudo sed -i "s/WaylandEnable=True/WaylandEnable=false/" /etc/gdm3/custom.conf
# Install NICE DCV Server & Nice XDCV
cd /tmp
wget https://d1uj6qtbmh3dt5.cloudfront.net/NICE-GPG-KEY
gpg --import NICE-GPG-KEY
wget 
https://d1uj6qtbmh3dt5.cloudfront.net/2023.0/Servers/nice-dcv-2023.0-15065-ubuntu2204-x86_64.tgz
tar -xvzf nice-dcv-2023.0-15065-ubuntu2204-x86_64.tgz
cd nice-dcv-2023.0-15065-ubuntu2204-x86_64
sudo apt -y install ./nice-dcv-server_2023.0.15065-1_amd64.ubuntu2204.deb
sudo apt -y install ./nice-xdcv_2023.0.547-1_amd64.ubuntu2204.deb
# Add "dcv" user to "video" group:
sudo usermod -aG video dcv
# Start dcv server:
sudo systemctl start dcvserver
# Create a session:
sudo dcv create-session my-test-session --owner=test


-- client --
# Install NICE DCV client and connect to the dcv host
wget 
https://d1uj6qtbmh3dt5.cloudfront.net/2023.0/Clients/nice-dcv-viewer_2023.0.5483-1_amd64.ubuntu2204.deb
dpkg -i nice-dcv-viewer_2023.0.5483-1_amd64.ubuntu2204.deb
dcvviewer https://:8443#my-test-session

# Then, try to change the display scale, and click "revert settings", the 
session should freeze
# gnome-shell log should contain similar log messages to the following:
May 30 15:59:03 test-2 gnome-shell[4906]: Failed to restore previous 
configuration: Invalid mode 3840x1352 (59,963089) for monitor 'unknown unknown'
May 30 15:59:03 test-2 gnome-shell[4906]: Failed to use linear monitor 
configuration: Invalid mode 800x600 (-nan) for monitor 'unknown unknown'
May 30 15:59:03 test-2 gnome-shell[4906]: Failed to use fallback monitor 
configuration: Invalid mode 800x600 (-nan) for monitor 'unknown unknown'
May 30 15:59:03 test-2 gnome-shell[4906]: Impossible to set scaling on crtc 59 
to 1,00, error id 2

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to mutter in Ubuntu.
https://bugs.launchpad.net/bugs/2020782

Title:
  Changing display scale setting and reverting it, causes gnome-shell to
  error with "Failed to restore previous configuration" and other error
  messages

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2020782/+subscriptions


-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 2020782] Re: Changing display scale setting and reverting it, causes gnome-shell to error with "Failed to restore previous configuration" and other error messages

2023-05-30 Thread Mustafa Kemal Gilor
I'm still able to reproduce the bug with the PPA installed. I'll
investigate this further and share my findings.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to mutter in Ubuntu.
https://bugs.launchpad.net/bugs/2020782

Title:
  Changing display scale setting and reverting it, causes gnome-shell to
  error with "Failed to restore previous configuration" and other error
  messages

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/2020782/+subscriptions


-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 2003176] Re: SRU: metacity crashes while minimizing a windows that has undocked child

2023-03-13 Thread Mustafa Kemal Gilor
Kinetic and above has >= 3.46.0, later series not affected.

** Changed in: metacity (Ubuntu)
   Status: New => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to metacity in Ubuntu.
https://bugs.launchpad.net/bugs/2003176

Title:
  SRU: metacity crashes while minimizing a windows that has undocked
  child

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/metacity/+bug/2003176/+subscriptions


-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 2003176] Re: SRU: metacity crashes while minimizing a windows that has undocked child

2023-02-13 Thread Mustafa Kemal Gilor
Verification is done for Focal and Jammy, I've run the test case 3 times
for both, and experienced no crashes while minimizing a parent window
with undocked child. Also, the window is restored properly when un-
minimized.

** Attachment added: "Screenshot from 2023-02-13 13-45-20.png"
   
https://bugs.launchpad.net/ubuntu/+source/metacity/+bug/2003176/+attachment/5646788/+files/Screenshot%20from%202023-02-13%2013-45-20.png

** Tags removed: verification-needed verification-needed-focal 
verification-needed-jammy
** Tags added: verification-done-focal verification-done-jammy

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to metacity in Ubuntu.
https://bugs.launchpad.net/bugs/2003176

Title:
  SRU: metacity crashes while minimizing a windows that has undocked
  child

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/metacity/+bug/2003176/+subscriptions


-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 2003176] Re: SRU: metacity crashes while minimizing a windows that has undocked child

2023-01-18 Thread Mustafa Kemal Gilor
** Changed in: metacity (Ubuntu Jammy)
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to metacity in Ubuntu.
https://bugs.launchpad.net/bugs/2003176

Title:
  SRU: metacity crashes while minimizing a windows that has undocked
  child

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/metacity/+bug/2003176/+subscriptions


-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 2003176] Re: SRU: metacity crashes while minimizing a windows that has undocked child

2023-01-18 Thread Mustafa Kemal Gilor
** Merge proposal unlinked:
   
https://code.launchpad.net/~mustafakemalgilor/ubuntu/+source/metacity/+git/metacity/+merge/435956

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to metacity in Ubuntu.
https://bugs.launchpad.net/bugs/2003176

Title:
  SRU: metacity crashes while minimizing a windows that has undocked
  child

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/metacity/+bug/2003176/+subscriptions


-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 2003176] Re: SRU: metacity crashes while minimizing a windows that has undocked child

2023-01-18 Thread Mustafa Kemal Gilor
** Changed in: metacity (Ubuntu Focal)
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to metacity in Ubuntu.
https://bugs.launchpad.net/bugs/2003176

Title:
  SRU: metacity crashes while minimizing a windows that has undocked
  child

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/metacity/+bug/2003176/+subscriptions


-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 2003176] Re: SRU: metacity crashes while minimizing a windows that has undocked child

2023-01-18 Thread Mustafa Kemal Gilor
** Description changed:

  [General information about the SRU]
  * It includes the fix for the bug 
https://gitlab.gnome.org/GNOME/metacity/-/issues/31
  * The fix is already included in 3.46.0 release: 
https://gitlab.gnome.org/GNOME/metacity/-/commit/77f1d55479bfef479f76011a1ee5636f9bf6b08b#9f621eb5fd3bcb2fa5c7bd228c9b1ad42edc46c8
  * The reproducer also revealed another issue with docked windows, undocked 
windows are not being restored after parent window is minimized and restored
  * The fix for restore is included in 3.46.1 release: 
https://gitlab.gnome.org/GNOME/metacity/-/commit/3db07fafa1c7ff9749b6a82ccb36d8b62f2304d9
  * Focal(3.36.1) and Jammy (3.44.0) needs both fixes to be backported
  
  [Impact]
  This affects users using applications that have docked windows
  
  [Test Case]
  
  * Install gnome-session-flashback (metacity) and reproducer's dependencies 
`sudo apt install lightdm gnome-session-flashback pyside2-tools 
python3-pyside2.qtwidgets`
  * Start a graphical session with metacity
  * run python3 Untitled.py
  * Undock one of the application's child windows
  * Minimize main window
  * Result: Metacity will crash
+ 
+ * Fix: install fix from ppa: 
+ * sudo add-apt-repository ppa:mustafakemalgilor/lp-2003176-0
+ * sudo apt update
+ * sudo reboot # or alternatively, restart display manager
+ * run python3 Untitled.py
+ * Undock one of the application's child windows
+ * Minimize main window
  * Expectation: it should not crash and the application should be minimized.
  
  [Regression Potential]
  The fix is small in size and localized, it should not cause any regressions.
  
  -
  
  Bug Version: 1:3.36.1-1 / 1:3.44.0-1
  
  Metacity is running without the composite manager.
  
  Users cannot minimize an application with an undocked child window
  
  ProblemType: Bug
  DistroRelease: Ubuntu 20.04 / Ubuntu 22.04
  Package: metacity 1:3.36.1-1 / 1:3.44.0-1
  ProcVersionSignature: Ubuntu 4.4.0-24.43-generic 4.4.10
  Uname: Linux 4.4.0-24-generic x86_64
  ApportVersion: 2.20.1-0ubuntu2.1
  Architecture: amd64

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to metacity in Ubuntu.
https://bugs.launchpad.net/bugs/2003176

Title:
  SRU: metacity crashes while minimizing a windows that has undocked
  child

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/metacity/+bug/2003176/+subscriptions


-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 2003176] Re: SRU: metacity crashes while minimizing a windows that has undocked child

2023-01-18 Thread Mustafa Kemal Gilor
** Description changed:

  [General information about the SRU]
  * It includes the fix for the bug 
https://gitlab.gnome.org/GNOME/metacity/-/issues/31
- * The fix is already included in 3.46.0 version: 
https://gitlab.gnome.org/GNOME/metacity/-/commit/77f1d55479bfef479f76011a1ee5636f9bf6b08b#9f621eb5fd3bcb2fa5c7bd228c9b1ad42edc46c8
- * Focal(3.36.1) and Jammy (3.44.0) needs the fix to be backported
+ * The fix is already included in 3.46.0 release: 
https://gitlab.gnome.org/GNOME/metacity/-/commit/77f1d55479bfef479f76011a1ee5636f9bf6b08b#9f621eb5fd3bcb2fa5c7bd228c9b1ad42edc46c8
+ * The reproducer also revealed another issue with docked windows, undocked 
windows are not being restored after parent window is minimized and restored
+ * The fix for restore is included in 3.46.1 release: 
https://gitlab.gnome.org/GNOME/metacity/-/commit/3db07fafa1c7ff9749b6a82ccb36d8b62f2304d9
+ * Focal(3.36.1) and Jammy (3.44.0) needs both fixes to be backported
  
  [Impact]
  This affects users using applications that have docked windows
  
  [Test Case]
  
  * Install gnome-session-flashback (metacity) and reproducer's dependencies 
`sudo apt install lightdm gnome-session-flashback pyside2-tools 
python3-pyside2.qtwidgets`
  * Start a graphical session with metacity
  * run python3 Untitled.py
  * Undock one of the application's child windows
  * Minimize main window
- * Result: Metacity will crash 
+ * Result: Metacity will crash
  * Expectation: it should not crash and the application should be minimized.
  
  [Regression Potential]
  The fix is small in size and localized, it should not cause any regressions.
  
  -
  
  Bug Version: 1:3.36.1-1 / 1:3.44.0-1
  
  Metacity is running without the composite manager.
  
  Users cannot minimize an application with an undocked child window
  
  ProblemType: Bug
  DistroRelease: Ubuntu 20.04 / Ubuntu 22.04
  Package: metacity 1:3.36.1-1 / 1:3.44.0-1
  ProcVersionSignature: Ubuntu 4.4.0-24.43-generic 4.4.10
  Uname: Linux 4.4.0-24-generic x86_64
  ApportVersion: 2.20.1-0ubuntu2.1
  Architecture: amd64

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to metacity in Ubuntu.
https://bugs.launchpad.net/bugs/2003176

Title:
  SRU: metacity crashes while minimizing a windows that has undocked
  child

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/metacity/+bug/2003176/+subscriptions


-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 2003176] Re: SRU: metacity crashes while minimizing a windows that has undocked child

2023-01-18 Thread Mustafa Kemal Gilor
Reproducer script:

** Attachment added: "Untitled.py"
   
https://bugs.launchpad.net/ubuntu/+source/metacity/+bug/2003176/+attachment/5642194/+files/Untitled.py

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to metacity in Ubuntu.
https://bugs.launchpad.net/bugs/2003176

Title:
  SRU: metacity crashes while minimizing a windows that has undocked
  child

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/metacity/+bug/2003176/+subscriptions


-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 2003176] [NEW] SRU: metacity crashes while minimizing a windows that has undocked child

2023-01-18 Thread Mustafa Kemal Gilor
Public bug reported:

[General information about the SRU]
* It includes the fix for the bug 
https://gitlab.gnome.org/GNOME/metacity/-/issues/31
* The fix is already included in 3.46.0 release: 
https://gitlab.gnome.org/GNOME/metacity/-/commit/77f1d55479bfef479f76011a1ee5636f9bf6b08b#9f621eb5fd3bcb2fa5c7bd228c9b1ad42edc46c8
* The reproducer also revealed another issue with docked windows, undocked 
windows are not being restored after parent window is minimized and restored
* The fix for restore is included in 3.46.1 release: 
https://gitlab.gnome.org/GNOME/metacity/-/commit/3db07fafa1c7ff9749b6a82ccb36d8b62f2304d9
* Focal(3.36.1) and Jammy (3.44.0) needs both fixes to be backported

[Impact]
This affects users using applications that have docked windows

[Test Case]

* Install gnome-session-flashback (metacity) and reproducer's dependencies 
`sudo apt install lightdm gnome-session-flashback pyside2-tools 
python3-pyside2.qtwidgets`
* Start a graphical session with metacity
* run python3 Untitled.py
* Undock one of the application's child windows
* Minimize main window
* Result: Metacity will crash
* Expectation: it should not crash and the application should be minimized.

[Regression Potential]
The fix is small in size and localized, it should not cause any regressions.

-

Bug Version: 1:3.36.1-1 / 1:3.44.0-1

Metacity is running without the composite manager.

Users cannot minimize an application with an undocked child window

ProblemType: Bug
DistroRelease: Ubuntu 20.04 / Ubuntu 22.04
Package: metacity 1:3.36.1-1 / 1:3.44.0-1
ProcVersionSignature: Ubuntu 4.4.0-24.43-generic 4.4.10
Uname: Linux 4.4.0-24-generic x86_64
ApportVersion: 2.20.1-0ubuntu2.1
Architecture: amd64

** Affects: metacity (Ubuntu)
 Importance: Undecided
 Status: New

** Affects: metacity (Ubuntu Focal)
 Importance: Undecided
 Assignee: Mustafa Kemal Gilor (mustafakemalgilor)
 Status: New

** Affects: metacity (Ubuntu Jammy)
 Importance: Undecided
 Assignee: Mustafa Kemal Gilor (mustafakemalgilor)
 Status: New

** Also affects: metacity (Ubuntu Focal)
   Importance: Undecided
   Status: New

** Also affects: metacity (Ubuntu Jammy)
   Importance: Undecided
   Status: New

** Changed in: metacity (Ubuntu Focal)
 Assignee: (unassigned) => Mustafa Kemal Gilor (mustafakemalgilor)

** Changed in: metacity (Ubuntu Jammy)
 Assignee: (unassigned) => Mustafa Kemal Gilor (mustafakemalgilor)

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to metacity in Ubuntu.
https://bugs.launchpad.net/bugs/2003176

Title:
  SRU: metacity crashes while minimizing a windows that has undocked
  child

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/metacity/+bug/2003176/+subscriptions


-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs